music-transcription 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 47821dcba8bd951fa6052d201b49c4253bf6a8c0
-  data.tar.gz: fc84a5d2ea369f1d17fcdf52a82e8d9a61bef9da
+  metadata.gz: 2bbc3d1440e2ac88166f035060fda110df18aeb5
+  data.tar.gz: 53b0c934d092ca5a176a481b1a00a532e4201ea7
 SHA512:
-  metadata.gz: 20284ea1e670062928ef8dc4ea86a342392e6746c7b511ced9ea2e4843a5b9705ffee13302ce984d09d12a01a32ccd2a23e4a25ae8787597afe2e97df3740928
-  data.tar.gz: 0c9083eb4e7cc5841db15f0f873f3f0835b27b403f1cd428d7536dd9113f5c630e41a7af306f6e2c468d82c4bfe47911681c4eff5c47d6aa69309ca0d05d710f
+  metadata.gz: ec1b59468978c4561be944b5c4f61f892399e34a72f5bc790037f3c67f297e64ae7d625a1a69a7cb967239fc20e432d5d2aebe1d9358d792d56cc573747b05a4
+  data.tar.gz: 5bd9cd9b7dd02043d28c94ca569ecef5ae1e0ae5dd1990a4dff20ce6aaf0207fb94811805bfc37c5abf0eede7afbce6fc8963c731abf4327da3347af46b7b3c7

data/lib/music-transcription/note.rb

@@ -20,7 +20,9 @@ class Note
   end
   
   def ensure_positive_duration
-    raise ValueNotPositiveError, "duration #{@duration} is not positive" if @duration <= 0
+    unless @duration > 0
+      raise ValueNotPositiveError, "duration #{@duration} is not positive"
+    end
   end
   
   def == other
@@ -33,6 +35,10 @@ class Note
   def clone
     Marshal.load(Marshal.dump(self))
   end
+  
+  def clear_links
+    @links = {}
+  end
 
   def transpose diff
     self.clone.transpose! diff
@@ -62,10 +68,6 @@ class Note
     return self
   end
   
-  def valid?
-    @duration > 0
-  end
-  
   class Sixteenth < Note
     def initialize pitches = [], links: {}, accent: Accents::NONE
       super(Rational(1,16),pitches,links:links,accent:accent)

data/lib/music-transcription/validatable.rb

@@ -5,6 +5,7 @@ module Validatable
   
   def validate
     @errors = []
+    
     @check_methods.each do |check_method|
       begin
         send(check_method)
@@ -12,14 +13,18 @@ module Validatable
         @errors.push e
       end
     end
-    if respond_to?(:validatables)
-      validatables.each do |v|
-        @errors += v.validate
-      end
+    
+    validatables.each do |v|
+      @errors += v.validate
     end
+    
     return @errors
   end
   
+  def validatables
+    []
+  end
+  
   def valid?
     self.validate
     @errors.empty?

data/lib/music-transcription/version.rb

@@ -2,6 +2,6 @@
 module Music
 module Transcription
   # music-transcription version
-  VERSION = "0.7.2"
+  VERSION = "0.7.3"
 end
 end

data/spec/meter_spec.rb

@@ -58,7 +58,7 @@ describe Meter do
     }.each do |context_str,args|
       context context_str do
         it 'should return true' do
-          Score.new(*args).should be_valid
+          Meter.new(*args).should be_valid
         end
       end
     end
@@ -71,7 +71,7 @@ describe Meter do
     }.each do |context_str,args|
       context context_str do
         it 'should return false' do
-          Score.new(*args).should be_invalid
+          Meter.new(*args).should be_invalid
         end
       end      
     end

data/spec/note_spec.rb

@@ -36,6 +36,14 @@ describe Note do
     end
   end
   
+  describe '#clear_links' do
+    it 'should remove all links' do
+      n = Note.new(2,[C2,E2],links: {C2 => Link::Slur.new(D2)})
+      n.clear_links
+      n.links.should be_empty
+    end
+  end
+  
   describe '#transpose!' do
     context 'given pitch diff' do
       before(:all) do
@@ -113,8 +121,6 @@ describe Note do
     context 'note with 0 duration' do
       it 'should return false' do
         Note.new(0,[C2]).should be_invalid
-        require 'pry'
-        binding.pry
       end
     end
     

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: music-transcription
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - James Tunnell