museum 0.3.0 → 0.5.0

data/spec/models/case_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Museum::Case do
   include_context 'loupe support'
@@ -8,16 +8,16 @@ describe Museum::Case do
   it { should have_many(:case_details) }
 
   describe '#freshen_if_expired' do
-    subject { expired_package.freshen_if_expired.updated_at.to_datetime }
-    it { should be > (Time.now - Museum.configuration.refresh_interval).to_datetime}
+    subject { expired_package.freshen_if_expired }
+    its(:updated_at) { should be > (Time.now - Museum.configuration.refresh_interval) }
   end
 
   describe '#expired?' do
-    context 'on an expired package' do
+    describe 'on an expired package' do
       subject { expired_package.expired? }
       it { should be true }
     end
-    context 'on a fresh package' do
+    describe 'on a fresh package' do
       subject { fresh_package.expired? }
       it { should be false }
     end

data/spec/models/loupe_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Museum::Loupe do
   include_context 'loupe support'

data/spec/museum_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe "Museum" do
   it 'should return correct version string' do

data/spec/rails_helper.rb

@@ -0,0 +1,88 @@
+require 'coveralls'
+Coveralls.wear!
+
+# This file is copied to spec/ when you run 'rails generate rspec:install'
+ENV['RAILS_ENV'] ||= 'test'
+require File.expand_path('../dummy/config/environment', __FILE__)
+# Prevent database truncation if the environment is production
+abort("The Rails environment is running in production mode!") if Rails.env.production?
+require 'spec_helper'
+require 'rspec/rails'
+# Add additional requires below this line. Rails is not loaded until this point!
+require 'shoulda/matchers'
+require 'rspec/its'
+require 'factory_girl_rails'
+require 'database_cleaner'
+require 'rake'
+
+# Requires supporting ruby files with custom matchers and macros, etc, in
+# spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
+# run as spec files by default. This means that files in spec/support that end
+# in _spec.rb will both be required and run as specs, causing the specs to be
+# run twice. It is recommended that you do not name files matching this glob to
+# end with _spec.rb. You can configure this pattern with the --pattern
+# option on the command line or in ~/.rspec, .rspec or `.rspec-local`.
+#
+# The following line is provided for convenience purposes. It has the downside
+# of increasing the boot-up time by auto-requiring all files in the support
+# directory. Alternatively, in the individual `*_spec.rb` files, manually
+# require only the support files necessary.
+#
+Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f }
+
+# Checks for pending migration and applies them before tests are run.
+# If you are not using ActiveRecord, you can remove this line.
+ActiveRecord::Migrator.migrations_paths = 'spec/dummy/db/migrate'
+ActiveRecord::Migration.maintain_test_schema!
+
+RSpec.configure do |config|
+  config.expect_with(:rspec) { |c| c.syntax = :should }
+
+  # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
+  # config.fixture_path = "#{::Rails.root}/spec/fixtures"
+
+  # If you're not using ActiveRecord, or you'd prefer not to run each of your
+  # examples within a transaction, remove the following line or assign false
+  # instead of true.
+  config.use_transactional_fixtures = false
+
+  config.before(:suite) do
+    DatabaseCleaner.strategy = :transaction
+    # DatabaseCleaner.clean_with(:truncation)
+    # MuseumDummy::Application.load_tasks
+    # puts 'call rake'
+    # Rake::Task['db:seed'].invoke # loading seeds
+  end
+  config.around(:each) do |example|
+    DatabaseCleaner.cleaning do
+      example.run
+    end
+  end
+
+  # RSpec Rails can automatically mix in different behaviours to your tests
+  # based on their file location, for example enabling you to call `get` and
+  # `post` in specs under `spec/controllers`.
+  #
+  # You can disable this behaviour by removing the line below, and instead
+  # explicitly tag your specs with their type, e.g.:
+  #
+  #     RSpec.describe UsersController, :type => :controller do
+  #       # ...
+  #     end
+  #
+  # The different available types are documented in the features, such as in
+  # https://relishapp.com/rspec/rspec-rails/docs
+  config.infer_spec_type_from_file_location!
+
+  # Filter lines from Rails gems in backtraces.
+  # config.filter_rails_from_backtrace!
+  # arbitrary gems may also be filtered via:
+  # config.filter_gems_from_backtrace("gem name")
+end
+
+Shoulda::Matchers.configure do |config|
+  config.integrate do |with|
+    with.test_framework :rspec
+    with.library :rails
+  end
+end

data/spec/routing/engine_routes_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Museum::CasesController do
   routes { Museum::Engine.routes }

data/spec/spec_helper.rb

@@ -1,72 +1,92 @@
-ENV["RAILS_ENV"] ||= 'test'
-require File.expand_path("../dummy/config/environment", __FILE__)
-
-require 'coveralls'
-Coveralls.wear!
-
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-
-require 'rspec/rails'
-# require 'rspec/autorun'
-require 'rspec/its'
-require 'rails/all'
-
-require 'factory_girl_rails'
-
-require 'database_cleaner'
-require 'shoulda/matchers'
-require 'museum'
-
-# Requires supporting ruby files with custom matchers and macros, etc,
-# in spec/support/ and its subdirectories.
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
-
-# Checks for pending migrations before tests are run.
-# If you are not using ActiveRecord, you can remove this line.
-ActiveRecord::Migration.maintain_test_schema!
-
+# This file was generated by the `rails generate rspec:install` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# The `.rspec` file also contains a few flags that are not defaults but that
+# users commonly want.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-
-  config.before(:suite) do
-    DatabaseCleaner.strategy = :truncation
-    DatabaseCleaner.clean_with(:truncation)
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
   end
 
-  config.before(:each) do
-    DatabaseCleaner.start
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
   end
 
-  config.after(:each) do
-    DatabaseCleaner.clean
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+=begin
+  # These two settings work together to allow you to limit a spec run
+  # to individual examples or groups you care about by tagging them with
+  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  # get run.
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = "spec/examples.txt"
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  config.disable_monkey_patching!
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
   end
 
-  config.infer_spec_type_from_file_location!
-
-  # ## Mock Framework
-  #
-  # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
-  #
-  # config.mock_with :mocha
-  # config.mock_with :flexmock
-  # config.mock_with :rr
-
-  # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
-  # config.fixture_path = "#{::Rails.root}/spec/fixtures"
-
-  # If you're not using ActiveRecord, or you'd prefer not to run each of your
-  # examples within a transaction, remove the following line or assign false
-  # instead of true.
-  # config.use_transactional_fixtures = true
-
-  # If true, the base class of anonymous controllers will be inferred
-  # automatically. This will be the default behavior in future versions of
-  # rspec-rails.
-  config.infer_base_class_for_anonymous_controllers = false
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
 
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
-  config.order = "random"
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+=end
 end

data/spec/support/case_support.rb

@@ -1,7 +1,7 @@
 shared_context 'case support' do
-  let!(:dummy_package) { FactoryGirl.create(:case, :name => 'bootswitch') }
-  let!(:next_package) { FactoryGirl.create(:case, :name => 'customizable_bootstrap') }
-  let!(:last_package) { FactoryGirl.create(:case, :name => 'bootstrap_leather') }
-  let!(:fresh_package) { FactoryGirl.create(:case, :name => 'bootstrap_pager').freshen }
-  let!(:expired_package) { FactoryGirl.create(:case, :name => 'private_person', :updated_at => (Time.now - 14400).to_datetime) }
+  let!(:dummy_package) { Museum::Case.find_by_name('bootswitch') }
+  let!(:next_package) { Museum::Case.find_by_name('customizable_bootstrap') }
+  let!(:last_package) { Museum::Case.find_by_name('bootstrap_leather') }
+  let!(:fresh_package) { Museum::Case.find_by_name('bootstrap_pager').freshen }
+  let!(:expired_package) { Museum::Case.find_by_name('private_person') }
 end

data/spec/support/controller_behaviors.rb

@@ -0,0 +1,116 @@
+shared_examples_for 'a successful page' do |options = {}|
+  context 'responds successfully' do
+    subject { response }
+    it { should be_success }
+  end
+  if options[:which_renders].present?
+    it_behaves_like 'a page rendering a template', options[:which_renders]
+  end
+end
+shared_examples_for 'a page rendering a template' do |template|
+  context "renders the #{template} template" do
+    subject { response }
+    it { should render_template(template) }
+  end
+end
+shared_examples_for 'an error response' do |http_status|
+  context "issues error response code #{http_status}" do
+    subject { response }
+    it { should have_http_status(http_status) }
+  end
+end
+shared_examples_for 'a redirect to' do |path|
+  context "redirects to #{path}" do
+    subject { response }
+    it { should redirect_to path_to_url(path) }
+  end
+end
+shared_examples_for 'a redirect matching' do |path_expression|
+  context "redirects matching #{path_expression}" do
+    subject { response.location }
+    it { should match path_expression }
+  end
+end
+shared_examples_for 'a redirect to sign in' do
+  it_behaves_like 'a redirect to', '/users/sign_in'
+end
+shared_examples_for 'a redirect with a message' do |path, options|
+  it_behaves_like 'a redirect matching', path
+  options.each do |key, value|
+    context "sets #{key.to_s} message" do
+      subject { flash[key] }
+      it { should eq value }
+    end
+  end
+end
+shared_examples_for 'an error response with message' do |message|
+  it_behaves_like 'an error response', :forbidden
+  context 'sets failure message' do
+    subject { flash[:error] }
+    it { should eq message }
+  end
+end
+shared_examples_for 'a 404 Not Found error' do
+  it_behaves_like 'an error response', :not_found
+  it_behaves_like 'a page rendering a template', '404'
+end
+shared_examples_for 'a page with a message' do |options|
+  it_behaves_like 'a successful page'
+  options.each do |key, value|
+    context "sets #{key.to_s} message" do
+      subject { flash[key] }
+      it { should eq value }
+    end
+  end
+end
+shared_examples_for 'a page with a message matching' do |options|
+  it_behaves_like 'a successful page'
+  options.each do |key, value|
+    context "sets #{key.to_s} message" do
+      subject { flash[key] }
+      it { should match value }
+    end
+  end
+end
+shared_examples_for 'a page with an error message' do |message|
+  it_behaves_like 'a page with a message', error: message
+end
+shared_examples_for 'a page with an alert message' do |message|
+  it_behaves_like 'a page with a message', alert: message
+end
+shared_examples_for 'a page with a notice message' do |message|
+  it_behaves_like 'a page with a message', notice: message
+end
+shared_examples_for 'a page with an error message matching' do |message|
+  it_behaves_like 'a page with a message matching', error: message
+end
+shared_examples_for 'a 403 Forbidden error' do
+  it_should_behave_like 'an error response with message', 'You are not authorized to access this page.'
+end
+shared_examples_for 'a redirect with error' do |path, message|
+  it_behaves_like 'a redirect to', path
+  context 'sets error' do
+    subject { flash[:error] }
+    it { should eq message }
+  end
+end
+shared_examples_for 'a redirect with notice' do |path, message|
+  it_behaves_like 'a redirect to', path
+  context 'sets notice' do
+    subject { flash[:notice] }
+    it { should eq message }
+  end
+end
+shared_examples_for 'a redirect with alert' do |path, message|
+  it_behaves_like 'a redirect to', path
+  context 'sets alert' do
+    subject { flash[:alert] }
+    it { should eq message }
+  end
+end
+shared_examples_for 'a response without error' do
+  context 'sets no errors' do
+    subject { flash[:error] }
+    it { should be nil }
+  end
+end

data/spec/support/loupe_support.rb

@@ -1,4 +1,4 @@
 shared_context 'loupe support' do
-  let!(:rubygems) { FactoryGirl.create(:loupe, :title => 'RubyGems', :uri_template => 'http://www.rubygems.org/api/v1/gems/%{name}.json') }
-  let!(:github) { FactoryGirl.create(:loupe, :title => 'GitHub', :uri_template => 'https://api.github.com/repos/%{user}/%{name}') }
+  let!(:rubygems) { Museum::Loupe.find_by_title('RubyGems') }
+  let!(:github) { Museum::Loupe.find_by_title('GitHub') }
 end