musa-dsl 0.42.0 → 0.42.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f157001c0d45494eda872c34d4d73c161b686da78f0192868637873845ca62e
-  data.tar.gz: 2d93034d622985b67ae894d0cf7f4a5acdba787b4453fd6dbad08aa88d096866
+  metadata.gz: 613cf84af52f6eb5dcfd399b94417f1e175242f32f8dc7cb2ab6452ebb58e9d0
+  data.tar.gz: 2a19dc6002ab89ae77f973d8a4405de380e73230bbd3f986d240071f654d505d
 SHA512:
-  metadata.gz: 4dc00ab7d48971758d26bf982e8b61771fe81c26bd9e7cdedba97e457d3c97ff8286f7e53689712c97bb10674fe5f59261ee1f1186a1f20dbda87b62a16aa858
-  data.tar.gz: 9da464c4a8cfce824392e1c37b4987b84bde21c59924da5daf34b97b46c183d70d06afff212ab0de7d5b45971c7267aab5260730509b21522f12c49ab5474d46
+  metadata.gz: e61a579a8c116af3e420ec7c98756734a7b00252981a8b42a2fe8472fd18bea679793fa879ab2dc1e279558472b55ba55bcdd7d1cab5889bf39af204db3b461f
+  data.tar.gz: b1678d001558905ed9939580849e48e8ef5a79c3d3131959e46f0d2c4505c77b1030c91bc6c156cc650b1e42bd1b7d32d978bc730fb14e576b8b29a0e0b552d5

data/docs/subsystems/sequencer.md

@@ -88,6 +88,20 @@ end
 transport.start
 ```
 
+## Times and durations
+
+The Sequencer internally encodes time using `Rational`. It is preferable to use Rational values (`1/2r`, `1r`, `3/4r`) instead of Float (`0.5`, `1.0`, `0.75`) for times and durations, as this avoids potential precision issues in the internal conversion.
+
+```ruby
+# Preferable
+at 1/2r do ... end
+wait 3/4r do ... end
+every 1/4r do ... end
+
+# Works but may cause imprecision
+at 0.5 do ... end
+```
+
 ## API Reference
 
 **Complete API documentation:**

data/lib/musa-dsl/sequencer/base-sequencer-implementation-play-timed.rb

@@ -21,8 +21,6 @@ module Musa::Sequencer
     private def _play_timed(timed_serie, start_position, control, &block)
 
       if first_value_sample = timed_serie.peek_next_value
-        debug "_play_timed: first_value_sample #{first_value_sample}"
-
         hash_mode = first_value_sample[:value].is_a?(Hash)
 
         if hash_mode

data/lib/musa-dsl/sequencer/base-sequencer-tick-based.rb

@@ -43,6 +43,12 @@ module Musa
       # - Time signature-based composition (4/4, 3/4, etc.)
       # - Tick-precise event scheduling
       #
+      # ## Rational vs Float
+      #
+      # The sequencer internally encodes time as Rational. It is preferable to use
+      # Rational values for positions and durations, as using Float may cause
+      # precision issues in the conversion.
+      #
       # @example Creating tick-based sequencer (4/4, 96 ticks per beat)
       #   sequencer = BaseSequencer.new(4, 96)  # 4 beats, 96 ticks/beat
       #   sequencer.ticks_per_bar  # => 384r
@@ -202,19 +208,18 @@ module Musa
           ticks_position = position / @tick_duration
 
           if ticks_position.round != ticks_position
-            original_position = position
-            position = ticks_position.round * @tick_duration
-
             if warn
               @logger.warn('BaseSequencer') do
                 '_check_position: rounding ' \
-                  "position #{original_position.inspect} (#{original_position.to_f.round(5)}) "\
-                  "to tick precision: #{position.inspect} (#{position.to_f.round(5)})"
+                  "position #{position.inspect} (#{position.to_f.round(5)}) "\
+                  "to tick precision: #{(ticks_position.round * @tick_duration).inspect} (#{(ticks_position.round * @tick_duration).to_f.round(5)})"
               end
             end
           end
 
-          position
+          # Always convert to Rational to ensure consistent hash key types
+          # (Float keys like 1.5 would not match Rational keys like 3/2r in timeslots hash)
+          ticks_position.round * @tick_duration
         end
 
         # Holds tick accumulation during fast-forward.

data/lib/musa-dsl/version.rb

@@ -1,3 +1,3 @@
 module Musa
-  VERSION = '0.42.0'.freeze
+  VERSION = '0.42.1'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: musa-dsl
 version: !ruby/object:Gem::Version
-  version: 0.42.0
+  version: 0.42.1
 platform: ruby
 authors:
 - Javier Sánchez Yeste