mumukit-sync 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 380186a77555510417026bf6aabd063a83bea1f64182819b121df078c0a1b436
-  data.tar.gz: '09b3c4a045fdc53fd19546ce228744308e1949c306ab9e96af7d280b95cad36d'
+  metadata.gz: 292bb83cfe620088d9ee13efcc8a839aafc2337813de75f1d5cffb09c6e2cebb
+  data.tar.gz: 384b5cebfec6360b4af095963853016f8410cccfc6edff81d9477eada820c70c
 SHA512:
-  metadata.gz: cfde552120a8a206ea26977d98b17a95e654193f495299daf271bfc953fcec355c0fda02f2d0b46e2f7dfb1a446c694c8ae00691972b09363a485d128ce26204
-  data.tar.gz: 6d3dbc5dced89107a7256d6180b89e36dee7acfa81d8293502584d523fbd6a383f7619271f0c63e2b0b0d90901d00594106155cbd8f1ffd993963828a810e43b
+  metadata.gz: 549c13c8f22fb061d9a229f8d7ae484eddc9e01c9dc22d2d6ac2f082da0143db4c0460f459fa91f4221b1c7849cc33cc2f3b385ed45dbdfa9cf5c3c6cd6558e2
+  data.tar.gz: 7feb1370691b2a0d0158d24d7e4586c3d360b93bf2960bc3720640403f7e83f4eefff84735be79c335f3a6674ddba13d702d9745b6c4094c4bc836a1b6c4be14

data/lib/mumukit/sync/inflator/exercise.rb

@@ -1,7 +1,7 @@
 module Mumukit::Sync::Inflator
   class Exercise
     def inflate!(key, resource_h)
-      return unless key.kind == :guide
+      return unless key.kind.like? :guide
       resource_h[:exercises]&.each do |it|
         language = it.dig(:language, :name) || resource_h.dig(:language, :name)
         inflate_exercise! it, language, resource_h

data/lib/mumukit/sync/store/base.rb

@@ -1,6 +1,6 @@
 class Mumukit::Sync::Store::Base
   def read_resource(sync_key)
-    post_transform sync_key.kind, pre_transform(sync_key.kind, do_read(sync_key)).deep_symbolize_keys
+    transform_after_symbolize sync_key.kind, transform_before_symbolize(sync_key.kind, do_read(sync_key)).deep_symbolize_keys
   end
 
   private
@@ -8,11 +8,11 @@ class Mumukit::Sync::Store::Base
   # We are assuming rails-like models, that can be whitelisted,
   # and that resource-hashes resemble the model structure.
   # The store must ensure that only valid hashes are read
-  def pre_transform(key, json)
-    Mumukit::Sync.constantize(key).whitelist_attributes(json, relations: true)
+  def transform_before_symbolize(key, json)
+    key.as_module.whitelist_attributes(json, relations: true)
   end
 
-  def post_transform(_key, json)
+  def transform_after_symbolize(_key, json)
     json
   end
 end

data/lib/mumukit/sync/store/bibliotheca.rb

@@ -4,7 +4,7 @@ module Mumukit::Sync::Store
   ## from Bibliotheca API
   class Bibliotheca < Mumukit::Sync::Store::Base
     include Mumukit::Sync::Store::WithWrappedLanguage
-    include Mumukit::Sync::Store::WithIdFiltering
+    include Mumukit::Sync::Store::WithFilteredId
 
     def initialize(bibliotheca_bridge)
       @bibliotheca_bridge = bibliotheca_bridge

data/lib/mumukit/sync/store/github.rb

@@ -14,7 +14,7 @@ module Mumukit::Sync::Store
     end
 
     def read_resource(sync_key)
-      return unless sync_key.kind == :guide
+      return unless sync_key.kind.like? :guide
 
       Mumukit::Sync::Store::Github::GuideImport.new(
         bot: @bot,
@@ -23,7 +23,7 @@ module Mumukit::Sync::Store
     end
 
     def write_resource!(sync_key, resource_h)
-      return unless sync_key.kind == :guide
+      return unless sync_key.kind.like? :guide
 
       Mumukit::Sync::Store::Github::GuideExport.new(
         slug: sync_key.id,

data/lib/mumukit/sync/store/thesaurus.rb

@@ -12,7 +12,7 @@ module Mumukit::Sync::Store
     end
 
     def do_read(sync_key)
-      return unless sync_key.kind == :language
+      return unless sync_key.kind.like? :language
       # the only difference between an `importable_info`
       # and a `resource_h` is the way `runner_url` is named
       Mumukit::Bridge::Runner.new(sync_key.id)

data/lib/mumukit/sync/store/with_filtered_id.rb

@@ -0,0 +1,5 @@
+module Mumukit::Sync::Store::WithFilteredId
+  def transform_before_symbolize(key, json)
+    super.tap { |it| it.indifferent_delete(:id) }
+  end
+end

data/lib/mumukit/sync/store/with_wrapped_language.rb

@@ -1,6 +1,6 @@
 module Mumukit::Sync::Store::WithWrappedLanguage
-  def post_transform(key, json)
-    if key == :guide
+  def transform_after_symbolize(key, json)
+    if key.like? :guide
       guide = json.dup
       wrap_language! guide
       guide[:exercises].each { |exercise| wrap_language! exercise }

data/lib/mumukit/sync/store.rb

@@ -12,5 +12,5 @@ require_relative './store/github'
 require_relative './store/json'
 require_relative './store/thesaurus'
 require_relative './store/with_wrapped_language'
-require_relative './store/with_id_filtering'
+require_relative './store/with_filtered_id'
 require_relative './store/bibliotheca'

data/lib/mumukit/sync/syncer.rb

@@ -12,7 +12,7 @@ module Mumukit::Sync
     def initialize(store, inflators = [], resource_classifier = nil)
       @store = store
       @inflators = inflators
-      @resource_classifier ||= proc { |kind| Mumukit::Sync.constantize(kind) }
+      @resource_classifier ||= proc { |kind| kind.as_module }
     end
 
     def sync_keys_matching(id_regex = nil)

data/lib/mumukit/sync/version.rb

@@ -1,5 +1,5 @@
 module Mumukit
   module Sync
-    VERSION = '0.2.1'
+    VERSION = '0.3.0'
   end
 end

data/lib/mumukit/sync.rb

@@ -6,18 +6,16 @@ require "mumukit/sync/version"
 
 module Mumukit
   module Sync
-    ## Creates a sync key, composed of a `kind` and `id`
+
+    # Creates a sync key, composed of a `kind` and `id`
+    #
+    # kind: string|symbol|class
+    # id: object
+    #
+    # Warning: in order to test the `kind`, always use the `like?` message
     def self.key(kind, id)
       struct kind: kind, id: id
     end
-
-    def self.constantize(kind)
-      classify(kind).constantize
-    end
-
-    def self.classify(kind)
-      kind.to_s.classify
-    end
   end
 end
 

data/mumukit-sync.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'mumukit-core', '~> 1.11'
+  spec.add_dependency 'mumukit-core', '~> 1.12'
   spec.add_dependency 'mumukit-bridge', '~> 3.5'
   spec.add_dependency 'mumukit-auth', '~> 7.0'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mumukit-sync
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Franco Bulgarelli
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-11-23 00:00:00.000000000 Z
+date: 2018-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mumukit-core
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '1.12'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '1.12'
 - !ruby/object:Gem::Dependency
   name: mumukit-bridge
   requirement: !ruby/object:Gem::Requirement
@@ -170,7 +170,7 @@ files:
 - lib/mumukit/sync/store/json.rb
 - lib/mumukit/sync/store/null.rb
 - lib/mumukit/sync/store/thesaurus.rb
-- lib/mumukit/sync/store/with_id_filtering.rb
+- lib/mumukit/sync/store/with_filtered_id.rb
 - lib/mumukit/sync/store/with_wrapped_language.rb
 - lib/mumukit/sync/syncer.rb
 - lib/mumukit/sync/version.rb

data/lib/mumukit/sync/store/with_id_filtering.rb

@@ -1,5 +0,0 @@
-module Mumukit::Sync::Store::WithIdFiltering
-  def pre_transform(key, json)
-    super.tap { |it| it.indifferent_delete(:id) }
-  end
-end