mumukit-inspection 3.6.1 → 3.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1bb215d88c099d1f4c084eb43386cab8e6b0052fa2d81f068be5aa1540e32b86
-  data.tar.gz: 06fdb5f7a573f24f22a103d4da7111bf5ab11e54a9a3a012f35c12c50d550ebe
+  metadata.gz: eee225cdc6402627f59ef3c3ee6b2836ca1ab689e62604fc24d19cae88f6aef9
+  data.tar.gz: 4db88cc5cfb767abf7a9032d093dcbdd4a3b67a4c579d799946379f6177e0176
 SHA512:
-  metadata.gz: b07d8268f3705860b8539b21fc5f7faf6a777003a0bf1f1bae1baef8ef2f92105f8fcde2769082ed1ab73e845b7ebb43cb129e7db2251748aa8dce2524162de8
-  data.tar.gz: d29e582cc95422f3017adc91a4aa3742e47bfdbdfda296a20f25fd6aaca97f621bb60d931669eae63da06163a26bfd7fb4e7488bdaebbce7e231d9d90032c956
+  metadata.gz: d85712bf42f4b77d4544faeefbe64e053faf791c248b3ea254b3023b8a1d3a0d5c15a08b8ad15454238b7ec7f1d01889a0bd06e3629f308b412775f179c98b0b
+  data.tar.gz: 21e049e9826a632e08b6c944423e804c03e00a59ed6000d38e5e3bbf9ab1e7b88118b2156170e646439c6b1c22e9181eaac8ad42c3abe8b8a5db815d51ecbbd3

data/lib/locales/en.yml

@@ -102,6 +102,7 @@ en:
       HasAssignmentReturn: '%{binding} returns the result of an assignment'
       HasCodeDuplication: '%{binding} has code duplication'
       HasEmptyIfBranches: '%{binding} has empty <i>%{keyword_if}</i> branches'
+      HasLongParameterList: '%{binding} has too many parameters. You may be missing an abstraction.'
       HasMisspelledBindings: '%{binding} is misspelled'
       HasMisspelledIdentifiers: '%{binding} is misspelled'
       HasRedundantBooleanComparison: '%{binding} makes unnecesary boolean comparisons'
@@ -110,10 +111,13 @@ en:
       HasRedundantLambda: '%{binding} has unnecessary lambdas'
       HasRedundantLocalVariableReturn: '%{binding} has unnecesary local variables; please try returning the expression directly'
       HasRedundantParameter: '%{binding} has unnecessary parameters, that can be removed using point-free'
-      HasRedundantReduction: '%{binding} uses <i>%{keyword_is}</i>, but it does not artihmetic.'
+      HasRedundantReduction: '%{binding} uses <i>%{keyword_is}</i>, but it does not artihmetic'
+      HasTooManyMethods: '%{binding} has too many methods'
       HasTooShortBindings: '%{binding} is a too short identifier'
-      HasUnreachableCode: '%{binding} has unreachable code.'
+      HasTooShortIdentifiers: '%{binding} is a too short identifier'
+      HasUnreachableCode: '%{binding} has unreachable code'
       HasWrongCaseBindings: '%{binding} does not honor case conventions'
+      HasWrongCaseIdentifiers: '%{binding} does not honor case conventions'
       Implements_except: '%{binding} %{must} implement interfaces distinct from %{target}'
       Implements_like: '%{binding} %{must} implement interfaces like %{target}'
       Implements_named: '%{binding} %{must} implement %{target}'
@@ -127,6 +131,7 @@ en:
       Instantiates_named: '%{binding} %{must} instantiate %{target}'
       Instantiates: '%{binding} %{must} instantiate objects'
       IsLongCode: '%{binding} is too long'
+      OverridesEqualOrHashButNotBoth: '%{binding} overrides <i>equals</i> or <i>hash</i> methods, but not both'
       Raises_except: '%{binding} %{must} throw exceptions distinct from %{target}'
       Raises_like: '%{binding} %{must} throw exceptions like %{target}'
       Raises_named: '%{binding} %{must} throw %{target}'

data/lib/locales/es.yml

@@ -98,14 +98,15 @@ es:
       DeclaresVariable_like: '%{binding} %{must} declarar una variable parecida a %{target}'
       DeclaresVariable_named: '%{binding} %{must} declarar una variable %{target}'
       DeclaresVariable: '%{binding} %{must} debe declarar variables'
-      DiscardsExceptions: '%{binding} está ignorando exceptiones silenciosamiente.'
-      DoesConsolePrint: '%{binding} está realizando impresiones por pantalla.'
+      DiscardsExceptions: '%{binding} está ignorando excepciones silenciosamiente'
+      DoesConsolePrint: '%{binding} está realizando impresiones por pantalla'
       DoesNilTest: '%{binding} hace comparaciones contra <i>%{keyword_null}</i>'
       DoesNullTest: '%{binding} hace comparaciones contra <i>%{keyword_null}</i>'
       DoesTypeTest: '%{binding} hace comparaciones contra strings'
       HasAssignmentReturn: '%{binding} devuelve el resultado de una asignación'
       HasCodeDuplication: '%{binding} tiene código repetido'
       HasEmptyIfBranches: '%{binding} tiene ramas de <i>%{keyword_if}</i> vacías'
+      HasLongParameterList: '%{binding} tiene demasiados parámetros. Te podría estar faltando una abstracción'
       HasMisspelledBindings: '%{binding} está mal escrito. Revisá la ortografía y procurá no usar abreviaturas'
       HasMisspelledIdentifiers: '%{binding} está mal escrito. Revisá la ortografía y procurá no usar abreviaturas'
       HasRedundantBooleanComparison: '%{binding} hace comparaciones booleanas innecesarias'
@@ -114,10 +115,11 @@ es:
       HasRedundantLambda: '%{binding} tiene lambdas innecesarias'
       HasRedundantLocalVariableReturn: '%{binding} usa variables locales innecesarias; podés retornar directamente la expresión'
       HasRedundantParameter: '%{binding} tiene parámetros innecesarios (se pueden eliminar mediante point-free)'
-      HasRedundantReduction: '%{binding} usa <i>%{keyword_is}</i>, pero no realiza cálculos.'
+      HasRedundantReduction: '%{binding} usa <i>%{keyword_is}</i>, pero no realiza cálculos'
+      HasTooManyMethods: '%{binding} tiene demasiados métodos'
       HasTooShortBindings: '%{binding} es un identificador muy corto'
       HasTooShortIdentifiers: '%{binding} es un identificador muy corto'
-      HasUnreachableCode: '%{binding} tiene código inalcanzable.'
+      HasUnreachableCode: '%{binding} tiene código inalcanzable'
       HasWrongCaseBindings: '%{binding} no respeta la convención de nombres'
       HasWrongCaseIdentifiers: '%{binding} no respeta la convención de nombres'
       Implements_except: '%{binding} %{must} implementar interfaces distintas de %{target}'
@@ -137,14 +139,15 @@ es:
       Instantiates_named: '%{binding} %{must} instanciar %{target}'
       Instantiates: '%{binding} %{must} instanciar objetos'
       IsLongCode: '%{binding} es muy largo. Tratá de delegar más'
+      OverridesEqualOrHashButNotBoth: '%{binding} redefine los métodos <i>equals</i> o <i>hash</i>, pero no ambos'
       Raises_except: '%{binding} %{must} lanzar excepciones diferentes a %{target}'
       Raises_like: '%{binding} %{must} lanzar excepciones parecidas a %{target}'
       Raises_named: '%{binding} %{must} lanzar %{target}'
-      Raises: '%{binding} %{must} lanzar exceptiones'
+      Raises: '%{binding} %{must} lanzar excepciones'
       Rescues_except: '%{binding} %{must} capturar excepciones diferentes a %{target}'
       Rescues_like: '%{binding} %{must} capturar excepciones parecidas a %{target}'
       Rescues_named: '%{binding} %{must} capturar %{target}'
-      Rescues: '%{binding} %{must} capturar exceptiones'
+      Rescues: '%{binding} %{must} capturar excepciones'
       ReturnsNil: '%{binding} retorna null, lo cual es una mala práctica'
       ReturnsNull: '%{binding} retorna null, lo cual es una mala práctica'
       SourceContains_named: 'la solución %{must} usar %{target}'
@@ -170,8 +173,8 @@ es:
       UsesCut: '%{binding} usa el operador !, lo cual es una mala práctica'
       UsesDyamicPolymorphism: '%{binding} %{must} usar polimorfismo'
       UsesDynamicMethodOverload: '%{binding} %{must} usar sobrecarga'
-      UsesExceptionHandling: '%{binding} %{must} realizar manejo de exceptiones'
-      UsesExceptions: '%{binding} %{must} usar exceptiones'
+      UsesExceptionHandling: '%{binding} %{must} realizar manejo de excepciones'
+      UsesExceptions: '%{binding} %{must} usar excepciones'
       UsesFail: '%{binding} usa <i>%{keyword_fail}</li>, lo cual es una mala práctica'
       UsesFindall: '%{binding} %{must} utilizar <i>%{keyword_findall}</i>'
       UsesForall: '%{binding} %{must} utilizar <i>%{keyword_forall}</i>'

data/lib/locales/pt.yml

@@ -98,14 +98,15 @@ pt:
       DeclaresVariable_like: '%{binding} %{must} declarar uma variável semelhante a %{target}'
       DeclaresVariable_named: '%{binding} %{must} declarar uma variável %{target}'
       DeclaresVariable: '%{binding} %{must} deve declarar variáveis'
-      DiscardsExceptions: '%{binding}  está silenciosamente ignorando exceções.'
-      DoesConsolePrint: '%{binding}  está fazendo impressões na tela.'
+      DiscardsExceptions: '%{binding}  está silenciosamente ignorando exceções'
+      DoesConsolePrint: '%{binding}  está fazendo impressões na tela'
       DoesNilTest: '%{binding}  faz comparações contra <i>%{keyword_null}</i>'
       DoesNullTest: '%{binding}  faz comparações contra <i>%{keyword_null}</i>'
       DoesTypeTest: '%{binding}  faz comparações contra strings'
       HasAssignmentReturn: '%{binding}  retorna o resultado de uma tarefa'
       HasCodeDuplication: '%{binding}  tem código repetido'
       HasEmptyIfBranches: '%{binding} tem vazio <i>%{keyword_if}</i> ramos'
+      HasLongParameterList: '%{binding} tem muitos parâmetros. Você pode estar perdendo uma abstração.'
       HasMisspelledBindings: '%{binding}  está incorreto. Verifique a ortografia e tente não usar abreviaturas'
       HasMisspelledIdentifiers: '%{binding}  está incorreto. Verifique a ortografia e tente não usar abreviaturas'
       HasRedundantBooleanComparison: '%{binding}  faz comparações booleanas desnecessárias'
@@ -114,11 +115,11 @@ pt:
       HasRedundantLambda: '%{binding}  possui lambdas desnecessários'
       HasRedundantLocalVariableReturn: '%{binding}  usa variáveis ​​locais desnecessárias; você pode retornar a expressão diretamente'
       HasRedundantParameter: '%{binding}  possui parâmetros desnecessários (pode ser removido por ponto-livre)'
-      HasRedundantReduction: '%{binding}  usa <i>%{keyword_is}</i>, mas não executa cálculos.'
+      HasRedundantReduction: '%{binding}  usa <i>%{keyword_is}</i>, mas não executa cálculos'
+      HasTooManyMethods: '%{binding} tem muitos métodos'
       HasTooShortBindings: '%{binding}  é um identificador muito curto'
-      HasTooShortIdentifiers: '%{binding}  é um identificador muito curto'
-      HasTooShortIdentifiers: '%{binding}  é um identificador muito curto'
-      HasUnreachableCode: '%{binding} tem código inacessível.'
+      HasTooShortIdentifiers: '%{binding} é um identificador muito curto'
+      HasUnreachableCode: '%{binding} tem código inacessível'
       HasWrongCaseBindings: '%{binding}  não respeita a convenção de nomenclatura'
       HasWrongCaseIdentifiers: '%{binding}  não respeita a convenção de nomenclatura'
       Implements_except: '%{binding} %{must} implementar interfaces diferentes de %{target}'
@@ -134,6 +135,7 @@ pt:
       Instantiates_named: '%{binding} %{must} instantiate %{target}'
       Instantiates: '%{binding} %{must} instanciar objetos'
       IsLongCode: '%{binding}  é muito longo. Tente delegar mais'
+      OverridesEqualOrHashButNotBoth: '%{binding} redefine os métodos <i>equals</i> ou <i>hash </i>, mas não ambos'
       Raises_except: '%{binding} %{must} lançar exceções diferentes de %{target}'
       Raises_like: '%{binding} %{must} lançar exceções semelhantes a %{target}'
       Raises_named: '%{binding} %{must} launch %{target}'

data/lib/mumukit/inspection/expectation.rb

@@ -1,11 +1,13 @@
 class Mumukit::Inspection::Expectation
 
-  SMELLS = %w(DiscardsExceptions DoesConsolePrint DoesNullTest DoesTypeTest
-              HasAssignmentReturn HasCodeDuplication HasEmptyIfBranches HasMisspelledIdentifiers
+  SMELLS = %w(DiscardsExceptions DoesConsolePrint DoesNilTest DoesNullTest DoesTypeTest
+              HasAssignmentReturn HasCodeDuplication HasEmptyIfBranches HasLongParameterList
+              HasMisspelledBindings HasMisspelledIdentifiers
               HasRedundantBooleanComparison HasRedundantGuards HasRedundantIf
               HasRedundantLambda HasRedundantLocalVariableReturn HasRedundantParameter
-              HasRedundantReduction HasTooShortIdentifiers HasUnreachableCode
-              HasWrongCaseIdentifiers IsLongCode ReturnsNull UsesCut UsesFail UsesUnificationOperator)
+              HasRedundantReduction HasTooManyMethods HasTooShortBindings HasTooShortIdentifiers HasUnreachableCode
+              HasWrongCaseBinding HasWrongCaseIdentifiers IsLongCode OverridesEqualOrHashButNotBoth
+              ReturnsNil ReturnsNull UsesCut UsesFail UsesUnificationOperator)
 
   attr_accessor :binding, :inspection
 

data/lib/mumukit/inspection/version.rb

@@ -1,5 +1,5 @@
 module Mumukit
   class Inspection
-    VERSION = '3.6.1'
+    VERSION = '3.6.2'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mumukit-inspection
 version: !ruby/object:Gem::Version
-  version: 3.6.1
+  version: 3.6.2
 platform: ruby
 authors:
 - Franco Leonardo Bulgarelli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-03 00:00:00.000000000 Z
+date: 2019-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mumukit-core
@@ -120,8 +120,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Minimal library for parsing Mumuki inspection language