mumuki-laboratory 7.4.2 → 7.6.1

data/app/assets/stylesheets/mumuki_laboratory/application/modules/popover.scss

@@ -5,5 +5,5 @@
 }
 
 .popover {
-  max-width: 30%;
+  max-width: 50%;
 }

data/app/controllers/application_controller.rb

@@ -7,20 +7,29 @@ class ApplicationController < ActionController::Base
   include Mumukit::Login::AuthenticationHelpers
 
   include Mumuki::Laboratory::Controllers::Authorization
+  include Mumuki::Laboratory::Controllers::Disabling
   include Mumuki::Laboratory::Controllers::Notifications
   include Mumuki::Laboratory::Controllers::DynamicErrors
   include Mumuki::Laboratory::Controllers::EmbeddedMode
 
   before_action :set_current_organization!
   before_action :set_locale!
+
+  before_action :ensure_user_enabled!, if: :current_user?
+  before_action :validate_active_organization!
+
   before_action :redirect_to_main_organization!, if: :should_redirect_to_main_organization?
+
   before_action :authorize_if_private!
+  before_action :validate_active_organization!
   before_action :validate_user_profile!, if: :current_user?
+
   before_action :visit_organization!, if: :current_user?
 
   after_action :leave_organization!
 
-  helper_method :login_button,
+  helper_method :current_workspace,
+                :login_button,
                 :notifications_count,
                 :user_notifications_path,
                 :has_notifications?,
@@ -49,8 +58,14 @@ class ApplicationController < ActionController::Base
     accessible_subject.validate_accessible_for! current_user
   end
 
+  def validate_active_organization!
+    return if current_user&.teacher_here?
+    Organization.current.validate_active!
+  end
+
+
   # required by Mumukit::Login
-  def login_button(options={})
+  def login_button(options = {})
     login_form.button_html I18n.t(:sign_in), options[:class]
   end
 
@@ -60,8 +75,16 @@ class ApplicationController < ActionController::Base
     raise Mumuki::Domain::NotFoundError unless content.usage_in_organization.try { |usage| redirect_to usage }
   end
 
+  def current_workspace
+    Mumuki::Domain::Workspace.new(current_user, Organization.current)
+  end
+
   private
 
+  def from_sessions?
+    params['controller'] == 'login'
+  end
+
   def login_settings
     Organization.current.login_settings
   end

data/app/controllers/concerns/users_controller_template.rb

@@ -6,16 +6,21 @@ module UsersControllerTemplate
     before_action :set_user!, only: [:show, :update]
     before_action :set_new_user!, only: :create
     before_action :protect_permissions_assignment!, only: [:create, :update]
+    after_action :verify_user_name!, only: :create
   end
 
   private
 
+  def verify_user_name!
+    @user.verify_name!
+  end
+
   def protect_permissions_assignment!
     current_user.protect_permissions_assignment! user_params[:permissions], @user.permissions_was
   end
 
   def permissible_params
-    super + [:email, :image_url, permissions: Mumukit::Auth::Roles::ROLES]
+    super + [:email, :image_url, :verified_first_name, :verified_last_name, permissions: Mumukit::Auth::Roles::ROLES]
   end
 
   def set_user!

data/app/controllers/invitations_controller.rb

@@ -7,6 +7,7 @@ class InvitationsController < ApplicationController
 
   skip_before_action :validate_user_profile!
   skip_before_action :authorize_if_private!
+  skip_before_action :validate_active_organization!
 
   def show
     redirect_to_organization! if current_user.student_of? @invitation.course

data/app/controllers/login_controller.rb

@@ -3,6 +3,7 @@ class LoginController < ApplicationController
 
   skip_before_action :verify_authenticity_token, if: lambda { Rails.env.development? }
   skip_before_action :validate_user_profile!
+  skip_before_action :validate_active_organization!
 
   private
 

data/app/helpers/application_helper.rb

@@ -7,7 +7,7 @@ module ApplicationHelper
   end
 
   def profile_picture
-    image_tag(current_user.image_url, height: 40, class: 'img-circle', onError: "this.onerror = null; this.src = '#{image_url('user_shape.png')}'")
+    image_tag(current_user.profile_picture, height: 40, class: 'img-circle', onError: "this.onerror = null; this.src = '#{image_url('user_shape.png')}'")
   end
 
   def paginate(object, options={})
@@ -39,7 +39,3 @@ module ApplicationHelper
     }.html_safe
   end
 end
-
-def sanitized(html)
-  Mumukit::ContentType::Sanitizer.sanitize html
-end

data/app/helpers/contextualization_result_helper.rb

@@ -1,10 +1,6 @@
 module ContextualizationResultHelper
-  def humanized_expectation_result_item(expectation_result)
-    %Q{<li>#{status_icon(expectation_result[:result])} #{humanized_expectation_explanation expectation_result}</li>}.html_safe
-  end
-
-  def humanized_expectation_explanation(expectation_result)
-    sanitized Mumukit::ContentType::Markdown.to_html(expectation_result[:explanation], one_liner: true)
+  def render_affable_expectation_result(affable_expectation_result)
+    %Q{#{status_icon(affable_expectation_result[:result])} #{affable_expectation_result[:explanation]}}.html_safe
   end
 
   def render_feedback?(contextualization)
@@ -19,12 +15,16 @@ module ContextualizationResultHelper
     if contextualization.exercise.hidden?
       :hidden_done
     elsif contextualization.exercise.choice?
-      contextualization.passed? ? :correct_answer : :wrong_answer
+      contextualization.solved? ? :correct_answer : :wrong_answer
     else
       contextualization.submission_status
     end
   end
 
+  def render_test_result_header(test_result)
+    [test_result[:title].presence, test_result[:summary]].compact.join(': ').html_safe
+  end
+
   def render_test_results(contextualization)
     if contextualization.test_results.present?
       template = contextualization.result.present? ? 'layouts/mixed_results' : 'layouts/test_results'

data/app/helpers/discussions_helper.rb

@@ -48,7 +48,7 @@ module DiscussionsHelper
   end
 
   def user_avatar(user, image_class='')
-    image_tag user.image_url, height: 40, class: "img-circle #{image_class}"
+    image_tag user.profile_picture, height: 40, class: "img-circle #{image_class}"
   end
 
   def discussions_link_with_teaser(item)

data/app/helpers/exercise_input_helper.rb

@@ -44,7 +44,7 @@ module ExerciseInputHelper
   end
 
   def should_render_need_help_dropdown?(assignment, organization = Organization.current)
-    !assignment.passed? && organization.ask_for_help_enabled?(assignment.submitter)
+    !assignment.solved? && organization.ask_for_help_enabled?(assignment.submitter)
   end
 
   def render_submit_button(assignment)

data/app/helpers/links_helper.rb

@@ -14,7 +14,7 @@ module LinksHelper
   end
 
   def link_to_status_codes(code)
-    "<a href='https://es.wikipedia.org/wiki/Anexo:C%C3%B3digos_de_estado_HTTP'> #{I18n.t("error_#{code}")} </a>"
+    "<a href='https://es.wikipedia.org/wiki/Anexo:C%C3%B3digos_de_estado_HTTP' target='_blank'> #{I18n.t("error_#{code}")} </a>"
   end
 
   def url_for_application(app_name)

data/app/helpers/overlapped_buttons_helper.rb

@@ -0,0 +1,17 @@
+module OverlappedButtonsHelper
+  def restart_icon
+    overlapped_button_icon :restart, :undo
+  end
+
+  def format_icon
+    overlapped_button_icon :format, :indent
+  end
+
+  def restart_guide_link(guide)
+    link_to restart_icon, guide_progress_path(guide), class: 'mu-content-toolbar-item', data: {confirm: t(:confirm_restart)}, method: :delete
+  end
+
+  def overlapped_button_icon(key, icon)
+    fa_icon(icon, title: t(key), class: 'fa-fw', role: 'button', 'aria-label': t(key))
+  end
+end

data/app/views/book/show.html.erb

@@ -32,13 +32,21 @@
 
   <h2><%= t(:chapters) %></h2>
 
-  <% @book.chapters.each do |it| %>
-    <div class="chapter">
-      <h3><%= it.number %>. <%= link_to_path_element it, mode: :plain %></h3>
-
-      <div class="text-box">
-        <%= it.description_teaser_html %>
+  <% @book.chapter_visibilities_in(current_workspace).each do |it, enabled| %>
+    <div class="chapter-container">
+      <div class="chapter <%= enabled ? '' : 'mu-locked' %>">
+        <h3><%= it.number %>. <%= link_to_path_element it, mode: :plain %></h3>
+        <div class="text-box" <%= 'aria-label=""' unless enabled %>%>
+          <%= it.description_teaser_html %>
+        </div>
       </div>
+
+      <% unless enabled  %>
+        <div class="text-center mu-lock">
+          <i class="fa fa-lock fa-5x"></i>
+          <p><%= t :locked_content %></p>
+        </div>
+      <% end %>
     </div>
   <% end %>
   <% if current_user? && @exams.present? %>

data/app/views/errors/gone.html.erb

@@ -4,7 +4,10 @@
     </div>
     <div class="body">
       <p>
-        <%= t(:gone_explanation, error: link_to_status_codes(410)).html_safe %>
+        <%= t(:error_description, error: link_to_status_codes(410)).html_safe %>
+      </p>
+      <p>
+        <%= Organization.current.explain_error(410, explanation).html_safe %>
       </p>
       <p>
         <a class="btn btn-success" href="/"> <%= t(:back_to_mumuki) %> </a>

data/app/views/exercise_solutions/_expectations.html.erb

@@ -5,8 +5,8 @@
     <% end %>
 
     <ul class="results-list">
-      <% assignment.humanized_expectation_results.each do |it| %>
-        <%= humanized_expectation_result_item it %>
+      <% assignment.affable_expectation_results.each do |it| %>
+        <li><%= render_affable_expectation_result it %></li>
       <% end %>
     </ul>
   </div>

data/app/views/exercise_solutions/_kids_results_button.html.erb

@@ -1,7 +1,7 @@
 <div class="row">
   <div class="col-md-12">
     <div class="actions">
-      <% if assignment.passed? %>
+      <% if assignment.solved? %>
         <%= next_exercise_button(@exercise) || close_modal_button %>
       <% else %>
         <button class="btn btn-success btn-block submission-control" id="kids-btn-retry" data-dismiss="modal" aria-label="<%= t :retry_exercise %>"> <%= t :retry_exercise %> </button>

data/app/views/exercises/_read_only.html.erb

@@ -94,7 +94,7 @@
         </div>
       </div>
 
-      <div role="tabpanel" class="tab-pane mu-input-panel fade" id="visible-extra">
+      <div role="tabpanel" class="tab-pane mu-input-panel fade mu-elipsis" id="visible-extra">
         <%= @discussion.extra_preview_html %>
       </div>
     </div>

data/app/views/exercises/show.html.erb

@@ -9,23 +9,23 @@
 <% @stats = @exercise.guide.stats_for(current_user) if current_user && @exercise.guide %>
 
 <% if @exercise.navigable_parent.timed? && !current_user.teacher? %>
-    <%= render partial: 'layouts/timer', locals: {end_time: @exercise.navigable_parent.real_end_time(current_user)} %>
+  <%= render partial: 'layouts/timer', locals: {end_time: @exercise.navigable_parent.real_end_time(current_user)} %>
 <% end %>
 
 <% unless @exercise.input_kids? %>
-    <div class="row">
-      <div class="mu-inline-block-right hidden-xs">
-        <h1><%= language_icon @exercise.language %></h1>
-      </div>
-      <div class="mu-inline-block-left">
-        <h1>
-          <span class="hidden-xs"><%= t(:exercise_number, number: @exercise.number) %>:&nbsp;</span>
-          <span><%= @exercise.name %></span>
-          <%= teacher_info_button @exercise %>
-          <%= link_to_bibliotheca_exercise @exercise %>
-        </h1>
-      </div>
+  <div class="row">
+    <div class="mu-inline-block-right hidden-xs">
+      <h1><%= language_icon @exercise.language %></h1>
     </div>
+    <div class="mu-inline-block-left">
+      <h1>
+        <span class="hidden-xs"><%= t(:exercise_number, number: @exercise.number) %>:&nbsp;</span>
+        <span><%= @exercise.name %></span>
+        <%= teacher_info_button @exercise %>
+        <%= link_to_bibliotheca_exercise @exercise %>
+      </h1>
+    </div>
+  </div>
 <% end %>
 
 <div>
@@ -54,6 +54,10 @@
 </div>
 
 <%= content_for :no_container do %>
-    <%= render partial: 'layouts/modals/guide_corollary', locals: {guide: @guide} %>
-    <%= render partial: 'layouts/modals/new_message', locals: {exercise: @exercise} if should_render_message_input?(@exercise) %>
+  <% if @assignment.skipped? %>
+    <%= render partial: 'layouts/exercise_skipped' %>
+  <% end %>
+
+  <%= render partial: 'layouts/modals/guide_corollary', locals: {guide: @guide} %>
+  <%= render partial: 'layouts/modals/new_message', locals: {exercise: @exercise} if should_render_message_input?(@exercise) %>
 <% end if current_user? %>

data/app/views/layouts/_exercise_skipped.html.erb

@@ -0,0 +1,28 @@
+<div class="modal fade mu-exercise-skipped" id="exercise-skipped" tabindex="-1" role="dialog" aria-hidden="true">
+  <div class="modal-dialog">
+    <div class="modal-content">
+      <div class="modal-header">
+        <p class="modal-title text-center title-font"><%= t :skipped_congratulations %></p>
+      </div>
+      <div class="modal-body">
+        <div class="container-fluid">
+          <%= t :skipped_description %>
+          <%= link_to (t :skipped_solve_anyway), "", "data-dismiss" => "modal" %>
+        </div>
+      </div>
+      <div class="modal-footer">
+        <div class="row">
+          <div class="col-md-12">
+            <%= next_exercise_button(@exercise) %>
+          </div>
+        </div>
+      </div>
+    </div>
+  </div>
+</div>
+<script>
+  $("#exercise-skipped").modal({
+    backdrop: 'static',
+    keyboard: false
+  });
+</script>

data/app/views/layouts/_kids.html.erb

@@ -17,7 +17,7 @@
     <div class="description"><%= exercise.description_task %></div>
     <div class="hint" style="display: none"><%= exercise.hint_html %></div>
   </div>
-  <div class="mu-kids-character-speech-bubble-failed <%= @assignment&.status %>" style="display: none"></div>
+  <div class="mu-kids-character-speech-bubble-failed <%= current_user? && @assignment.status %>" style="display: none"></div>
 </div>
 <div id="mu-kids-discussion-link-html" class="hidden">
   <%= kids_read_discussions_link(exercise) %>

data/app/views/layouts/_test_results.html.erb

@@ -1,27 +1,30 @@
-<% if contextualization.single_visual_result? %>
-  <%= contextualization.single_visual_result_html %>
+<% if contextualization.single_visible_test_result? %>
+  <div class="mu-single-test-result">
+    <h5 class="text-danger mu-test-result-header"><%= render_test_result_header contextualization.affable_test_results.first %></h5>
+    <%= contextualization.first_test_result_html %>
+  </div>
 <% else %>
   <strong><%= t :test_results %>:</strong>
-  <ul class="results-list">
-    <% contextualization.test_results.each_with_index do |test_result, index| %>
+  <ul class="results-list mu-multiple-test-results">
+    <% contextualization.affable_test_results.each_with_index do |test_result, index| %>
       <li>
         <% if test_result[:status].failed? %>
-          <span class="text-danger">
+          <span class="text-danger mu-test-result-header">
             <%= status_icon(test_result[:status]) %>
-            <strong class="example-title"><%= test_result[:title] %></strong>
+            <%= render_test_result_header test_result %>
             <% unless contextualization.visible_success_output? %>
               <a data-toggle="collapse" href="#example-result-<%= index %>"  class="example-see-more"><%= t :view_details %></a>
             <% end %>
           </span>
         <% else %>
-          <span class="text-success example-title">
+          <span class="text-success mu-test-result-header">
             <%= status_icon(test_result[:status]) %>
             <%= test_result[:title] %>
           </span>
         <% end %>
 
         <div class="example-result collapse <%= 'in' if contextualization.visible_success_output? %>" id="example-result-<%= index %>">
-          <%= contextualization.output_content_type.to_html test_result[:result] %>
+          <%= contextualization.test_result_html test_result %>
         </div>
       </li>
     <% end %>

data/app/views/layouts/exercise_inputs/editors/_code.html.erb

@@ -4,13 +4,14 @@
                   class: 'form-control editor',
                   value: @current_content,
                   data: {lines: 17} %>
-  <a class="editor-resize" title="<%= t(:fullscreen) %> (F11)">
-    <span class="fa-stack fa-lg">
-      <i class="fa fa-square-o fa-stack-2x"></i>
-      <i class="fa fa-expand fa-stack-1x"></i>
-    </span>
-  </a>
   <div class="mu-overlapped">
-    <a class="editor-reset submission-reset"><%= restart_icon %></a>
+    <a class="editor-resize" title="<%= t(:fullscreen) %> (F11)">
+      <span class="fa-stack fa-lg">
+        <i class="fa fa-square-o fa-stack-2x"></i>
+        <i class="fa fa-expand fa-stack-1x"></i>
+      </span>
+    </a>
+    <a class="editor-format"><%= format_icon %></a>
+    <a class="editor-reset submission-reset" data-confirm="<%= t(:confirm_reset) %>"><%= restart_icon %></a>
   </div>
 </div>

data/app/views/layouts/exercise_inputs/editors/_multiple_files.html.erb

@@ -26,15 +26,14 @@
       <% end %>
     </div>
 
-    <a class="editor-resize multiple-files" title="<%= t(:fullscreen) %> (F11)">
-      <span class="fa-stack fa-lg">
-        <i class="fa fa-square-o fa-stack-2x"></i>
-        <i class="fa fa-expand fa-stack-1x"></i>
-      </span>
-    </a>
-
-    <div class="mu-overlapped">
-      <a class="editor-reset submission-reset"><%= restart_icon %></a>
+    <div class="mu-overlapped multiple-files">
+      <a class="editor-resize" title="<%= t(:fullscreen) %> (F11)">
+        <span class="fa-stack fa-lg">
+          <i class="fa fa-square-o fa-stack-2x"></i>
+          <i class="fa fa-expand fa-stack-1x"></i>
+        </span>
+      </a>
+      <!--<a class="editor-reset submission-reset" data-confirm="<%= t(:confirm_reset) %>"><%= restart_icon %></a> -->
     </div>
 
   </div>