mumuki-laboratory 7.4.0 → 7.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7c23a0042d4601c10b7b61f3196cb7e227fe0ac33f9c7a48b70c57a8a12854cb
-  data.tar.gz: ee21361e7e928cdd3552e00c112ef2d4a38215b8e165f353e9ec701dfa1a22f9
+  metadata.gz: 79986a0a901198e3180b64363b42fe60ec3624770f91d5344ed24924c0ea35e4
+  data.tar.gz: f4697b90f0db3248d2fb9fbf05f1a96cdb8b778b0025f77f9a425180271e7c79
 SHA512:
-  metadata.gz: df62506d35e812616ec5476b728d89d8128594503c04b9d152778be3aa4242f209cd20578a49ca85df231e7bc812b3530a555680b897034667f006bc56f53f60
-  data.tar.gz: b4c914f2ebaa83f9d685b0e87262e8f1588e154896cc0f18fa434c00edd3504324b63c10f8251f607990d3d9bf4d50b30d35d5f1459e7416b8d456b5a57ca3db
+  metadata.gz: ca14a8ab6f454820fa4712bd876e3c3d4598febfe95789b078ab6ea67ad2ba80974f9c71e8f62cf500690bb60986e48e87c4437f7f806cb161c92de14c8261dd
+  data.tar.gz: b34ea27ac01bbde88b65a5f38410b5b3b743dd4847b60e7e5c8d26c061740f7ac2bd4e0dac38ca1748dfdad698e861362fedde047d6ee03d97e5810d50830ecc

data/README.md

@@ -178,6 +178,12 @@ which are granted to be safe and stable.
 
 * `mumuki.bridge.Laboratory`
   * `.runTests`
+* `mumuki.editor`
+  * `formatContent`
+  * `reset`
+  * `toggleFullscreen`
+* `mumuki.elipsis`
+  * `replaceHtml`
 * `mumuki.kids`
   * `registerBlocksAreaScaler`
   * `registerStateScaler`
@@ -185,6 +191,9 @@ which are granted to be safe and stable.
   * `scaleBlocksArea`
   * `scaleState`
   * `showResult`
+* `mumuki.renderers`
+  * `SpeechBubbleRenderer`
+  * `renderSpeechBubbleResultItem`
 * `mumuki.locale`
 * `mumuki.MultipleScenarios`
   * `scenarios`
@@ -200,22 +209,29 @@ which are granted to be safe and stable.
 
 ### Bridge Response Format
 
-```json
+```javascript
 {
-  "status": "failed",
-  "guide_finished_by_solution": false,
-  "class_for_progress_list_item":"progress-list-item text-center danger active",
-  "html":"...",
-  "title_html":"...",
-  "button_html":"...",
-  "expectations_html":"...",
-  "remaining_attempts_html":null,
-  "test_results":[
-      {
-        "title":null,
-        "status":"failed",
-        "result":"..."
-      }
+  "status": "passed|passed_with_warnings|failed",
+  "guide_finished_by_solution": "boolean",
+  "class_for_progress_list_item": "string",
+  "html": "string",
+  "remaining_attempts_html": "string" ,
+  "title_html": "string",                         // kids-only
+  "button_html": "string",                        // kids-only
+  "expectations": [                               // kids-only
+    {
+      "status": "passed|failed",
+      "explanation": "string"
+    }
+  ],
+  "tips": [ "string" ],                           // kids-only
+  "test_results": [                               // kids-only
+    {
+      "title": "string",
+      "status": "passed|failed",
+      "result": "string",
+      "summary": "string"
+    }
   ]
 }
 ```
@@ -463,7 +479,7 @@ POST /organization/:id/courses/
 
 ```json
 {
-   "name":"....",
+   "name": "....",
 }
 ```
 
@@ -539,7 +555,7 @@ Sample response body:
 ```json
 {
   "organizations": [
-    { "name": "academy", "contact_email": "a@a.com", "locale": "es-AR", "login_methods": ["facebook"], "books": ["libro"], "public": true, "logo_url":"http://..." },
+    { "name": "academy", "contact_email": "a@a.com", "locale": "es-AR", "login_methods": ["facebook"], "books": ["libro"], "public": true, "logo_url": "http://..." },
     { "name": "alcal", "contact_email": "b@b.com", "locale": "en-US", "login_methods": ["facebook", "github"], "books": ["book"], "public": false }
   ]
 }
@@ -555,7 +571,7 @@ get /organizations/:name
 Sample response body:
 
 ```json
-{ "name": "academy", "contact_email": "a@a.com", "locale": "es-AR", "login_methods": ["facebook"], "books": ["libro"], "public": true, "logo_url":"http://..." }
+{ "name": "academy", "contact_email": "a@a.com", "locale": "es-AR", "login_methods": ["facebook"], "books": ["libro"], "public": true, "logo_url": "http://..." }
 ```
 **Minimal permission**: `janitor` of the organization.
 

data/app/assets/javascripts/mumuki_laboratory/application/codemirror.js

@@ -23,6 +23,14 @@ var mumuki = mumuki || {};
     })
   }
 
+  function formatContent() {
+    mumuki.page.editors.each(function (_, editor) {
+      editor.setSelection({line: 0, ch: 0}, {line: editor.lineCount()})
+      editor.indentSelection("smart")
+      editor.setSelection({line: 0})
+    });
+  }
+
   function toggleFullscreen() {
     $('body').toggleClass('fullscreen');
     $('.editor-resize .fa-stack-1x').toggleClass('fa-expand').toggleClass('fa-compress');
@@ -61,7 +69,9 @@ var mumuki = mumuki || {};
   }
 
   mumuki.editor = mumuki.editor || {};
+  mumuki.editor.reset = resetEditor;
   mumuki.editor.toggleFullscreen = toggleFullscreen;
+  mumuki.editor.formatContent = formatContent;
   mumuki.editor.indentWithSpaces = indentWithSpaces;
   mumuki.editor.syncContent = syncContent;
 
@@ -75,12 +85,19 @@ var mumuki = mumuki || {};
     updateCodeMirrorLanguage();
     onSelectUpdateCodeMirror();
 
-    $('.editor-reset').click(function () {
-      resetEditor();
+    $('.editor-reset').click(function (event) {
+      event.stopPropagation();
+      const selection = confirm(this.getAttribute('data-confirm'));
+      if(selection) resetEditor();
     });
+
     $('.editor-resize').click(function () {
       toggleFullscreen();
     });
+
+    $('.editor-format').click(function (){
+      formatContent();
+    });
   });
 
 }(mumuki));

data/app/assets/javascripts/mumuki_laboratory/application/elipsis.js

@@ -0,0 +1,31 @@
+// This module defines three client-side-only special sections, and allows them to be replaced
+// by adding the `mu-elipsis` class, or by calling `mumuki.elipsis()`:
+//
+// * <elipsis-for-student@ ...code... @elipsis-for-student>                     : replaces code with an elipsis
+// * <hidden-for-student@ ...code... @hidden-for-student>                       : completely hides code
+// * <description-for-student[...text...]@ ...code... @description-for-student> : replaces code a message sourrounded by elipsis
+//
+//
+// This module assumes the strings are already markdown-like escaped code strings, not plain code
+(function (mumuki) {
+
+  function elipsis(code) {
+    return code
+      .replace(/&lt;elipsis-for-student@[\s\S]*?@elipsis-for-student&gt;/g, ' ... ')
+      .replace(/&lt;hidden-for-student@[\s\S]*?@hidden-for-student&gt;/g, '')
+      .replace(/&lt;description-for-student\[([^\]]*)\]@[\s\S]*?@description-for-student&gt;/g, ' ... $1 ... ');
+  }
+
+  mumuki.elipsis = elipsis;
+  mumuki.elipsis.replaceHtml = () => {
+    let $elipsis = $('.mu-elipsis');
+    $elipsis.each((it, e) =>  {
+      let $e = $(e);
+      $e.html(mumuki.elipsis($e.html()));
+    })
+  };
+
+  mumuki.load(() => {
+    mumuki.elipsis.replaceHtml();
+  });
+})(mumuki);

data/app/assets/javascripts/mumuki_laboratory/application/interval.js

@@ -0,0 +1,17 @@
+var mumuki = mumuki || {};
+
+(function (mumuki) {
+  // When using Turbolinks, intervals loaded inside <body> aren't destroyed on page changes
+  // Use this function instead if you want the behaviour of a regular setInterval
+  mumuki.setInterval = function (intervalFunction, milliseconds) {
+    const interval = setInterval.apply(this, [intervalFunction, milliseconds]);
+
+    // Using one to avoid calling clearInterval on every page chance.
+    $(document).one('turbolinks:before-cache turbolinks:before-render', function () {
+      clearInterval(interval);
+    });
+
+    return interval;
+  }.bind(this);
+
+}(mumuki));

data/app/assets/javascripts/mumuki_laboratory/application/kids.js

@@ -169,28 +169,17 @@ mumuki.load(function () {
       $bubble.find('.mu-kids-character-speech-bubble-failed').hide();
       $bubble.find('.mu-kids-discussion-link').remove();
       Object.keys(mumuki.kids.resultAction).forEach($bubble.removeClass.bind($bubble));
-      mumuki.kids._getOverlay().hide();
+      mumuki.kids._getOverlay().hide()
     },
 
     _showMessageOnCharacterBubble: function (data) {
-      var $bubble = mumuki.kids._getCharacterBubble();
-      $bubble.find('.mu-kids-character-speech-bubble-tabs').hide();
-      $bubble.find('.mu-kids-character-speech-bubble-normal').hide();
-      $bubble.find('.mu-kids-character-speech-bubble-failed').show().html(data.title_html);
-      $bubble.addClass(data.status);
-      if (data.status === 'passed_with_warnings') {
-        $bubble.find('.mu-kids-character-speech-bubble-failed').append(data.expectations_html);
-      }
-      if (this._shouldDisplayDiscussionsLink(data.status)) {
-        $bubble.append(discussionsLinkHtml);
-      }
+      const renderer = new mumuki.renderers.SpeechBubbleRenderer(mumuki.kids._getCharacterBubble());
+      renderer.setDiscussionsLinkHtml(discussionsLinkHtml);
+      renderer.setResponseData(data);
+      renderer.render();
       mumuki.kids._getOverlay().show();
     },
 
-    _shouldDisplayDiscussionsLink: function (status) {
-      return ['failed', 'passed_with_warnings'].some(it => it === status);
-    },
-
     _showOnSuccessPopup: function (data) {
       mumuki.kids._updateSubmissionResult(data.html);
       mumuki.presenterCharacter.playAnimation('success_l', mumuki.kids._getCharacterImage());
@@ -313,7 +302,7 @@ mumuki.load(function () {
     });
 
     if (paragraphCount > 1) {
-      nextSpeechBlinking = setInterval(() => $nextSpeech.fadeTo('slow', 0.1).fadeTo('slow', 1.0), 1000);
+      nextSpeechBlinking = mumuki.setInterval(() => $nextSpeech.fadeTo('slow', 0.1).fadeTo('slow', 1.0), 1000);
     }
 
     $nextSpeech.click(showNextParagraph);

data/app/assets/javascripts/mumuki_laboratory/application/messages.js

@@ -45,7 +45,7 @@ mumuki.load(function () {
       });
     },
     setMessagesInterval: function () {
-      setInterval(Chat.getMessages, 60000);
+      mumuki.setInterval(Chat.getMessages, 60000);
     },
     submitMessagesForm: function (url, readUrl, errorUrl) {
       var $container = $('.mu-view-messages');

data/app/assets/javascripts/mumuki_laboratory/application/speech-bubble-renderer.js

@@ -0,0 +1,99 @@
+((mumuki)=> {
+
+  function renderSpeechBubbleResultItem(item) {
+    return `
+        <div class="results-item">
+          <ul class="results-list">
+            <li>${item}</li>
+          </ul>
+        </div>`;
+  }
+
+  // A mumuki.renderers.SpeechBubbleRenderer allows to configure a kids speech bubble
+  // with the data of a test response from bridge
+  class SpeechBubbleRenderer {
+    constructor($bubble) {
+      this.$bubble = $bubble;
+      this.$failedArea = $bubble.find('.mu-kids-character-speech-bubble-failed');
+    }
+
+    _chooseResultItem() {
+      if (this._responseStatus() !== 'passed' && this._hasTips()) {
+        this._appendFirstTip()
+      } else if (this._responseStatus() === 'failed') {
+        this._appendFirstFailedTestResultSummary();
+      } else if (this._responseStatus() === 'passed_with_warnings') {
+        this._appendFirstExpectationResult();
+      }
+    }
+
+    _appendFirstFailedTestResultSummary() {
+      const failedTestResult = this._failedTestResults()[0]
+      if (failedTestResult && failedTestResult.summary) {
+        this._appendResultItem(mumuki.renderers.renderSpeechBubbleResultItem(failedTestResult.summary));
+      }
+    }
+
+    _appendFirstExpectationResult() {
+      this._appendResultItem(mumuki.renderers.renderSpeechBubbleResultItem(this.responseData.expectations[0].explanation));
+    }
+
+    _appendFirstTip() {
+      this._appendResultItem(mumuki.renderers.renderSpeechBubbleResultItem(this.responseData.tips[0]));
+    }
+
+    _appendResultItem(item) {
+      this._addClass('with-result-item');
+      this.$failedArea.append(item);
+    }
+
+    _addClass(klass) {
+      this.$bubble.addClass(klass);
+    }
+
+    _appendDiscussionsLinkHtml() {
+      if (this._shouldDisplayDiscussionsLink()) {
+        this.$bubble.append(this.discussionsLinkHtml);
+      }
+    }
+
+    _shouldDisplayDiscussionsLink() {
+      return ['failed', 'passed_with_warnings'].some(it => it === this._responseStatus());
+    }
+
+    _responseStatus() {
+      return this.responseData.status;
+    }
+
+    _hasTips() {
+      return this.responseData.tips && this.responseData.tips.length
+    }
+
+    _failedTestResults() {
+      return this.responseData.test_results.filter((it) => it.status === 'failed');
+    }
+
+    setDiscussionsLinkHtml(discussionsLinkHtml) {
+      this.discussionsLinkHtml = discussionsLinkHtml;
+    }
+
+    setResponseData(responseData) {
+      this.responseData = responseData;
+    }
+
+    // Entry point of the renderer. It just updates the UI, not returning anything
+    // Configure the renderer with `setDiscussionsLinkHtml` and `setResponseData` first.
+    render() {
+      this.$bubble.find('.mu-kids-character-speech-bubble-tabs').hide();
+      this.$bubble.find('.mu-kids-character-speech-bubble-normal').hide();
+      this.$failedArea.show().html(this.responseData.title_html);
+      this._addClass(this._responseStatus());
+      this._chooseResultItem();
+      this._appendDiscussionsLinkHtml();
+    }
+  }
+
+  mumuki.renderers = mumuki.renderers || {};
+  mumuki.renderers.SpeechBubbleRenderer = SpeechBubbleRenderer;
+  mumuki.renderers.renderSpeechBubbleResultItem = renderSpeechBubbleResultItem;
+})(mumuki)

data/app/assets/javascripts/mumuki_laboratory/application/timer.js

@@ -8,7 +8,7 @@ var mumuki = mumuki || {};
     var duration = moment.duration(diffTime, 'milliseconds');
     var intervalDuration = 1000;
 
-    var interval = setInterval(function () {
+    var interval = mumuki.setInterval(function () {
       duration = moment.utc(duration - intervalDuration);
       if(duration.valueOf() <= 0) {
         clearInterval(interval);

data/app/assets/stylesheets/mumuki_laboratory/application/modules/_editor.scss

@@ -13,25 +13,6 @@ $multifile-inactive-tab-border-color: #ECF0F1;
   max-height: none;
 }
 
-.submission-reset {
-  padding: 5px;
-  cursor: pointer;
-}
-
-.editor-resize {
-  position: absolute;
-  padding: 5px;
-  cursor: pointer;
-  z-index: 10;
-  top: 0;
-  right: 0;
-  font-size: 0.5em;
-  &.multiple-files {
-    top: 43px;
-  }
-}
-
-
 body:not(.fullscreen) {
   .CodeMirror-wrap,
   .CodeMirror-scroll {
@@ -69,10 +50,6 @@ body.fullscreen {
       overflow-y: scroll;
       overflow-x: auto;
     }
-    .submission-reset,
-    .editor-resize {
-      margin-right: 15px;
-    }
   }
 }
 

data/app/assets/stylesheets/mumuki_laboratory/application/modules/_exercise_results.scss

@@ -10,6 +10,9 @@
 ul.results-list {
   list-style-type: none;
   padding-left: 10px;
+  li:first-letter {
+    text-transform: capitalize
+  }
 }
 
 .results-list pre {
@@ -27,3 +30,11 @@ ul.results-list {
     color: white;
   }
 }
+
+.mu-single-test-result {
+  .error-text, /* backward compatibility with gobstones runner */
+  .mu-test-result-header {
+    display: block;
+    line-height: 25px;
+  }
+}

data/app/assets/stylesheets/mumuki_laboratory/application/modules/_kids.scss

@@ -154,7 +154,7 @@ $kids-speech-tabs-width: 40px;
         }
       }
 
-      &.passed_with_warnings {
+      &.with-result-item {
         padding-top: 5px;
         padding-bottom: 5px;
 

data/app/assets/stylesheets/mumuki_laboratory/application/modules/_overlap.scss

@@ -5,6 +5,25 @@
 .mu-overlapped {
   z-index: 10;
   position: absolute;
-  bottom: 0;
+  top: 0;
   right: 0;
-}
+  display: flex;
+  flex-direction: column;
+  a {
+    cursor: pointer;
+    padding: 5px;
+  }
+  &.multiple-files {
+    top: 43px;
+  }
+}
+
+.editor-resize {
+  font-size: 0.5em;
+}
+
+body.fullscreen {
+  .mu-overlapped a {
+    margin-right: 15px;
+  }
+}