mumuki-laboratory 7.10.5 → 7.11.0

data/spec/features/choose_organization_spec.rb

@@ -8,7 +8,7 @@ feature 'Choose organization Flow' do
   let(:user4) { create(:user, permissions: {student: 'immersive-orga/*'}) }
 
   before do
-    %w(pdep central foo immersive-orga).each do |it|
+    %w(pdep central foo immersive-orga base).each do |it|
       create(:organization,
              name: it,
              book: create(:book,
@@ -18,14 +18,15 @@ feature 'Choose organization Flow' do
     end
   end
 
-  before { Organization.find_by_name('immersive-orga').tap { |it| it.immersive = true }.save! }
+  before { Organization.locate!('immersive-orga').update!(immersive: true) }
+  before { Organization.locate!('central').update!(immersible: true) }
   before { set_current_user! user }
 
   context 'when organization exists' do
     before { Organization.central.switch! }
 
     scenario 'when visiting with implicit subdomain and no permissions' do
-      set_implicit_central!
+      set_subdomain_host! 'central'
 
       visit '/'
 
@@ -33,19 +34,19 @@ feature 'Choose organization Flow' do
       expect(page).not_to have_text('Do you want to go there?')
     end
 
-    scenario 'when visiting with implicit subdomain and permissions to only one non-immersive organization' do
+    scenario 'when visiting immersible orga with permissions to only one non-immersive organization' do
       set_current_user! user2
-      set_implicit_central!
+      set_subdomain_host! 'central'
 
       visit '/'
 
       expect(page).to have_text('Sign Out')
-      expect(page).to have_text('Do you want to go there?')
+      expect(page).not_to have_text('Do you want to go there?')
     end
 
-    scenario 'when visiting with implicit subdomain and permissions to only one immersive organization' do
+    scenario 'when visiting immersible orga with permissions to only one immersive organization', :navigation_error do
       set_current_user! user4
-      set_implicit_central!
+      set_subdomain_host! 'central'
 
       visit '/'
 
@@ -54,37 +55,18 @@ feature 'Choose organization Flow' do
       expect(page).to have_text('immersive-orga')
     end
 
-    scenario 'when visiting with implicit subdomain and permissions to two or more organizations' do
+    scenario 'when visiting immersible orga with permissions to many non-immersive organizations' do
       set_current_user! user3
-      set_implicit_central!
+      set_subdomain_host! 'central'
 
       visit '/'
 
       expect(page).to have_text('Sign Out')
-      expect(page).to have_text('Do you want to go there?')
-    end
-
-    scenario 'when visiting central explicitly' do
-      set_subdomain_host!('central')
-
-      visit '/'
-
-      expect(page).not_to have_text('Do you want to go there?')
-      expect(page).not_to have_text('pdep')
-    end
-
-    scenario 'when visit foo subdomain' do
-      set_current_user! user3
-      set_subdomain_host!('foo')
-
-      visit '/'
-
       expect(page).not_to have_text('Do you want to go there?')
-      expect(page).to have_text('foo')
     end
   end
 
-  scenario 'when organization does not exist' do
+  scenario 'when organization does not exist', :http_response_headers do
     visit '/'
 
     expect(page).to have_http_status(404)

data/spec/features/disable_user_flow_spec.rb

@@ -17,8 +17,7 @@ feature 'disable user flow', organization_workspace: :test do
     scenario 'enabled visitor' do
       visit '/'
 
-      expect(page).to have_text('ム mumuki')
-      expect(page).to have_text(current_organization.book.name)
+      expect(page_body).to have_text(current_organization.book.name)
       expect(user.reload.last_organization).to eq current_organization
     end
 
@@ -27,8 +26,7 @@ feature 'disable user flow', organization_workspace: :test do
 
       visit '/'
 
-      expect(page).to_not have_text('ム mumuki')
-      expect(page).to_not have_text(current_organization.book.name)
-      expect(page).to have_text('You are trying to visit a permamently disabled or deleted resource')
+      expect(page_body).to_not have_text(current_organization.book.name)
+      expect(page_body).to have_text('You are trying to visit a permamently disabled or deleted resource')
     end
 end

data/spec/features/disabled_organization_flow_spec.rb

@@ -17,8 +17,7 @@ feature 'disable user flow', organization_workspace: :test do
   scenario 'enabled organization' do
     visit '/'
 
-    expect(page).to have_text('ム mumuki')
-    expect(page).to have_text(current_organization.book.name)
+    expect(page_body).to have_text(current_organization.book.name)
     expect(user.reload.last_organization).to eq current_organization
   end
 
@@ -29,17 +28,15 @@ feature 'disable user flow', organization_workspace: :test do
     scenario 'visit /' do
       visit '/'
 
-      expect(page).to_not have_text('ム mumuki')
-      expect(page).to_not have_text(current_organization.book.name)
-      expect(page).to have_text(I18n.t(:unprepared_organization_explanation))
+      expect(page_body).to_not have_text(current_organization.book.name)
+      expect(page_body).to have_text(I18n.t(:unprepared_organization_explanation))
     end
 
     scenario 'visit /user' do
       visit '/test/user'
 
-      expect(page).to_not have_text('ム mumuki')
-      expect(page).to_not have_text(current_organization.book.name)
-      expect(page).to have_text(I18n.t(:unprepared_organization_explanation))
+      expect(page_body).to_not have_text(current_organization.book.name)
+      expect(page_body).to have_text(I18n.t(:unprepared_organization_explanation))
     end
 
   end
@@ -51,17 +48,15 @@ feature 'disable user flow', organization_workspace: :test do
     scenario 'visit /' do
       visit '/'
 
-      expect(page).to_not have_text('ム mumuki')
-      expect(page).to_not have_text(current_organization.book.name)
-      expect(page).to have_text(I18n.t(:disabled_organization_explanation))
+      expect(page_body).to_not have_text(current_organization.book.name)
+      expect(page_body).to have_text(I18n.t(:disabled_organization_explanation))
     end
 
     scenario 'visit /user' do
       visit '/test/user'
 
-      expect(page).to_not have_text('ム mumuki')
-      expect(page).to_not have_text(current_organization.book.name)
-      expect(page).to have_text(I18n.t(:disabled_organization_explanation))
+      expect(page_body).to_not have_text(current_organization.book.name)
+      expect(page_body).to have_text(I18n.t(:disabled_organization_explanation))
     end
 
     end

data/spec/features/exercise_flow_spec.rb

@@ -182,7 +182,7 @@ feature 'Exercise Flow', organization_workspace: :test do
       expect(page.find("#mu-exercise-layout")['value']).to eq('input_right')
     end
 
-    scenario 'visit exercise by id, upload layout, not queriable language' do
+    scenario 'visit exercise by id, upload layout, not queriable language', :invalid_selector_error do
       visit "/exercises/#{problem_5.id}"
 
       expect(page).to have_text('Succ5')
@@ -272,7 +272,7 @@ feature 'Exercise Flow', organization_workspace: :test do
       expect(page).not_to have_xpath("//a[@title='Edit']")
     end
 
-    scenario 'writer should see the edit exercise link' do
+    scenario 'writer should see the edit exercise link', :xpath_no_matches do
       set_current_user! writer
 
       visit "/exercises/#{problem_2.id}"

data/spec/features/guide_reset_spec.rb

@@ -39,7 +39,7 @@ feature 'Guide Reset Flow', organization_workspace: :test do
       expect(page).to_not have_xpath(restart_xpath)
     end
 
-    scenario 'visit guide with solutions sent for it' do
+    scenario 'visit guide with solutions sent for it', :xpath_no_matches do
       problem.submit_solution! user
 
       visit "/lessons/#{lesson.id}"

data/spec/features/guides_flow_spec.rb

@@ -115,7 +115,7 @@ feature 'Guides Flow', organization_workspace: :test do
         expect(page).not_to have_xpath("//a[@title='Edit']")
       end
 
-      scenario 'writer should see the edit guide link' do
+      scenario 'writer should see the edit guide link', :xpath_no_matches do
         set_current_user! writer
 
         visit "/guides/#{lesson.guide.id}"

data/spec/features/home_private_flow_spec.rb

@@ -45,7 +45,7 @@ feature 'private org' do
       allow_any_instance_of(ApplicationController).to receive(:from_sessions?).and_return(false)
     end
 
-    scenario 'visitor should raise forbidden error' do
+    scenario 'visitor should raise forbidden error', :organization_not_nil do
       set_current_user! visitor
 
       visit '/'
@@ -59,7 +59,6 @@ feature 'private org' do
       visit '/'
 
       expect(student.reload.last_organization).to eq current_organization
-      expect(page).to have_text('powered by mumuki')
       expect(page).to have_text(current_organization.description)
       expect(page).to have_text(current_organization.book.description)
     end
@@ -70,7 +69,6 @@ feature 'private org' do
       visit '/'
 
       expect(teacher.reload.last_organization).to eq current_organization
-      expect(page).to have_text('powered by mumuki')
       expect(page).to have_text(current_organization.description)
       expect(page).to have_text(current_organization.book.description)
     end

data/spec/features/home_public_flow_spec.rb

@@ -17,11 +17,10 @@ feature 'public org', organization_workspace: :test do
 
   context 'anonymous visitor' do
     scenario 'from outside' do
-      Capybara.current_session.driver.header 'Referer', 'http://google.com'
+      set_request_header! 'Referer', 'http://google.com'
 
       visit '/'
 
-      expect(page).to have_text('ム mumuki')
       expect(page).to have_text('First Steps')
       expect(page).to have_selector('.chapter', text: 'Functional Programming')
       expect(page).to have_text(current_organization.book.name)
@@ -29,11 +28,10 @@ feature 'public org', organization_workspace: :test do
     end
 
     scenario 'from inside' do
-      Capybara.current_session.driver.header 'Referer', 'http://en.mumuki.io/exercises/1'
+      set_request_header! 'Referer', 'http://en.mumuki.io/exercises/1'
 
       visit '/'
 
-      expect(page).to have_text('ム mumuki')
       expect(page).to have_text('First Steps')
       expect(page).to have_selector('.chapter', text: 'Functional Programming')
       expect(page).to have_text(current_organization.book.name)
@@ -46,11 +44,10 @@ feature 'public org', organization_workspace: :test do
     before { exam.authorize! user }
 
     scenario 'from outside' do
-      Capybara.current_session.driver.header 'Referer', 'http://google.com'
+      set_request_header! 'Referer', 'http://google.com'
 
       visit '/'
 
-      expect(page).to have_text('ム mumuki')
       expect(page).to have_text('First Steps')
       expect(page).to have_selector('.chapter', text: 'Functional Programming')
       expect(page).to have_text(current_organization.book.name)
@@ -59,11 +56,10 @@ feature 'public org', organization_workspace: :test do
     end
 
     scenario 'from inside' do
-      Capybara.current_session.driver.header 'Referer', 'http://en.mumuki.io/exercises/1'
+      set_request_header! 'Referer', 'http://en.mumuki.io/exercises/1'
 
       visit '/'
 
-      expect(page).to have_text('ム mumuki')
       expect(page).to have_text('First Steps')
       expect(page).to have_selector('.chapter', text: 'Functional Programming')
       expect(page).to_not have_selector('.chapter.mu-locked', text: 'Functional Programming')
@@ -80,11 +76,10 @@ feature 'public org', organization_workspace: :test do
     before { exam.authorize! user }
 
     scenario 'from inside' do
-      Capybara.current_session.driver.header 'Referer', 'http://google.com'
+      set_request_header! 'Referer', 'http://google.com'
 
       visit '/'
 
-      expect(page).to have_text('ム mumuki')
       expect(page).to have_text('First Steps')
       expect(page).to have_selector('.chapter.mu-locked', text: 'Functional Programming')
       expect(page).to have_text(current_organization.book.name)
@@ -95,11 +90,10 @@ feature 'public org', organization_workspace: :test do
   context 'incognito user' do
     before { current_organization.update! incognito_mode_enabled: true }
     scenario 'from inside' do
-      Capybara.current_session.driver.header 'Referer', 'http://google.com'
+      set_request_header! 'Referer', 'http://google.com'
 
       visit '/'
 
-      expect(page).to have_text('ム mumuki')
       expect(page).to have_text('First Steps')
       expect(page).to have_selector('.chapter', text: 'Functional Programming')
       expect(page).to have_text(current_organization.book.name)

data/spec/features/invitations_flow_spec.rb

@@ -9,7 +9,7 @@ feature 'Invitations Flow', organization_workspace: :test do
       create(:lesson, guide: guide)
     ]) }
   let(:book) { organization.book }
- 
+
   before do
     book.update! chapters: [chapter]
   end
@@ -33,7 +33,7 @@ feature 'Invitations Flow', organization_workspace: :test do
   context 'with existing memberships' do
     let(:permissions) { { student: 'test/nodejs' } }
 
-    scenario 'visit invitation, already joined' do
+    scenario 'visit invitation, already joined', :navigation_error do
       visit '/join/invitacionAlNodejs'
       expect(page).to have_text('Start Practicing!')
     end

data/spec/features/login_flow_spec.rb

@@ -24,7 +24,7 @@ feature 'Login Flow', organization_workspace: :test do
     expect(page).to have_text('Sign Out')
   end
 
-  scenario 'can login and keeps session' do
+  scenario 'can login and keeps session', :navigation_error do
     visit '/'
 
     click_on 'Sign in'
@@ -45,7 +45,7 @@ feature 'Login Flow', organization_workspace: :test do
     expect(page).to have_text('awesomeRubyGuide')
   end
 
-  scenario 'can logout' do
+  scenario 'can logout', :element_not_interactable_error do
     visit '/'
 
     click_on 'Sign in'

data/spec/features/not_found_private_flow_spec.rb

@@ -22,8 +22,8 @@ feature 'not found private on app', organization_workspace: :base do
     expect(page).to have_text 'You may have mistyped the address or the page may have moved'
   end
 
-  scenario 'api without authorization' do
-    Capybara.current_session.driver.header 'Authorization', "Bearer #{student_api_client.token}"
+  scenario 'api without authorization', :json_eq_error do
+    set_request_header! 'Authorization', "Bearer #{student_api_client.token}"
 
     visit '/api/nonexistentroute'
 
@@ -33,8 +33,8 @@ feature 'not found private on app', organization_workspace: :base do
       ' with permissions !student:central/*;teacher:;headmaster:;janitor:;admin:;owner:']
   end
 
-  scenario 'api with authentication' do
-    Capybara.current_session.driver.header 'Authorization', "Bearer #{admin_api_client.token}"
+  scenario 'api with authentication', :json_eq_error do
+    set_request_header! 'Authorization', "Bearer #{admin_api_client.token}"
 
     visit '/api/nonexistentroute'
 

data/spec/features/not_found_public_flow_spec.rb

@@ -2,17 +2,12 @@ require 'spec_helper'
 
 feature 'not found public on app' do
   let!(:central) { create(:organization, name: 'central') }
+  let!(:base) { create(:organization, name: 'base') }
   let!(:some_orga) { create(:public_organization, name: 'someorga', profile: profile) }
 
   let(:profile) { Mumuki::Domain::Organization::Profile.parse json  }
   let(:json) { { contact_email: 'some@email.com', locale: 'en', errors_explanations: { 404 => 'Some explanation'} } }
 
-  scenario 'when routes does not exist in implicit central' do
-    visit '/foo'
-
-    expect(page).to have_text('You may have mistyped the address')
-  end
-
   scenario 'when route does not exist in explicit central' do
     set_subdomain_host! 'test'
 

data/spec/features/profile_flow_spec.rb

@@ -49,7 +49,7 @@ feature 'Profile Flow', organization_workspace: :test do
       expect(page).to have_text('Please complete your profile data to continue!')
     end
 
-    scenario 'is able to log out' do
+    scenario 'is able to log out', :element_not_interactable_error do
       click_on 'Sign in'
       set_automatic_login! false
 

data/spec/helpers/page_title_helper_spec.rb

@@ -12,8 +12,8 @@ describe PageTitleHelper, organization_workspace: :test do
 
     before { reindex_current_organization! }
 
-    it { expect(page_title nil).to eq 'Mumuki - test - Improve your programming skills' }
-    it { expect(page_title Problem.new).to eq 'Mumuki - test - Improve your programming skills' }
-    it { expect(page_title exercise).to eq 'C1: A Guide - An Exercise - Mumuki - test' }
+    it { expect(page_title nil).to eq 'test' }
+    it { expect(page_title Problem.new).to eq 'test' }
+    it { expect(page_title exercise).to eq 'C1: A Guide - An Exercise - test' }
   end
 end

data/spec/javascripts/editors-spec.js

@@ -47,6 +47,29 @@ describe('editors', () => {
     expect(mumuki.editors.getSubmission()).toEqual({"solution[content]":"the solution"});
   });
 
+
+  it('reads the form if no sources and exercise is multifile', () => {
+    $('body').html(`
+    <form role="form" class="new_solution">
+      <div class="field form-group editor-code">
+        <textarea
+          class="form-control editor"
+          data-editor-language="html"
+          name="solution[content[index.html]]"
+          id="solution_content[index.html]">some html</textarea>
+        <textarea
+          class="form-control editor"
+          data-editor-language="css"
+          name="solution[content[receta.css]]"
+          id="solution_content[receta.css]">some css</textarea>
+      </div>
+    </form>`)
+    expect(mumuki.editors.getSubmission()).toEqual({
+      "solution[content[index.html]]": "some html",
+      "solution[content[receta.css]]": "some css"
+    });
+  });
+
   it('produces empty submission if no form nor sources', () => {
     $('body').html(``);
     expect(mumuki.editors.getSubmission()).toEqual({});

data/spec/javascripts/gamification-spec.js

@@ -0,0 +1,58 @@
+describe('gamification', () => {
+  describe('formula', () => {
+    it('has positive coefficients', () => {
+      expect(mumuki.gamification.Formula.QUADRATIC_COEFFICIENT).toBeGreaterThan(0);
+      expect(mumuki.gamification.Formula.LINEAR_COEFFICIENT).toBeGreaterThan(0);
+    });
+
+    it('has negative constant term', () => {
+      expect(mumuki.gamification.Formula.CONSTANT_TERM).toBeLessThan(0);
+    });
+  });
+
+  describe('level progression', () => {
+    describe('exp to level up', () => {
+      it('takes 175 exp points to go from level 1 to 2', () => {
+        expect(new mumuki.gamification.LevelProgression(0).expToLevelUp()).toBe(175);
+      });
+
+      it('takes 225 points to go from level 2 to 3', () => {
+        expect(new mumuki.gamification.LevelProgression(175).expToLevelUp()).toBe(225);
+      });
+    });
+
+    describe('current level', () => {
+      it('is at level 1 when 0 exp points', () => {
+        expect(new mumuki.gamification.LevelProgression(0).currentLevel()).toBe(1);
+      });
+
+      it('is at level 5 when 1000 exp points', () => {
+        expect(new mumuki.gamification.LevelProgression(1000).currentLevel()).toBe(5);
+      });
+    });
+
+    describe('triggers level change', () => {
+      it('does not trigger when small exp difference', () => {
+        expect(new mumuki.gamification.LevelProgression(1000).triggersLevelChange(1050)).toBe(false);
+      });
+
+      it('does trigger when big exp difference', () => {
+        expect(new mumuki.gamification.LevelProgression(1000).triggersLevelChange(1500)).toBe(true);
+      });
+    });
+
+    describe('current level progress', () => {
+      it('is at 0% when just leveled up', () => {
+        expect(new mumuki.gamification.LevelProgression(675).currentLevelProgress()).toBe(0);
+      });
+
+      it('is at 50% when halfway through', () => {
+        expect(new mumuki.gamification.LevelProgression(837).currentLevelProgress()).toBeCloseTo(0.50, 0.01);
+      });
+
+      it('is at 99% when almost there', () => {
+        expect(new mumuki.gamification.LevelProgression(999).currentLevelProgress()).toBeCloseTo(0.99, 0.01);
+      });
+    });
+  });
+});