mumuki-javascript-runner 1.5.0 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cb2c3425cccd2c1dd04911c424109da786ab4cd9a6969904f168db188f625045
-  data.tar.gz: e849e9592b35944b138969f9596004471574bfea4eae1612fbaf53bd3f0a8a2e
+  metadata.gz: 643e7004181714b9389b777b05343707d8c83af4b2aa5f409b433b7a290af5f7
+  data.tar.gz: 42fb43b4425a6ff90c7522ae1de68980c4f0683e80dfb083db70d89be6f8dd85
 SHA512:
-  metadata.gz: 875f71c53f6566579d4efe71dfe4e2522e3286f538d80957d5bfadf4875a8d003a536db763a20e3fa283af80bea54a351d6a5a3f27693549e610e8fe9ff050f5
-  data.tar.gz: 162afef619eaff6248339f5c8d9703816434174bb65de82b25e7fed7de6572b1663c7f6ec447b1f929cd407e5d32bc8d9756365d9ff2f60b3d8eb448b46fabac
+  metadata.gz: 40a7062a6a43c6caf6a4623c7977d3b4e052d06a830f2c8e3242c4d49706e9afb73cfb47d09a6e1674acbda7cc897c5730bd9c6351e5e4e1dad289b4a74d622a
+  data.tar.gz: 72ff4deb4365eef74e042ad1edfe9203e85cd379c8d7307d269348d8521e442153d9751c8ce985ae905d4b9b0627f54d1217f05dd83c7b1121b1539cad226522

data/lib/feedback_hook.rb

@@ -0,0 +1,25 @@
+class JavascriptFeedbackHook < Mumukit::Hook
+  def run!(request, results)
+    content = request.content
+    test_results = test_failure_messages results
+
+    JavascriptExplainer.new.explain(content, test_results)
+  end
+
+  def test_failure_messages(results)
+    structured_test_results = results.test_results[0]
+    if structured_test_results.is_a? Array
+      structured_test_results.select { |it| it[1].failed? }.map { |it| it[2] }.join("\n")
+    else
+      ''
+    end
+  end
+
+  class JavascriptExplainer < Mumukit::Explainer
+    def explain_is_not_defined(_, test_results)
+      (/([a-zA-Z0-9_]+) is not defined/.match test_results).try do |it|
+        {identifier: it[1]}
+      end
+    end
+  end
+end

data/lib/javascript_runner.rb

@@ -1,10 +1,13 @@
 require 'mumukit'
 
+I18n.load_translations_path File.join(__dir__, 'locales', '*.yml')
+
 Mumukit.runner_name = 'javascript'
 Mumukit.configure do |config|
-  config.docker_image = 'mumuki/mumuki-mocha-worker'
+  config.docker_image = 'mumuki/mumuki-mocha-worker:2.0'
   config.structured = true
   config.stateful = true
+  config.content_type = 'markdown'
 end
 
 require_relative './version'
@@ -12,5 +15,6 @@ require_relative './metadata_hook'
 require_relative './validation_hook'
 require_relative './test_hook'
 require_relative './expectations_hook'
+require_relative './feedback_hook'
 require_relative './query_hook'
-require_relative './try_hook'
+require_relative './try_hook'

data/lib/locales/en.yml

@@ -0,0 +1,2 @@
+en:
+  is_not_defined: "it looks like you are using `%{identifier}` but it is not defined. Perhaps you have misspelled it or you need to define it"

data/lib/locales/es.yml

@@ -0,0 +1,2 @@
+es:
+  is_not_defined: "parece que estás usando `%{identifier}` pero no está definido. ¿Puede que hayas escrito mal su nombre o tengas que definirlo?"

data/lib/locales/pt.yml

@@ -0,0 +1,2 @@
+pt:
+  is_not_defined: "Parece que você usa %{identifier} mas não está indefinido. Você digitou o nome errado ou precisa defini-lo"

data/lib/query_hook.rb

@@ -95,11 +95,15 @@ javascript
 
   def error_patterns
     [
-      Mumukit::ErrorPattern::Errored.new(syntax_error_regexp)
+      Mumukit::ErrorPattern::Errored.new(error_regexp)
     ]
   end
 
-  def syntax_error_regexp
-    /(?=\X*SyntaxError)(solution.*\n)|SyntaxError.*\n\K    at \X*/
+  def error_types
+    '(Reference|Syntax|Type)Error'
+  end
+
+  def error_regexp
+    /(?=\X*#{error_types})(solution.*\n|var __mumuki_query_result__ = )|#{error_types}.*\n\K\X*/
   end
 end

data/lib/test_hook.rb

@@ -1,13 +1,12 @@
 class JavascriptTestHook < Mumukit::Templates::FileHook
   isolated true
   structured true, separator: '!!!JAVASCRIPT-MUMUKI-OUTPUT!!!'
+  line_number_offset 3, include_extra: true
 
   def compile_file_content(request)
 <<javascript
 'use strict';
-
-var assert = require('assert');
-
+let assert = require('assert');
 #{request.extra}
 #{request.content}
 describe('', function() {
@@ -32,11 +31,19 @@ javascript
     transform(super['tests'])
   end
 
+  def post_process_unstructured_result(file, result, status)
+    if status.errored?
+      [content_type.code(result.gsub(/(SyntaxError: .*\n)(.|\n)*/) { $1 }), status]
+    else
+      super
+    end
+  end
+
   def transform(examples)
     examples.map { |e| [e['fullTitle'], e['err'].present? ? :failed : :passed, parse_out(e['err'])] }
   end
 
   def parse_out(exception)
-    exception.present? ? exception['message'] : ''
+    exception.present? ? content_type.code(exception['message']) : ''
   end
 end

data/lib/validation_hook.rb

@@ -1,7 +1,7 @@
 class JavascriptValidationHook < Mumukit::Hook
   def validate!(request)
     matches = request_matches?(request) do |it|
-      it =~ /(^|\W+)(require|process|os|fs|eval|cluster|v8|vm|tty|tls|root|global|crypto|stream|events)(\W+|$)/
+      it =~ /(^|[^_[[:alnum:]]]+)(require|process|os|fs|eval|cluster|v8|vm|tty|tls|root|global|crypto|stream|events)([^_[[:alnum:]]]+|$)/
     end
     raise Mumukit::RequestValidationError, "You can not use #{$2} here" if matches
   end

data/lib/version.rb

@@ -1,3 +1,3 @@
 module JavascriptVersionHook
-  VERSION = '1.5.0'
+  VERSION = '1.8.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mumuki-javascript-runner
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.8.0
 platform: ruby
 authors:
 - Franco Leonardo Bulgarelli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-26 00:00:00.000000000 Z
+date: 2021-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mumukit
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.30'
+        version: '2.40'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.30'
+        version: '2.40'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -102,7 +102,11 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/expectations_hook.rb
+- lib/feedback_hook.rb
 - lib/javascript_runner.rb
+- lib/locales/en.yml
+- lib/locales/es.yml
+- lib/locales/pt.yml
 - lib/metadata_hook.rb
 - lib/query_hook.rb
 - lib/test_hook.rb
@@ -128,7 +132,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Javascript Runner for Mumuki