mumuki-javascript-runner 1.5.0 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cb2c3425cccd2c1dd04911c424109da786ab4cd9a6969904f168db188f625045
-  data.tar.gz: e849e9592b35944b138969f9596004471574bfea4eae1612fbaf53bd3f0a8a2e
+  metadata.gz: 1dc108165a6187802b53ed65230fdcab0afaa85b9494f49855ed5e086a1158d6
+  data.tar.gz: a19387ab148f83b6d87f8e6b59dcc41266bec8ab1964ba934a5602d60d02c48f
 SHA512:
-  metadata.gz: 875f71c53f6566579d4efe71dfe4e2522e3286f538d80957d5bfadf4875a8d003a536db763a20e3fa283af80bea54a351d6a5a3f27693549e610e8fe9ff050f5
-  data.tar.gz: 162afef619eaff6248339f5c8d9703816434174bb65de82b25e7fed7de6572b1663c7f6ec447b1f929cd407e5d32bc8d9756365d9ff2f60b3d8eb448b46fabac
+  metadata.gz: f7137d3840e9d7890d425ac6f2423598a4fb651314b207494e2a88c94e5eb76b53a269a00d869374640fb52411a5d1600de8a2dbd98c5c753fa3e432cab8234b
+  data.tar.gz: 55e9f22881c641fd3b9244db5ef47ef5f18f6c0ce7cfd295ca68fbcf48a05e1a495c33d9a778bfa99a160ea468098c6d36b5eff1eeaa0290bf7694a0ac00d991

data/lib/feedback_hook.rb

@@ -0,0 +1,25 @@
+class JavascriptFeedbackHook < Mumukit::Hook
+  def run!(request, results)
+    content = request.content
+    test_results = test_failure_messages results
+
+    JavascriptExplainer.new.explain(content, test_results)
+  end
+
+  def test_failure_messages(results)
+    structured_test_results = results.test_results[0]
+    if structured_test_results.is_a? Array
+      structured_test_results.select { |it| it[1].failed? }.map { |it| it[2] }.join("\n")
+    else
+      ''
+    end
+  end
+
+  class JavascriptExplainer < Mumukit::Explainer
+    def explain_is_not_defined(_, test_results)
+      (/([a-zA-Z0-9_]+) is not defined/.match test_results).try do |it|
+        {identifier: it[1]}
+      end
+    end
+  end
+end

data/lib/javascript_runner.rb

@@ -1,5 +1,7 @@
 require 'mumukit'
 
+I18n.load_translations_path File.join(__dir__, 'locales', '*.yml')
+
 Mumukit.runner_name = 'javascript'
 Mumukit.configure do |config|
   config.docker_image = 'mumuki/mumuki-mocha-worker'
@@ -12,5 +14,6 @@ require_relative './metadata_hook'
 require_relative './validation_hook'
 require_relative './test_hook'
 require_relative './expectations_hook'
+require_relative './feedback_hook'
 require_relative './query_hook'
-require_relative './try_hook'
+require_relative './try_hook'

data/lib/locales/en.yml

@@ -0,0 +1,2 @@
+en:
+  is_not_defined: "it looks like you are using `%{identifier}` but it is not defined. Perhaps you have misspelled it or you need to define it"

data/lib/locales/es.yml

@@ -0,0 +1,2 @@
+es:
+  is_not_defined: "parece que estás usando `%{identifier}` pero no está definido. ¿Puede que hayas escrito mal su nombre o tengas que definirlo?"

data/lib/locales/pt.yml

@@ -0,0 +1,2 @@
+pt:
+  is_not_defined: "Parece que você usa %{identifier} mas não está indefinido. Você digitou o nome errado ou precisa defini-lo"

data/lib/query_hook.rb

@@ -95,11 +95,15 @@ javascript
 
   def error_patterns
     [
-      Mumukit::ErrorPattern::Errored.new(syntax_error_regexp)
+      Mumukit::ErrorPattern::Errored.new(error_regexp)
     ]
   end
 
-  def syntax_error_regexp
-    /(?=\X*SyntaxError)(solution.*\n)|SyntaxError.*\n\K    at \X*/
+  def error_types
+    '(Reference|Syntax|Type)Error'
+  end
+
+  def error_regexp
+    /(?=\X*#{error_types})(solution.*\n|var __mumuki_query_result__ = )|#{error_types}.*\n\K\X*/
   end
 end

data/lib/version.rb

@@ -1,3 +1,3 @@
 module JavascriptVersionHook
-  VERSION = '1.5.0'
+  VERSION = '1.6.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mumuki-javascript-runner
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.6.0
 platform: ruby
 authors:
 - Franco Leonardo Bulgarelli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-26 00:00:00.000000000 Z
+date: 2020-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mumukit
@@ -102,7 +102,11 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/expectations_hook.rb
+- lib/feedback_hook.rb
 - lib/javascript_runner.rb
+- lib/locales/en.yml
+- lib/locales/es.yml
+- lib/locales/pt.yml
 - lib/metadata_hook.rb
 - lib/query_hook.rb
 - lib/test_hook.rb
@@ -128,7 +132,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubyforge_project: 
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Javascript Runner for Mumuki