mumuki-java-runner 1.5.1 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 023122917d42a6f19f684a74788fba8504047391228c7e6d79d674e432625614
-  data.tar.gz: ec1365ba7c159817c67369005f17a8d3b47f7df54d3bc66b67a0c7a4e3351980
+  metadata.gz: a3e49fce3563aa66a7604c91f88cdd8f1d8410c0531c7c03973cbdb9f86311e8
+  data.tar.gz: 970a07892790c2d723436f3a3cce059345ca8f82d9f3cfefef6b23b89c88843b
 SHA512:
-  metadata.gz: 317d813cf478b75cce92c34c4abac903e05d156775e11eb8c914ee0f4c0e0eae14f6cdd5868a555c69a35166f930ebba057688933e7017d70902a97f047b549f
-  data.tar.gz: 9f5ae68faa9b891f62c18cd18e569fd2dff89d54bd4e6aebbb188a937d7047d2db310e161b7841d82b1c61a1d0c76964d289955db3cd14b8bb292e636aaada8e
+  metadata.gz: 9f16499caf666e4d009b921f5be08407a5c7be624b1db52bfd4c6d7b2d46ca04f14fb8771f63086988485dd5aadb11e2e4accfbbf9a6a066d174c03ca89186d1
+  data.tar.gz: ab72b1133f8c40c567ed87d08a957615cce92e36b2eff9991460b1899fe5a762a1c836bedcee173474514a63f26f553da48a1215ba14bcbfaffb2fae81f6087c

data/lib/feedback_hook.rb

@@ -34,13 +34,32 @@ class JavaFeedbackHook < Mumukit::Hook
 
     def explain_cannot_find_symbol(_, result)
       (/#{error} cannot find symbol#{near_regex}#{symbol_regex}#{location_regex}/.match result).try do |it|
-        {near: it[1], symbol: it[2].strip, location: it[3].strip}
+        symbol = it[2].strip
+        location = it[3].strip
+
+        {near: it[1], symbol: localize_symbol(symbol), at_location: at_location(symbol, location) }
+      end
+    end
+
+    def explain_lossy_conversion(_, result)
+      (/#{error} incompatible types: possible lossy conversion from (.*) to (.*)#{near_regex}/.match result).try do |it|
+        { from: it[1], to: it[2], near: it[3] }
       end
     end
 
     def explain_incompatible_types(_, result)
       (/#{error} incompatible types: (.*) cannot be converted to (.*)#{near_regex}/.match result).try do |it|
-        {down: it[1], up: it[2], near: it[3]}
+        actual = it[1]
+        expected = it[2]
+        near = it[3]
+
+        { message: I18n.t(type_incompatibilty_kind(actual, expected), actual: actual, expected: expected, near: near) }
+      end
+    end
+
+    def explain_wrong_constructor_arguments(_, result)
+      (/#{error} constructor (.*) in class (.*) cannot be applied to given types;#{near_regex}/.match result).try do |it|
+        { class: it[2] }
       end
     end
 
@@ -56,6 +75,24 @@ class JavaFeedbackHook < Mumukit::Hook
       end
     end
 
+    def explain_implemented_method_should_be_public(_, result)
+     (/#{error} (.*) in (.*) cannot implement (.*) in (.*)#{near_regex}\n  attempting to assign weaker access privileges/.match result).try do |it|
+       {method: it[1], class: it[2], near: it[5]}
+     end
+    end
+
+    def explain_missing_implementation(_, result)
+      (/#{error} (.*) is not abstract and does not override abstract method (.*) in (.*)#{near_regex}/.match result).try do |it|
+        {down: it[1], method: it[2], up: it[3] }
+      end
+    end
+
+    def explain_missing_return_type(_, result)
+      (/#{error} invalid method declaration; return type required#{near_regex}/.match result).try do |it|
+        { near: it[1] }
+      end
+    end
+
     private
 
     def start_regex(symbol=' ')
@@ -74,6 +111,14 @@ class JavaFeedbackHook < Mumukit::Hook
       start_regex 'location:'
     end
 
+    def type_incompatibilty_kind(a_type, another)
+      [a_type, another].any? { |it| primitive_types.include?(it) } ? :incompatible_types_primitives : :incompatible_types_classes
+    end
+
+    def primitive_types
+      ['byte', 'short', 'int', 'long', 'float', 'double', 'boolean', 'char']
+    end
+
     def error
       '[eE]rror:'
     end
@@ -84,5 +129,34 @@ class JavaFeedbackHook < Mumukit::Hook
       end
     end
 
+    def at_location(symbol, location)
+      symbol_type, _ = parse_symbol symbol
+      return '' if symbol_type == 'class'
+
+      ' ' + I18n.t(:at_location, {
+        location: localize_symbol(location)
+      })
+    end
+
+    def localize_symbol(symbol)
+      symbol_type, name, type = parse_symbol symbol
+      i18n_key = "symbol_#{symbol_type}"
+      return "`#{symbol}`" unless I18n.exists? i18n_key
+
+      I18n.t(i18n_key, { name: name }) + localize_of_type(type)
+    end
+
+    def localize_of_type(type)
+      return '' if type.nil?
+
+      ' ' + I18n.t(:of_type, type: type)
+    end
+
+    def parse_symbol(result)
+      parts = /^(\w+) ([\w\(\)]+)( of type (\w+))?/.match result
+      return ['', '', ''] if parts.nil?
+
+      [parts[1], parts[2], parts[4]]
+    end
   end
 end

data/lib/locales/en.yml

@@ -1,10 +1,19 @@
 en:
-  missing_semicolon: "Missing ';' near `%{near}`"
-  missing_parenthesis: "Missing '(' near `%{near}`"
+  at_location: "in %{location}"
+  cannot_find_symbol: "Cannot find `%{symbol}` declaration%{at_location}"
+  implemented_method_should_be_public: "Method `%{method}` in class `%{class}` should be public. Check if it has the right visibility near `%{near}`."
+  incompatible_types_classes: "Class `%{actual}` should be a `%{expected}`. Probably an _extends_ or _implements_ is missing near `%{near}`."
+  incompatible_types_primitives: "You are returning a `%{actual}` where a `%{expected}` is needed near `%{near}`"
+  incompatible_types: "%{message}"
   missing_bracket: "Missing { near `%{near}`. Maybe you misspelled a class or method declaration."
+  missing_implementation: "An implementation of method `%{method}` is missing in class `%{down}`, since it is defined at `%{up}`"
+  missing_parenthesis: "Missing '(' near `%{near}`"
   missing_parameter_type: "Missing parameter type near `%{near}`"
-  cannot_find_symbol: "Cannot find `%{symbol}` declaration in `%{location}`"
   missing_return_statement: "There is a method that must return something, but doesn't. Check your code again!"
-  incompatible_types: "Class `%{down}` should be a `%{up}`. Probably an _extends_ or _implements_ is missing near `%{near}`."
+  missing_return_type: "Missing return type near `%{near}`"
+  missing_semicolon: "Missing ';' near `%{near}`"
+  lossy_conversion: "You are trying to convert a `%{from}` into a `%{to}`, but `%{from}` is more specific, and data may be lost. If you are sure about doing this, add a `(%{to})` to the left side of the expression near `%{near}`."
+  of_type: "of type `%{type}`"
   unexpected_close_curly: "You have a syntax error. Check if you're missing a `;` or a `{` near line %{line}."
   unexpected_close_paren: "You have a syntax error. Check if you're missing a `(` or have an extra `)` near line %{line}. Also make sure all parameters declare their types."
+  wrong_constructor_arguments: "Constructor of class `%{class}` doesn't exist or it expects another amount or type of arguments"

data/lib/locales/es.yml

@@ -1,10 +1,22 @@
 es:
-  missing_semicolon: "Parece que falta un ';' cerca de `%{near}`"
-  missing_parenthesis: "Parece que falta un '(' cerca de `%{near}`"
-  missing_bracket: "Se esperaba una { cerca de `%{near}`. Fijate si tal vez, introdujiste un paréntesis de más o está mal escrita la declaración de clase o método."
-  missing_parameter_type: "Parece que falta el tipo de un parámetro cerca de `%{near}`"
-  cannot_find_symbol: "No se encontró la definición de `%{symbol}` en `%{location}`"
+  at_location: "en %{location}"
+  cannot_find_symbol: "Te falta la definición de %{symbol}%{at_location}"
+  implemented_method_should_be_public: "El método `%{method}` en la clase `%{class}` debería ser público. Revisá si tiene la visibilidad correcta cerca de `%{near}`."
+  incompatible_types_classes: "La clase `%{actual}` debería ser un `%{expected}`. Revisá si no te falta un _extends_ o _implements_ cerca de `%{near}`."
+  incompatible_types_primitives: "Estás devolviendo un `%{actual}` donde se necesitaba un `%{expected}` cerca de `%{near}`"
+  incompatible_types: "%{message}"
+  missing_bracket: "Te falta una `{` cerca de `%{near}`. Fijate si te sobran paréntesis o está mal escrita la declaración de clase o método."
+  missing_implementation: "Te está faltando implementar el método `%{method}` en la clase `%{down}`, ya que está definido en `%{up}`"
+  missing_parenthesis: "Parece que te falta un '(' cerca de `%{near}`"
+  missing_parameter_type: "Parece que te falta el tipo de un parámetro cerca de `%{near}`"
   missing_return_statement: "Hay un método que debería retornar algo, pero no está retornando nada. ¡Revisá bien tu código!"
-  incompatible_types: "La clase `%{down}` debería ser un `%{up}`. Revisá si no te falta un _extends_ o _implements_ cerca de `%{near}`."
-  unexpected_close_curly: "Tenés un error de sintaxis. Fijate si no te falta un `;` o una `{` cerca de la línea %{line}."
-  unexpected_close_paren: "Tenés un error de sintaxis. Fijate si no te falta un `(` o te sobra un `)` cerca de la línea %{line}. Asegurate también de que todos los parámetros declaren sus tipos."
+  missing_return_type: "Te falta especificar el tipo de retorno cerca de `%{near}`"
+  missing_semicolon: "Parece que te falta un ';' cerca de `%{near}`"
+  lossy_conversion: "Estás intentando convertir un `%{from}` a un `%{to}`, pero `%{from}` es más específico y se podrían perder datos. Si realmente querés hacerlo, agregá un `(%{to})` a la izquierda de la expresión, cerca de `%{near}`."
+  of_type: "de tipo `%{type}`"
+  symbol_class: "la clase `%{name}`"
+  symbol_method: "método `%{name}`"
+  symbol_variable: "la variable `%{name}`"
+  unexpected_close_curly: "Fijate si no te falta un `;` o una `{` cerca de la línea %{line}."
+  unexpected_close_paren: "Fijate si no te falta un `(` o te sobra un `)` cerca de la línea %{line}. Asegurate también de que todos los parámetros declaren sus tipos."
+  wrong_constructor_arguments: "El constructor de la clase `%{class}` no existe o espera otra cantidad o tipo de argumentos"

data/lib/version.rb

@@ -1,3 +1,3 @@
 module JavaVersionHook
-  VERSION = '1.5.1'
+  VERSION = '1.6.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mumuki-java-runner
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.6.0
 platform: ruby
 authors:
 - Franco Leonardo Bulgarelli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-24 00:00:00.000000000 Z
+date: 2019-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mumukit
@@ -128,8 +128,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: Java Runner for Mumuki