mumuki-domain 9.3.0 → 9.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b78b493d9f7e6314a746e22d17fe33c140dada6e77a9af84da850098180a1677
-  data.tar.gz: 9ed9017804d844c8a24540dcdf5c32d4ad78d8a28b186e3df1dbd83b845ff5cd
+  metadata.gz: 801f11c820f31c39323edff06d235e0c48804b1454f5dbd118363a34f153808f
+  data.tar.gz: daaa6a61637d5d52412fee38276de7c2ebad10cb696f28b912cbe4ef3ca49247
 SHA512:
-  metadata.gz: 84faddd371cc851bbb08155cddb140dd6a17eaa3920f73cf235950d3321f07be4dd4f44325708b582904ee4d1eac2b5c426be3afb7b82e566834d87686eec3b2
-  data.tar.gz: 93cf6080fba52bffbe3d7fafd4a3ed0121f55accaa8b1c7950e9512a4f409b9031288b51998ab7caff22ac161fd4c0d4c9fb663f369cafb00a42afcfe6ad5732
+  metadata.gz: 4b0370b955ddf9ae29c02dde36613b1bde7fcd3c3711e55f20744bcdcd283e711f461ad6ab2766b0b560fa7e845a401a2cf0172d4a04d7223eb93671ea85e95f
+  data.tar.gz: 1ea134ed3fe1ac847c524eff4479463f7a75c6d96ef2ecdcb6ef2c62162c38ab0effaae3e76da02c57666418747fd01753c3b369f5a0dae1058b794dac22c067

data/app/models/application_record.rb

@@ -103,6 +103,21 @@ class ApplicationRecord < ActiveRecord::Base
     end
   end
 
+  def self.with_pg_retry(&block)
+    retries ||= 0
+    transaction(&block)
+  rescue ActiveRecord::StatementInvalid => e
+    retries += 1
+
+    raise e if retries > 2
+    if %w(PG::ConnectionBad PG::UnableToSend).any? { |it| e.message.include? it }
+      warn "Postgres connection failed. Retrying in 5 seconds..."
+      sleep 5
+      ActiveRecord::Base.connection.verify!
+      retry
+    end
+  end
+
   def self.numbered(*associations)
     class_eval do
       associations.each do |it|

data/app/models/concerns/with_pg_lock.rb

@@ -0,0 +1,19 @@
+module WithPgLock
+  ##
+  # Lock PG table, reload model and execute callback if
+  # criterion is met
+  #
+  def with_pg_lock(callback, criterion = proc { true })
+    # Some notes:
+    #
+    # * nowait is a postgre specific option and may not work with other databases
+    # * nowait will raise an exception if the lock can not be acquired
+    # * we are using a double check lock pattern to reduce lock acquisition
+    with_lock('for update nowait') do
+      reload
+      callback.call if criterion.call
+    end if criterion.call
+  rescue
+    nil
+  end
+end

data/app/models/concerns/with_reminders.rb

@@ -1,5 +1,6 @@
 module WithReminders
   extend ActiveSupport::Concern
+  include WithPgLock
 
   def build_reminder
     mailer = UserMailer.new
@@ -18,23 +19,13 @@ module WithReminders
   end
 
   # Try to send a reminder, by acquiring a database lock for update
-  # the aproppriate record. This object can't be updated as long as
+  # the appropriate record. This object can't be updated as long as
   # the reminder is being sent.
   #
   # This method is aimed to be sent across multiple servers or processed concurrently
   # and still not send duplicate mails
   def try_remind_with_lock!
-    # Some notes:
-    #
-    # * nowait is a postgre specific option and may not work with other databases
-    # * nowait will raise an exception if the lock can not be acquired
-    # * we are using a double check lock pattern to reduce lock acquisition
-    with_lock('for update nowait') do
-      reload
-      remind! if should_remind?
-    end if should_remind?
-  rescue
-    nil
+    with_pg_lock proc { remind! }, proc { should_remind? }
   end
 
   private

data/app/models/concerns/with_responsible_moderator.rb

@@ -0,0 +1,51 @@
+module WithResponsibleModerator
+  extend ActiveSupport::Concern
+
+  MODERATOR_MAX_RESPONSIBLE_TIME = 45.minutes
+
+  def toggle_responsible!(moderator)
+    if responsible?(moderator)
+      no_responsible!
+    elsif no_current_responsible?
+      responsible! moderator
+    end
+  end
+
+  def any_responsible?
+    responsible_moderator_at.present? && (responsible_moderator_at + MODERATOR_MAX_RESPONSIBLE_TIME).future?
+  end
+
+  def no_current_responsible?
+    !any_responsible?
+  end
+
+  def responsible?(moderator)
+    any_responsible? && responsible_moderator_by == moderator
+  end
+
+  def current_responsible_visible_for?(user)
+    user&.moderator_here? && any_responsible?
+  end
+
+  def can_toggle_responsible?(user)
+    can_have_responsible? && user_can_be_responsible?(user)
+  end
+
+  private
+
+  def responsible!(moderator)
+    update! responsible_moderator_at: Time.now, responsible_moderator_by: moderator
+  end
+
+  def no_responsible!
+    update! responsible_moderator_at: nil, responsible_moderator_by: nil
+  end
+
+  def user_can_be_responsible?(user)
+    user&.moderator_here? && (no_current_responsible? || responsible?(user))
+  end
+
+  def can_have_responsible?
+    opened? || pending_review?
+  end
+end

data/app/models/discussion.rb

@@ -1,11 +1,11 @@
 class Discussion < ApplicationRecord
-  include WithDiscussionStatus, WithScopedQueries, Contextualization
+  include WithDiscussionStatus, WithScopedQueries, Contextualization, WithResponsibleModerator
 
   belongs_to :item, polymorphic: true
   has_many :messages, -> { order(:created_at) }, dependent: :destroy
   belongs_to :initiator, class_name: 'User'
 
-  belongs_to :last_moderator_access_by, class_name: 'User', optional: true
+  belongs_to :responsible_moderator_by, class_name: 'User', optional: true
   belongs_to :status_updated_by, class_name: 'User', optional: true
 
   belongs_to :exercise, foreign_type: :exercise, foreign_key: 'item_id'
@@ -15,21 +15,24 @@ class Discussion < ApplicationRecord
 
   scope :by_language, -> (language) { includes(:exercise).joins(exercise: :language).where(languages: {name: language}) }
   scope :order_by_responses_count, -> (direction) { reorder(validated_messages_count: direction, messages_count: opposite(direction)) }
-  scope :by_requires_moderator_response, -> (boolean) { where(requires_moderator_response: boolean.to_boolean) }
+  scope :by_requires_attention, -> (boolean) { opened_and_requires_moderator_response(boolean).or(pending_review).no_responsible_moderator }
+  scope :opened_and_requires_moderator_response, -> (boolean) { where(requires_moderator_response: boolean.to_boolean)
+                                                                  .where(status: :opened) }
+  scope :no_responsible_moderator, -> { where('responsible_moderator_at < ?', Time.now - MODERATOR_MAX_RESPONSIBLE_TIME)
+                                          .or(where(responsible_moderator_at: nil)) }
+  scope :pending_review, -> { where(status: :pending_review) }
 
   after_create :subscribe_initiator!
 
   markdown_on :description
 
   sortable :responses_count, :upvotes_count, :created_at, default: :created_at_desc
-  filterable :status, :language, :requires_moderator_response
+  filterable :status, :language, :requires_attention
   pageable
 
   delegate :language, to: :item
   delegate :to_discussion_status, to: :status
 
-  MODERATOR_REVIEW_AVERAGE_TIME = 17.minutes
-
   scope :for_user, -> (user) do
     if user.try(:moderator_here?)
       all
@@ -81,7 +84,7 @@ class Discussion < ApplicationRecord
   end
 
   def friendly
-    initiator.name
+    initiator.abbreviated_name
   end
 
   def subscription_for(user)
@@ -101,6 +104,7 @@ class Discussion < ApplicationRecord
     messages.create(message)
     user.subscribe_to! self
     unread_subscriptions(user)
+    no_responsible! if responsible?(user)
   end
 
   def authorized?(user)
@@ -125,6 +129,8 @@ class Discussion < ApplicationRecord
       update! status: status,
               status_updated_by: user,
               status_updated_at: Time.now
+
+      no_responsible! if responsible?(user)
     end
   end
 
@@ -144,6 +150,14 @@ class Discussion < ApplicationRecord
     validated_messages_count > 0
   end
 
+  def requires_attention_for?(user)
+    user&.moderator_here? && requires_attention?
+  end
+
+  def requires_attention?
+    no_current_responsible? && status.requires_attention_for?(self)
+  end
+
   def subscribe_initiator!
     initiator.subscribe_to! self
   end
@@ -163,25 +177,6 @@ class Discussion < ApplicationRecord
             requires_moderator_response: !has_moderator_response
   end
 
-  def update_last_moderator_access!(user)
-    if user&.moderator_here? && !last_moderator_access_visible_for?(user)
-      update! last_moderator_access_at: Time.now,
-              last_moderator_access_by: user
-    end
-  end
-
-  def being_accessed_by_moderator?
-    last_moderator_access_at.present? && (last_moderator_access_at + MODERATOR_REVIEW_AVERAGE_TIME).future?
-  end
-
-  def last_moderator_access_visible_for?(user)
-    show_last_moderator_access_for?(user) && being_accessed_by_moderator?
-  end
-
-  def show_last_moderator_access_for?(user)
-    user&.moderator_here? && last_moderator_access_by != user
-  end
-
   def self.debatable_for(klazz, params)
     debatable_id = params[:"#{klazz.underscore}_id"]
     klazz.constantize.find(debatable_id)

data/app/models/exam_authorization_request.rb

@@ -21,7 +21,7 @@ class ExamAuthorizationRequest < ApplicationRecord
   def icon
     case status.to_sym
     when :pending
-      { class: 'info-circle', type: 'info' }
+      { class: 'hourglass', type: 'info' }
     when :approved
       { class: 'check-circle', type: 'success' }
     when :rejected

data/app/models/exam_registration.rb

@@ -1,4 +1,5 @@
 class ExamRegistration < ApplicationRecord
+  include WithPgLock
   include WithTimedEnablement
   include TerminalNavigation
 
@@ -16,6 +17,8 @@ class ExamRegistration < ApplicationRecord
 
   alias_attribute :name, :description
 
+  scope :should_process, -> { where(processed: false).where(arel_table[:end_time].lt(Time.now)) }
+
   def authorization_criterion
     @authorization_criterion ||= ExamRegistration::AuthorizationCriterion.parse(authorization_criterion_type, authorization_criterion_value)
   end
@@ -40,11 +43,21 @@ class ExamRegistration < ApplicationRecord
     registrees.where.not(id: Notification.notified_users_ids_for(self, self.organization))
   end
 
+  # Try to process authorization request, by acquiring a database lock for update
+  # the appropriate record.
+  #
+  # This method is aimed to be sent across multiple servers or processed concurrently
+  # and still not send duplicate mails
   def process_requests!
+    with_pg_lock proc { process_authorization_requests! }, proc { !processed? }
+  end
+
+  def process_authorization_requests!
     authorization_requests.each do |it|
       process_request! it
       it.try_authorize!
     end
+    update! processed: true
   end
 
   def authorization_request_for(user)

data/app/models/user_stats.rb

@@ -11,7 +11,7 @@ class UserStats < ApplicationRecord
   end
 
   def activity(date_range = nil)
-    date_filter = { submitted_at: date_range }.compact
+    date_filter = { updated_at: date_range }.compact
     {
         exercises: {
             solved_count: organization_exercises

data/db/migrate/20210512200453_add_processed_flag_to_exam_registration.rb

@@ -0,0 +1,5 @@
+class AddProcessedFlagToExamRegistration < ActiveRecord::Migration[5.1]
+  def change
+    add_column :exam_registrations, :processed, :boolean, default: false
+  end
+end

data/db/migrate/20210518100153_rename_last_moderator_access.rb

@@ -0,0 +1,6 @@
+class RenameLastModeratorAccess < ActiveRecord::Migration[5.1]
+  def change
+    rename_column :discussions, :last_moderator_access_by_id, :responsible_moderator_by_id
+    rename_column :discussions, :last_moderator_access_at, :responsible_moderator_at
+  end
+end

data/lib/mumuki/domain/factories/organization_factory.rb

@@ -6,6 +6,7 @@ FactoryBot.define do
     locale { 'en' }
     settings {}
     name { 'an-organization' }
+    time_zone { 'UTC' }
     book
   end
 

data/lib/mumuki/domain/organization/profile.rb

@@ -13,7 +13,8 @@ class Mumuki::Domain::Organization::Profile < Mumukit::Platform::Model
                       :community_link,
                       :errors_explanations,
                       :welcome_email_template,
-                      :welcome_email_sender
+                      :welcome_email_sender,
+                      :time_zone
 
   def locale_json
     locale_h.to_json
@@ -38,4 +39,9 @@ class Mumuki::Domain::Organization::Profile < Mumukit::Platform::Model
   def open_graph_image_url
     @open_graph_image_url ||= Mumukit::Platform.laboratory.url_for("logo-alt.png")  # Best image size: 256x256
   end
+
+  def time_zone
+    @time_zone || 'Buenos Aires'
+  end
+
 end

data/lib/mumuki/domain/organization/settings.rb

@@ -46,4 +46,5 @@ class Mumuki::Domain::Organization::Settings < Mumukit::Platform::Model
   def in_preparation?
     in_preparation_until.present? && in_preparation_until.future?
   end
+
 end

data/lib/mumuki/domain/status/discussion/closed.rb

@@ -12,4 +12,8 @@ module Mumuki::Domain::Status::Discussion::Closed
   def self.iconize
     {class: :danger, type: 'times-circle'}
   end
+
+  def self.requires_attention_for?(_)
+    false
+  end
 end

data/lib/mumuki/domain/status/discussion/opened.rb

@@ -28,4 +28,8 @@ module Mumuki::Domain::Status::Discussion::Opened
   def self.should_be_shown?(*)
     true
   end
+
+  def self.requires_attention_for?(discussion)
+    discussion.requires_moderator_response?
+  end
 end

data/lib/mumuki/domain/status/discussion/pending_review.rb

@@ -12,4 +12,8 @@ module Mumuki::Domain::Status::Discussion::PendingReview
   def self.iconize
     {class: :info, type: 'hourglass'}
   end
+
+  def self.requires_attention_for?(_)
+    true
+  end
 end

data/lib/mumuki/domain/status/discussion/solved.rb

@@ -16,4 +16,8 @@ module Mumuki::Domain::Status::Discussion::Solved
   def self.should_be_shown?(*)
     true
   end
+
+  def self.requires_attention_for?(_)
+    false
+  end
 end

data/lib/mumuki/domain/version.rb

@@ -1,5 +1,5 @@
 module Mumuki
   module Domain
-    VERSION = '9.3.0'
+    VERSION = '9.8.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mumuki-domain
 version: !ruby/object:Gem::Version
-  version: 9.3.0
+  version: 9.8.0
 platform: ruby
 authors:
 - Franco Leonardo Bulgarelli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-05-13 00:00:00.000000000 Z
+date: 2021-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -291,11 +291,13 @@ files:
 - app/models/concerns/with_name.rb
 - app/models/concerns/with_notifications.rb
 - app/models/concerns/with_number.rb
+- app/models/concerns/with_pg_lock.rb
 - app/models/concerns/with_preferences.rb
 - app/models/concerns/with_profile.rb
 - app/models/concerns/with_progress.rb
 - app/models/concerns/with_randomizations.rb
 - app/models/concerns/with_reminders.rb
+- app/models/concerns/with_responsible_moderator.rb
 - app/models/concerns/with_scoped_queries.rb
 - app/models/concerns/with_scoped_queries/filter.rb
 - app/models/concerns/with_scoped_queries/page.rb
@@ -666,6 +668,8 @@ files:
 - db/migrate/20210318194559_add_dates_to_certificate_program.rb
 - db/migrate/20210318195238_rename_certificate_dates.rb
 - db/migrate/20210330175706_create_exam_registration_user_join_table.rb
+- db/migrate/20210512200453_add_processed_flag_to_exam_registration.rb
+- db/migrate/20210518100153_rename_last_moderator_access.rb
 - lib/mumuki/domain.rb
 - lib/mumuki/domain/area.rb
 - lib/mumuki/domain/engine.rb