multiparameter_attributes_handler 0.1.0 → 0.1.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZWFmYjJjMmVhMDMzMGY1NGFlMTY3Yzc1Mjk2OTIyYjdmZjM5MTE3ZA==
+    YTE5NGNhNTY0NmE4NzY2MzVmOGM5ZmUyZjM3YzI2MTI4N2U1M2EzNA==
   data.tar.gz: !binary |-
-    ZmEzZWIzMzcwMzM5MGQyZmUzMDkyNTBiODlmN2U1NmFjODUyZGU5OQ==
+    OGM1NDgzMzZmN2RjNTRiYTYyOWVhMzI0NzM4YWMyYWYxMjAyMmVhMg==
 SHA512:
   metadata.gz: !binary |-
-    OTkwYmE5ZTFmNDRiYzQxMWJhMTNmMTU5N2E5YTUyMjVjZjJiNTZjNzIzMjll
-    NTVhOTZjZTI2MTg1ODA2M2Y4NTY0MTI0MzQ5MjZmMTI0OGY4YmIxOTRkYzMx
-    MDI5N2YyNDY5MmFkOTdjODhjNWNhNTNiYzZjMjI3ODQ5NGQ5NzQ=
+    OGE5NGRlNzMyNWIxZTIxMjYwYTA5MmUwN2Y3Y2JmM2UxN2EzNjA5NTVlMWJm
+    NjJhYTZmYmFmNjQxNDlmNTJkMDJlMjQ1NGYwOGExZDJmZGM1MmUzMjhkMmRi
+    YzdmYmViODRhNjIzYzVlYmIzMmNjOWUwZGVhMTAwNGY2MTM1YjI=
   data.tar.gz: !binary |-
-    YzVjZTY3NmIyZGU5ODdlMDE3OTc0NWIyZjUwMzQ2OGE0ODMzODM2NWYzMDNi
-    M2NhZGFlNjI4NTkwMzI0MDU5YzIxNjU5ZTUzOGVhOTdiNzMzOTZiNTA2YWM2
-    MzA3NzRlNjY2ZWZjY2ViYjdjNjA5NWQzNDEwZGYwMTUyNWZlZGY=
+    ZTcxNTlmYmYxMjk3OWRmYmJjMTQxYzcxN2FmYWM3ZTVlYzMyZDg4MzI0NzU2
+    NGM0ZTg4M2U1ZTliNWNkZTBlZTAwMGM3OTcyMTY2NmZhNDg2MmRhNDhmYTk1
+    NTcxN2U2MzExMWQzZTlmMjI2MjA4NDYzMjJiOWYyYmEwMzlkNmY=

data/README.rdoc

@@ -32,9 +32,12 @@ This creates a last_read key with a time object derived from the values
         "last_read(1i)" => "2004", 
         "last_read(2i)" => "6", 
         "last_read(3i)" => "24",
-        "last_read"     => Time.local('2004', '6', '24')
+        "last_read"     => Date.new(2004, 6, 24)
     }
 
+Note that if hours and minutes are also present, the derived value will be a
+Time object.
+
 === Modifying the output
 
 If you need to modify the derived values, pass a block to manipulate_all, and
@@ -48,7 +51,7 @@ Will create
         "last_read(1i)" => "2004", 
         "last_read(2i)" => "6", 
         "last_read(3i)" => "24",
-        "last_read"     => Time.local('2004', '6', '24').to_s
+        "last_read"     => Date.new('2004', '6', '24').to_s
     }
 
 == An ActiveResource example

data/lib/multiparameter_attributes_handler/manipulator.rb

@@ -45,7 +45,11 @@ module MultiparameterAttributesHandler
     private
     def convert_to_time(multiparameter, values)
       begin
-        Time.local(*values)
+        if values.length == 3
+          Date.new *values.collect(&:to_i)
+        else
+          Time.local *values
+        end
       rescue => e
         msg = "Error determining value_of #{multiparameter} from #{values} (#{e.message})"
         raise_assignment_errors(multiparameter, values, msg, e)

data/lib/multiparameter_attributes_handler/version.rb

@@ -1,11 +1,20 @@
 module MultiparameterAttributesHandler
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end
 
 # History
 # =======
-# 
-# 0.1.0: Allowed a block to be user to modify the output
+#
+# 0.1.1: Returns Date object if only multiparameter only has three elements
+# -------------------------------------------------------------------------
+#
+# A problem was identified where summer time caused a problem with hour offsets
+# if the multiparameter was for a date.
+#
+# The new logic is that if date and time are contained in the multiparameter,
+# a Time object is returned. If only date is present, a date object is returned
+# 
+# 0.1.0: Allowes a block to be user to modify the output
 # ------------------------------------------------------
 # A use case was found where the resulting data needed to be stored as a 
 # string, rather than a date. As there may be other ways the output needs

data/test/multiparameter_attributes_handler/manipulator_test.rb

@@ -23,18 +23,21 @@ module MultiparameterAttributesHandler
     end
 
     def test_value_of_multiparameter
-      assert_equal time_for('last_read'), manipulator.value_of('last_read')
       assert_equal time_for('other'), manipulator.value_of('other')
     end
 
     def test_value_mod_changes_values
       manipulator = Manipulator.new(hash, &:to_s)
-      assert_equal time_for('last_read').to_s, manipulator.value_of('last_read')
+      assert_equal date_for('last_read').to_s, manipulator.value_of('last_read')
+    end
+
+    def test_value_of_multiparameter_when_date
+      assert_equal date_for('last_read'), @manipulator.value_of('last_read')
     end
     
     def test_value_mod_with_lambda
       manipulator = Manipulator.new(hash) {|value| value + 1}
-      assert_equal (time_for('last_read') + 1), manipulator.value_of('last_read')
+      assert_equal (date_for('last_read') + 1), manipulator.value_of('last_read')
     end
 
     def test_output_returns_original_content
@@ -108,5 +111,9 @@ module MultiparameterAttributesHandler
       Time.local *manipulator.values_for(field)
     end
 
+    def date_for(field)
+      Date.new *manipulator.values_for(field).collect(&:to_i)
+    end
+
   end
 end

data/test/multiparameter_attributes_handler_test.rb

@@ -9,12 +9,12 @@ class MultiparameterAttributesHandlerTest < Test::Unit::TestCase
 
   def test_manipulate_all   
     output = MultiparameterAttributesHandler.manipulate_all(attributes)
-    assert_equal Time.local(2004, 6, 24), output['last_read']
+    assert_equal Date.new(2004, 6, 24), output['last_read']
   end
   
   def test_manipulate_all_with_block
     output = MultiparameterAttributesHandler.manipulate_all(attributes, &:to_s)
-    assert_equal Time.local(2004, 6, 24).to_s, output['last_read']
+    assert_equal Date.new(2004, 6, 24).to_s, output['last_read']
   end
   
   def attributes

data/test/thing_test.rb

@@ -15,7 +15,7 @@ class ThingTest < Test::Unit::TestCase
     @thing.attributes = attributes
     # note that extra #to_date call allows test to pass for Oracle, which
     # treats dates/times the same
-    assert_equal Time.local(2004, 6, 24), @thing.attributes['last_read']
+    assert_equal Date.new(2004, 6, 24), @thing.attributes['last_read']
   end
 
   def test_multiparameter_attributes_on_date_with_empty_year

metadata

@@ -1,18 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: multiparameter_attributes_handler
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Rob Nichols
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-27 00:00:00.000000000 Z
+date: 2015-07-29 00:00:00.000000000 Z
 dependencies: []
 description: Rails forms helpers for date and time fields generate multiparameter
-  params. multiparameter_attributes_handler allows objects to assign these to thier
-  attributes,
+  params. multiparameter_attributes_handler allows objects to use these params.
 email:
 - rob@undervale.co.uk
 executables: []
@@ -32,7 +31,8 @@ files:
 - test/thing.rb
 - test/thing_test.rb
 homepage: https://github.com/reggieb/multiparameter_attributes_handler
-licenses: []
+licenses:
+- MIT-LICENSE
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -50,13 +50,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.4.1
 signing_key: 
 specification_version: 4
-summary: Allows objects with attributes, to handle multiparameter params
+summary: Allows non-active_record objects to handle multiparameter params
 test_files:
-- test/thing_test.rb
 - test/multiparameter_attributes_handler_test.rb
 - test/thing.rb
 - test/multiparameter_attributes_handler/multiparameter_attributes_handler_error_test.rb
 - test/multiparameter_attributes_handler/manipulator_test.rb
+- test/thing_test.rb