multi_zip 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1e4e927a532bd99e7fc59c1a6f84da9bb8369694
-  data.tar.gz: 753a83ee20f222d33b04e29f4edd131062976ada
+  metadata.gz: b4d9becd80958a0eb07dab22a0207dfcb91ebe00
+  data.tar.gz: eb1092f782ab4fc2e6933eb5a36b84036bf9cfca
 SHA512:
-  metadata.gz: 11ba062b2125374d543c50f05c48045d51e5b62fc01ed0f8348a26a1b65159b9f40fa2702ad61600a07e3a75fab5fdbaf11815b4cf595edaf87984ab7dd8ee2b
-  data.tar.gz: 3a261d116078bc97320ff789ef2eeb7052dfe1d407c911036a462069535fb9a713420b65bb148c75c4f9644d0d0a66ff394360d066b2e102590c10f5255a5f78
+  metadata.gz: 9a6eca1072c53f5266e9e8afdee331b7df518df68ebceb5a10b9120fc9041e3710552fdcd557eba80ed51ec95692864b2724cf11f64afa0f5986fc1883412e7d
+  data.tar.gz: e90c64a98a10a98dcedda42f190d1551a507f83166d3ea5612f0996e6a47e8d7b9a8d087998caeee975d8b146c3984bdf3e2f848fe5d9723549bf5ca2e43c7f2

data/.gitignore

@@ -14,3 +14,4 @@
 mkmf.log
 .ruby-*
 *.gem
+test_in_all_rubies.sh

data/.travis.yml

@@ -1,12 +1,12 @@
 language: ruby
 rvm:
-  - ruby-head
   - ree
   - 1.8.7
   - 1.9.3
   - 2.0.0
-  - 2.1.5
-  - 2.2.1
+  - 2.1.8
+  - 2.2.4
+  - 2.3.0
   - jruby-18mode
   - jruby-19mode
   - rbx-2
@@ -15,3 +15,4 @@ matrix:
     - rvm:
       - ruby-head
       - rbx-2
+sudo: false

data/Gemfile

@@ -4,8 +4,7 @@ gemspec
 
 # can't use pry on old rubies or on rubinius
 if RUBY_VERSION.to_f >= 2.0 && RUBY_ENGINE == 'ruby'
-  gem 'pry', :require => false
-  gem 'pry-byebug', :require => false
+  gem 'byebug', :require => false
   gem 'guard-rspec', :require => false
 end
 

data/Guardfile

@@ -1,43 +1,7 @@
-# A sample Guardfile
-# More info at https://github.com/guard/guard#readme
-
-## Uncomment and set this to only include directories you want to watch
-# directories %w(app lib config test spec features)
-
-## Uncomment to clear the screen before every task
-# clearing :on
-
-## Guard internally checks for changes in the Guardfile and exits.
-## If you want Guard to automatically start up again, run guard in a
-## shell loop, e.g.:
-##
-##  $ while bundle exec guard; do echo "Restarting Guard..."; done
-##
-## Note: if you are using the `directories` clause above and you are not
-## watching the project directory ('.'), then you will want to move
-## the Guardfile to a watched dir and symlink it back, e.g.
-#
-#  $ mkdir config
-#  $ mv Guardfile config/
-#  $ ln -s config/Guardfile .
-#
-# and, you'll have to watch "config/Guardfile" instead of "Guardfile"
-
-# Note: The cmd option is now required due to the increasing number of ways
-#       rspec may be run, below are examples of the most common uses.
-#  * bundler: 'bundle exec rspec'
-#  * bundler binstubs: 'bin/rspec'
-#  * spring: 'bin/rspec' (This will use spring if running and you have
-#                          installed the spring binstubs per the docs)
-#  * zeus: 'zeus rspec' (requires the server to be started separately)
-#  * 'just' rspec: 'rspec'
-
 guard :rspec, cmd: "bundle exec rspec" do
   require "guard/rspec/dsl"
   dsl = Guard::RSpec::Dsl.new(self)
 
-  # Feel free to open issues for suggestions and improvements
-
   # RSpec files
   rspec = dsl.rspec
   watch(rspec.spec_helper) { rspec.spec_dir }
@@ -47,31 +11,4 @@ guard :rspec, cmd: "bundle exec rspec" do
   # Ruby files
   ruby = dsl.ruby
   dsl.watch_spec_files_for(ruby.lib_files)
-
-  # Rails files
-  rails = dsl.rails(view_extensions: %w(erb haml slim))
-  dsl.watch_spec_files_for(rails.app_files)
-  dsl.watch_spec_files_for(rails.views)
-
-  watch(rails.controllers) do |m|
-    [
-      rspec.spec.("routing/#{m[1]}_routing"),
-      rspec.spec.("controllers/#{m[1]}_controller"),
-      rspec.spec.("acceptance/#{m[1]}")
-    ]
-  end
-
-  # Rails config changes
-  watch(rails.spec_helper)     { rspec.spec_dir }
-  watch(rails.routes)          { "#{rspec.spec_dir}/routing" }
-  watch(rails.app_controller)  { "#{rspec.spec_dir}/controllers" }
-
-  # Capybara features specs
-  watch(rails.view_dirs)     { |m| rspec.spec.("features/#{m[1]}") }
-
-  # Turnip features and steps
-  watch(%r{^spec/acceptance/(.+)\.feature$})
-  watch(%r{^spec/acceptance/steps/(.+)_steps\.rb$}) do |m|
-    Dir[File.join("**/#{m[1]}.feature")][0] || "spec/acceptance"
-  end
 end

data/README.md

@@ -12,8 +12,8 @@ It currently supports `.zip` archives only. See TODO for info on others.
 MultiZip provides a very small and focused set of functions:
 
  * Create a new zip archive or open existing one.
- * Add files to a archive from using content from a variable.
- * Read files from a archive in to a variable.
+ * Add files to an archive from a file a variable.
+ * Read files from an archive in to a variable.
  * Extract files from an archive to a local file.
  * List files contained in an archive.
  * Delete files from an archive.
@@ -43,7 +43,8 @@ Do the standard dance: Either add `gem 'multi_zip'` to your Gemfile or run
 `gem install multi_zip`.
 
 __IMPORTANT NEXT STEP:__ You will also need a zip backend gem installed and
-required. See `Supported Backends` for of which ones can be used.
+required. See [Supported Backend Gems](#supported-backend-gems) for a list of
+which ones can be used.
 
 ## Getting started
 
@@ -81,13 +82,13 @@ You can also check which of these supported backends is currently available:
 
 ```ruby
 > MultiZip.available_backends
- => [] 
+ => []
 > require 'archive/zip'
- => true 
+ => true
 > MultiZip.available_backends
- => [:archive_zip] 
+ => [:archive_zip]
 > require 'zip'
- => true 
+ => true
 > MultiZip.available_backends
  => [:rubyzip, :archive_zip]
 ```
@@ -162,7 +163,7 @@ file = zip.remove_members([
 # => true
 ```
 
-#### Creating a new instance and passing a block 
+#### Creating a new instance and passing a block
 
 `.new` can accept a block:
 
@@ -212,7 +213,7 @@ This behaviour is likely to change in future versions; see the below section
 that talks about the `#close` method for more information.
 
 #### `#close` method is currently a non-op
- 
+
 You'll notice that there is a `#close` method, but you may not know that it
 doesn't yet do anything since the underlying archive is not kept open between
 method calls.
@@ -220,69 +221,16 @@ method calls.
 However, you should still use `#close` where appropriate since this
 behaviour is likely to change in the future.
 
-#### Support for other Rubies
-
-Supporting MRI, Jruby and Rubinius covers 95% of the production-ruby market.
-However, In the future I plan on **trying** to support:
-
-  * maglev
-  * ironruby
-  * macruby
-
-The current travis-ci configuration only tests on Linux. Adding macruby
-support also means testing on OS X. I would like to one-day test with MRI, Ironruby and Jruby on Windows.
+#### Backend support on platforms
 
 MultiZip is written in pure ruby and so it should be able to run on any
 runtime that is compatible with MRI 1.8.7; however, the backend gems it uses
 may or may not work on every platform -- which is one of the reasons this
-gem exists in the first place! One day I would like to support backend gems
-that are specific to Jruby/Java and Windows.
-  
+gem exists in the first place!
+
 ## TODO
 
-Most important things, in order of importance:
-
-  * #add_member: add file to archive from filesystem (new method).
-  * Document exceptions raised, what they mean and how to use them.
-  * Add inline docs for methods.
-  * support *nix zip(1L)/unzip(1L) without needing backend gem (with warning).
-
-Other things that need to be done, in no particular order:
-
-  * Add support for more backends.
-  * Support for backend gems to process other formats (gzip, bzip2, 7zip, tar, etc).
-  * Keep the backend archive open between method calls.
-  * Add soak tests for memory usage once archived are kept open.
-  * Ensure #close is executed when MultiZip instance goes out of scope.
-  * Option to overwrite and existing archive instead of adding to it.
-  * #extract_member: extract file to path using original member name.
-  * #write_member: support for reading from IO streams.
-  * test with different majour versions of current supported backends.
-  * Standardize Exception classes and when to raise them.
-  * #read_*, #extract_* and #write_* methods should accept a block.
-  * #extract_members: extract multiple files with one command (new method).
-  * #write_member: add entire directory (recursively or not) to archive.
-  * #write_members: add multiple files by wildcard (new method).
-  * #add_members: add multiple files to archive from filesystem (new method).
-  * #remove_members: remove multiple member files from the archive (new_method).
-  * #read_members: read multiple files wildcard.
-  * #read_members: read multiple files via prefix as #list_members does.
-  * #extract_members: extract multiple files via prefix as #list_members does (new method).
-  * #extract_members: extract multiple files wildcard (new method).
-  * #member_info: return information (name, size, etc) about member (new method).
-  * #read_member_stream: return member as IO Stream to keeping large amounts of data in memory (new method).
-  * Write guide to show others how they can add their own backends gems.
-  * #member_type: return the type of the member (new method).
-  * #member_exists?: accept an argument to specify the file type (file, dir, symlink, etc).
-  * Soak-test each backend to find memory leaks.
-
-Things that I'd **like** to do, but that are probably not realistic because
-they cannot be sufficiently abstracted across all backend gems:
-
-  * Ability to set location and compression format and level of archive.
-  * Ability to set compression format and level of individual members (for Epub compatibility).
-  * Ability to set archive location of individual members (for Epub compatibility).
-  * Support creating, reading from and writing to password-protected or encrypted archives.
+See [TODO.md](TODO.md).
 
 ## Contributing
 

data/TODO.md

@@ -0,0 +1,49 @@
+## MultiZip TODO
+
+#### Most important things, in order of importance:
+
+  * #add_member: add file to archive from filesystem (new method).
+  * Document exceptions raised, what they mean and how to use them.
+  * Add inline docs for methods.
+  * support *nix zip(1L)/unzip(1L) without needing backend gem (with warning).
+
+#### Other things that need to be done, in no particular order:
+
+  * Add support for more backends.
+  * Support for backend gems to process other formats (gzip, bzip2, 7zip, tar, etc).
+  * Keep the backend archive open between method calls.
+  * Add soak tests for memory usage once archived are kept open.
+  * Ensure #close is executed when MultiZip instance goes out of scope.
+  * Option to overwrite and existing archive instead of adding to it.
+  * #extract_member: extract file to path using original member name.
+  * #write_member: support for reading from IO streams.
+  * test with different majour versions of current supported backends.
+  * Standardize Exception classes and when to raise them.
+  * #read_*, #extract_* and #write_* methods should accept a block.
+  * #extract_members: extract multiple files with one command (new method).
+  * #write_member: add entire directory (recursively or not) to archive.
+  * #write_members: add multiple files by wildcard (new method).
+  * #add_members: add multiple files to archive from filesystem (new method).
+  * #remove_members: remove multiple member files from the archive (new_method).
+  * #read_members: read multiple files wildcard.
+  * #read_members: read multiple files via prefix as #list_members does.
+  * #extract_members: extract multiple files via prefix as #list_members does (new method).
+  * #extract_members: extract multiple files wildcard (new method).
+  * #member_info: return information (name, size, etc) about member (new method).
+  * #read_member_stream: return member as IO Stream to keeping large amounts of data in memory (new method).
+  * Write guide to show others how they can add their own backends gems.
+  * #member_type: return the type of the member (new method).
+  * #member_exists?: accept an argument to specify the file type (file, dir, symlink, etc).
+  * Soak-test each backend to find memory leaks.
+
+#### Things that I'd **like** to do, but won't.
+
+These are thinks that would be really nice to have but that are probably not
+realistic because they cannot be abstracted across all backend gems:
+
+  * Ability to set location and compression format and level of archive.
+  * Ability to set compression format and level of individual members (for Epub compatibility).
+  * Ability to set archive location of individual members (for Epub compatibility).
+  * Support creating, reading from and writing to password-protected or encrypted archives.
+  * Support MagLev, IronRuby and MacRuby.
+  * Support Windows.

data/lib/multi_zip/errors.rb

@@ -1,7 +1,29 @@
 class MultiZip
-  class BaseError < RuntimeError; end
-  
-  class NoSupportedBackendError < BaseError; end
+  class BaseError < RuntimeError;
+    def to_s
+      if respond_to?(:message)
+        message
+      else
+        super
+      end
+    end
+  end
+
+  class NoSupportedBackendError < BaseError;
+    def message
+      "No supported backend found. Supported backends are #{MultiZip::BACKENDS.map(&:first).map(&:to_s).sort.join(', ')}"
+    end
+  end
+
+  class InvalidBackendError < BaseError;
+    attr_reader :requested_backend
+    def initialize(requested_backend)
+      @requested_backend = requested_backend
+    end
+    def message
+      "The requested backend \"#{@requested_backend}\" was not found. Supported backends are #{MultiZip::BACKENDS.map(&:first).map(&:to_s).sort.join(', ')}"
+    end
+  end
 
   class ArchiveError < BaseError
     attr_reader :archive_filename, :original_exception
@@ -26,10 +48,11 @@ class MultiZip
     def initialize(member_path)
       @member_path = member_path
     end
+  end
+
+  class MemberNotFoundError < MemberError
     def message
       "Member \"#{@member_path}\" not found."
     end
   end
-
-  class MemberNotFoundError < MemberError; end
-end
+end

data/lib/multi_zip/version.rb

@@ -1,3 +1,3 @@
 class MultiZip
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/lib/multi_zip.rb

@@ -53,7 +53,7 @@ class MultiZip
       extend BACKENDS[@backend][:constant].call
       return @backend
     else
-      raise NoSupportedBackendError, "Not a supported backend. Supported backends are #{BACKENDS.map(&:first).map(&:to_s).sort.join(', ')}"
+      raise InvalidBackendError.new(backend_name)
     end
   end
 
@@ -187,7 +187,7 @@ private
         return name
       end
     end
-    raise NoSupportedBackendError, "No supported backend found: #{BACKEND_PREFERENCE.join(', ')}"
+    raise NoSupportedBackendError
   end
 end
 

data/multi_zip.gemspec

@@ -19,6 +19,14 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "~> 3.1.0"
+  if RUBY_VERSION < '1.9'
+    # ruby 1.8.7 or ree
+    spec.add_development_dependency "rake", '10.1.1'
+  elsif RUBY_VERSION >= '1.9' && RUBY_VERSION < '2.0'
+    # 1.9.x
+    spec.add_development_dependency "rake", '11.1.2'
+  else
+    spec.add_development_dependency "rake"
+  end
+  spec.add_development_dependency "rspec", "~> 3.4.0"
 end

data/spec/backend_shared_example.rb

@@ -1,15 +1,15 @@
 shared_examples 'zip backend' do |backend_name|
-  let(:filename) { archive_fixture_filename }
-  subject { MultiZip.new(filename, :backend => backend_name) }
+  context "backend: #{backend_name}" do
+    let(:filename) { archive_fixture_filename }
+    subject { MultiZip.new(filename, :backend => backend_name) }
 
-  before do
-    apply_constants(backend_name)
-    # subject.backend = backend_name
-  end
-  after { stash_constants(backend_name) }
+    before do
+      apply_constants(backend_name)
+      # subject.backend = backend_name
+    end
+    after { stash_constants(backend_name) }
 
-  describe '#read_member' do
-    context "backend: #{backend_name}" do
+    describe '#read_member' do
       context 'member found' do
         archive_member_files.each do |member_file|
           it "returns '#{member_file}' as a string" do
@@ -30,13 +30,9 @@ shared_examples 'zip backend' do |backend_name|
         it_behaves_like 'raises MemberNotFoundError', :read_member, archive_member_directories.first
       end
 
-      context 'archive not found' do
-        it_behaves_like 'raises ArchiveNotFoundError', :read_member, archive_member_files.first
-      end
+      it_behaves_like 'archive not found, raises ArchiveNotFoundError', :read_member, archive_member_files.first
 
-      context 'archive is not a file' do
-        it 'raises ArchiveNotFoundError'
-      end
+      it_behaves_like 'archive is not a file, raises ArchiveNotFoundError', :read_member, archive_member_files.first
 
       context 'archive cannot be accessed due to permissions' do
         it 'raises ArchiveNotAccessibleError'
@@ -46,10 +42,8 @@ shared_examples 'zip backend' do |backend_name|
         it_behaves_like 'raises InvalidArchiveError', :read_member, archive_member_files.first
       end
     end
-  end
 
-  describe '#read_members' do
-    context "backend: #{backend_name}" do
+    describe '#read_members' do
       context 'all members found' do
         it 'returns the member content as an array a string in order of args' do
           extracted_files = subject.read_members(archive_member_files)
@@ -70,13 +64,9 @@ shared_examples 'zip backend' do |backend_name|
           [ archive_member_files.first, 'doesnt_exist' ]
       end
 
-      context 'archive not found' do
-        it_behaves_like 'raises ArchiveNotFoundError', :read_members, archive_member_files
-      end
+      it_behaves_like 'archive not found, raises ArchiveNotFoundError', :read_members, archive_member_files
 
-      context 'archive is not a file' do
-        it 'raises ArchiveNotFoundError'
-      end
+      it_behaves_like 'archive is not a file, raises ArchiveNotFoundError', :read_members, archive_member_files
 
       context 'archive cannot be accessed due to permissions' do
         it 'raises ArchiveNotAccessibleError'
@@ -87,10 +77,8 @@ shared_examples 'zip backend' do |backend_name|
           [ archive_member_files.first, archive_member_directories.first ]
       end
     end
-  end
 
-  describe '#extract_member' do
-    context "backend: #{backend_name}" do
+    describe '#extract_member' do
       let(:tempfile) { Tempfile.new('multi_zip_test') }
 
       context 'member found' do
@@ -121,13 +109,9 @@ shared_examples 'zip backend' do |backend_name|
         end
       end
 
-      context 'archive not found' do
-        it_behaves_like 'raises ArchiveNotFoundError', :extract_member, archive_member_files.first, 'destination'
-      end
+      it_behaves_like 'archive not found, raises ArchiveNotFoundError', :extract_member, archive_member_files.first, 'destination'
 
-      context 'archive is not a file' do
-        it 'raises ArchiveNotFoundError'
-      end
+      it_behaves_like 'archive is not a file, raises ArchiveNotFoundError', :extract_member, archive_member_files.first, 'destination'
 
       context 'archive cannot be accessed due to permissions' do
         it 'raises ArchiveNotAccessibleError'
@@ -142,10 +126,8 @@ shared_examples 'zip backend' do |backend_name|
         end
       end
     end
-  end
 
-  describe '#list_members' do
-    context "backend: #{backend_name}" do
+    describe '#list_members' do
       context 'file contains members' do
         it 'returns array member file names' do
           expect(subject.list_members).to eq(archive_member_names)
@@ -169,16 +151,15 @@ shared_examples 'zip backend' do |backend_name|
       end
 
       context 'contains no members, is empty archive' do
-        it 'returns empty array'
+        let(:filename) { empty_archive_fixture_filename }
+        it 'returns empty array' do
+          expect(subject.list_members).to eq( [ ] )
+        end
       end
 
-      context 'archive not found' do
-        it_behaves_like 'raises ArchiveNotFoundError', :list_members
-      end
+      it_behaves_like 'archive not found, raises ArchiveNotFoundError', :list_members
 
-      context 'archive is not a file' do
-        it 'raises ArchiveNotFoundError'
-      end
+      it_behaves_like 'archive is not a file, raises ArchiveNotFoundError', :list_members
 
       context 'archive cannot be accessed due to permissions' do
         it 'raises ArchiveNotAccessibleError'
@@ -188,10 +169,8 @@ shared_examples 'zip backend' do |backend_name|
         it_behaves_like 'raises InvalidArchiveError', :list_members
       end
     end
-  end
 
-  describe '#member_exists?' do
-    context "backend: #{backend_name}" do
+    describe '#member_exists?' do
       context 'member is a file' do
         it 'returns true if member exists' do
           expect(subject.member_exists?(archive_member_files.first)).to be_truthy
@@ -208,13 +187,9 @@ shared_examples 'zip backend' do |backend_name|
         expect(subject.member_exists?('does_not_exist')).to be_falsey
       end
 
-      context 'archive not found' do
-        it_behaves_like 'raises ArchiveNotFoundError', :member_exists?, archive_member_files.first
-      end
+      it_behaves_like 'archive not found, raises ArchiveNotFoundError', :member_exists?, archive_member_files.first
 
-      context 'archive is not a file' do
-        it 'raises ArchiveNotFoundError'
-      end
+      it_behaves_like 'archive is not a file, raises ArchiveNotFoundError', :member_exists?, archive_member_files.first
 
       context 'archive cannot be accessed due to permissions' do
         it 'raises ArchiveNotAccessibleError'
@@ -224,10 +199,8 @@ shared_examples 'zip backend' do |backend_name|
         it_behaves_like 'raises InvalidArchiveError', :member_exists?, archive_member_files.first
       end
     end
-  end
 
-  describe '#write_member' do
-    context "backend: #{backend_name}" do
+    describe '#write_member' do
       after { FileUtils.rm(filename) if File.exists?(filename) }
 
       let(:filename) { "/tmp/multizip_test.zip" }
@@ -236,7 +209,7 @@ shared_examples 'zip backend' do |backend_name|
 
       context 'archive did not exist' do
         before { expect(File.exists?(filename)).to be_falsey }
-        
+
         let!(:result) do
           subject.write_member(member_file_name, member_file_contents)
         end
@@ -331,10 +304,8 @@ shared_examples 'zip backend' do |backend_name|
         it 'raises ArchiveInvalidError'
       end
     end
-  end
 
-  describe '#remove_member' do
-    context "backend: #{backend_name}" do
+    describe '#remove_member' do
       subject { MultiZip.new(temp_filename, :backend => backend_name) }
 
       let(:temp_filename) { "/tmp/multizip_test.zip" }
@@ -351,7 +322,7 @@ shared_examples 'zip backend' do |backend_name|
             MultiZip.new(temp_filename).member_exists?(member_file_name)
           ).to be_truthy
         end
-        
+
         let!(:result) do
           subject.remove_member(member_file_name)
         end
@@ -379,9 +350,7 @@ shared_examples 'zip backend' do |backend_name|
         end
       end
 
-      context 'archive not found' do
-        it_behaves_like 'raises ArchiveNotFoundError', :remove_member, archive_member_files.first
-      end
+      it_behaves_like 'archive not found, raises ArchiveNotFoundError', :remove_member, archive_member_files.first
 
       context 'archive is not a file' do
         it 'raises ArchiveNotFoundError'
@@ -395,10 +364,8 @@ shared_examples 'zip backend' do |backend_name|
         it 'raises ArchiveInvalidError'
       end
     end
-  end  
 
-  describe '#remove_members' do
-    context "backend: #{backend_name}" do
+    describe '#remove_members' do
       subject { MultiZip.new(temp_filename, :backend => backend_name) }
 
       let(:temp_filename) { "/tmp/multizip_test.zip" }
@@ -417,7 +384,7 @@ shared_examples 'zip backend' do |backend_name|
             ).to be_truthy
           end
         end
-        
+
         let!(:result) do
           subject.remove_members(member_file_names)
         end
@@ -447,9 +414,7 @@ shared_examples 'zip backend' do |backend_name|
         end
       end
 
-      context 'archive not found' do
-        it_behaves_like 'raises ArchiveNotFoundError', :remove_members, archive_member_files
-      end
+      it_behaves_like 'archive not found, raises ArchiveNotFoundError', :remove_members, archive_member_files
 
       context 'archive is not a file' do
         it 'raises ArchiveNotFoundError'
@@ -463,7 +428,7 @@ shared_examples 'zip backend' do |backend_name|
         it 'raises ArchiveInvalidError'
       end
     end
-  end  
+  end
 end
 
 shared_examples 'raises MemberNotFoundError' do |*args|
@@ -480,8 +445,22 @@ shared_examples 'raises InvalidArchiveError' do |*args|
 end
 
 shared_examples 'raises ArchiveNotFoundError' do |*args|
-  let(:filename) { 'doesnt_exist' }  
   it 'raises ArchiveNotFoundError' do
     expect(lambda{ subject.send(args.shift, *args) }).to raise_error(MultiZip::ArchiveNotFoundError)
   end
 end
+
+shared_examples 'archive not found, raises ArchiveNotFoundError' do |*args|
+  context 'archive not found' do
+    let(:filename) { 'doesnt_exist' }
+    it_behaves_like 'raises ArchiveNotFoundError', *args
+  end
+end
+
+shared_examples 'archive is not a file, raises ArchiveNotFoundError' do |*args|
+  context 'archive is not a file' do
+    let(:filename) { not_an_archive_fixture_filename }
+    it_behaves_like 'raises ArchiveNotFoundError', *args
+  end
+end
+

data/spec/spec_helper.rb

@@ -2,8 +2,7 @@ require 'multi_zip'
 
 # can't use pry on old rubies or on rubinius
 if RUBY_VERSION.to_f >= 2.0 && RUBY_ENGINE == 'ruby'
-  require 'pry'
-  require 'pry-byebug'
+  require 'byebug'
 end
 
 RSpec.configure do |config|
@@ -29,12 +28,24 @@ RSpec.configure do |config|
   Kernel.srand config.seed
 end
 
+def fixture_path(file)
+  ['spec/fixtures/', file].join
+end
+
 def invalid_archive_fixture_filename
-  'spec/fixtures/invalid.zip'
+  fixture_path('invalid.zip')
 end
 
 def archive_fixture_filename
-  'spec/fixtures/test.zip'
+  fixture_path('test.zip')
+end
+
+def not_an_archive_fixture_filename
+  fixture_path('test')
+end
+
+def empty_archive_fixture_filename
+  fixture_path('empty.zip')
 end
 
 def archive_members
@@ -72,7 +83,7 @@ def test_with_rubyzip?
   end
   false
 rescue Gem::LoadError
-  false  
+  false
 end
 
 def test_with_zipruby?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: multi_zip
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Matthew Nielsen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-27 00:00:00.000000000 Z
+date: 2016-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.4.0
 description: Abstracts zipping and unzipping using whatever gems are installed using
   one consistent API. Provides swappable zipping/unzipping backends so you're not
   tied to just one gem. Supports rubyzip, archive-zip, zipruby and others.
@@ -70,6 +70,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- TODO.md
 - lib/multi_zip.rb
 - lib/multi_zip/backend/archive_zip.rb
 - lib/multi_zip/backend/rubyzip.rb
@@ -78,8 +79,10 @@ files:
 - lib/multi_zip/version.rb
 - multi_zip.gemspec
 - spec/backend_shared_example.rb
+- spec/fixtures/empty.zip
 - spec/fixtures/invalid.zip
 - spec/fixtures/test.zip
+- spec/fixtures/test/.gitkeep
 - spec/lib/multi_zip/backend/archive_zip_spec.rb
 - spec/lib/multi_zip/backend/rubyzip_spec.rb
 - spec/lib/multi_zip/backend/zipruby_spec.rb
@@ -111,8 +114,10 @@ specification_version: 4
 summary: Abstracts zipping and unzipping using whatever gems are installed, automatically.
 test_files:
 - spec/backend_shared_example.rb
+- spec/fixtures/empty.zip
 - spec/fixtures/invalid.zip
 - spec/fixtures/test.zip
+- spec/fixtures/test/.gitkeep
 - spec/lib/multi_zip/backend/archive_zip_spec.rb
 - spec/lib/multi_zip/backend/rubyzip_spec.rb
 - spec/lib/multi_zip/backend/zipruby_spec.rb