multi_xml 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 35c36bec2ca00daa71d6eae5b1f388f5bdf3493d06ade5d6c8aeb54fb2f8762f
-  data.tar.gz: fe3a14804a79e8dd143ab381b5ef11abf917ce3a1653d6c780d99fa7d6b9dd44
+  metadata.gz: d8e4560022692cf83853b50994663cbabfc0bdb943e78c4c2288dff38869bd08
+  data.tar.gz: d25368ffc55f43108708b46cc228e7d4506f44d61cb4d371cdb549fe36bfea2b
 SHA512:
-  metadata.gz: 5863c814199d20da08c88b6fc52b56186c2e4d0c2c9248d9678c04862dab09cb048473ab86c605a022add743e1b1be91682974cf21c192d8c3eeb98abcbc6011
-  data.tar.gz: 48fe9f604a468b59a01832187869b0bb118f5a8c63ccb2c8b51c27d2fe00b6bb7aedd3beeb384cc69ee5562b75e5196cb93ac37f79fd6fb68aba9ea82c692dbc
+  metadata.gz: 82885e626a6961ffaa1f34d039ba1a4ac0017c917c46f8232413f020252f9b88873643e44ca7c2b5ad1a7e510c2bccaf3757c246c4c2df801600048ee440f4c1
+  data.tar.gz: 96ea0d4b0947cdeb5230f07687d94be756379a80db7f7fd5e0484ff5a2b1cbc3407eee3c2ea3dce6e49d2595b0daa2f5ab404d20fda5d71fc8dd9bc0bbc7a748

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+0.9.1
+-----
+* Fix `MultiXml.method(:load)` resolving to `Kernel#load`. The legacy `MultiXml` constant forwarded calls to `MultiXML` via `method_missing`, but `Module#method` doesn't consult `method_missing`, so `MultiXml.method(:load)` resolved to the inherited `Kernel#load` and crashed with `LoadError` when invoked. Replaces `method_missing` with explicit singleton-method forwarders for every public method on `MultiXML`, mirroring the [analogous fix in MultiJSON](https://github.com/sferik/multi_json/issues/66).
+
 0.9.0
 -----
 * Add `MultiXML.with_parser` for fiber-local scoped parser overrides, matching `MultiJSON.with_adapter`. The override lives in `Fiber[:multi_xml_parser]`, so concurrent fibers and threads each see their own parser without racing on a shared module variable; nested calls save and restore the previous value.

data/lib/multi_xml/version.rb

@@ -3,5 +3,5 @@ module MultiXML
   #
   # @api public
   # @return [Gem::Version] the gem version
-  VERSION = Gem::Version.create("0.9.0")
+  VERSION = Gem::Version.create("0.9.1")
 end

data/lib/multi_xml.rb

@@ -157,45 +157,35 @@ require_relative "multi_xml/deprecated"
 #
 # Downstream code that still writes MultiXml.parse(...) or
 # rescue MultiXml::ParseError continues to work, but emits a one-time
-# deprecation warning pointing at MultiXML. The module forwards every
-# method call to {MultiXML} via {.method_missing} and resolves constant
-# access via {.const_missing}, so both dotted calls and :: constant
-# lookups (including rescue clauses) route through the canonical module.
+# deprecation warning pointing at MultiXML. Each public method on
+# {MultiXML} gets an explicit forwarder defined on this module, and
+# constant access resolves via {.const_missing}, so both dotted calls
+# and :: constant lookups (including rescue clauses) route through
+# the canonical module.
 #
 # @api public
 # @deprecated Use {MultiXML} (all-caps) instead. Will be removed in v1.0.
 module MultiXml
-  class << self
-    # Forward method calls to {MultiXML}, emitting a one-time warning
-    #
-    # @api public
-    # @return [Object] the delegated call's return value
-    # @example
-    #   MultiXml.parse("<a>1</a>")  # delegates to MultiXML.parse
-    # rubocop:disable Naming/BlockForwarding, Style/ArgumentsForwarding
-    def method_missing(name, *args, **kwargs, &block)
+  # Forward every public method MultiXML exposes through an explicit
+  # singleton method on the legacy MultiXml module, so callers that
+  # capture the method as a Method object (``MultiXml.method(:load)``)
+  # find this forwarder instead of falling back to inherited methods like
+  # ``Kernel#load``. The earlier ``method_missing``-based shim left
+  # ``MultiXml.method(:load)`` resolving to ``Kernel#load`` (because
+  # ``Module#method`` doesn't consult ``method_missing``) so a captured
+  # ``MultiXml.method(:load)`` would interpret the XML payload as a file
+  # path and crash with ``LoadError``. Forwarding eagerly fixes the
+  # capture path while preserving the one-time deprecation warning each
+  # call emits.
+  (::MultiXML.public_methods - ::Module.public_methods).each do |forwarded|
+    define_singleton_method(forwarded) do |*args, **kwargs, &block|
       ::MultiXML.warn_deprecation_once(:multi_xml_constant,
         "The MultiXml constant is deprecated and will be removed in v1.0. Use MultiXML instead.")
-      if ::MultiXML.respond_to?(name)
-        ::MultiXML.public_send(name, *args, **kwargs, &block)
-      else
-        super
-      end
-    end
-    # rubocop:enable Naming/BlockForwarding, Style/ArgumentsForwarding
-
-    # Respond to any method {MultiXML} responds to
-    #
-    # @api public
-    # @param name [Symbol] method name
-    # @param include_private [Boolean] include private methods
-    # @return [Boolean] true if {MultiXML} responds to the method
-    # @example
-    #   MultiXml.respond_to?(:parse)  #=> true
-    def respond_to_missing?(name, include_private)
-      ::MultiXML.respond_to?(name, include_private)
+      ::MultiXML.public_send(forwarded, *args, **kwargs, &block)
     end
+  end
 
+  class << self
     # Resolve missing constants to their {MultiXML} counterparts
     #
     # The lookup is performed with ``inherit: false`` so a stray

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: multi_xml
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Erik Berlin