multi_smtp 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8b4c0d11e7bf9ef7fdbe9599079af40962c5619f
-  data.tar.gz: 82f6f530e1025b1e87ddf17dc515dc052abaf79b
+  metadata.gz: 23e763868f6b569e48370beafec837ca5b3576fc
+  data.tar.gz: 2ef877d1d11bc165539ee85ede08b5dfb467a29b
 SHA512:
-  metadata.gz: e4716c7ea2d5d1c583fd7eee596b21eb2bfdb20d5d24c5803dc64f94637b1a88db2ec4377bd25a9da75b33688f7ae1c7c920528fa72c4abb48c3928d23a59528
-  data.tar.gz: 091f3eff7730e6afd13a2d2fc777d0cc7d278c6b01f33afe314e9d6abd1fc7510bba12218556f4d3c9a590a684b30be8c7c1340587499802ea86e2a77956fc48
+  metadata.gz: 46437e91bc54924e46069db89e4317f37b85409961ae74957ecf0148384d796670e2f77108001c8e6e1df0b326f4b5f3f7ebaca0966865d038ca201e82103002
+  data.tar.gz: 26eb14f158e409b3dd515918437301e775f477c60cdd9daed0b0c7b265cc4a471342ed295283d8a2e2ccb438ffaf05cc502c9ff6a7215d9c3af85cb59572393e

data/.gitignore

@@ -12,3 +12,4 @@
 *.o
 *.a
 mkmf.log
+*.gem

data/lib/multi_smtp/mail.rb

@@ -14,8 +14,12 @@ module MultiSMTP
           super(mail)
           break
         rescue Exception => e
-          if all_providers_failed?(index) && error_notifier
+          next unless all_providers_failed?(index)
+
+          if error_notifier
             error_notifier.notify(mail)
+          else
+            raise e
           end
         end
       end

data/lib/multi_smtp/version.rb

@@ -1,3 +1,3 @@
 module MultiSMTP
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/multi_smtp.gemspec

@@ -18,9 +18,10 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "mail", "~> 2.6.3"
+  spec.add_runtime_dependency "mail", "~> 2.6", ">= 2.6.3"
 
   spec.add_development_dependency "bundler", "~> 1.7"
+  spec.add_development_dependency "pry", "~> 0.10", ">= 0.10.1"
   spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.1.0"
+  spec.add_development_dependency "rspec", "~> 3.1", ">= 3.1.0"
 end

data/spec/lib/multi_smtp/mail_spec.rb

@@ -39,13 +39,25 @@ describe MultiSMTP::Mail, "#deliver!" do
   end
 
   context "all smtp providers fail" do
-    it "notifies airbrake" do
-      allow_any_instance_of(Net::SMTP).to receive(:start).
-        and_raise(Net::SMTPFatalError)
+    context "notifier is set" do
+      it "notifies airbrake" do
+        allow_any_instance_of(Net::SMTP).to receive(:start).
+          and_raise(Net::SMTPFatalError)
 
-      MultiSMTP::Mail.new({}).deliver!(mail)
+        MultiSMTP::Mail.new({}).deliver!(mail)
+
+        expect(error_notifier).to have_received(:notify).once
+      end
+    end
+
+    context "notifier is not set" do
+      it "re-raises the original exception" do
+        MultiSMTP.error_notifier = nil
+        allow_any_instance_of(Net::SMTP).to receive(:start).
+          and_raise(Net::SMTPFatalError)
 
-      expect(error_notifier).to have_received(:notify).once
+        expect { MultiSMTP::Mail.new({}).deliver!(mail) }.to raise_exception
+      end
     end
   end
 

data/spec/spec_helper.rb

@@ -3,6 +3,7 @@ $LOAD_PATH << File.join(File.dirname(__FILE__))
 
 require "rubygems"
 require "rspec"
+require "pry"
 require "multi_smtp"
 
 RSpec.configure do |config|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: multi_smtp
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Harlow Ward
@@ -15,6 +15,9 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.6'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.6.3
   type: :runtime
@@ -22,6 +25,9 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.6'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.6.3
 - !ruby/object:Gem::Dependency
@@ -38,6 +44,26 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.10'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.10.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.10'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.10.1
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -57,6 +83,9 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.1'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.0
   type: :development
@@ -64,6 +93,9 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.1'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.0
 description: Email failover in Rails with MultiSMTP