multi_process 1.0.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9f71381653129f6aa7bf31441102ce950a28ce3d39da4bf7b4542ac1401b1ee3
-  data.tar.gz: 98146cfa10d5530f03b11d1d80679417d6820dd2764ec9161751f77bdad309f6
+  metadata.gz: dddbd3442f480abb21f2e64ce86365471a4f04e6832e385f07e9d52a45038e95
+  data.tar.gz: fb7b5bcb5f053cacac6d3c2cbe2ff84ef200622fa06b8c045db6105051807ab2
 SHA512:
-  metadata.gz: 331cf8cb96d54d265fecaa6750b9c71d9e11231385d6d778ffde6a664d636478b855e525cbe2d3bd474127308ab615b2f90e8599f80159af01041dae3117506a
-  data.tar.gz: dde0d89ada0985a2188edb4ec9a169d595d609580370c9e1f1f2b818897c7ed9b2c88420b5608f002b281c9c93c45c8d800cba4adcbaeaac652d8cbd01f16938
+  metadata.gz: 92843a792257de7057e597f062ac53c690ccddd223dfdcfae94e42917a74cf0b299def05a691b880737cb7e51670ca6b343bf788e743201b312c8a32ce2fb0df
+  data.tar.gz: c3db19666a44e40c06d4f321079bddf8182e5c2169cd616cc4855fbb3a0e90818bbbd27b180f2d3791e1927df7899bcdd5f83dcc0c323a60b4230ebb9c61a222

data/.editorconfig

@@ -0,0 +1,12 @@
+# EditorConfig is awesome: https://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+[*]
+indent_style = space
+indent_size = 2
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true

data/.github/workflows/test.yml

@@ -0,0 +1,38 @@
+# vim: ft=yaml
+
+name: test
+on: push
+jobs:
+  rspec:
+    name: ruby-${{ matrix.ruby }}
+    runs-on: ubuntu-20.04
+
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ["3.1", "3.0", "2.7"]
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: True
+
+      - run: bundle exec rspec --color
+
+  rubocop:
+    name: rubocop
+    runs-on: ubuntu-20.04
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.1
+          bundler-cache: True
+        env:
+          BUNDLE_JOBS: 4
+          BUNDLE_RETRY: 3
+
+      - run: bundle exec rubocop --parallel --color

data/.rubocop.yml

@@ -0,0 +1,9 @@
+# .rubocop.yml
+
+inherit_gem:
+  rubocop-config: default.yml
+
+AllCops:
+  TargetRubyVersion: 2.7
+  SuggestExtensions: False
+  NewCops: enable

data/CHANGELOG.md

@@ -1,13 +1,36 @@
 # Changelog
+
 All notable changes to this project will be documented in this file.
 
-The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
-and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+## [1.2.0] - 2022-06-03
+
+### Added
+
+- `run!` and `wait!` to raise error if any process exits with an error code != 0
+
+## [1.1.1] - 2020-12-21
+
+### Fixed
+
+- Replaced deprecated `#with_clean_env` method
+
+## [1.1.0] - 2020-11-19
+
+### Added
+
+- Add support for IPv6 by using the hostname instead of the loopback IPv4 address (#2)
+
 ## 1.0.0 - 2019-05-13
+
 ### Fixed
+
 - Possible concurrent hash modification while iterating (#1)
 
-[Unreleased]: https://github.com/jgraichen/multi_process/compare/v1.0.0...HEAD
+[unreleased]: https://github.com/jgraichen/multi_process/compare/v1.2.0...HEAD
+[1.2.0]: https://github.com/jgraichen/multi_process/compare/v1.1.1...v1.2.0
+[1.1.1]: https://github.com/jgraichen/multi_process/compare/v1.1.0...v1.1.1
+[1.1.0]: https://github.com/jgraichen/multi_process/compare/v1.0.0...v1.1.0

data/Gemfile

@@ -1,7 +1,11 @@
-source 'https://rubygems.org'
+# frozen_string_literal: true
 
-gem 'rake'
-gem 'rspec', '>= 3.0.0.beta1'
+source 'https://rubygems.org'
 
 # Specify your gem's dependencies in multi_process.gemspec
 gemspec
+
+gem 'rake'
+gem 'rake-release', '~> 1.3'
+gem 'rspec', '~> 3.11'
+gem 'rubocop-config', github: 'jgraichen/rubocop-config', ref: 'v9', require: false

data/README.md

@@ -1,31 +1,35 @@
 # MultiProcess
 
-Handle multiple processes. Ruby >= 2.0.
-
-TODO: Just experiment.
+Run multiple processes.
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
-    gem 'multi_process'
+```ruby
+gem 'multi_process'
+```
 
 And then execute:
 
-    $ bundle
+```
+$ bundle
+```
 
 Or install it yourself as:
 
-    $ gem install multi_process
+```
+$ gem install multi_process
+```
 
 ## Usage
 
-```
+```ruby
 receiver = MultiProcess::Logger $stdout, $stderr, sys: false
 group = MultiProcess::Group.new receiver: receiver
-group << MultiProcess::Process.new %w(ruby test.rb), title: 'rubyA'
-group << MultiProcess::Process.new %w(ruby test.rb), title: 'rubyB'
-group << MultiProcess::Process.new %w(ruby test.rb), title: 'rubyC'
+group << MultiProcess::Process.new %w[ruby test.rb], title: 'rubyA'
+group << MultiProcess::Process.new %w[ruby test.rb], title: 'rubyB'
+group << MultiProcess::Process.new %w[ruby test.rb], title: 'rubyC'
 group.start # Start in background
 group.run   # Block until finished
 group.wait  # Wait until finished
@@ -43,7 +47,7 @@ group.stop  # Stop processes
 
 ## Contributing
 
-1. Fork it ( http://github.com/jgraichen/multi_process/fork )
+1. Fork it (http://github.com/jgraichen/multi_process/fork)
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
@@ -51,7 +55,7 @@ group.stop  # Stop processes
 
 ## License
 
-Copyright (C) 2019  Jan Graichen
+Copyright © 2019 Jan Graichen
 
 This program is free software: you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by

data/Rakefile

@@ -1,4 +1,6 @@
-require 'bundler/gem_tasks'
+# frozen_string_literal: true
+
+require 'rake/release'
 require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)

data/lib/multi_process/errors.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+module MultiProcess
+  class Error < StandardError; end
+
+  class ProcessError < Error
+    attr_reader :process
+
+    def initialize(process, *args, **kwargs)
+      @process = process
+      super(*args, **kwargs)
+    end
+  end
+end

data/lib/multi_process/group.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module MultiProcess
   #
   # Store and run a group of processes.
@@ -24,7 +26,7 @@ module MultiProcess
     #
     def initialize(receiver: nil, partition: nil)
       @processes = []
-      @receiver  = receiver ? receiver : MultiProcess::Logger.global
+      @receiver  = receiver || MultiProcess::Logger.global
       @partition = partition ? partition.to_i : 0
       @mutex     = Mutex.new
     end
@@ -87,6 +89,21 @@ module MultiProcess
       end
     end
 
+    # Wait until all process terminated.
+    #
+    # Raise an error if a process exists unsuccessfully.
+    #
+    # @param opts [ Hash ] Options.
+    # @option opts [ Integer ] :timeout Timeout in seconds to wait before raising {Timeout::Error}.
+    #
+    def wait!(timeout: nil)
+      if timeout
+        ::Timeout.timeout(timeout) { wait! }
+      else
+        processes.each(&:wait!)
+      end
+    end
+
     # Start all process and wait for them to terminate.
     #
     # Given options will be passed to {#start} and {#wait}.
@@ -96,17 +113,32 @@ module MultiProcess
     # when timeout error is raised.
     #
     def run(delay: nil, timeout: nil)
-      if partition > 0
-        partition.times.map do
-          Thread.new do
-            while (process = next_process)
-              process.run
-            end
-          end
-        end.each(&:join)
+      if partition.positive?
+        run_partition(&:run)
       else
-        start delay: delay
-        wait timeout: timeout
+        start(delay: delay)
+        wait(timeout: timeout)
+      end
+    ensure
+      stop
+    end
+
+    # Start all process and wait for them to terminate.
+    #
+    # Given options will be passed to {#start} and {#wait}. {#start}
+    # will only be called if partition is zero.
+    #
+    # If timeout is given process will be terminated using {#stop} when
+    # timeout error is raised.
+    #
+    # An error will be raised if any process exits unsuccessfully.
+    #
+    def run!(delay: nil, timeout: nil)
+      if partition.positive?
+        run_partition(&:run!)
+      else
+        start(delay: delay)
+        wait!(timeout: timeout)
       end
     ensure
       stop
@@ -151,5 +183,17 @@ module MultiProcess
         processes[@index - 1]
       end
     end
+
+    def run_partition
+      Array.new(partition) do
+        Thread.new do
+          Thread.current.report_on_exception = false
+
+          while (process = next_process)
+            yield process
+          end
+        end
+      end.each(&:join)
+    end
   end
 end

data/lib/multi_process/logger.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module MultiProcess
   # Can create pipes and multiplex pipe content to put into
   # given IO objects e.g. multiple output from multiple
@@ -12,7 +14,7 @@ module MultiProcess
     #   error sources.
     #
     def initialize(*args)
-      @opts  = Hash === args.last ? args.pop : {}
+      @opts  = args.last.is_a?(Hash) ? args.pop : {}
       @out   = args[0] || $stdout
       @err   = args[1] || $stderr
 
@@ -25,12 +27,12 @@ module MultiProcess
 
     def received(process, name, line)
       case name
-      when :err, :stderr
-        output process, line, io: @err, delimiter: 'E>'
-      when :out, :stdout
-        output process, line
-      when :sys
-        output(process, line, delimiter: '$>') if @opts[:sys]
+        when :err, :stderr
+          output process, line, io: @err, delimiter: 'E>'
+        when :out, :stdout
+          output process, line
+        when :sys
+          output(process, line, delimiter: '$>') if @opts[:sys]
       end
     end
 
@@ -49,15 +51,13 @@ module MultiProcess
     private
 
     def output(process, line, opts = {})
-      opts[:delimiter]   ||= ' |'
+      opts[:delimiter] ||= ' |'
       name = if opts[:name]
                opts[:name].to_s.dup
+             elsif process
+               process.title.to_s.rjust(@colwidth, ' ')
              else
-               if process
-                 process.title.to_s.rjust(@colwidth, ' ')
-               else
-                 (' ' * @colwidth)
-               end
+               (' ' * @colwidth)
              end
 
       io = opts[:io] || @out

data/lib/multi_process/loop.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'nio'
 
 module MultiProcess

data/lib/multi_process/nil_receiver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module MultiProcess
   # Receiver implementation that does nothing on every input.
   #

data/lib/multi_process/process/bundle_exec.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 class MultiProcess::Process
   # Provides functionality to wrap command in with bundle
   # execute.
   #
   module BundleExec
     def initialize(*args)
-      opts = Hash === args.last ? args.pop : {}
-      super %w(bundle exec) + args, opts
+      opts = args.last.is_a?(Hash) ? args.pop : {}
+      super %w[bundle exec] + args, opts
     end
   end
 end

data/lib/multi_process/process/rails.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class MultiProcess::Process
   # Provides functionality for a process that is a rails server
   # process.
@@ -12,21 +14,15 @@ class MultiProcess::Process
     #
     attr_reader :server
 
-    # Port server should be running on.
-    #
-    # Default will be a free port determined when process is created.
-    #
-    attr_reader :port
-
     def initialize(opts = {})
       self.server = opts[:server] if opts[:server]
       self.port   = opts[:port]   if opts[:port]
 
-      super *server_command, opts
+      super(*server_command, opts)
     end
 
     def server_command
-      ['rails', 'server', server, '--port', port].reject(&:nil?).map(&:to_s)
+      ['rails', 'server', server, '--port', port].compact.map(&:to_s)
     end
 
     def server=(server)
@@ -34,7 +30,7 @@ class MultiProcess::Process
     end
 
     def port=(port)
-      @port = port.to_i == 0 ? free_port : port.to_i
+      @port = port.to_i.zero? ? free_port : port.to_i
     end
 
     def port
@@ -42,9 +38,9 @@ class MultiProcess::Process
     end
 
     def available?
-      fail ArgumentError.new "Cannot check availability for port #{port}." if port == 0
+      raise ArgumentError.new "Cannot check availability for port #{port}." if port.zero?
 
-      TCPSocket.new('127.0.0.1', port).close
+      TCPSocket.new('localhost', port).close
       true
     rescue Errno::ECONNREFUSED, Errno::EHOSTUNREACH
       false
@@ -67,10 +63,10 @@ class MultiProcess::Process
 
     def free_port
       socket = Socket.new(:INET, :STREAM, 0)
-      socket.bind(Addrinfo.tcp('127.0.0.1', 0))
+      socket.bind(Addrinfo.tcp('localhost', 0))
       socket.local_address.ip_port
     ensure
-      socket.close if socket
+      socket&.close
     end
   end
 end

data/lib/multi_process/process.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/core_ext/module/delegation'
 
 module MultiProcess
@@ -20,14 +22,14 @@ module MultiProcess
 
     def initialize(*args)
       args.flatten!
-      opts = (Hash === args.last ? args.pop : {})
+      opts = (args.last.is_a?(Hash) ? args.pop : {})
 
       @title        = opts[:title].to_s || args.first.to_s.strip.split(/\s+/, 2)[0]
-      @command      = args.map { |arg| (arg =~ /\A[\s"']+\z/ ? arg.inspect : arg).gsub '"', '\"' }.join(' ')
-      @childprocess = create_childprocess *args
+      @command      = args.map {|arg| (/\A[\s"']+\z/.match?(arg) ? arg.inspect : arg).gsub '"', '\"' }.join(' ')
+      @childprocess = create_childprocess(*args)
 
-      @env          = opts[:env] if Hash === opts[:env]
-      @env_clean    = opts[:clean_env].nil? ? true : !!opts[:clean_env]
+      @env          = opts[:env] if opts[:env].is_a?(Hash)
+      @env_clean    = opts[:clean_env].nil? ? true : !opts[:clean_env].nil?
 
       self.receiver = opts[:receiver] || MultiProcess::Logger.global
 
@@ -54,6 +56,20 @@ module MultiProcess
       end
     end
 
+    # Wait until process finished.
+    #
+    # If no timeout is given it will wait definitely.
+    #
+    # @param opts [Hash] Options.
+    # @option opts [Integer] :timeout Timeout to wait in seconds.
+    #
+    def wait!(opts = {})
+      wait(opts)
+      return if exit_code.zero?
+
+      raise ::MultiProcess::ProcessError.new(self, "Process #{pid} exited with code #{exit_code}")
+    end
+
     # Start process.
     #
     # Started processes will be stopped when ruby VM exists by hooking into
@@ -63,7 +79,7 @@ module MultiProcess
       return false if started?
 
       at_exit { stop }
-      receiver.message(self, :sys, command) if receiver
+      receiver&.message(self, :sys, command)
       start_childprocess
       @started = true
     end
@@ -73,7 +89,7 @@ module MultiProcess
     # Will call `ChildProcess#stop`.
     #
     def stop(*args)
-      childprocess.stop *args if started?
+      childprocess.stop(*args) if started?
     end
 
     # Check if server is available. What available means can be defined
@@ -97,7 +113,7 @@ module MultiProcess
       Timeout.timeout timeout do
         sleep 0.2 until available?
       end
-    rescue Timeout::Error => ex
+    rescue Timeout::Error
       raise Timeout::Error.new "Server #{id.inspect} on port #{port} didn't get up after #{timeout} seconds..."
     end
 
@@ -116,6 +132,15 @@ module MultiProcess
       wait opts
     end
 
+    # Start process and wait until it's finished.
+    #
+    # Given arguments will be passed to {#wait!}.
+    #
+    def run!(opts = {})
+      start
+      wait!(opts)
+    end
+
     # @!group Working Directory
 
     # Working directory for child process.
@@ -150,7 +175,8 @@ module MultiProcess
     # Set environment.
     #
     def env=(env)
-      fail ArgumentError.new 'Environment must be a Hash.' unless hash === env
+      raise ArgumentError.new 'Environment must be a Hash.' unless env.is_a?(Hash)
+
       @env = env
     end
 
@@ -178,7 +204,7 @@ module MultiProcess
     # Create child process.
     #
     def create_childprocess(*args)
-      ChildProcess.new *args.flatten
+      ChildProcess.new(*args.flatten)
     end
 
     # Start child process.
@@ -186,11 +212,11 @@ module MultiProcess
     # Can be used to hook in subclasses and modules.
     #
     def start_childprocess
-      env.each { |k, v| childprocess.environment[k.to_s] = v.to_s }
+      env.each {|k, v| childprocess.environment[k.to_s] = v.to_s }
       childprocess.cwd = dir
 
       if clean_env?
-        Bundler.with_clean_env { childprocess.start }
+        Bundler.with_original_env { childprocess.start }
       else
         childprocess.start
       end

data/lib/multi_process/receiver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module MultiProcess
   # Can handle input from multiple processes and run custom
   # actions on event and output.
@@ -14,12 +16,12 @@ module MultiProcess
 
       Loop.instance.watch(reader) do |action, monitor|
         case action
-        when :registered
-          connected(process, name)
-        when :ready
-          received(process, name, read(monitor.io))
-        when :eof
-          removed(process, name)
+          when :registered
+            connected(process, name)
+          when :ready
+            received(process, name, read(monitor.io))
+          when :eof
+            removed(process, name)
         end
       end
 
@@ -40,7 +42,7 @@ module MultiProcess
     # Must be overridden by subclass.
     #
     def received(_process, _name, _message)
-      fail NotImplementedError.new 'Subclass responsibility.'
+      raise NotImplementedError.new 'Subclass responsibility.'
     end
 
     # Read content from pipe. Can be used to provide custom reading
@@ -55,12 +57,10 @@ module MultiProcess
     # Called after pipe for process and name was removed because it
     # reached EOF.
     #
-    def removed(_process, _name)
-    end
+    def removed(_process, _name); end
 
     # Called after new pipe for process and name was created.
     #
-    def connected(_process, _name)
-    end
+    def connected(_process, _name); end
   end
 end

data/lib/multi_process/string_receiver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module MultiProcess
   # Receiver implementation storing process output
   # in string.
@@ -9,7 +11,7 @@ module MultiProcess
 
     def get(name)
       @strings ||= {}
-      @strings[name.to_s] ||= ''
+      @strings[name.to_s] ||= +''
     end
   end
 end

data/lib/multi_process/version.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module MultiProcess
   module VERSION
     MAJOR = 1
-    MINOR = 0
+    MINOR = 2
     PATCH = 0
     STAGE = nil
-    STRING = [MAJOR, MINOR, PATCH, STAGE].reject(&:nil?).join('.')
+    STRING = [MAJOR, MINOR, PATCH, STAGE].compact.join('.')
 
     def self.to_s
       STRING

data/lib/multi_process.rb

@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 require 'multi_process/version'
 require 'childprocess'
 
 module MultiProcess
   DEFAULT_TIMEOUT = 60
 
+  require 'multi_process/errors'
+
   require 'multi_process/loop'
   require 'multi_process/group'
   require 'multi_process/receiver'

data/multi_process.gemspec

@@ -1,5 +1,6 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'multi_process/version'
 
@@ -13,8 +14,11 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/jgraichen/multi_process'
   spec.license       = 'GPLv3'
 
+  spec.metadata['rubygems_mfa_required'] = 'true'
+  spec.required_ruby_version = '>= 2.7'
+
   spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.executables   = spec.files.grep(%r{^bin/}) {|f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 

data/renovate.json

@@ -0,0 +1,6 @@
+{
+  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
+  "extends": [
+    "local>jgraichen/renovate-config"
+  ]
+}

data/spec/files/env.rb

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 
-$stdout.puts "ENV: #{ENV[ARGV[0]]}"
+$stdout.puts "ENV: #{ENV.fetch(ARGV[0], nil)}"
 $stdout.sync
 
 sleep 1

data/spec/files/fail.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+exit Integer(ARGV.fetch(0, '1'))

data/spec/files/sleep.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 
 sleep ARGV[0].to_i

data/spec/files/test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 2.times do
   $stdout.puts "Output from #{ARGV[0]}"

data/spec/multi_process/group_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe MultiProcess::Group do
+  subject(:group) { MultiProcess::Group.new }
+
+  before do
+    group << MultiProcess::Process.new(command)
+  end
+
+  describe '#run!' do
+    context 'with failing command' do
+      let(:command) { %w[ruby spec/files/fail.rb] }
+
+      it 'does raise an error' do
+        expect { group.run! }.to raise_error(MultiProcess::ProcessError, /Process \d+ exited with code 1/)
+      end
+    end
+
+    context 'with partition and failing command' do
+      subject(:group) { MultiProcess::Group.new(partition: 1) }
+
+      let(:command) { %w[ruby spec/files/fail.rb] }
+
+      it 'does raise an error' do
+        expect { group.run! }.to raise_error(MultiProcess::ProcessError, /Process \d+ exited with code 1/)
+      end
+    end
+  end
+end

data/spec/multi_process/process_spec.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe MultiProcess::Process do
+  subject(:process) { MultiProcess::Process.new(command) }
+
+  describe '#run!' do
+    context 'with failing command' do
+      let(:command) { %w[ruby spec/files/fail.rb] }
+
+      it 'does raise an error' do
+        expect { process.run! }.to raise_error(MultiProcess::ProcessError, /Process \d+ exited with code 1/)
+      end
+    end
+  end
+end

data/spec/multi_process_spec.rb

@@ -1,62 +1,64 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe MultiProcess do
-  it 'should run processes' do
+  it 'runs processes (I)' do
     reader, writer = IO.pipe
 
     logger = MultiProcess::Logger.new writer, collapse: false
     group  = MultiProcess::Group.new receiver: logger
-    group << MultiProcess::Process.new(%w(ruby spec/files/test.rb A), title: 'rubyA')
-    group << MultiProcess::Process.new(%w(ruby spec/files/test.rb B), title: 'rubyBB')
-    group << MultiProcess::Process.new(%w(ruby spec/files/test.rb C), title: 'rubyCCC')
+    group << MultiProcess::Process.new(%w[ruby spec/files/test.rb A], title: 'rubyA')
+    group << MultiProcess::Process.new(%w[ruby spec/files/test.rb B], title: 'rubyBB')
+    group << MultiProcess::Process.new(%w[ruby spec/files/test.rb C], title: 'rubyCCC')
     group.run
 
-    expect(reader.read_nonblock(4096).split("\n")).to match_array <<-EOF.gsub(/^\s+\./, '').split("\n")
+    expect(reader.read_nonblock(4096).split("\n")).to match_array <<-OUTPUT.gsub(/^\s+\./, '').split("\n")
     .  rubyBB  | Output from B
     .   rubyA  | Output from A
     .   rubyA  | Output from A
     . rubyCCC  | Output from C
     . rubyCCC  | Output from C
     .  rubyBB  | Output from B
-    EOF
+    OUTPUT
   end
 
-  it 'should run processes' do
+  it 'runs processes (II)' do
     start = Time.now
 
     group = MultiProcess::Group.new receiver: MultiProcess::NilReceiver.new
-    group << MultiProcess::Process.new(%w(ruby spec/files/sleep.rb 5000), title: 'rubyA')
-    group << MultiProcess::Process.new(%w(ruby spec/files/sleep.rb 5000), title: 'rubyB')
-    group << MultiProcess::Process.new(%w(ruby spec/files/sleep.rb 5000), title: 'rubyC')
+    group << MultiProcess::Process.new(%w[ruby spec/files/sleep.rb 5000], title: 'rubyA')
+    group << MultiProcess::Process.new(%w[ruby spec/files/sleep.rb 5000], title: 'rubyB')
+    group << MultiProcess::Process.new(%w[ruby spec/files/sleep.rb 5000], title: 'rubyC')
     group.start
     sleep 1
     group.stop
 
     group.processes.each do |p|
-      expect(p).to_not be_alive
+      expect(p).not_to be_alive
     end
     expect(Time.now - start).to be < 2
   end
 
-  it 'should partition processes' do
+  it 'partitions processes' do
     group = MultiProcess::Group.new partition: 4, receiver: MultiProcess::NilReceiver.new
-    group << MultiProcess::Process.new(%w(ruby sleep.rb 1), dir: 'spec/files', title: 'rubyA')
-    group << MultiProcess::Process.new(%w(ruby sleep.rb 1), dir: 'spec/files', title: 'rubyB')
-    group << MultiProcess::Process.new(%w(ruby sleep.rb 1), dir: 'spec/files', title: 'rubyC')
-    group << MultiProcess::Process.new(%w(ruby sleep.rb 1), dir: 'spec/files', title: 'rubyD')
-    group << MultiProcess::Process.new(%w(ruby sleep.rb 1), dir: 'spec/files', title: 'rubyE')
-    group << MultiProcess::Process.new(%w(ruby sleep.rb 1), dir: 'spec/files', title: 'rubyF')
-    group << MultiProcess::Process.new(%w(ruby sleep.rb 1), dir: 'spec/files', title: 'rubyG')
-    group << MultiProcess::Process.new(%w(ruby sleep.rb 1), dir: 'spec/files', title: 'rubyH')
+    group << MultiProcess::Process.new(%w[ruby sleep.rb 1], dir: 'spec/files', title: 'rubyA')
+    group << MultiProcess::Process.new(%w[ruby sleep.rb 1], dir: 'spec/files', title: 'rubyB')
+    group << MultiProcess::Process.new(%w[ruby sleep.rb 1], dir: 'spec/files', title: 'rubyC')
+    group << MultiProcess::Process.new(%w[ruby sleep.rb 1], dir: 'spec/files', title: 'rubyD')
+    group << MultiProcess::Process.new(%w[ruby sleep.rb 1], dir: 'spec/files', title: 'rubyE')
+    group << MultiProcess::Process.new(%w[ruby sleep.rb 1], dir: 'spec/files', title: 'rubyF')
+    group << MultiProcess::Process.new(%w[ruby sleep.rb 1], dir: 'spec/files', title: 'rubyG')
+    group << MultiProcess::Process.new(%w[ruby sleep.rb 1], dir: 'spec/files', title: 'rubyH')
 
     start = Time.now
     group.run
-    expect(Time.now - start).to be_within(0.3).of(2)
+    expect(Time.now - start).to be_within(0.5).of(2)
   end
 
-  it 'should env processes' do
+  it 'envs processes' do
     receiver = MultiProcess::StringReceiver.new
-    process  = MultiProcess::Process.new(%w(ruby spec/files/env.rb TEST), env: { 'TEST' => 'abc' }, receiver: receiver)
+    process  = MultiProcess::Process.new(%w[ruby spec/files/env.rb TEST], env: {'TEST' => 'abc'}, receiver: receiver)
     process.run
 
     expect(receiver.get(:out)).to eq "ENV: abc\n"

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rspec'
 
 require 'bundler'
@@ -5,7 +7,7 @@ Bundler.require
 
 require 'multi_process'
 
-Dir[File.expand_path('spec/support/**/*.rb')].each { |f| require f }
+Dir[File.expand_path('spec/support/**/*.rb')].sort.each {|f| require f }
 
 RSpec.configure do |config|
   # ## Mock Framework

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: multi_process
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Jan Graichen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-13 00:00:00.000000000 Z
+date: 2022-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -73,13 +73,17 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".editorconfig"
+- ".github/workflows/test.yml"
 - ".gitignore"
+- ".rubocop.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - lib/multi_process.rb
+- lib/multi_process/errors.rb
 - lib/multi_process/group.rb
 - lib/multi_process/logger.rb
 - lib/multi_process/loop.rb
@@ -91,15 +95,20 @@ files:
 - lib/multi_process/string_receiver.rb
 - lib/multi_process/version.rb
 - multi_process.gemspec
+- renovate.json
 - spec/files/env.rb
+- spec/files/fail.rb
 - spec/files/sleep.rb
 - spec/files/test.rb
+- spec/multi_process/group_spec.rb
+- spec/multi_process/process_spec.rb
 - spec/multi_process_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/jgraichen/multi_process
 licenses:
 - GPLv3
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -108,20 +117,23 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.3.7
 signing_key: 
 specification_version: 4
 summary: Handle multiple child processes.
 test_files:
 - spec/files/env.rb
+- spec/files/fail.rb
 - spec/files/sleep.rb
 - spec/files/test.rb
+- spec/multi_process/group_spec.rb
+- spec/multi_process/process_spec.rb
 - spec/multi_process_spec.rb
 - spec/spec_helper.rb