multi_column_search 0.0.2 → 1.0.0

data/CHANGELOG

@@ -1,3 +1,5 @@
+v1.0.0  Added SQL INJ Test and launch to production
+
 v0.0.2  Fixed Debuging messages.
 
 v0.0.1. Initial release.

data/README.rdoc

@@ -4,6 +4,11 @@ Quick and dirty multi column LIKE searches. Need to search accross multiple colu
 
 Running lots of queries or have a large data set? You should probably upgrade to a real search back-end already!
 
+== Requirements
+
+This gem requires ActiveRecord 3
+
+
 == Examples
 
 Add a search method to your model by calling multi_column_search with the fields you want to search.

data/lib/multi_column_search.rb

@@ -23,13 +23,11 @@ module MultiColumnSearch
     like = connection.adapter_name == "PostgreSQL" ? "ILIKE" : "LIKE"
     scope options[:name], lambda { |terms|
       terms = terms.split.join('%')
-      conditions = terms.split.inject([]) do |acc, term|
+      conditions = terms.split.inject(where(nil)) do |acc, term|
         pattern = get_multi_column_pattern options[:match], term
-        acc << columns.collect { |column| "#{table_name}.#{column} #{like} '#{pattern}'" }  
+        where(columns.collect { |column| "#{table_name}.#{column} #{like} :pattern" }.join(' OR '), {:pattern => pattern})  
       
-      end
-      
-      where conditions.map { |c| "(" + c.join(' OR ') + ")" }.join(' OR ')
+      end      
       }     
   end
   

data/multi_column_search.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{multi_column_search}
-  s.version = "0.0.2"
+  s.version = "1.0.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jack Russell Software"]
-  s.date = %q{2010-08-18}
+  s.date = %q{2010-09-29}
   s.description = %q{Quick and dirty multi column LIKE searches.}
   s.email = %q{team@jackrussellsoftware.com}
   s.extra_rdoc_files = ["CHANGELOG", "README.rdoc", "lib/multi_column_search.rb"]

data/spec/multi_column_search_spec.rb

@@ -24,6 +24,10 @@ describe MultiColumnSearch do
        Sponsor.search('Mount P').count.should == 2
      end
 
+     it "should not allow sql injection" do
+       Sponsor.search(%q{'"`}).should == []  
+     end
+     
   end
   
   

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: multi_column_search
 version: !ruby/object:Gem::Version 
+  hash: 23
   prerelease: false
   segments: 
+  - 1
   - 0
   - 0
-  - 2
-  version: 0.0.2
+  version: 1.0.0
 platform: ruby
 authors: 
 - Jack Russell Software
@@ -14,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-08-18 00:00:00 -04:00
+date: 2010-09-29 00:00:00 -04:00
 default_executable: 
 dependencies: []
 
@@ -58,6 +59,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
@@ -66,6 +68,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 11
       segments: 
       - 1
       - 2