muffin_man 1.5.12 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 526c64f895aaaaa85524610880e5c0b7234891f2bc96ab96bd06fba80543abf4
-  data.tar.gz: 3867cb62c7cf5c5fea6d28e271a3859591055d5e40debb13c21bcbd65749e8f7
+  metadata.gz: c6a23fde4189af4c23e82ceecce92bc1c04a823b1425654d1ea6c2201a4560e3
+  data.tar.gz: ed9e5d6702dbb1c968d0d1d025c25f95b2964a9237a826adcb8eacc441a5d737
 SHA512:
-  metadata.gz: 617efb9dec4d967e99b9b0cd7d3ecc7423b4b38d4904a51db80dd4f947c6b66fc935fcb7bd9b7964b74d0535012186b948a4863f4780c663f0099c2fcf6e8216
-  data.tar.gz: 0fe69dabf49c80198a53bd6b5a1d375bd0a17199cec2875f40d2597e79741f47e6ea411d9482d6d755226a5faf75554dd5dc59d3eb7253e98af3b8e572854453
+  metadata.gz: 52b0b85823c119e7a625cdbb18bc256a3758e60be2abed558e95ff91a148d434ef0a217208bf9c4b72adf71f9b48166f6b3a3f7b59c26b2a945fe19c34db8464
+  data.tar.gz: 415a81fc29205f8b49883a9460558c364a4217f87475388d1221200b34d57fcc0e51e0c53eb44dd173892202c6424977654f0087170193da42b573678f65486a

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 2.0.0 [#47](https://github.com/patterninc/muffin_man/pull/47)
+
+- BREAKING CHANGES: Changed signature of processing_directive check as it was confusing and was not working. processing_directive is a nested structure. It has marketplace_ids. Having marketplace_ids as an independent parameter was confusing.
+- Added new endpoint support - delete_subscription.
+
 # 1.5.12 [#45](https://github.com/patterninc/muffin_man/pull/45)
 
 - Small update to putTransportDetails

data/lib/muffin_man/notifications/v1.rb

@@ -43,17 +43,12 @@ module MuffinMan
         params = params.transform_keys(&:to_s)
         subscription_params = { "destinationId" => params["destination_id"] }
         # currently SP-API's `processingDirective` only supports ANY_OFFER_CHANGED notification type.
-        if PROCESSING_DIRECTIVE_SUPPORTED_NOTIFICATIONS.include? notification_type
-          subscription_params["processingDirective"] =
-            { "eventFilter" => { "eventFilterType" => notification_type,
-                                 "marketplaceIds" => params["marketplace_ids"] } }
-          unless params["aggregation_time_period"].nil?
-            subscription_params["processingDirective"]["eventFilter"]
-              .merge!("aggregationSettings" => {
-                        "aggregationTimePeriod" => params["aggregation_time_period"]
-                      })
-          end
+        if include_processing_directive?(notification_type, params)
+          subscription_params.merge!(
+            "processingDirective" => params["processing_directive"]
+          )
         end
+
         subscription_params.merge!("payloadVersion" => params["payload_version"]) unless params["payload_version"].nil?
         @request_body = subscription_params
         @request_type = "POST"
@@ -80,6 +75,20 @@ module MuffinMan
         @request_type = "DELETE"
         call_api
       end
+
+      def delete_destination(destination_id)
+        @local_var_path = "#{NOTIFICATION_PATH}/destinations/#{destination_id}"
+        @scope = NOTIFICATION_SCOPE
+        @request_type = "DELETE"
+        call_api
+      end
+
+      private
+
+      def include_processing_directive?(notification_type, params)
+        PROCESSING_DIRECTIVE_SUPPORTED_NOTIFICATIONS.include?(notification_type) &&
+          params["processing_directive"].present?
+      end
     end
   end
 end

data/lib/muffin_man/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MuffinMan
-  VERSION = "1.5.12"
+  VERSION = "2.0.0"
 end

data/muffin_man.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "rspec", "~> 3.2"
   spec.add_development_dependency 'webmock', '~> 2.1'
-  spec.add_development_dependency 'byebug'
+  spec.add_development_dependency 'byebug', '~> 11.1.3'
   spec.add_development_dependency 'mock_redis', '>=0.14'
   spec.add_runtime_dependency 'typhoeus', '~> 1.0', '>= 1.0.1'
   spec.add_runtime_dependency 'aws-sigv4', '>= 1.1'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: muffin_man
 version: !ruby/object:Gem::Version
-  version: 1.5.12
+  version: 2.0.0
 platform: ruby
 authors:
 - Gavin
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-01-03 00:00:00.000000000 Z
+date: 2023-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -44,16 +44,16 @@ dependencies:
   name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 11.1.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 11.1.3
 - !ruby/object:Gem::Dependency
   name: mock_redis
   requirement: !ruby/object:Gem::Requirement