mudguard 0.2.0 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a7b56ba51f10b0d6d32fcb120599bc145b275076b30786b6955285f5da26668
-  data.tar.gz: ca75c47ff5f80584407bb0da9d56b64f7c9e1e65cc8f7fc8b377ea0e8d83fefa
+  metadata.gz: a871581e7e7227dcc8c20bc00a925eb3b71bd23f76f1e30f76267fe9bbe97503
+  data.tar.gz: 2dec890800cb5661fc6930429d70171c5b29a8e4c888ad6f030d668bb8f0644e
 SHA512:
-  metadata.gz: e9bd40c81779ed70c331c0d445b735edb3e561967e65fce1dc228a62ad86fd9298dfaa990d3bded3faec6191b5821204466c9ed29cdf89d12e9eee1678884d81
-  data.tar.gz: 427d86d72d87f73d11dedfbb7a35d42ead0145919bf85e32dd5c9055bc977a2dadb9be668f76a081e61f54510a6ebb4aa66e7f4b11746da1a222efde3ad5b760
+  metadata.gz: 1fd2e9ee1f41f0f3d033ba1015a12b715377366876d835003a4b0dd0e5743cd1728d1a6f739812cabb2017b882e2fda33aeec5dde443e79fcfe65f980ff08fda
+  data.tar.gz: 62c6548a4c2b3a3e1bed074be382b3e73b89f60aaa3968217c56d33e4fdc03238a482955697609664055c630c6aa46c634e022f44747123c306ab5f0a5bb31bd

data/.github/workflows/ruby.yml

@@ -0,0 +1,35 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Ruby
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.5']
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+    # change this to (see https://github.com/ruby/setup-ruby#versioning):
+    # uses: ruby/setup-ruby@v1
+      uses: ruby/setup-ruby@473e4d8fe5dd94ee328fdfca9f8c9c7afc9dae5e
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run tests
+      run: bundle exec rspec --format RSpec::Github::Formatter

data/.gitignore

@@ -4,6 +4,9 @@
 # or operating system, you probably want to add a global ignore instead:
 #   git config --global core.excludesfile '~/.gitignore_global'
 
+# Ignore RubyMine
+/.idea
+
 # Ignore bundler config.
 /.bundle
 

data/.rubocop.yml

@@ -19,7 +19,7 @@ Style/Documentation:
     - 'spec/**/*.rb'
 
 Style/HashEachMethods:
-    Enabled: true
+  Enabled: true
 
 Style/HashTransformKeys:
   Enabled: true
@@ -30,3 +30,8 @@ Style/HashTransformValues:
 Layout/LineLength:
   Description: 'Limit lines to 100 characters.'
   Max: 100
+
+
+Lint/EmptyFile:
+  Exclude:
+    - 'spec/lib/infrastructure/persistence/project_repository_project/**/*.rb'

data/Gemfile.lock

@@ -1,18 +1,18 @@
 PATH
   remote: .
   specs:
-    mudguard (0.2.0)
+    mudguard (0.2.5)
       parser (~> 2.7)
       rake (~> 13.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (2.4.0)
+    ast (2.4.2)
     byebug (11.1.3)
-    coderay (1.1.2)
-    diff-lcs (1.3)
-    ffi (1.12.2)
+    coderay (1.1.3)
+    diff-lcs (1.4.4)
+    ffi (1.15.0)
     formatador (0.2.5)
     guard (2.16.2)
       formatador (>= 0.2.4)
@@ -28,61 +28,65 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    listen (3.2.1)
+    listen (3.5.1)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
-    lumberjack (1.2.5)
+    lumberjack (1.2.8)
     method_source (1.0.0)
     nenv (0.3.0)
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    parallel (1.19.1)
-    parser (2.7.1.3)
-      ast (~> 2.4.0)
-    pry (0.13.1)
+    parallel (1.20.1)
+    parser (2.7.2.0)
+      ast (~> 2.4.1)
+    pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    pry-byebug (3.9.0)
+    pry-byebug (3.8.0)
       byebug (~> 11.0)
-      pry (~> 0.13.0)
+      pry (~> 0.10)
     pry-doc (1.1.0)
       pry (~> 0.11)
       yard (~> 0.9.11)
     rainbow (3.0.0)
-    rake (13.0.1)
+    rake (13.0.3)
     rb-fsevent (0.10.4)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
-    rexml (3.2.4)
-    rspec (3.9.0)
-      rspec-core (~> 3.9.0)
-      rspec-expectations (~> 3.9.0)
-      rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.2)
-      rspec-support (~> 3.9.3)
-    rspec-expectations (3.9.2)
+    regexp_parser (2.1.1)
+    rexml (3.2.5)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.1)
+      rspec-support (~> 3.10.0)
+    rspec-github (2.3.1)
+      rspec-core (~> 3.0)
+    rspec-mocks (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-support (3.9.3)
-    rubocop (0.84.0)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.2)
+    rubocop (0.93.1)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8)
       rexml
-      rubocop-ast (>= 0.0.3)
+      rubocop-ast (>= 0.6.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.0.3)
-      parser (>= 2.7.0.1)
-    ruby-progressbar (1.10.1)
+    rubocop-ast (1.4.1)
+      parser (>= 2.7.1.5)
+    ruby-progressbar (1.11.0)
     shellany (0.0.1)
-    thor (1.0.1)
+    thor (1.1.0)
     unicode-display_width (1.7.0)
-    yard (0.9.25)
+    yard (0.9.26)
 
 PLATFORMS
   ruby
@@ -97,6 +101,7 @@ DEPENDENCIES
   pry-doc (~> 1.0)
   rake (~> 13.0)
   rspec (~> 3.9)
+  rspec-github
   rubocop (~> 0.80)
 
 BUNDLED WITH

data/Guardfile

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 rspec_options = {
-  cmd: "rspec",
+  cmd: "bundle exec rspec",
   notification: false,
   failed_mode: :focus
 }
@@ -12,5 +12,5 @@ guard "rspec", rspec_options do
   watch(%r{^lib/mudguard/(.+)\.rb$}) { |m| "spec/lib/#{m[1]}_spec.rb" }
   watch(%r{^lib/mudguard/(.+)\.rb$}) { |m| Dir.glob("spec/lib/#{m[1]}_*.rb") }
   watch("spec/spec_helper.rb") { "spec" }
-  watch(%r{^exe\/mudguard$}) { |_| "spec/exe/mudguard_spec.rb" }
+  watch(%r{^exe/mudguard$}) { |_| "spec/exe/mudguard_spec.rb" }
 end

data/lib/mudguard/domain/consts.rb

@@ -7,15 +7,7 @@ module Mudguard
     # Knows all constants of the project
     class Consts
       def initialize(sources:)
-        @consts = sources
-                  .flat_map(&:find_consts)
-                  .each_with_object(Hash.new { |h, k| h[k] = {} }) do |c, a|
-          path = split_hierarchy(c)
-          const_name = path.last
-          module_names = path.take(path.count - 1)
-          sub_module = module_names.reduce(a) { |h, m| h[m] }
-          sub_module[const_name] = {} unless sub_module.key?(const_name)
-        end
+        @consts = sources.flat_map(&:find_consts).each_with_object({}, &method(:add_const))
       end
 
       def resolve(module_name, const_name)
@@ -35,6 +27,14 @@ module Mudguard
 
       private
 
+      def add_const(const, all_consts)
+        path = split_hierarchy(const)
+        const_name = path.last
+        module_names = path.take(path.count - 1)
+        sub_module = module_names.reduce(all_consts) { |h, m| h.key?(m) ? h[m] : h[m] = {} }
+        sub_module[const_name] = {} unless sub_module.key?(const_name)
+      end
+
       SEPARATOR = "::"
 
       def find_const_deeper(current_module, remaining_modules, consts, const_path)

data/lib/mudguard/domain/dependency.rb

@@ -6,7 +6,7 @@ module Mudguard
     class Dependency
       attr_reader :location, :dependency
 
-      def initialize(location: nil, dependency:)
+      def initialize(dependency:, location: nil)
         @location = location
         @dependency = dependency
       end

data/lib/mudguard/domain/source.rb

@@ -1,6 +1,13 @@
 # frozen_string_literal: true
 
-require "parser/current"
+orig = $VERBOSE
+begin
+  $VERBOSE = nil # silence warning when ruby versions are not exactly matching
+  require "parser/current"
+ensure
+  $VERBOSE = orig
+end
+
 require_relative "dependency"
 require_relative "dependency_visitor"
 require_relative "const_visitor"

data/lib/mudguard/infrastructure/persistence/project_repository.rb

@@ -13,16 +13,24 @@ module Mudguard
           def load_source_policies(project_path)
             file = PolicyFile.read(project_path)
             scopes = file.flat_map do |patterns, policies|
-              sources = RubyFiles.select(project_path, patterns: [patterns])
-              sources.flat_map { |s| { source: s, policies: policies } }
+              build_scope(patterns, policies, project_path)
             end
 
             sources = scopes.group_by { |e| e[:source] }
 
-            sources.map do |source, group|
-              policies = group.flat_map { |r| r[:policies] }.uniq
-              Domain::SourcePolicies.new(source: source, policies: policies)
-            end
+            sources.map(&method(:build_policies))
+          end
+
+          private
+
+          def build_policies(source, group)
+            policies = group.flat_map { |r| r[:policies] }.uniq
+            Domain::SourcePolicies.new(source: source, policies: policies)
+          end
+
+          def build_scope(patterns, policies, project_path)
+            sources = RubyFiles.select(project_path, patterns: [patterns])
+            sources.flat_map { |s| { source: s, policies: policies } }
           end
         end
       end

data/lib/mudguard/infrastructure/persistence/ruby_files.rb

@@ -25,7 +25,7 @@ module Mudguard
           def enumerate_files(project_path, patterns)
             project_path_name = Pathname.new(project_path)
             ruby_files = patterns.map { |p| File.join(project_path, p) }
-            Dir.glob(ruby_files).map do |f|
+            Dir.glob(ruby_files).select { |f| File.file?(f) }.map do |f|
               file_path_name = Pathname.new(f)
               diff_path = file_path_name.relative_path_from(project_path_name).to_s
               Mudguard::Domain::Source.new(location: File.join("./", diff_path),

data/lib/mudguard/infrastructure/rake/task.rb

@@ -12,6 +12,8 @@ module Mudguard
       # Provides Mudguard Rake Tasks
       class Task < ::Rake::TaskLib
         def initialize(project_dir: Dir.pwd)
+          super()
+
           @project_dir = project_dir
 
           desc "Run Mudguard"

data/lib/mudguard/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Mudguard
-  VERSION = "0.2.0"
+  VERSION = "0.2.5"
 end

data/mudguard.gemspec

@@ -17,6 +17,7 @@ Gem::Specification.new do |spec|
 
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = spec.homepage
+  spec.required_ruby_version = ">= 2.5.3"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been
@@ -37,6 +38,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "pry-doc", "~>1.0"
   spec.add_development_dependency "rake", "~>13.0"
   spec.add_development_dependency "rspec", "~> 3.9"
+  spec.add_development_dependency "rspec-github"
   spec.add_development_dependency "rubocop", "~>0.80"
 
   spec.add_dependency "parser", "~>2.7"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mudguard
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.5
 platform: ruby
 authors:
 - Jorg Jenni
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-12 00:00:00.000000000 Z
+date: 2021-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -122,6 +122,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.9'
+- !ruby/object:Gem::Dependency
+  name: rspec-github
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -173,6 +187,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".envrc"
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".mudguard.yml"
 - ".rubocop.yml"
@@ -225,7 +240,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.5.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="