muck-engine 3.3.10 → 3.3.11

data/VERSION

@@ -1 +1 @@
-3.3.10
+3.3.11

data/app/helpers/muck_engine_helper.rb

@@ -230,7 +230,9 @@ module MuckEngineHelper
   def truncate_on_word(text, length = 270, end_string = ' ...')
     return '' if text.blank?
     if text.length > length + end_string.length
-      stop_index = text.rindex(' ', length - end_string.length)
+      no_html_end_string = strip_tags(end_string)      
+      stop_index = text.rindex(' ', length - no_html_end_string.length)
+      raise "End string (omission text) was longer than the allowed length for the entire string. Please use a shorter omission string - ie '...'" if stop_index.blank?
       text[0,stop_index] + end_string
     else
       text + end_string

data/muck-engine.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{muck-engine}
-  s.version = "3.3.10"
+  s.version = "3.3.11"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Justin Ball", "Joel Duffin"]

data/test/spec/helpers/muck_engine_helper_spec.rb

@@ -60,11 +60,16 @@ describe MuckEngineHelper do
   end
   
   describe "html_summarize_by_chars" do
+    before do
+      @html = "<div>This <span>text</span> will need to be reduced down to characters without any html.</div>"
+    end
     it "should remove html and summarize to 270 chars" do
-      html = "<div>This <span>text</span> will need to be reduced down to characters without any html.</div>"
-      result = helper.html_summarize_by_chars(html, 30)
+      result = helper.html_summarize_by_chars(@html, 30)
       result.should == "This text will need to be..."
     end
+    it "should raise an error if omission text is too long" do
+      helper.html_summarize_by_chars(@html, 30, 'a really long omission text that will be longer than the allowed number of strings').should raise_error
+    end
   end
   
   describe "truncate_words" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: muck-engine
 version: !ruby/object:Gem::Version 
-  hash: 31
+  hash: 29
   prerelease: 
   segments: 
   - 3
   - 3
-  - 10
-  version: 3.3.10
+  - 11
+  version: 3.3.11
 platform: ruby
 authors: 
 - Justin Ball