much-rails 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba7d46f07c2592e152fe836a0cff5a7bf8061e9f531aac1c6a748f1365cc383b
-  data.tar.gz: 19e41c6e470a0021b6b78ea9c7eff7e6e530758d0522a591b4f8623b610f9fa2
+  metadata.gz: 06a9727075cd562255a4af1a8d1a37f542cda97dae2180389d6c16446ad545a9
+  data.tar.gz: 750e9cb46067e57fbbc4bdf46181e3cf274c1a9e6eacfb04ee702cfd8268d4ff
 SHA512:
-  metadata.gz: 37bdf6aa9a624f270cd53e5ba22f3e400f331b9b91c29aed2c6169627350f9c49e2f929ff6b9bc83665c789953559f67f546c11fd4cc9660814b46f61bfb2bb9
-  data.tar.gz: eb78925cf707aef2f6484665963da6dee38f495cad04de680f7ea349292eae41b77bdd36f014b05a2e5fcda48e8c8d03b23485f60786020100794f4d1cb3c15f
+  metadata.gz: 8a3e8f4bd80630a89fbca5bd1a88ccf83f7e99c957f81ce7c16255164cb08af8dc404e6cc2f319aba35dfe9acb9f63c91650fbbde814cb7576ecbfcce07f3295
+  data.tar.gz: 41884fcc5e7671a4fd3faa79cef4297ececfbcc6d5ad5c3fd79e8979950dbd413ebc9b984bda7350f199585b5619878b1e7158361f96283b77fd21f8b4b1d749

data/lib/much-rails.rb

@@ -18,6 +18,7 @@ require "much-rails/destroy_action"
 require "much-rails/destroy_service"
 require "much-rails/has_slug"
 require "much-rails/input_value"
+require "much-rails/invalid_error"
 require "much-rails/json"
 require "much-rails/layout"
 require "much-rails/not_given"

data/lib/much-rails/action.rb

@@ -115,7 +115,7 @@ module MuchRails::Action
     def initialize(params: nil, request: nil)
       @params = params.to_h.with_indifferent_access
       @request = request
-      @errors = Hash.new{ |hash, key| hash[key] = [] }
+      @errors = HashWithIndifferentAccess.new{ |hash, key| hash[key] = [] }
     end
 
     def on_call

data/lib/much-rails/change_action_result.rb

@@ -40,7 +40,7 @@ class MuchRails::ChangeActionResult
   end
 
   def extract_validation_error(field_name)
-    validation_errors.delete(field_name)
+    Array.wrap(validation_errors.delete(field_name)).compact
   end
 
   def any_unextracted_validation_errors?

data/lib/much-rails/destroy_service.rb

@@ -1,10 +1,12 @@
 # frozen_string_literal: true
 
+require "much-rails/invalid_error"
 require "much-rails/mixin"
 require "much-rails/records"
 require "much-rails/records/validate_destroy"
 require "much-rails/result"
 require "much-rails/service"
+require "much-rails/service_validation_errors"
 
 module MuchRails; end
 
@@ -51,6 +53,13 @@ module MuchRails::DestroyService
                 validation_error_messages: ex.error_full_messages.to_a,
               )
             end
+            e.add(MuchRails::InvalidError) do |ex|
+              MuchRails::SaveService::FailureResult.new(
+                exception: ex,
+                validation_errors: ex.errors,
+                validation_error_messages: ex.error_messages,
+              )
+            end
           end
     end
   end

data/lib/much-rails/invalid_error.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module MuchRails; end
+
+# MuchRails::InvalidError allows for raising and auto-rescueing general
+# validation errors outside the scope of e.g. an ActiveRecord save.
+class MuchRails::InvalidError < StandardError
+  attr_reader :errors
+
+  def initialize(backtrace: nil, **errors)
+    @errors = errors
+
+    super(@errors.inspect)
+    set_backtrace(backtrace) if backtrace
+  end
+
+  def error_messages
+    @errors.to_a.map do |(field_name, message)|
+      "#{field_name}: #{Array.wrap(message).to_sentence}"
+    end
+  end
+end

data/lib/much-rails/save_service.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "active_record"
+require "much-rails/invalid_error"
 require "much-rails/mixin"
 require "much-rails/result"
 require "much-rails/service"
@@ -52,6 +53,13 @@ module MuchRails::SaveService
                   ex.record&.errors&.full_messages.to_a,
               )
             end
+            e.add(MuchRails::InvalidError) do |ex|
+              MuchRails::SaveService::FailureResult.new(
+                exception: ex,
+                validation_errors: ex.errors,
+                validation_error_messages: ex.error_messages,
+              )
+            end
           end
     end
   end

data/lib/much-rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MuchRails
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

data/test/unit/action_tests.rb

@@ -199,7 +199,7 @@ module MuchRails::Action
           end
 
           if params[:fail_custom_validation]
-            errors[:custom_validation] << "ERROR1"
+            errors["custom_validation"] << "ERROR1"
           end
         end
 

data/test/unit/change_action_result_tests.rb

@@ -64,10 +64,14 @@ class MuchRails::ChangeActionResult
   class ValidationMethodsTests < UnitTests
     desc "validation methods"
     subject do
-      unit_class.failure(validation_errors: {
-        name: ["NAME ERROR"],
-        other: ["OTHER ERROR"],
-      })
+      unit_class.failure(
+        validation_errors: {
+          name: ["NAME ERROR"],
+          other: ["OTHER ERROR"],
+          empty: [],
+          none: nil,
+        },
+      )
     end
 
     should "know its attributes" do
@@ -76,6 +80,8 @@ class MuchRails::ChangeActionResult
         .equals({
           name: ["NAME ERROR"],
           other: ["OTHER ERROR"],
+          empty: [],
+          none: [nil],
         })
 
       # validation_error_messages
@@ -90,6 +96,12 @@ class MuchRails::ChangeActionResult
         .equals(["NAME ERROR"])
       assert_that(subject.extract_validation_error(:other))
         .equals(["OTHER ERROR"])
+      assert_that(subject.extract_validation_error(:empty))
+        .equals([])
+      assert_that(subject.extract_validation_error(:none))
+        .equals([])
+      assert_that(subject.extract_validation_error(:unknown))
+        .equals([])
       assert_that(subject.validation_errors).is_empty
 
       # any_unextracted_validation_errors?

data/test/unit/destroy_service_tests.rb

@@ -73,6 +73,7 @@ module MuchRails::DestroyService
         RuntimeError.new(Factory.string),
         ArgumentError.new(Factory.string),
         MuchRails::Records::DestructionInvalid.new(FakeRecord.new),
+        MuchRails::InvalidError.new,
       ]
     end
     let(:exception_classes){ exceptions.map(&:class) }
@@ -102,6 +103,8 @@ module MuchRails::DestroyService
         .is_an_instance_of(MuchRails::ServiceValidationErrors)
       assert_that(subject.service_validation_errors.exception_classes)
         .includes(MuchRails::Records::DestructionInvalid)
+      assert_that(subject.service_validation_errors.exception_classes)
+        .includes(MuchRails::InvalidError)
     end
   end
 
@@ -185,6 +188,22 @@ module MuchRails::DestroyService
     end
   end
 
+  class ValidationErrorsResultForInvalidErrorTests < ValidationErrorsTests
+    desc "when .result_for is passed an MuchRails::InvalidError"
+
+    let(:exception){ MuchRails::InvalidError.new }
+
+    should "return a failure result with the record and validation errors" do
+      result = subject.result_for(exception)
+
+      assert_that(result.failure?).is_true
+      assert_that(result.exception).equals(exception)
+      assert_that(result.validation_errors).equals(exception.errors)
+      assert_that(result.validation_error_messages)
+        .equals(exception.error_messages)
+    end
+  end
+
   class FailureResultTests < UnitTests
     desc "FailureResult"
     subject{ unit_class::FailureResult }

data/test/unit/invalid_error_tests.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+require "assert"
+require "much-rails/invalid_error"
+
+class MuchRails::InvalidError
+  class UnitTests < Assert::Context
+    desc "MuchRails::InvalidError"
+    subject{ unit_class }
+
+    let(:unit_class){ MuchRails::InvalidError }
+
+    should "be configured as expected" do
+      assert_that(subject < StandardError).is_true
+    end
+  end
+
+  class InitSetupTests < UnitTests
+    desc "when init"
+    subject{ unit_class.new }
+
+    should have_readers :errors
+    should have_imeths :error_messages
+
+    should "know its attributes" do
+      assert_that(subject.backtrace).is_nil
+      assert_that(subject.errors).equals({})
+      assert_that(subject.message).equals(subject.errors.inspect)
+      assert_that(subject.error_messages).equals([])
+
+      backtrace = Array.new(Factory.integer(3)){ Factory.path }
+      errors =
+        {
+          field1: ["ERROR 1A", "ERROR 2B"],
+          field2: "ERROR 2A",
+        }
+      exception = unit_class.new(backtrace: backtrace, **errors)
+      assert_that(exception.backtrace).equals(backtrace)
+      assert_that(exception.errors).equals(errors)
+      assert_that(exception.message).equals(exception.errors.inspect)
+      assert_that(exception.error_messages)
+        .equals(["field1: ERROR 1A and ERROR 2B", "field2: ERROR 2A"])
+    end
+  end
+end

data/test/unit/save_service_tests.rb

@@ -73,6 +73,7 @@ module MuchRails::SaveService
         RuntimeError.new(Factory.string),
         ArgumentError.new(Factory.string),
         ActiveRecord::RecordInvalid.new(FakeRecord.new),
+        MuchRails::InvalidError.new,
       ]
     end
     let(:exception_classes){ exceptions.map(&:class) }
@@ -102,6 +103,8 @@ module MuchRails::SaveService
         .is_an_instance_of(MuchRails::ServiceValidationErrors)
       assert_that(subject.service_validation_errors.exception_classes)
         .includes(ActiveRecord::RecordInvalid)
+      assert_that(subject.service_validation_errors.exception_classes)
+        .includes(MuchRails::InvalidError)
     end
   end
 
@@ -197,6 +200,22 @@ module MuchRails::SaveService
     end
   end
 
+  class ValidationErrorsResultForInvalidErrorTests < ValidationErrorsTests
+    desc "when .result_for is passed an MuchRails::InvalidError"
+
+    let(:exception){ MuchRails::InvalidError.new }
+
+    should "return a failure result with the record and validation errors" do
+      result = subject.result_for(exception)
+
+      assert_that(result.failure?).is_true
+      assert_that(result.exception).equals(exception)
+      assert_that(result.validation_errors).equals(exception.errors)
+      assert_that(result.validation_error_messages)
+        .equals(exception.error_messages)
+    end
+  end
+
   class FailureResultTests < UnitTests
     desc "FailureResult"
     subject{ unit_class::FailureResult }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: much-rails
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Kelly Redding
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-05-17 00:00:00.000000000 Z
+date: 2021-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: much-style-guide
@@ -277,6 +277,7 @@ files:
 - lib/much-rails/destroy_service.rb
 - lib/much-rails/has_slug.rb
 - lib/much-rails/input_value.rb
+- lib/much-rails/invalid_error.rb
 - lib/much-rails/json.rb
 - lib/much-rails/layout.rb
 - lib/much-rails/layout/helper.rb
@@ -333,6 +334,7 @@ files:
 - test/unit/destroy_service_tests.rb
 - test/unit/has_slug_tests.rb
 - test/unit/input_value_tests.rb
+- test/unit/invalid_error_tests.rb
 - test/unit/json_tests.rb
 - test/unit/layout_tests.rb
 - test/unit/mixin_tests.rb
@@ -408,6 +410,7 @@ test_files:
 - test/unit/destroy_service_tests.rb
 - test/unit/has_slug_tests.rb
 - test/unit/input_value_tests.rb
+- test/unit/invalid_error_tests.rb
 - test/unit/json_tests.rb
 - test/unit/layout_tests.rb
 - test/unit/mixin_tests.rb