much-rails 0.2.7 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8a66a39e5898e5491c562aed8a32fb4036382a3d62485e71d45d8c946d18f622
-  data.tar.gz: ff4307e38c7d7d8115823189bd5d39d7799b3f4bcedc0fd5f3e39320215dfffe
+  metadata.gz: ee8fc1ccf3484f2b015d6dc6f1911bcca2bddb9832809391dc48ef2aeac023bb
+  data.tar.gz: a0a9b4ba294d780e3a4002545e967505f8f32e15bb231e3fbd1e9d594ed4f9b1
 SHA512:
-  metadata.gz: 40877d371bdefb9fb77e370c5847a61becc905658ccaf2504066ed2092a4e0f3343e9fcf37e6e334e90155c14a6f13cea4bf1e0faaf7f893554e9b333f235ff7
-  data.tar.gz: 804743827c52ec702454bc5fed1999883ffaa8d7a0434c8266323f23d1fb231ed73bf2bec93b710d84797297c4cd58566209e0ba1fba09f7eb3a8cb9997a9417
+  metadata.gz: f47fe549b83381ec39c226cf52760d8b5ca2d386c66e3e4db3b37f22ce07d855dd665e499fe5db15e54e7263a5903f5759cbb2d9d60a175dffead64917388f79
+  data.tar.gz: 3c50dc018ab3d5e0d6bf98cc8725b99314e9527d400890500c5ffbc8bf1e9ed2772da689b00bd7ef4b8fdf4d256927a71e338401da57ec53879019ad5a4ae5f2

data/lib/much-rails.rb

@@ -18,6 +18,7 @@ require "much-rails/destroy_action"
 require "much-rails/destroy_service"
 require "much-rails/has_slug"
 require "much-rails/input_value"
+require "much-rails/invalid_error"
 require "much-rails/json"
 require "much-rails/layout"
 require "much-rails/not_given"

data/lib/much-rails/action.rb

@@ -31,7 +31,7 @@ module MuchRails::Action
 
     add_config :much_rails_action
 
-    attr_reader :params, :current_session, :request, :errors
+    attr_reader :params, :request, :errors
   end
 
   mixin_class_methods do
@@ -112,11 +112,10 @@ module MuchRails::Action
   end
 
   mixin_instance_methods do
-    def initialize(params: nil, current_session: nil, request: nil)
+    def initialize(params: nil, request: nil)
       @params = params.to_h.with_indifferent_access
-      @current_session = current_session
       @request = request
-      @errors = Hash.new{ |hash, key| hash[key] = [] }
+      @errors = HashWithIndifferentAccess.new{ |hash, key| hash[key] = [] }
     end
 
     def on_call
@@ -150,8 +149,17 @@ module MuchRails::Action
       @much_rails_successful_action
     end
 
+    def controller_session=(value)
+      @controller_session = value
+    end
+
     private
 
+    def controller_session
+      @controller_session ||=
+        request&.env&.[]("action_controller.instance")&.session
+    end
+
     def default_action_success_result
       MuchRails::Action::HeadResult.new(:ok)
     end

data/lib/much-rails/action/controller.rb

@@ -9,30 +9,31 @@ module MuchRails::Action; end
 # MuchRails::Action::Controller defines the behaviors for controllers processing
 # MuchRails::Actions.
 module MuchRails::Action::Controller
-  DEFAULT_ACTION_CLASS_FORMAT = :any
-
   include MuchRails::Mixin
 
+  def self.DEFAULT_ACTION_CLASS_FORMAT
+    :any
+  end
+
   mixin_included do
     attr_reader :much_rails_action_class
 
-    before_action(
+    prepend_before_action(
       :require_much_rails_action_class,
-      only: MuchRails::Action::Router::CONTROLLER_CALL_ACTION_METHOD_NAME,
+      only: MuchRails::Action::Router.CONTROLLER_CALL_ACTION_METHOD_NAME,
     )
     before_action :permit_all_much_rails_action_params
   end
 
   mixin_instance_methods do
     define_method(
-      MuchRails::Action::Router::CONTROLLER_CALL_ACTION_METHOD_NAME,
+      MuchRails::Action::Router.CONTROLLER_CALL_ACTION_METHOD_NAME,
     ) do
       respond_to do |format|
         format.public_send(much_rails_action_class_format) do
           result =
             much_rails_action_class.call(
               params: much_rails_action_params,
-              current_session: current_session,
               request: request,
             )
           instance_exec(result, &result.execute_block)
@@ -41,7 +42,7 @@ module MuchRails::Action::Controller
     end
 
     define_method(
-      MuchRails::Action::Router::CONTROLLER_NOT_FOUND_METHOD_NAME,
+      MuchRails::Action::Router.CONTROLLER_NOT_FOUND_METHOD_NAME,
     ) do
       respond_to do |format|
         format.html do
@@ -51,11 +52,12 @@ module MuchRails::Action::Controller
     end
 
     def much_rails_action_class_name
-      "::#{params[MuchRails::Action::Router::ACTION_CLASS_PARAM_NAME]}"
+      "::#{params[MuchRails::Action::Router.ACTION_CLASS_PARAM_NAME]}"
     end
 
     def much_rails_action_class_format
-      much_rails_action_class.format || DEFAULT_ACTION_CLASS_FORMAT
+      much_rails_action_class.format ||
+      MuchRails::Action::Controller.DEFAULT_ACTION_CLASS_FORMAT
     end
 
     def much_rails_action_params
@@ -67,7 +69,7 @@ module MuchRails::Action::Controller
           params
             .to_h
             .except(
-              MuchRails::Action::Router::ACTION_CLASS_PARAM_NAME,
+              MuchRails::Action::Router.ACTION_CLASS_PARAM_NAME,
               :controller,
               :action,
             ),

data/lib/much-rails/action/router.rb

@@ -6,10 +6,21 @@ module MuchRails; end
 module MuchRails::Action; end
 
 class MuchRails::Action::Router < MuchRails::Action::BaseRouter
-  DEFAULT_CONTROLLER_NAME = "application"
-  CONTROLLER_CALL_ACTION_METHOD_NAME = :much_rails_call_action
-  CONTROLLER_NOT_FOUND_METHOD_NAME = :much_rails_not_found
-  ACTION_CLASS_PARAM_NAME = :much_rails_action_class_name
+  def self.DEFAULT_CONTROLLER_NAME
+    "application"
+  end
+
+  def self.CONTROLLER_CALL_ACTION_METHOD_NAME
+    :much_rails_call_action
+  end
+
+  def self.CONTROLLER_NOT_FOUND_METHOD_NAME
+    :much_rails_not_found
+  end
+
+  def self.ACTION_CLASS_PARAM_NAME
+    :much_rails_action_class_name
+  end
 
   def self.url_class
     MuchRails::Action::Router::URL
@@ -28,7 +39,10 @@ class MuchRails::Action::Router < MuchRails::Action::BaseRouter
       raise ArgumentError, "routes file `#{file_path.inspect}` does not exist."
     end
 
-    new(routes_file_name, controller_name: controller_name) do
+    new(
+      routes_file_name.to_s.split(File::SEPARATOR).join("_"),
+      controller_name: controller_name,
+    ) do
       instance_eval(File.read(file_path), file_path.to_s, 1)
     end
   end
@@ -38,7 +52,7 @@ class MuchRails::Action::Router < MuchRails::Action::BaseRouter
   def initialize(name = nil, controller_name: nil, &block)
     super(name, &block)
 
-    @controller_name = controller_name || DEFAULT_CONTROLLER_NAME
+    @controller_name = controller_name || self.class.DEFAULT_CONTROLLER_NAME
   end
 
   # Example:
@@ -49,8 +63,10 @@ class MuchRails::Action::Router < MuchRails::Action::BaseRouter
   #   end
   def apply_to(application_routes_draw_scope)
     validate!
-    draw_url_to   = "#{controller_name}##{CONTROLLER_NOT_FOUND_METHOD_NAME}"
-    draw_route_to = "#{controller_name}##{CONTROLLER_CALL_ACTION_METHOD_NAME}"
+    draw_url_to =
+      "#{controller_name}##{self.class.CONTROLLER_NOT_FOUND_METHOD_NAME}"
+    draw_route_to =
+      "#{controller_name}##{self.class.CONTROLLER_CALL_ACTION_METHOD_NAME}"
 
     definition_names = Set.new
 
@@ -63,7 +79,8 @@ class MuchRails::Action::Router < MuchRails::Action::BaseRouter
           as: (definition.name if definition_names.add?(definition.name)),
           defaults:
             definition.default_params.merge({
-              ACTION_CLASS_PARAM_NAME => request_type_action.class_name,
+              self.class.ACTION_CLASS_PARAM_NAME =>
+                request_type_action.class_name,
               "format" => request_type_action.format,
             }),
           constraints: request_type_action.constraints_lambda,
@@ -79,7 +96,8 @@ class MuchRails::Action::Router < MuchRails::Action::BaseRouter
         as: (definition.name if definition_names.add?(definition.name)),
         defaults:
           definition.default_params.merge({
-            ACTION_CLASS_PARAM_NAME => definition.default_action_class_name,
+            self.class.ACTION_CLASS_PARAM_NAME =>
+              definition.default_action_class_name,
             "format" => definition.default_action_format,
           }),
       )
@@ -97,14 +115,14 @@ class MuchRails::Action::Router < MuchRails::Action::BaseRouter
     def path_for(**kargs)
       MuchRails::RailsRoutes.instance.public_send(
         "#{name}_path",
-        **kargs.symbolize_keys,
+        **kargs.symbolize_keys.except(:format),
       )
     end
 
     def url_for(**kargs)
       MuchRails::RailsRoutes.instance.public_send(
         "#{name}_url",
-        **kargs.symbolize_keys,
+        **kargs.symbolize_keys.except(:format),
       )
     end
   end

data/lib/much-rails/change_action_result.rb

@@ -27,12 +27,15 @@ class MuchRails::ChangeActionResult
 
     @service_result = save_service_result
 
-    @service_result.validation_errors ||= {}
+    @service_result.validation_errors ||= HashWithIndifferentAccess.new
   end
 
   def validation_errors
     @validation_errors ||=
-      service_result.get_for_all_results(:validation_errors).to_h
+      service_result
+        .get_for_all_results(:validation_errors)
+        .to_h
+        .with_indifferent_access
   end
 
   def validation_error_messages
@@ -40,7 +43,7 @@ class MuchRails::ChangeActionResult
   end
 
   def extract_validation_error(field_name)
-    validation_errors.delete(field_name)
+    Array.wrap(validation_errors.delete(field_name)).compact
   end
 
   def any_unextracted_validation_errors?

data/lib/much-rails/destroy_service.rb

@@ -1,10 +1,12 @@
 # frozen_string_literal: true
 
+require "much-rails/invalid_error"
 require "much-rails/mixin"
 require "much-rails/records"
 require "much-rails/records/validate_destroy"
 require "much-rails/result"
 require "much-rails/service"
+require "much-rails/service_validation_errors"
 
 module MuchRails; end
 
@@ -51,6 +53,13 @@ module MuchRails::DestroyService
                 validation_error_messages: ex.error_full_messages.to_a,
               )
             end
+            e.add(MuchRails::InvalidError) do |ex|
+              MuchRails::SaveService::FailureResult.new(
+                exception: ex,
+                validation_errors: ex.errors,
+                validation_error_messages: ex.error_messages,
+              )
+            end
           end
     end
   end

data/lib/much-rails/invalid_error.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module MuchRails; end
+
+# MuchRails::InvalidError allows for raising and auto-rescueing general
+# validation errors outside the scope of e.g. an ActiveRecord save.
+class MuchRails::InvalidError < StandardError
+  attr_reader :errors
+
+  def initialize(backtrace: nil, **errors)
+    @errors = errors
+
+    super(@errors.inspect)
+    set_backtrace(backtrace) if backtrace
+  end
+
+  def error_messages
+    @errors.to_a.map do |(field_name, message)|
+      "#{field_name}: #{Array.wrap(message).to_sentence}"
+    end
+  end
+end

data/lib/much-rails/save_service.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "active_record"
+require "much-rails/invalid_error"
 require "much-rails/mixin"
 require "much-rails/result"
 require "much-rails/service"
@@ -52,6 +53,13 @@ module MuchRails::SaveService
                   ex.record&.errors&.full_messages.to_a,
               )
             end
+            e.add(MuchRails::InvalidError) do |ex|
+              MuchRails::SaveService::FailureResult.new(
+                exception: ex,
+                validation_errors: ex.errors,
+                validation_error_messages: ex.error_messages,
+              )
+            end
           end
     end
   end

data/lib/much-rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MuchRails
-  VERSION = "0.2.7"
+  VERSION = "0.4.2"
 end

data/much-rails.gemspec

@@ -29,7 +29,7 @@ Gem::Specification.new do |gem|
 
   gem.add_dependency("activerecord",   ["> 5.0", "< 7.0"])
   gem.add_dependency("activesupport",  ["> 5.0", "< 7.0"])
-  gem.add_dependency("dassets",        ["~> 0.15.2"])
+  gem.add_dependency("dassets",        ["~> 0.15.3"])
   gem.add_dependency("dassets-erubi",  ["~> 0.1.1"])
   gem.add_dependency("dassets-sass",   ["~> 0.5.1"])
   gem.add_dependency("much-boolean",   ["~> 0.2.1"])

data/test/support/config/routes/test/subrouter.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+url :root, "/subrouter"

data/test/support/fake_action_controller.rb

@@ -13,20 +13,31 @@ module FakeActionController
   end
 
   mixin_class_methods do
-    def before_action(method_name, **)
-      before_actions << method_name
+    def before_action(*args, &block)
+      before_action_calls << Assert::StubCall.new(*args, &block)
     end
 
-    def before_actions
-      @before_actions ||= []
+    def prepend_before_action(*args, &block)
+      prepend_before_action_calls << Assert::StubCall.new(*args, &block)
+    end
+
+    def before_action_calls
+      @before_action_calls ||= []
+    end
+
+    def prepend_before_action_calls
+      @prepend_before_action_calls ||= []
     end
   end
 
   mixin_instance_methods do
     def initialize(params)
       @params = FakeParams.new(params)
-      self.class.before_actions.each do |before_action|
-        public_send(before_action)
+      self.class.prepend_before_action_calls.each do |before_action_call|
+        public_send(before_action_call.args.first)
+      end
+      self.class.before_action_calls.each do |before_action_call|
+        public_send(before_action_call.args.first)
       end
     end
 

data/test/unit/action/controller_tests.rb

@@ -17,8 +17,8 @@ module MuchRails::Action::Controller
       assert_that(subject).includes(MuchRails::Mixin)
     end
 
-    should "know its constants" do
-      assert_that(subject::DEFAULT_ACTION_CLASS_FORMAT).equals(:any)
+    should "know its attributes" do
+      assert_that(subject.DEFAULT_ACTION_CLASS_FORMAT).equals(:any)
     end
   end
 
@@ -29,6 +29,19 @@ module MuchRails::Action::Controller
     let(:receiver_class) do
       Class.new{ include FakeActionController }
     end
+
+    should "be configured as expected" do
+      assert_that(subject.prepend_before_action_calls.size).equals(1)
+      assert_that(subject.prepend_before_action_calls.last.args)
+        .equals([
+          :require_much_rails_action_class,
+          only: MuchRails::Action::Router.CONTROLLER_CALL_ACTION_METHOD_NAME,
+        ])
+
+      assert_that(subject.before_action_calls.size).equals(1)
+      assert_that(subject.before_action_calls.last.args)
+        .equals([:permit_all_much_rails_action_params])
+    end
   end
 
   class ReceiverInitTests < ReceiverTests
@@ -41,7 +54,7 @@ module MuchRails::Action::Controller
 
     let(:params1) do
       {
-        MuchRails::Action::Router::ACTION_CLASS_PARAM_NAME => "Actions::Show",
+        MuchRails::Action::Router.ACTION_CLASS_PARAM_NAME => "Actions::Show",
         controller: "actions",
         action: "show",
         nested: {
@@ -53,10 +66,10 @@ module MuchRails::Action::Controller
     should have_readers :much_rails_action_class
 
     should have_imeths(
-      MuchRails::Action::Router::CONTROLLER_CALL_ACTION_METHOD_NAME,
+      MuchRails::Action::Router.CONTROLLER_CALL_ACTION_METHOD_NAME,
     )
     should have_imeths(
-      MuchRails::Action::Router::CONTROLLER_NOT_FOUND_METHOD_NAME,
+      MuchRails::Action::Router.CONTROLLER_NOT_FOUND_METHOD_NAME,
     )
     should have_imeths :much_rails_action_class_name
     should have_imeths :much_rails_action_class_format
@@ -69,7 +82,7 @@ module MuchRails::Action::Controller
         .equals("::Actions::Show")
 
       assert_that(subject.much_rails_action_class_format)
-        .equals(unit_module::DEFAULT_ACTION_CLASS_FORMAT)
+        .equals(unit_module.DEFAULT_ACTION_CLASS_FORMAT)
 
       assert_that(subject.much_rails_action_params)
         .equals(
@@ -91,7 +104,7 @@ module MuchRails::Action::Controller
 
     let(:params1) do
       {
-        MuchRails::Action::Router::ACTION_CLASS_PARAM_NAME =>
+        MuchRails::Action::Router.ACTION_CLASS_PARAM_NAME =>
           "Actions::Unknown",
       }
     end

data/test/unit/action/router_tests.rb

@@ -16,17 +16,17 @@ class MuchRails::Action::Router
 
     should have_imeths :url_class
 
-    should "be a BaseRouter" do
+    should "be configured as expected" do
       assert_that(subject < MuchRails::Action::BaseRouter).is_true
     end
 
-    should "know its constants" do
-      assert_that(subject::DEFAULT_CONTROLLER_NAME).equals("application")
-      assert_that(subject::CONTROLLER_CALL_ACTION_METHOD_NAME)
+    should "know its attributes" do
+      assert_that(subject.DEFAULT_CONTROLLER_NAME).equals("application")
+      assert_that(subject.CONTROLLER_CALL_ACTION_METHOD_NAME)
         .equals(:much_rails_call_action)
-      assert_that(subject::CONTROLLER_NOT_FOUND_METHOD_NAME)
+      assert_that(subject.CONTROLLER_NOT_FOUND_METHOD_NAME)
         .equals(:much_rails_not_found)
-      assert_that(subject::ACTION_CLASS_PARAM_NAME)
+      assert_that(subject.ACTION_CLASS_PARAM_NAME)
         .equals(:much_rails_action_class_name)
       assert_that(subject.url_class).equals(unit_class::URL)
     end
@@ -45,6 +45,12 @@ class MuchRails::Action::Router
       assert_that(router.url_set.fetch(:root).path).equals("/")
     end
 
+    should "eval the nested named routes file" do
+      router = unit_class.load("test/subrouter")
+      assert_that(router.url_set).is_not_empty
+      assert_that(router.url_set.fetch(:root).path).equals("/subrouter")
+    end
+
     should "complain if no file name given" do
       assert_that{ unit_class.load([nil, "", "  "]) }.raises(ArgumentError)
     end
@@ -64,7 +70,7 @@ class MuchRails::Action::Router
 
     should "know its attributes" do
       assert_that(subject.controller_name)
-        .equals(unit_class::DEFAULT_CONTROLLER_NAME)
+        .equals(unit_class.DEFAULT_CONTROLLER_NAME)
 
       router = unit_class.new(controller_name: controller_name1)
       assert_that(router.controller_name).equals(controller_name1)
@@ -99,13 +105,13 @@ class MuchRails::Action::Router
 
       expected_draw_url_to =
         "#{subject.controller_name}"\
-        "##{unit_class::CONTROLLER_NOT_FOUND_METHOD_NAME}"
+        "##{unit_class.CONTROLLER_NOT_FOUND_METHOD_NAME}"
       expected_draw_route_to =
         "#{subject.controller_name}"\
-        "##{unit_class::CONTROLLER_CALL_ACTION_METHOD_NAME}"
+        "##{unit_class.CONTROLLER_CALL_ACTION_METHOD_NAME}"
       expected_default_defaults =
         {
-          unit_class::ACTION_CLASS_PARAM_NAME => default_class_name,
+          unit_class.ACTION_CLASS_PARAM_NAME => default_class_name,
           "format" => :html,
         }
 
@@ -117,7 +123,7 @@ class MuchRails::Action::Router
           as: url_name,
           defaults:
             {
-              unit_class::ACTION_CLASS_PARAM_NAME => request_type_class_name,
+              unit_class.ACTION_CLASS_PARAM_NAME => request_type_class_name,
               "format" => :html,
             },
           constraints: request_type_proc,
@@ -212,12 +218,12 @@ class MuchRails::Action::Router
     should have_imeths :path_for, :url_for
 
     should "know its attributes" do
-      path_string = subject.path_for(test: "args")
+      path_string = subject.path_for(test: "args", format: "html")
       assert_that(path_string).equals("TEST PATH OR URL STRING")
       assert_that(@rails_routes_method_missing_call.args)
         .equals(["#{url_name1}_path".to_sym, { test: "args" }])
 
-      url_string = subject.url_for(test: "args")
+      url_string = subject.url_for(test: "args", format: "xml")
       assert_that(url_string).equals("TEST PATH OR URL STRING")
       assert_that(@rails_routes_method_missing_call.args)
         .equals(["#{url_name1}_url".to_sym, { test: "args" }])

data/test/unit/action/unprocessable_entity_result_tests.rb

@@ -20,7 +20,7 @@ class MuchRails::Action::UnprocessableEntityResult
     let(:controller1){ FakeController.new(params1) }
     let(:params1) do
       {
-        MuchRails::Action::Router::ACTION_CLASS_PARAM_NAME => "Actions::Show",
+        MuchRails::Action::Router.ACTION_CLASS_PARAM_NAME => "Actions::Show",
       }
     end
     let(:errors1) do

data/test/unit/action_tests.rb

@@ -176,11 +176,7 @@ module MuchRails::Action
   class InitTests < ReceiverTests
     desc "when init"
     subject do
-      receiver_class.new(
-        params: params1,
-        current_session: current_session1,
-        request: request1,
-      )
+      receiver_class.new(params: params1, request: request1)
     end
 
     let(:receiver_class) do
@@ -203,7 +199,7 @@ module MuchRails::Action
           end
 
           if params[:fail_custom_validation]
-            errors[:custom_validation] << "ERROR1"
+            errors["custom_validation"] << "ERROR1"
           end
         end
 
@@ -218,6 +214,10 @@ module MuchRails::Action
         on_after_call do
           @after_call_called = true
         end
+
+        def action_controller_session
+          controller_session
+        end
       end
     end
 
@@ -234,16 +234,41 @@ module MuchRails::Action
         active: "true",
       }
     end
-    let(:current_session1){ "CURRENT SESSION 1" }
-    let(:request1){ "REQUEST 1" }
+    let(:request1){ FakeRequest.new }
 
-    should have_readers :params, :current_session, :request, :errors
+    should have_readers :params, :request, :errors
+    should have_writers :controller_session
     should have_imeths :on_call, :valid_action?, :successful_action?
 
     should "know its attributes" do
       assert_that(subject.params).equals(params1.with_indifferent_access)
-      assert_that(subject.current_session).equals(current_session1)
       assert_that(subject.request).equals(request1)
+      assert_that(subject.action_controller_session).is_a(FakeSession)
+
+      receiver = receiver_class.new(params: params1)
+      assert_that(receiver.action_controller_session).is_nil
+
+      controller_session = FakeRequest.new
+      receiver.controller_session = controller_session
+      assert_that(receiver.action_controller_session).is(controller_session)
+
+      receiver =
+        receiver_class.new(params: params1, request: FakeRequestWithNoEnv.new)
+      assert_that(receiver.action_controller_session).is_nil
+
+      receiver =
+        receiver_class.new(
+          params: params1,
+          request: FakeRequestWithNoControllerInstance.new,
+        )
+      assert_that(receiver.action_controller_session).is_nil
+
+      receiver =
+        receiver_class.new(
+          params: params1,
+          request: FakeRequestWithNoControllerInstance.new,
+        )
+      assert_that(receiver.action_controller_session).is_nil
     end
 
     should "return the expected Result" do
@@ -409,4 +434,31 @@ module MuchRails::Action
       assert_that(result.errors[:custom_validation]).includes("ERROR1")
     end
   end
+
+  class FakeController
+    def session
+      FakeSession.new
+    end
+  end
+
+  class FakeSession
+  end
+
+  class FakeRequest
+    def env
+      { "action_controller.instance" => FakeController.new }
+    end
+  end
+
+  class FakeRequestWithNoControllerInstance
+    def env
+      { "action_controller.instance" => nil }
+    end
+  end
+
+  class FakeRequestWithNoEnv
+    def env
+      nil
+    end
+  end
 end

data/test/unit/change_action_result_tests.rb

@@ -64,19 +64,27 @@ class MuchRails::ChangeActionResult
   class ValidationMethodsTests < UnitTests
     desc "validation methods"
     subject do
-      unit_class.failure(validation_errors: {
-        name: ["NAME ERROR"],
-        other: ["OTHER ERROR"],
-      })
+      unit_class.failure(
+        validation_errors: {
+          name: ["NAME ERROR"],
+          other: ["OTHER ERROR"],
+          empty: [],
+          none: nil,
+        },
+      )
     end
 
     should "know its attributes" do
       # validation_errors
       assert_that(subject.validation_errors)
         .equals({
-          name: ["NAME ERROR"],
-          other: ["OTHER ERROR"],
+          "name" => ["NAME ERROR"],
+          "other" => ["OTHER ERROR"],
+          "empty" => [],
+          "none" => [nil],
         })
+      assert_that(subject.validation_errors[:name]).equals(["NAME ERROR"])
+      assert_that(subject.validation_errors["name"]).equals(["NAME ERROR"])
 
       # validation_error_messages
       assert_that(subject.validation_error_messages)
@@ -88,8 +96,14 @@ class MuchRails::ChangeActionResult
       # extract_validation_error
       assert_that(subject.extract_validation_error(:name))
         .equals(["NAME ERROR"])
-      assert_that(subject.extract_validation_error(:other))
+      assert_that(subject.extract_validation_error("other"))
         .equals(["OTHER ERROR"])
+      assert_that(subject.extract_validation_error(:empty))
+        .equals([])
+      assert_that(subject.extract_validation_error("none"))
+        .equals([])
+      assert_that(subject.extract_validation_error(:unknown))
+        .equals([])
       assert_that(subject.validation_errors).is_empty
 
       # any_unextracted_validation_errors?

data/test/unit/change_action_tests.rb

@@ -57,14 +57,7 @@ module MuchRails::ChangeAction
 
   class InitTests < ReceiverTests
     desc "when init"
-    subject{ receiver_class.new(params: {}) }
-    subject do
-      receiver_class.new(
-        params: {},
-        current_session: nil,
-        request: nil,
-      )
-    end
+    subject{ receiver_class.new(params: {}, request: nil) }
 
     setup do
       Assert.stub(subject, :any_unextracted_change_result_validation_errors?) do
@@ -84,13 +77,7 @@ module MuchRails::ChangeAction
 
   class RecordErrorsWithResultExceptionTests < InitTests
     desc "with record errors and a result exception"
-    subject do
-      receiver_class.new(
-        params: {},
-        current_session: nil,
-        request: nil,
-      )
-    end
+    subject{ receiver_class.new(params: {}, request: nil) }
 
     setup do
       Assert.stub(subject, :any_unextracted_change_result_validation_errors?) do
@@ -118,13 +105,7 @@ module MuchRails::ChangeAction
 
   class RecordErrorsWithNoResultExceptionTests < InitTests
     desc "with record errors and no result exception"
-    subject do
-      receiver_class.new(
-        params: {},
-        current_session: nil,
-        request: nil,
-      )
-    end
+    subject{ receiver_class.new(params: {}, request: nil) }
 
     setup do
       Assert.stub(subject, :any_unextracted_change_result_validation_errors?) do
@@ -149,13 +130,7 @@ module MuchRails::ChangeAction
 
   class ChangeResultMethodTests < InitTests
     desc "#change_result method"
-    subject do
-      receiver_class.new(
-        params: {},
-        current_session: nil,
-        request: nil,
-      )
-    end
+    subject{ receiver_class.new(params: {}, request: nil) }
 
     should "memoize and return the expected Result" do
       result = subject.change_result
@@ -178,13 +153,7 @@ module MuchRails::ChangeAction
 
   class AnyUnextractedChangeResultValidationErrorsMethodTests < ReceiverTests
     desc "#any_unextracted_change_result_validation_errors? method"
-    subject do
-      receiver_class.new(
-        params: {},
-        current_session: nil,
-        request: nil,
-      )
-    end
+    subject{ receiver_class.new(params: {}, request: nil) }
 
     let(:receiver_class) do
       Class.new do
@@ -205,13 +174,7 @@ module MuchRails::ChangeAction
   class NoValidationErrorsTests <
           AnyUnextractedChangeResultValidationErrorsMethodTests
     desc "with no validation errors"
-    subject do
-      receiver_class.new(
-        params: {},
-        current_session: nil,
-        request: nil,
-      )
-    end
+    subject{ receiver_class.new(params: {}, request: nil) }
 
     let(:receiver_class) do
       Class.new do
@@ -232,13 +195,7 @@ module MuchRails::ChangeAction
   class ValidationErrorsTests <
           AnyUnextractedChangeResultValidationErrorsMethodTests
     desc "with validation errors"
-    subject do
-      receiver_class.new(
-        params: {},
-        current_session: nil,
-        request: nil,
-      )
-    end
+    subject{ receiver_class.new(params: {}, request: nil) }
 
     let(:receiver_class) do
       Class.new do

data/test/unit/destroy_action_tests.rb

@@ -50,13 +50,7 @@ module MuchRails::DestroyAction
 
   class InitTests < ReceiverTests
     desc "when init"
-    subject do
-      receiver_class.new(
-        params: {},
-        current_session: nil,
-        request: nil,
-      )
-    end
+    subject{ receiver_class.new(params: {}, request: nil) }
 
     should have_imeths :destroy_result
 

data/test/unit/destroy_service_tests.rb

@@ -73,6 +73,7 @@ module MuchRails::DestroyService
         RuntimeError.new(Factory.string),
         ArgumentError.new(Factory.string),
         MuchRails::Records::DestructionInvalid.new(FakeRecord.new),
+        MuchRails::InvalidError.new,
       ]
     end
     let(:exception_classes){ exceptions.map(&:class) }
@@ -102,6 +103,8 @@ module MuchRails::DestroyService
         .is_an_instance_of(MuchRails::ServiceValidationErrors)
       assert_that(subject.service_validation_errors.exception_classes)
         .includes(MuchRails::Records::DestructionInvalid)
+      assert_that(subject.service_validation_errors.exception_classes)
+        .includes(MuchRails::InvalidError)
     end
   end
 
@@ -185,6 +188,22 @@ module MuchRails::DestroyService
     end
   end
 
+  class ValidationErrorsResultForInvalidErrorTests < ValidationErrorsTests
+    desc "when .result_for is passed an MuchRails::InvalidError"
+
+    let(:exception){ MuchRails::InvalidError.new }
+
+    should "return a failure result with the record and validation errors" do
+      result = subject.result_for(exception)
+
+      assert_that(result.failure?).is_true
+      assert_that(result.exception).equals(exception)
+      assert_that(result.validation_errors).equals(exception.errors)
+      assert_that(result.validation_error_messages)
+        .equals(exception.error_messages)
+    end
+  end
+
   class FailureResultTests < UnitTests
     desc "FailureResult"
     subject{ unit_class::FailureResult }

data/test/unit/invalid_error_tests.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+require "assert"
+require "much-rails/invalid_error"
+
+class MuchRails::InvalidError
+  class UnitTests < Assert::Context
+    desc "MuchRails::InvalidError"
+    subject{ unit_class }
+
+    let(:unit_class){ MuchRails::InvalidError }
+
+    should "be configured as expected" do
+      assert_that(subject < StandardError).is_true
+    end
+  end
+
+  class InitSetupTests < UnitTests
+    desc "when init"
+    subject{ unit_class.new }
+
+    should have_readers :errors
+    should have_imeths :error_messages
+
+    should "know its attributes" do
+      assert_that(subject.backtrace).is_nil
+      assert_that(subject.errors).equals({})
+      assert_that(subject.message).equals(subject.errors.inspect)
+      assert_that(subject.error_messages).equals([])
+
+      backtrace = Array.new(Factory.integer(3)){ Factory.path }
+      errors =
+        {
+          field1: ["ERROR 1A", "ERROR 2B"],
+          field2: "ERROR 2A",
+        }
+      exception = unit_class.new(backtrace: backtrace, **errors)
+      assert_that(exception.backtrace).equals(backtrace)
+      assert_that(exception.errors).equals(errors)
+      assert_that(exception.message).equals(exception.errors.inspect)
+      assert_that(exception.error_messages)
+        .equals(["field1: ERROR 1A and ERROR 2B", "field2: ERROR 2A"])
+    end
+  end
+end

data/test/unit/save_action_tests.rb

@@ -50,13 +50,7 @@ module MuchRails::SaveAction
 
   class InitTests < ReceiverTests
     desc "when init"
-    subject do
-      receiver_class.new(
-        params: {},
-        current_session: nil,
-        request: nil,
-      )
-    end
+    subject{ receiver_class.new(params: {}, request: nil) }
 
     should have_imeths :save_result
 

data/test/unit/save_service_tests.rb

@@ -73,6 +73,7 @@ module MuchRails::SaveService
         RuntimeError.new(Factory.string),
         ArgumentError.new(Factory.string),
         ActiveRecord::RecordInvalid.new(FakeRecord.new),
+        MuchRails::InvalidError.new,
       ]
     end
     let(:exception_classes){ exceptions.map(&:class) }
@@ -102,6 +103,8 @@ module MuchRails::SaveService
         .is_an_instance_of(MuchRails::ServiceValidationErrors)
       assert_that(subject.service_validation_errors.exception_classes)
         .includes(ActiveRecord::RecordInvalid)
+      assert_that(subject.service_validation_errors.exception_classes)
+        .includes(MuchRails::InvalidError)
     end
   end
 
@@ -197,6 +200,22 @@ module MuchRails::SaveService
     end
   end
 
+  class ValidationErrorsResultForInvalidErrorTests < ValidationErrorsTests
+    desc "when .result_for is passed an MuchRails::InvalidError"
+
+    let(:exception){ MuchRails::InvalidError.new }
+
+    should "return a failure result with the record and validation errors" do
+      result = subject.result_for(exception)
+
+      assert_that(result.failure?).is_true
+      assert_that(result.exception).equals(exception)
+      assert_that(result.validation_errors).equals(exception.errors)
+      assert_that(result.validation_error_messages)
+        .equals(exception.error_messages)
+    end
+  end
+
   class FailureResultTests < UnitTests
     desc "FailureResult"
     subject{ unit_class::FailureResult }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: much-rails
 version: !ruby/object:Gem::Version
-  version: 0.2.7
+  version: 0.4.2
 platform: ruby
 authors:
 - Kelly Redding
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-12 00:00:00.000000000 Z
+date: 2021-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: much-style-guide
@@ -105,14 +105,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.15.2
+        version: 0.15.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.15.2
+        version: 0.15.3
 - !ruby/object:Gem::Dependency
   name: dassets-erubi
   requirement: !ruby/object:Gem::Requirement
@@ -277,6 +277,7 @@ files:
 - lib/much-rails/destroy_service.rb
 - lib/much-rails/has_slug.rb
 - lib/much-rails/input_value.rb
+- lib/much-rails/invalid_error.rb
 - lib/much-rails/json.rb
 - lib/much-rails/layout.rb
 - lib/much-rails/layout/helper.rb
@@ -304,6 +305,7 @@ files:
 - test/helper.rb
 - test/support/actions/show.rb
 - test/support/config/routes/test.rb
+- test/support/config/routes/test/subrouter.rb
 - test/support/factory.rb
 - test/support/fake_action_controller.rb
 - test/system/.keep
@@ -333,6 +335,7 @@ files:
 - test/unit/destroy_service_tests.rb
 - test/unit/has_slug_tests.rb
 - test/unit/input_value_tests.rb
+- test/unit/invalid_error_tests.rb
 - test/unit/json_tests.rb
 - test/unit/layout_tests.rb
 - test/unit/mixin_tests.rb
@@ -379,6 +382,7 @@ test_files:
 - test/helper.rb
 - test/support/actions/show.rb
 - test/support/config/routes/test.rb
+- test/support/config/routes/test/subrouter.rb
 - test/support/factory.rb
 - test/support/fake_action_controller.rb
 - test/system/.keep
@@ -408,6 +412,7 @@ test_files:
 - test/unit/destroy_service_tests.rb
 - test/unit/has_slug_tests.rb
 - test/unit/input_value_tests.rb
+- test/unit/invalid_error_tests.rb
 - test/unit/json_tests.rb
 - test/unit/layout_tests.rb
 - test/unit/mixin_tests.rb