much-rails 0.2.3 → 0.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f4834b7655c265c28bb9f46729491681daa8003dd99615c2074f27a010f22e10
-  data.tar.gz: 70603cc1bd5717a2edf35ff23cf2fa50ae35dc494431e2fbc476388af8c3d6a1
+  metadata.gz: 4b16874b1abd3bada37a15e501101bf2b1f3b0f49949e939078a06fe5df861ee
+  data.tar.gz: abf58e64838b2a14a2a2b3d243f6fb601dbe93fb1537f00a9cfca12e09c2c16a
 SHA512:
-  metadata.gz: d3e614697001a8f9dd5d09a78dcfa3c5e4f6fb458406a7af6c018d7a829687b74c1a98c673ef3e62ec8f7a28f85e4a59f4b3bd7c01ccb95b4ff0d661f569cb61
-  data.tar.gz: dcd670e7ca04b1394a92a8a9a7a55b31fd825f5f99bf0282a18d4907e7f614536f30195756ceda6b4320a2fec0d073caf96ab5b74aa57428e4331a1c73381cd7
+  metadata.gz: 3a971f04f2f90b7c5adc8284d7fe7b6ff11a115d637183921c6bc2f12867e226f6ce741513068cf9418f6094778e9b2adf27e74fafaf11fcf3e621913271058f
+  data.tar.gz: c0ba8ef4a6242a9e0d1ccfe56d1d6b1a6aeec49f994e47e9d4c52553bc13f6311fe3f5e2a41ce7105c30b3d7bbac79f68399d6e2f75b5bbfbde85aad6d457b23

data/lib/much-rails/action.rb

@@ -31,7 +31,7 @@ module MuchRails::Action
 
     add_config :much_rails_action
 
-    attr_reader :params, :current_user, :request, :errors
+    attr_reader :params, :current_session, :request, :errors
   end
 
   mixin_class_methods do
@@ -107,17 +107,14 @@ module MuchRails::Action
 
     def default_action_template_name
       @default_action_template_name ||=
-        to_s
-          .remove(/\A#{MuchRails.config.action.namespace}/)
-          .tableize
-          .singularize
+        to_s.remove(/\A#{MuchRails.config.action.namespace}/).underscore
     end
   end
 
   mixin_instance_methods do
-    def initialize(params: nil, current_user: nil, request: nil)
+    def initialize(params: nil, current_session: nil, request: nil)
       @params = params.to_h.with_indifferent_access
-      @current_user = current_user
+      @current_session = current_session
       @request = request
       @errors = Hash.new{ |hash, key| hash[key] = [] }
     end
@@ -257,6 +254,10 @@ module MuchRails::Action
           template: template || default_action_template_name,
         }.merge(**kargs)
 
+      if view_model&.respond_to?(:much_rails_action=)
+        view_model.much_rails_action = self
+      end
+
       @much_rails_action_result =
         MuchRails::Action::RenderResult.new(view_model, *args, **result_kargs)
       halt

data/lib/much-rails/action/base_router.rb

@@ -70,8 +70,8 @@ class MuchRails::Action::BaseRouter
   #       url :users, "/users", "Users::Index"
   #     }
   #   AdminRouter.path_for(:users) # => "/admin/users"
-  def path_for(name, *args)
-    @url_set.path_for(name, *args)
+  def path_for(name, **kargs)
+    @url_set.path_for(name, **kargs)
   end
 
   # Example:
@@ -87,8 +87,8 @@ class MuchRails::Action::BaseRouter
   #       url :users, "/users", "Users::Index"
   #     }
   #   AdminRouter.url_for(:users) # => "http://example.org/admin/users"
-  def url_for(name, *args)
-    @url_set.url_for(name, *args)
+  def url_for(name, **kargs)
+    @url_set.url_for(name, **kargs)
   end
 
   # Example:
@@ -149,7 +149,7 @@ class MuchRails::Action::BaseRouter
   #       get    "/new",    "Root::New"
   #       post   "/",       "Root::Create"
   #       get    "/edit",   "Root::Edit"
-  #       put    "/",       "Root::Update"
+  #       put    "/",       "Root::Upsert"
   #       patch  "/",       "Root::Update"
   #       get    "/remove", "Root::Remove"
   #       delete "/",       "Root::Destroy"
@@ -301,6 +301,14 @@ class MuchRails::Action::BaseRouter
       def constraints_lambda
         request_type.constraints_lambda
       end
+
+      def class_constant
+        @class_constant ||= class_name.constantize
+      end
+
+      def format
+        class_constant.format
+      end
     end
 
   class URLSet
@@ -350,12 +358,12 @@ class MuchRails::Action::BaseRouter
       end
     end
 
-    def path_for(name, *args)
-      fetch(name).path_for(*args)
+    def path_for(name, **kargs)
+      fetch(name).path_for(**kargs)
     end
 
-    def url_for(name, *args)
-      fetch(name).url_for(*args)
+    def url_for(name, **kargs)
+      fetch(name).url_for(**kargs)
     end
   end
 
@@ -396,11 +404,11 @@ class MuchRails::Action::BaseRouter
       self.class.url_path(@router, @url_path)
     end
 
-    def path_for(*args)
+    def path_for(**kargs)
       raise NotImplementedError
     end
 
-    def url_for(*args)
+    def url_for(**kargs)
       raise NotImplementedError
     end
 
@@ -460,6 +468,16 @@ class MuchRails::Action::BaseRouter
       !@default_action_class_name.nil?
     end
 
+    def default_action_class_constant
+      return unless has_default_action_class_name?
+
+      @default_action_class_constant ||= default_action_class_name.constantize
+    end
+
+    def default_action_format
+      default_action_class_constant&.format
+    end
+
     def ==(other)
       return super unless other.is_a?(self.class)
 

data/lib/much-rails/action/controller.rb

@@ -32,7 +32,7 @@ module MuchRails::Action::Controller
           result =
             much_rails_action_class.call(
               params: much_rails_action_params,
-              current_user: current_user,
+              current_session: current_session,
               request: request,
             )
           instance_exec(result, &result.execute_block)

data/lib/much-rails/action/router.rb

@@ -52,16 +52,19 @@ class MuchRails::Action::Router < MuchRails::Action::BaseRouter
     draw_url_to   = "#{controller_name}##{CONTROLLER_NOT_FOUND_METHOD_NAME}"
     draw_route_to = "#{controller_name}##{CONTROLLER_CALL_ACTION_METHOD_NAME}"
 
+    definition_names = Set.new
+
     definitions.each do |definition|
       definition.request_type_actions.each do |request_type_action|
         application_routes_draw_scope.public_send(
           definition.http_method,
           definition.path,
           to: draw_route_to,
-          as: definition.name,
+          as: (definition.name if definition_names.add?(definition.name)),
           defaults:
             definition.default_params.merge({
               ACTION_CLASS_PARAM_NAME => request_type_action.class_name,
+              "format" => request_type_action.format,
             }),
           constraints: request_type_action.constraints_lambda,
         )
@@ -73,10 +76,11 @@ class MuchRails::Action::Router < MuchRails::Action::BaseRouter
         definition.http_method,
         definition.path,
         to: draw_route_to,
-        as: definition.name,
+        as: (definition.name if definition_names.add?(definition.name)),
         defaults:
           definition.default_params.merge({
             ACTION_CLASS_PARAM_NAME => definition.default_action_class_name,
+            "format" => definition.default_action_format,
           }),
       )
     end
@@ -90,12 +94,18 @@ class MuchRails::Action::Router < MuchRails::Action::BaseRouter
   alias_method :draw, :apply_to
 
   class URL < MuchRails::Action::BaseRouter::BaseURL
-    def path_for(*args)
-      MuchRails::RailsRoutes.instance.public_send("#{name}_path", *args)
+    def path_for(**kargs)
+      MuchRails::RailsRoutes.instance.public_send(
+        "#{name}_path",
+        **kargs.symbolize_keys.except(:format),
+      )
     end
 
-    def url_for(*args)
-      MuchRails::RailsRoutes.instance.public_send("#{name}_url", *args)
+    def url_for(**kargs)
+      MuchRails::RailsRoutes.instance.public_send(
+        "#{name}_url",
+        **kargs.symbolize_keys.except(:format),
+      )
     end
   end
 end

data/lib/much-rails/input_value.rb

@@ -7,7 +7,7 @@ module MuchRails::InputValue
   def self.strip(value)
     return if value.blank?
 
-    value.to_s.strip
+    value.to_s.strip.presence
   end
 
   def self.strip_all(values)

data/lib/much-rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MuchRails
-  VERSION = "0.2.3"
+  VERSION = "0.2.8"
 end

data/much-rails.gemspec

@@ -37,6 +37,6 @@ Gem::Specification.new do |gem|
   gem.add_dependency("much-mixin",     ["~> 0.2.4"])
   gem.add_dependency("much-not-given", ["~> 0.1.2"])
   gem.add_dependency("much-result",    ["~> 0.1.3"])
-  gem.add_dependency("much-slug",      ["~> 0.1.1"])
+  gem.add_dependency("much-slug",      ["~> 0.1.2"])
   gem.add_dependency("oj",             ["~> 3.10"])
 end

data/test/support/actions/show.rb

@@ -7,5 +7,7 @@ module Actions; end
 module Actions::Show
   include MuchRails::Action
 
+  format :html
+
   params_root :nested
 end

data/test/unit/action/base_router_tests.rb

@@ -80,13 +80,13 @@ class MuchRails::Action::BaseRouter
     end
 
     should "build path/URL strings for named URLs" do
-      path_string = subject.path_for(:url1, "TEST PATH ARGS")
+      path_string = subject.path_for(:url1, test: "args")
       assert_that(path_string).equals("TEST PATH STRING")
-      assert_that(@url_set_path_for_call.args).equals([:url1, "TEST PATH ARGS"])
+      assert_that(@url_set_path_for_call.args).equals([:url1, { test: "args" }])
 
-      url_string = subject.url_for(:url1, "TEST URL ARGS")
+      url_string = subject.url_for(:url1, test: "args")
       assert_that(url_string).equals("TEST URL STRING")
-      assert_that(@url_set_url_for_call.args).equals([:url1, "TEST URL ARGS"])
+      assert_that(@url_set_url_for_call.args).equals([:url1, { test: "args" }])
     end
 
     should "define request types" do
@@ -296,20 +296,30 @@ class MuchRails::Action::BaseRouter
     desc "when init"
     subject{ request_type_action_class.new(request_type1, action_class_name1) }
 
+    setup do
+      Assert.stub(action_class_name1, :constantize){ action_class1 }
+    end
+
     let(:name1){ Factory.symbol }
     let(:constraints_lambda1){ ->(request){} }
     let(:request_type1) do
       unit_class::RequestType.new(name1, constraints_lambda1)
     end
     let(:action_class_name1){ Factory.string }
+    let(:action_class1) do
+      Struct.new(:format).new([:html, :any].sample)
+    end
 
     should have_imeths :request_type, :class_name, :constraints_lambda
+    should have_imeths :class_constant, :format
 
     should "know its attributes" do
       assert_that(subject.request_type).equals(request_type1)
       assert_that(subject.class_name).equals(action_class_name1)
       assert_that(subject.constraints_lambda)
         .equals(request_type1.constraints_lambda)
+      assert_that(subject.class_constant).equals(action_class1)
+      assert_that(subject.format).equals(subject.class_constant.format)
     end
   end
 
@@ -380,13 +390,13 @@ class MuchRails::Action::BaseRouter
 
       subject.add(:url1, Factory.url)
 
-      path_string = subject.path_for(:url1, "TEST PATH ARGS")
+      path_string = subject.path_for(:url1, test: "args")
       assert_that(path_string).equals("TEST PATH STRING")
-      assert_that(@url_path_for_call.args).equals(["TEST PATH ARGS"])
+      assert_that(@url_path_for_call.args).equals([{ test: "args" }])
 
-      url_string = subject.url_for(:url1, "TEST URL ARGS")
+      url_string = subject.url_for(:url1, test: "args")
       assert_that(url_string).equals("TEST URL STRING")
-      assert_that(@url_url_for_call.args).equals(["TEST URL ARGS"])
+      assert_that(@url_url_for_call.args).equals([{ test: "args" }])
     end
   end
 
@@ -450,8 +460,8 @@ class MuchRails::Action::BaseRouter
       assert_that(subject.path)
         .equals(base_url_class.url_path(router1, url_path1))
 
-      assert_that{ subject.path_for("TEST ARGS") }.raises(NotImplementedError)
-      assert_that{ subject.url_for("TEST ARGS") }.raises(NotImplementedError)
+      assert_that{ subject.path_for(test: "args") }.raises(NotImplementedError)
+      assert_that{ subject.url_for(test: "args") }.raises(NotImplementedError)
     end
   end
 
@@ -506,6 +516,15 @@ class MuchRails::Action::BaseRouter
       )
     end
 
+    setup do
+      Assert.stub(default_action_class_name1, :constantize) do
+        default_action_class1
+      end
+    end
+
+    let(:default_action_class1) do
+      Struct.new(:format).new([:html, :any].sample)
+    end
     let(:default_params1) do
       { Factory.string => Factory.string }
     end
@@ -514,6 +533,7 @@ class MuchRails::Action::BaseRouter
     should have_readers :default_action_class_name, :request_type_actions
     should have_readers :called_from
     should have_imeths :path, :name, :has_default_action_class_name?
+    should have_imeths :default_action_class_constant, :default_action_format
 
     should "know its attributes" do
       assert_that(subject.http_method).equals(http_method1)
@@ -525,6 +545,10 @@ class MuchRails::Action::BaseRouter
       assert_that(subject.called_from).equals(caller1)
       assert_that(subject.path).equals(url_path1)
       assert_that(subject.name).equals(url_name1)
+      assert_that(subject.default_action_class_constant)
+        .equals(default_action_class1)
+      assert_that(subject.default_action_format)
+        .equals(subject.default_action_class_constant.format)
     end
   end
 end

data/test/unit/action/controller_tests.rb

@@ -35,6 +35,10 @@ module MuchRails::Action::Controller
     desc "when init"
     subject{ receiver_class.new(params1) }
 
+    setup do
+      Assert.stub(::Actions::Show, :format){ nil }
+    end
+
     let(:params1) do
       {
         MuchRails::Action::Router::ACTION_CLASS_PARAM_NAME => "Actions::Show",
@@ -75,10 +79,9 @@ module MuchRails::Action::Controller
 
       assert_that(subject.much_rails_action_class).equals(Actions::Show)
 
-      Actions::Show.format(:html)
+      Assert.stub(::Actions::Show, :format){ :html }
       receiver = receiver_class.new(params1)
       assert_that(receiver.much_rails_action_class_format).equals(:html)
-      Actions::Show.format(nil)
     end
   end
 

data/test/unit/action/router_tests.rb

@@ -104,7 +104,10 @@ class MuchRails::Action::Router
         "#{subject.controller_name}"\
         "##{unit_class::CONTROLLER_CALL_ACTION_METHOD_NAME}"
       expected_default_defaults =
-        { unit_class::ACTION_CLASS_PARAM_NAME => default_class_name }
+        {
+          unit_class::ACTION_CLASS_PARAM_NAME => default_class_name,
+          "format" => :html,
+        }
 
       assert_that(application_routes.get_calls.size).equals(3)
       assert_that(application_routes.get_calls[0].pargs).equals([url_path])
@@ -113,14 +116,17 @@ class MuchRails::Action::Router
           to: expected_draw_route_to,
           as: url_name,
           defaults:
-            { unit_class::ACTION_CLASS_PARAM_NAME => request_type_class_name },
+            {
+              unit_class::ACTION_CLASS_PARAM_NAME => request_type_class_name,
+              "format" => :html,
+            },
           constraints: request_type_proc,
         )
       assert_that(application_routes.get_calls[1].pargs).equals([url_path])
       assert_that(application_routes.get_calls[1].kargs)
         .equals(
           to: expected_draw_route_to,
-          as: url_name,
+          as: nil,
           defaults: expected_default_defaults,
         )
       assert_that(application_routes.get_calls[2].pargs).equals([url2_path])
@@ -135,7 +141,7 @@ class MuchRails::Action::Router
       assert_that(application_routes.post_calls.last.kargs)
         .equals(
           to: expected_draw_route_to,
-          as: url_name,
+          as: nil,
           defaults: expected_default_defaults,
         )
 
@@ -153,7 +159,7 @@ class MuchRails::Action::Router
       assert_that(application_routes.patch_calls.last.kargs)
         .equals(
           to: expected_draw_route_to,
-          as: url_name,
+          as: nil,
           defaults: expected_default_defaults,
         )
 
@@ -162,7 +168,7 @@ class MuchRails::Action::Router
       assert_that(application_routes.delete_calls.last.kargs)
         .equals(
           to: expected_draw_route_to,
-          as: url_name,
+          as: nil,
           defaults: expected_default_defaults,
         )
     end
@@ -206,15 +212,15 @@ class MuchRails::Action::Router
     should have_imeths :path_for, :url_for
 
     should "know its attributes" do
-      path_string = subject.path_for("TEST PATH ARGS")
+      path_string = subject.path_for(test: "args", format: "html")
       assert_that(path_string).equals("TEST PATH OR URL STRING")
       assert_that(@rails_routes_method_missing_call.args)
-        .equals(["#{url_name1}_path".to_sym, "TEST PATH ARGS"])
+        .equals(["#{url_name1}_path".to_sym, { test: "args" }])
 
-      url_string = subject.url_for("TEST URL ARGS")
+      url_string = subject.url_for(test: "args", format: "xml")
       assert_that(url_string).equals("TEST PATH OR URL STRING")
       assert_that(@rails_routes_method_missing_call.args)
-        .equals(["#{url_name1}_url".to_sym, "TEST URL ARGS"])
+        .equals(["#{url_name1}_url".to_sym, { test: "args" }])
     end
   end
 

data/test/unit/action_tests.rb

@@ -167,7 +167,7 @@ module MuchRails::Action
       assert_that(subject.default_action_template_name)
         .equals(
           "some/namespace/for/"\
-          "#{MuchRails.config.action.namespace.tableize.singularize}"\
+          "#{MuchRails.config.action.namespace.underscore}"\
           "thing/show",
         )
     end
@@ -178,7 +178,7 @@ module MuchRails::Action
     subject do
       receiver_class.new(
         params: params1,
-        current_user: current_user1,
+        current_session: current_session1,
         request: request1,
       )
     end
@@ -234,15 +234,15 @@ module MuchRails::Action
         active: "true",
       }
     end
-    let(:current_user1){ "CURRENT USER 1" }
+    let(:current_session1){ "CURRENT SESSION 1" }
     let(:request1){ "REQUEST 1" }
 
-    should have_readers :params, :current_user, :request, :errors
+    should have_readers :params, :current_session, :request, :errors
     should have_imeths :on_call, :valid_action?, :successful_action?
 
     should "know its attributes" do
       assert_that(subject.params).equals(params1.with_indifferent_access)
-      assert_that(subject.current_user).equals(current_user1)
+      assert_that(subject.current_session).equals(current_session1)
       assert_that(subject.request).equals(request1)
     end
 
@@ -318,6 +318,7 @@ module MuchRails::Action
           layout: false,
         )
 
+      view_model = Object.new
       receiver_class.on_call do
         render(view_model, "some/view/template", layout: false)
       end
@@ -330,18 +331,29 @@ module MuchRails::Action
           layout: false,
         )
 
+      view_model =
+        Class
+          .new{
+            def much_rails_action
+              "NOT A MUCH RAILS ACTION"
+            end
+          }
+          .new
       receiver_class.on_call do
         render(view_model, "some/view/template", template: "other/template")
       end
       action = receiver_class.new(params: params1)
       result = action.call
       assert_that(result.render_view_model).is(view_model)
+      assert_that(result.render_view_model.much_rails_action).is_not(action)
       assert_that(result.render_kargs).equals(template: "other/template")
 
+      view_model = Struct.new(:much_rails_action).new(nil)
       receiver_class.on_call{ render(view_model, template: "other/template") }
       action = receiver_class.new(params: params1)
       result = action.call
       assert_that(result.render_view_model).is(view_model)
+      assert_that(result.render_view_model.much_rails_action).is(action)
       assert_that(result.render_kargs).equals(template: "other/template")
     end
 

data/test/unit/change_action_tests.rb

@@ -61,7 +61,7 @@ module MuchRails::ChangeAction
     subject do
       receiver_class.new(
         params: {},
-        current_user: nil,
+        current_session: nil,
         request: nil,
       )
     end
@@ -87,7 +87,7 @@ module MuchRails::ChangeAction
     subject do
       receiver_class.new(
         params: {},
-        current_user: nil,
+        current_session: nil,
         request: nil,
       )
     end
@@ -121,7 +121,7 @@ module MuchRails::ChangeAction
     subject do
       receiver_class.new(
         params: {},
-        current_user: nil,
+        current_session: nil,
         request: nil,
       )
     end
@@ -152,7 +152,7 @@ module MuchRails::ChangeAction
     subject do
       receiver_class.new(
         params: {},
-        current_user: nil,
+        current_session: nil,
         request: nil,
       )
     end
@@ -181,7 +181,7 @@ module MuchRails::ChangeAction
     subject do
       receiver_class.new(
         params: {},
-        current_user: nil,
+        current_session: nil,
         request: nil,
       )
     end
@@ -208,7 +208,7 @@ module MuchRails::ChangeAction
     subject do
       receiver_class.new(
         params: {},
-        current_user: nil,
+        current_session: nil,
         request: nil,
       )
     end
@@ -235,7 +235,7 @@ module MuchRails::ChangeAction
     subject do
       receiver_class.new(
         params: {},
-        current_user: nil,
+        current_session: nil,
         request: nil,
       )
     end

data/test/unit/destroy_action_tests.rb

@@ -53,7 +53,7 @@ module MuchRails::DestroyAction
     subject do
       receiver_class.new(
         params: {},
-        current_user: nil,
+        current_session: nil,
         request: nil,
       )
     end

data/test/unit/input_value_tests.rb

@@ -9,12 +9,21 @@ module MuchRails::InputValue
     subject{ unit_class }
 
     let(:unit_class){ MuchRails::InputValue }
+    let(:non_blank_but_empty_to_s_object) do
+      Class
+        .new{
+          def to_s
+            ["", " "].sample
+          end
+        }
+        .new
+    end
 
     should have_imeths :strip, :strip_all
 
     should "know its attributes" do
       # strip
-      input_value = [nil, "", " "].sample
+      input_value = [nil, "", " ", non_blank_but_empty_to_s_object].sample
       assert_that(subject.strip(input_value)).is_nil
 
       input_value = [" VALUE  ", "\r VALUE\n"].sample

data/test/unit/save_action_tests.rb

@@ -53,7 +53,7 @@ module MuchRails::SaveAction
     subject do
       receiver_class.new(
         params: {},
-        current_user: nil,
+        current_session: nil,
         request: nil,
       )
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: much-rails
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.8
 platform: ruby
 authors:
 - Kelly Redding
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-08 00:00:00.000000000 Z
+date: 2021-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: much-style-guide
@@ -217,14 +217,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 0.1.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 0.1.2
 - !ruby/object:Gem::Dependency
   name: oj
   requirement: !ruby/object:Gem::Requirement