much-rails 0.2.1 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d5a9113cb9c28d12b0bcffbf5df47f43c2efe956dcb3eae246643461029af788
-  data.tar.gz: 95d5050085a06b6b747217b61d04197972948de584f48125bad8c858896913dc
+  metadata.gz: 604eda47d3d5c2f66e52716269d3652f8799c022187829e83c2815fcf22dfd11
+  data.tar.gz: f765d10688da5b2a2aeb8827532806cf2c92a2bdf54fe8aedb2bcefc8304ffae
 SHA512:
-  metadata.gz: 9699a1c4fede48c47b4e7e47148a3dc256b0d3ee29d8b681041614719b9d734946fc001599704f26237637bacaf204013ed01b5c8ff72d3cbceeb049bb5ea407
-  data.tar.gz: c550915e3af0b1142e73ad28b60e2e6944f5d789e769bbc31dcd35f07ace0ed16ba1bb18f253b8392b53b363167da70b33539589448d73bc1e21992341748768
+  metadata.gz: 2170ba5582c6f6eb88011b2188bcd69f89c57b05d0df8a56ab26678ab52409cda999cac0b129d1606a70770414d067f09d3b7c8702df6e451f89c40bb9079452
+  data.tar.gz: a92cc7b6571d14e755ba60c4156c2daffe142c86c2204a60869c7d5f56130d7d265480884adc9a03dee4e90bdc07e148319593c53e900eefde62a32488c3bdf8

data/lib/much-rails.rb

@@ -4,6 +4,7 @@ require "active_support"
 require "active_support/core_ext"
 
 require "much-rails/version"
+require "much-rails/abstract_class"
 require "much-rails/action"
 require "much-rails/boolean"
 require "much-rails/call_method"

data/lib/much-rails/abstract_class.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require "much-rails/mixin"
+
+# MuchRails::AbstractClass overrides the `new` class method to prevent a class
+# from being instantiated directly.
+module MuchRails::AbstractClass
+  include MuchRails::Mixin
+
+  after_mixin_included do
+    self.abstract_class = self
+
+    define_singleton_method(:new) do |*args, &block|
+      if abstract_class?
+        raise(
+          NotImplementedError,
+          "#{self} is an abstract class and cannot be instantiated.",
+        )
+      end
+
+      super(*args, &block)
+    end
+  end
+
+  mixin_class_methods do
+    def abstract_class
+      @abstract_class
+    end
+
+    def abstract_class=(value)
+      @abstract_class = value
+    end
+
+    def abstract_class?
+      !!(abstract_class == self)
+    end
+  end
+end

data/lib/much-rails/action/base_router.rb

@@ -70,8 +70,8 @@ class MuchRails::Action::BaseRouter
   #       url :users, "/users", "Users::Index"
   #     }
   #   AdminRouter.path_for(:users) # => "/admin/users"
-  def path_for(name, *args)
-    @url_set.path_for(name, *args)
+  def path_for(name, **kargs)
+    @url_set.path_for(name, **kargs)
   end
 
   # Example:
@@ -87,8 +87,8 @@ class MuchRails::Action::BaseRouter
   #       url :users, "/users", "Users::Index"
   #     }
   #   AdminRouter.url_for(:users) # => "http://example.org/admin/users"
-  def url_for(name, *args)
-    @url_set.url_for(name, *args)
+  def url_for(name, **kargs)
+    @url_set.url_for(name, **kargs)
   end
 
   # Example:
@@ -350,12 +350,12 @@ class MuchRails::Action::BaseRouter
       end
     end
 
-    def path_for(name, *args)
-      fetch(name).path_for(*args)
+    def path_for(name, **kargs)
+      fetch(name).path_for(**kargs)
     end
 
-    def url_for(name, *args)
-      fetch(name).url_for(*args)
+    def url_for(name, **kargs)
+      fetch(name).url_for(**kargs)
     end
   end
 
@@ -396,11 +396,11 @@ class MuchRails::Action::BaseRouter
       self.class.url_path(@router, @url_path)
     end
 
-    def path_for(*args)
+    def path_for(**kargs)
       raise NotImplementedError
     end
 
-    def url_for(*args)
+    def url_for(**kargs)
       raise NotImplementedError
     end
 

data/lib/much-rails/action/router.rb

@@ -90,12 +90,18 @@ class MuchRails::Action::Router < MuchRails::Action::BaseRouter
   alias_method :draw, :apply_to
 
   class URL < MuchRails::Action::BaseRouter::BaseURL
-    def path_for(*args)
-      MuchRails::RailsRoutes.instance.public_send("#{name}_path", *args)
+    def path_for(**kargs)
+      MuchRails::RailsRoutes.instance.public_send(
+        "#{name}_path",
+        **kargs.symbolize_keys,
+      )
     end
 
-    def url_for(*args)
-      MuchRails::RailsRoutes.instance.public_send("#{name}_url", *args)
+    def url_for(**kargs)
+      MuchRails::RailsRoutes.instance.public_send(
+        "#{name}_url",
+        **kargs.symbolize_keys,
+      )
     end
   end
 end

data/lib/much-rails/assets.rb

@@ -12,20 +12,16 @@ end
 module MuchRails::Assets
   def self.configure_for_rails(rails)
     MuchRails::Assets.configure do |config|
-      # Cache fingerprints in memory for performance gains.
-      config.fingerprint_cache MuchRails::Assets::MemCache.new
-
-      # Cache compiled content in memory in development/test for performance
-      # gains since we aren't caching to the file system. Otherwise, don't
-      # cache in memory as we are caching to the file system and won't benefit
-      # from the in memory cache.
-      much_rails_content_cache =
-        if rails.env.development? || rails.env.test?
-          MuchRails::Assets::MemCache.new
-        else
-          MuchRails::Assets::NoCache.new
-        end
-      config.content_cache much_rails_content_cache
+      # Cache fingerprints/content in memory in non-development for performance
+      # gains. Don't cache in memory in developlemnt so changes are reflected
+      # without restarting the server.
+      if !rails.env.development?
+        config.fingerprint_cache MuchRails::Assets::MemCache.new
+        config.content_cache MuchRails::Assets::MemCache.new
+      else
+        config.fingerprint_cache MuchRails::Assets::NoCache.new
+        config.content_cache MuchRails::Assets::NoCache.new
+      end
 
       # Cache out compiled file content to the public folder in non
       # development/test environments.
@@ -33,21 +29,40 @@ module MuchRails::Assets
         config.file_store rails.root.join("public")
       end
 
-      # Look for asset files in the app/assets folder. Support ERB processing
-      # on all .js and .scss files. Support compilation of .scss files.
-      config.source rails.root.join("app", "assets") do |s|
+      # Look for asset files in the app/assets/css folder. Support ERB
+      # on all .scss files. Support compilation of .scss files.
+      config.source rails.root.join("app", "assets", "css") do |s|
+        s.base_path "css"
+
         # Reject SCSS partials
         s.filter do |paths|
           paths.reject{ |p| File.basename(p) =~ /^_.*\.scss$/ }
         end
 
-        s.engine "js",   MuchRails::Assets::Erubi::Engine
         s.engine "scss", MuchRails::Assets::Erubi::Engine
         s.engine "scss", MuchRails::Assets::Sass::Engine, {
           syntax: "scss",
           output_style: "compressed",
         }
       end
+
+      # Look for asset files in the app/assets/img folder.
+      config.source rails.root.join("app", "assets", "img") do |s|
+        s.base_path "img"
+      end
+
+      # Look for asset files in the app/assets/js folder. Support ERB
+      # on all .js files.
+      config.source rails.root.join("app", "assets", "js") do |s|
+        s.base_path "js"
+
+        s.engine "js", MuchRails::Assets::Erubi::Engine
+      end
+
+      # Look for asset files in the app/assets/vendor folder
+      config.source rails.root.join("app", "assets", "vendor") do |s|
+        s.base_path "vendor"
+      end
     end
     MuchRails::Assets.init
   end

data/lib/much-rails/input_value.rb

@@ -7,7 +7,7 @@ module MuchRails::InputValue
   def self.strip(value)
     return if value.blank?
 
-    value.to_s.strip
+    value.to_s.strip.presence
   end
 
   def self.strip_all(values)

data/lib/much-rails/service_validation_errors.rb

@@ -10,7 +10,7 @@ class MuchRails::ServiceValidationErrors
   end
 
   def add(exception_class, &block)
-    unless exception_class < Exception
+    unless exception_class && exception_class < Exception
       raise(ArgumentError, "#{exception_class} is not an Exception")
     end
 

data/lib/much-rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MuchRails
-  VERSION = "0.2.1"
+  VERSION = "0.2.6"
 end

data/much-rails.gemspec

@@ -29,7 +29,7 @@ Gem::Specification.new do |gem|
 
   gem.add_dependency("activerecord",   ["> 5.0", "< 7.0"])
   gem.add_dependency("activesupport",  ["> 5.0", "< 7.0"])
-  gem.add_dependency("dassets",        ["~> 0.15.1"])
+  gem.add_dependency("dassets",        ["~> 0.15.2"])
   gem.add_dependency("dassets-erubi",  ["~> 0.1.1"])
   gem.add_dependency("dassets-sass",   ["~> 0.5.1"])
   gem.add_dependency("much-boolean",   ["~> 0.2.1"])
@@ -37,6 +37,6 @@ Gem::Specification.new do |gem|
   gem.add_dependency("much-mixin",     ["~> 0.2.4"])
   gem.add_dependency("much-not-given", ["~> 0.1.2"])
   gem.add_dependency("much-result",    ["~> 0.1.3"])
-  gem.add_dependency("much-slug",      ["~> 0.1.1"])
+  gem.add_dependency("much-slug",      ["~> 0.1.2"])
   gem.add_dependency("oj",             ["~> 3.10"])
 end

data/test/unit/abstract_class_tests.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+require "assert"
+require "much-rails/abstract_class"
+
+module MuchRails::AbstractClassTest
+  class UnitTests < Assert::Context
+    desc "MuchRails::AbstractClass"
+    subject{ unit_class }
+
+    let(:unit_class){ MuchRails::AbstractClass }
+
+    should "include MuchRails::Mixin" do
+      assert_that(subject).includes(MuchRails::Mixin)
+    end
+  end
+
+  class ReceiverTests < UnitTests
+    desc "receiver"
+    subject{ receiver_class }
+
+    let(:receiver_class) do
+      Class.new.tap{ |c| c.include unit_class }
+    end
+    let(:receiver_subclass) do
+      Class.new(receiver_class)
+    end
+
+    should have_accessor :abstract_class
+    should have_imeths :new, :abstract_class?
+
+    should "know if it is an abstract class or not" do
+      assert_that(subject.abstract_class?).equals(true)
+      assert_that(receiver_subclass.abstract_class?).equals(false)
+    end
+
+    should "prevent calling .new on the receiver" do
+      assert_that{ subject.new }.raises(NotImplementedError)
+    end
+
+    should "allow calling .new on subclasses of the receiver" do
+      assert_that(receiver_subclass.new).is_a?(subject)
+    end
+  end
+end

data/test/unit/action/base_router_tests.rb

@@ -80,13 +80,13 @@ class MuchRails::Action::BaseRouter
     end
 
     should "build path/URL strings for named URLs" do
-      path_string = subject.path_for(:url1, "TEST PATH ARGS")
+      path_string = subject.path_for(:url1, test: "args")
       assert_that(path_string).equals("TEST PATH STRING")
-      assert_that(@url_set_path_for_call.args).equals([:url1, "TEST PATH ARGS"])
+      assert_that(@url_set_path_for_call.args).equals([:url1, { test: "args" }])
 
-      url_string = subject.url_for(:url1, "TEST URL ARGS")
+      url_string = subject.url_for(:url1, test: "args")
       assert_that(url_string).equals("TEST URL STRING")
-      assert_that(@url_set_url_for_call.args).equals([:url1, "TEST URL ARGS"])
+      assert_that(@url_set_url_for_call.args).equals([:url1, { test: "args" }])
     end
 
     should "define request types" do
@@ -380,13 +380,13 @@ class MuchRails::Action::BaseRouter
 
       subject.add(:url1, Factory.url)
 
-      path_string = subject.path_for(:url1, "TEST PATH ARGS")
+      path_string = subject.path_for(:url1, test: "args")
       assert_that(path_string).equals("TEST PATH STRING")
-      assert_that(@url_path_for_call.args).equals(["TEST PATH ARGS"])
+      assert_that(@url_path_for_call.args).equals([{ test: "args" }])
 
-      url_string = subject.url_for(:url1, "TEST URL ARGS")
+      url_string = subject.url_for(:url1, test: "args")
       assert_that(url_string).equals("TEST URL STRING")
-      assert_that(@url_url_for_call.args).equals(["TEST URL ARGS"])
+      assert_that(@url_url_for_call.args).equals([{ test: "args" }])
     end
   end
 
@@ -450,8 +450,8 @@ class MuchRails::Action::BaseRouter
       assert_that(subject.path)
         .equals(base_url_class.url_path(router1, url_path1))
 
-      assert_that{ subject.path_for("TEST ARGS") }.raises(NotImplementedError)
-      assert_that{ subject.url_for("TEST ARGS") }.raises(NotImplementedError)
+      assert_that{ subject.path_for(test: "args") }.raises(NotImplementedError)
+      assert_that{ subject.url_for(test: "args") }.raises(NotImplementedError)
     end
   end
 

data/test/unit/action/router_tests.rb

@@ -206,15 +206,15 @@ class MuchRails::Action::Router
     should have_imeths :path_for, :url_for
 
     should "know its attributes" do
-      path_string = subject.path_for("TEST PATH ARGS")
+      path_string = subject.path_for(test: "args")
       assert_that(path_string).equals("TEST PATH OR URL STRING")
       assert_that(@rails_routes_method_missing_call.args)
-        .equals(["#{url_name1}_path".to_sym, "TEST PATH ARGS"])
+        .equals(["#{url_name1}_path".to_sym, { test: "args" }])
 
-      url_string = subject.url_for("TEST URL ARGS")
+      url_string = subject.url_for(test: "args")
       assert_that(url_string).equals("TEST PATH OR URL STRING")
       assert_that(@rails_routes_method_missing_call.args)
-        .equals(["#{url_name1}_url".to_sym, "TEST URL ARGS"])
+        .equals(["#{url_name1}_url".to_sym, { test: "args" }])
     end
   end
 

data/test/unit/assets_tests.rb

@@ -23,7 +23,7 @@ module MuchRails::Assets
     setup do
       subject.reset
 
-      in_development_env = Factory.boolean
+      in_development_env = true
       Assert.stub(FakeRails.env, :development?){ in_development_env }
       Assert.stub(FakeRails.env, :test?){ !in_development_env }
 
@@ -34,14 +34,11 @@ module MuchRails::Assets
       subject.configure_for_rails(FakeRails)
     end
 
-    should "configure the fingerprint cache to use a memory cache" do
+    should "configure the fingerprint/content cache to use no cache" do
       assert_that(subject.config.fingerprint_cache)
-        .is_instance_of(subject::MemCache)
-    end
-
-    should "configure the content cache to use a memory cache" do
+        .is_instance_of(subject::NoCache)
       assert_that(subject.config.content_cache)
-        .is_instance_of(subject::MemCache)
+        .is_instance_of(subject::NoCache)
     end
 
     should "not configure a file store" do
@@ -49,16 +46,14 @@ module MuchRails::Assets
         .is_not_equal_to(FakeRails.root.join("public"))
     end
 
-    should "configure the app's app/assets folder as a source" do
+    should "configure the app's app/assets/css folder as a source" do
       source =
         subject.config.sources.detect do |source|
-          source.path == FakeRails.root.join("app", "assets").to_s
+          source.path == FakeRails.root.join("app", "assets", "css").to_s
         end
 
       assert_that(source).is_not_nil
-      assert_that(source.engines["js"].size).equals(1)
-      assert_that(source.engines["js"].first)
-        .is_instance_of(subject::Erubi::Engine)
+      assert_that(source.base_path).equals("css")
       assert_that(source.engines["scss"].size).equals(2)
       assert_that(source.engines["scss"].first)
         .is_instance_of(subject::Erubi::Engine)
@@ -66,6 +61,41 @@ module MuchRails::Assets
         .is_instance_of(subject::Sass::Engine)
     end
 
+    should "configure the app's app/assets/img folder as a source" do
+      source =
+        subject.config.sources.detect do |source|
+          source.path == FakeRails.root.join("app", "assets", "img").to_s
+        end
+
+      assert_that(source).is_not_nil
+      assert_that(source.base_path).equals("img")
+      assert_that(source.engines.empty?).is_true
+    end
+
+    should "configure the app's app/assets/js folder as a source" do
+      source =
+        subject.config.sources.detect do |source|
+          source.path == FakeRails.root.join("app", "assets", "js").to_s
+        end
+
+      assert_that(source).is_not_nil
+      assert_that(source.base_path).equals("js")
+      assert_that(source.engines["js"].size).equals(1)
+      assert_that(source.engines["js"].first)
+        .is_instance_of(subject::Erubi::Engine)
+    end
+
+    should "configure the app's app/assets/vendor folder as a source" do
+      source =
+        subject.config.sources.detect do |source|
+          source.path == FakeRails.root.join("app", "assets", "vendor").to_s
+        end
+
+      assert_that(source).is_not_nil
+      assert_that(source.base_path).equals("vendor")
+      assert_that(source.engines.empty?).is_true
+    end
+
     should "initialize itself" do
       assert_that(@init_call).is_not_nil
     end
@@ -84,9 +114,11 @@ module MuchRails::Assets
       subject.configure_for_rails(FakeRails)
     end
 
-    should "configure the content cache to use no cache" do
+    should "configure the fingerprint/content cache to use a memory cache" do
+      assert_that(subject.config.fingerprint_cache)
+        .is_instance_of(subject::MemCache)
       assert_that(subject.config.content_cache)
-        .is_instance_of(subject::NoCache)
+        .is_instance_of(subject::MemCache)
     end
 
     should "configure a file store for the app's public folder" do

data/test/unit/input_value_tests.rb

@@ -9,12 +9,21 @@ module MuchRails::InputValue
     subject{ unit_class }
 
     let(:unit_class){ MuchRails::InputValue }
+    let(:non_blank_but_empty_to_s_object) do
+      Class
+        .new{
+          def to_s
+            ["", " "].sample
+          end
+        }
+        .new
+    end
 
     should have_imeths :strip, :strip_all
 
     should "know its attributes" do
       # strip
-      input_value = [nil, "", " "].sample
+      input_value = [nil, "", " ", non_blank_but_empty_to_s_object].sample
       assert_that(subject.strip(input_value)).is_nil
 
       input_value = [" VALUE  ", "\r VALUE\n"].sample

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: much-rails
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.6
 platform: ruby
 authors:
 - Kelly Redding
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-26 00:00:00.000000000 Z
+date: 2021-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: much-style-guide
@@ -105,14 +105,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.15.1
+        version: 0.15.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.15.1
+        version: 0.15.2
 - !ruby/object:Gem::Dependency
   name: dassets-erubi
   requirement: !ruby/object:Gem::Requirement
@@ -217,14 +217,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 0.1.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: 0.1.2
 - !ruby/object:Gem::Dependency
   name: oj
   requirement: !ruby/object:Gem::Requirement
@@ -251,6 +251,7 @@ files:
 - LICENSE
 - README.md
 - lib/much-rails.rb
+- lib/much-rails/abstract_class.rb
 - lib/much-rails/action.rb
 - lib/much-rails/action/base_command_result.rb
 - lib/much-rails/action/base_result.rb
@@ -306,6 +307,7 @@ files:
 - test/support/factory.rb
 - test/support/fake_action_controller.rb
 - test/system/.keep
+- test/unit/abstract_class_tests.rb
 - test/unit/action/base_command_result_tests.rb
 - test/unit/action/base_result_tests.rb
 - test/unit/action/base_router_tests.rb
@@ -369,8 +371,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
+rubygems_version: 3.2.4
 signing_key: 
 specification_version: 4
 summary: Rails utilities.
@@ -381,6 +382,7 @@ test_files:
 - test/support/factory.rb
 - test/support/fake_action_controller.rb
 - test/system/.keep
+- test/unit/abstract_class_tests.rb
 - test/unit/action/base_command_result_tests.rb
 - test/unit/action/base_result_tests.rb
 - test/unit/action/base_router_tests.rb