much-rails 0.1.3 → 0.2.4

data/test/unit/records/always_destroyable_tests.rb

@@ -34,7 +34,7 @@ module MuchRails::Records::AlwaysDestroyable
 
       assert_that(subject.destroy).is_true
 
-      # won't raise MuchRails::Records::ValidateDestroy::DestructionInvalid
+      # won't raise MuchRails::Records::DestructionInvalid
       subject.destroy!
 
       assert_that(subject.destroyable?).is_true

data/test/unit/records/not_destroyable_tests.rb

@@ -32,7 +32,7 @@ module MuchRails::Records::NotDestroyable
       assert_that(subject.destroy).is_false
 
       assert_that(->{ subject.destroy! })
-        .raises(MuchRails::Records::ValidateDestroy::DestructionInvalid)
+        .raises(MuchRails::Records::DestructionInvalid)
 
       assert_that(subject.destroyable?).is_false
     end

data/test/unit/records/validate_destroy_tests.rb

@@ -62,17 +62,17 @@ module MuchRails::Records::ValidateDestroy
 
       exception =
         assert_that(->{ subject.destroy! })
-          .raises(MuchRails::Records::ValidateDestroy::DestructionInvalid)
+          .raises(MuchRails::Records::DestructionInvalid)
       assert_that(exception.message)
         .equals("TEST DESTRUCTION ERROR1\nTEST DESTRUCTION ERROR2")
-      assert_that(exception.destruction_errors)
+      assert_that(exception.errors)
         .equals(base: subject.destruction_error_messages.to_a)
       assert_that(subject.super_destroy_called).is_true
 
       exception =
         assert_that(->{ subject.destroy!(as: :thing) })
-          .raises(MuchRails::Records::ValidateDestroy::DestructionInvalid)
-      assert_that(exception.destruction_errors)
+          .raises(MuchRails::Records::DestructionInvalid)
+      assert_that(exception.errors)
         .equals(thing: subject.destruction_error_messages.to_a)
 
       subject.super_destroy_called = nil
@@ -138,9 +138,85 @@ module MuchRails::Records::ValidateDestroy
     end
   end
 
+  class DestructionInvalidTests < UnitTests
+    desc "MuchRails::Records::DestructionInvalid"
+    subject{ exception_class }
+
+    let(:exception_class){ MuchRails::Records::DestructionInvalid }
+
+    let(:record){ FakeRecordClass.new }
+
+    should "be configured as expected" do
+      assert_that(subject < StandardError).is_true
+    end
+  end
+
+  class DestructionInvalidInitTests < DestructionInvalidTests
+    desc "when init"
+    subject{ exception_class.new(record) }
+
+    should have_readers :record, :errors, :error_full_messages
+
+    should "know its attributes when destruction errors exist" do
+      record.destruction_errors_exist = true
+      record.validate_destroy
+
+      assert_that(subject.message)
+        .equals(record.destruction_error_messages.to_a.join("\n"))
+      assert_that(subject.record).is(record)
+      assert_that(subject.errors).equals(
+        base: record.destruction_error_messages.to_a,
+      )
+      assert_that(subject.error_full_messages)
+        .equals(record.destruction_error_messages.to_a)
+    end
+
+    should "know its attributes when destruction errors don't exist" do
+      assert_that(subject.message).equals("")
+      assert_that(subject.record).is(record)
+      assert_that(subject.errors).equals({})
+      assert_that(subject.error_full_messages).equals([])
+    end
+  end
+
+  class DestructionInvalidInitWithFieldNameTests < DestructionInvalidTests
+    desc "when init with a field name"
+    subject{ exception_class.new(record, field_name: field_name) }
+
+    let(:field_name){ Factory.string }
+
+    should "know its attributes when destruction errors exist" do
+      record.destruction_errors_exist = true
+      record.validate_destroy
+
+      assert_that(subject.message)
+        .equals(record.destruction_error_messages.to_a.join("\n"))
+      assert_that(subject.record).is(record)
+      assert_that(subject.errors).equals(
+        field_name.to_sym => record.destruction_error_messages.to_a,
+      )
+      assert_that(subject.error_full_messages)
+        .equals(
+          record
+            .destruction_error_messages
+            .map do |m|
+              ActiveModel::Error.new(record, field_name, m).full_message
+            end,
+        )
+    end
+
+    should "know its attributes when destruction errors don't exist" do
+      assert_that(subject.message).equals("")
+      assert_that(subject.record).is(record)
+      assert_that(subject.errors).equals({})
+      assert_that(subject.error_full_messages).equals([])
+    end
+  end
+
   require "active_record"
 
   class FakeRecordBaseClass
+    extend ActiveRecord::Translation
     # Include ActiveRecord::Persistence to test the `destroy!` logic
     # (the `_raise_record_not_destroyed` method) that we had to re-implement in
     # the MuchRails::Records::ValidateDestroy.
@@ -150,6 +226,10 @@ module MuchRails::Records::ValidateDestroy
 
     attr_accessor :destruction_errors_exist
 
+    def self.base_class?
+      true
+    end
+
     def destroy
       @super_destroy_called = true
     end

data/test/unit/save_service_tests.rb

@@ -44,49 +44,209 @@ module MuchRails::SaveService
     end
   end
 
-  class RecordInvalidErrorSetupTests < ReceiverTests
-    desc "with an ActiveRecord::RecordInvalid error"
+  class ReceiverInitTests < ReceiverTests
+    desc "when init"
+    subject{ receiver_class.new(exception: exception) }
+
+    let(:exception){ nil }
+  end
+
+  class ReceiverInitAroundCallCallbackTests < ReceiverInitTests
+    desc "around_call callback"
     setup do
-      Assert.stub(exception, :record){ record }
+      Assert.stub(
+        MuchRails::SaveService::ValidationErrors,
+        :exception_classes,
+      ){ exception_classes }
+      Assert.stub_on_call(
+        MuchRails::SaveService::ValidationErrors,
+        :result_for,
+      ) do |call|
+        @result_for_call = call
+        validation_error_result
+      end
     end
 
-    let(:exception){ ActiveRecord::RecordInvalid.new }
+    let(:exception){ exceptions.sample }
+    let(:exceptions) do
+      [
+        RuntimeError.new(Factory.string),
+        ArgumentError.new(Factory.string),
+        ActiveRecord::RecordInvalid.new(FakeRecord.new),
+      ]
+    end
+    let(:exception_classes){ exceptions.map(&:class) }
+    let(:validation_error_result) do
+      MuchResult.failure(error: result_error_message)
+    end
+    let(:result_error_message){ Factory.string }
+
+    should "rescue raised exceptions and "\
+           "use the ValidationErrors to build a result" do
+      result = subject.call
+
+      assert_that(result.failure?).is_true
+      assert_that(result.error).equals(result_error_message)
+    end
   end
 
-  class ExceptionWithRecordErrorsTests < RecordInvalidErrorSetupTests
-    desc "with an exception that has record errors"
+  class ValidationErrorsTests < UnitTests
+    desc "ValidationErrors"
+    subject{ unit_class::ValidationErrors }
 
-    let(:record){ @fake_record ||= FakeRecord.new }
+    should have_imeths :add, :exception_classes, :result_for
+    should have_imeths :service_validation_errors
+
+    should "know its ServiceValidationErrors" do
+      assert_that(subject.service_validation_errors)
+        .is_an_instance_of(MuchRails::ServiceValidationErrors)
+      assert_that(subject.service_validation_errors.exception_classes)
+        .includes(ActiveRecord::RecordInvalid)
+    end
+  end
 
-    should "return a failure result with the exception and record errors" do
-      result = subject.call(exception: exception)
+  class ValidationErrorsAddTests < ValidationErrorsTests
+    desc ".add"
 
-      assert_that(result.failure?).is_true
-      assert_that(result.exception).equals(exception)
-      assert_that(result.validation_errors)
-        .equals(some_field: %w[ERROR1 ERROR2])
-      assert_that(result.validation_error_messages)
-        .equals(["some_field ERROR1", "some_field ERROR2"])
+    setup do
+      Assert.stub_on_call(subject.service_validation_errors, :add) do |call|
+        @add_call = call
+      end
+    end
+
+    let(:exception_class){ StandardError }
+    let(:block){ proc{ MuchResult.failure } }
+
+    should "call #add on its ServiceValidationErrors" do
+      subject.add(exception_class, &block)
+      assert_that(@add_call.args).equals([exception_class])
+      assert_that(@add_call.block).is(block)
+    end
+  end
+
+  class ValidationErrorsExceptionClassesTests < ValidationErrorsTests
+    desc ".exception_classes"
+
+    setup do
+      Assert.stub(
+        subject.service_validation_errors,
+        :exception_classes,
+      ){ exception_classes }
+    end
+
+    let(:exception_classes) do
+      [
+        StandardError,
+        ArgumentError,
+      ]
+    end
+
+    should "call #exception_classes on its ServiceValidationErrors" do
+      assert_that(subject.exception_classes).is(exception_classes)
+    end
+  end
+
+  class ValidationErrorsResultForTests < ValidationErrorsTests
+    desc ".result_for"
+
+    setup do
+      Assert.stub_on_call(
+        subject.service_validation_errors,
+        :result_for,
+      ) do |call|
+        @result_for_call = call
+        result_for_result
+      end
+    end
+
+    let(:exception){ StandardError.new(Factory.string) }
+    let(:result_for_result){ MuchResult.failure }
+
+    should "call #result_for on its ServiceValidationErrors" do
+      assert_that(subject.result_for(exception)).is(result_for_result)
+      assert_that(@result_for_call.args).equals([exception])
     end
   end
 
-  class ExceptionWithoutRecordErrorsTests < RecordInvalidErrorSetupTests
-    desc "with an exception that has no record errors"
+  class ValidationErrorsResultForRecordInvalidTests < ValidationErrorsTests
+    desc "when .result_for is passed an ActiveRecord::RecordInvalid"
+
+    let(:exception){ ActiveRecord::RecordInvalid.new(record) }
+    let(:record){ FakeRecord.new }
 
-    let(:record){ nil }
+    let(:no_record_exception){ ActiveRecord::RecordInvalid.new }
+
+    should "return a failure result with the record and validation errors" do
+      result = subject.result_for(exception)
+
+      assert_that(result.failure?).is_true
+      assert_that(result.exception).equals(exception)
+      assert_that(result.validation_errors).equals(record.errors.to_h)
+      assert_that(result.validation_error_messages)
+        .equals(record.errors.full_messages.to_a)
+    end
 
     should "return a failure result with the exception and empty "\
            "record errors" do
-      result = subject.call(exception: exception)
+      result = subject.result_for(no_record_exception)
 
       assert_that(result.failure?).is_true
-      assert_that(result.exception).equals(exception)
+      assert_that(result.exception).equals(no_record_exception)
       assert_that(result.validation_errors).equals({})
       assert_that(result.validation_error_messages).equals([])
     end
   end
 
+  class FailureResultTests < UnitTests
+    desc "FailureResult"
+    subject{ unit_class::FailureResult }
+
+    setup do
+      Assert.stub_tap_on_call(MuchResult, :failure) do |_, call|
+        @much_result_failure_call = call
+      end
+    end
+
+    let(:exception){ StandardError.new(Factory.string) }
+    let(:validation_errors){ { Factory.symbol => Factory.string } }
+    let(:custom_value){ Factory.string }
+
+    should have_imeths :new
+
+    should "use MuchResult.failure to build a result" do
+      result =
+        subject.new(
+          exception: exception,
+          validation_errors: validation_errors,
+          custom: custom_value,
+        )
+      assert_that(result.failure?).is_true
+      assert_that(@much_result_failure_call.kargs)
+        .equals(
+          exception: exception,
+          validation_errors: validation_errors,
+          custom: custom_value,
+        )
+    end
+
+    should "raise an error without an exception or validation errors" do
+      assert_that{
+        subject.new(validation_errors: validation_errors)
+      }.raises(ArgumentError)
+    end
+
+    should "raise an error without an exception or validation errors" do
+      assert_that{
+        subject.new(exception: exception)
+      }.raises(ArgumentError)
+    end
+  end
+
   class FakeRecord
+    def self.i18n_scope
+      "fake_record"
+    end
+
     def errors
       Errors.new
     end

data/test/unit/service_validation_errors_tests.rb

@@ -0,0 +1,107 @@
+# frozen_string_literal: true
+
+class MuchRails::ServiceValidationErrors
+  class UnitTests < Assert::Context
+    desc "MuchRails::ServiceValidationErrors"
+    subject{ unit_class }
+
+    let(:unit_class){ MuchRails::ServiceValidationErrors }
+  end
+
+  class InitTests < UnitTests
+    desc "when init"
+    subject{ unit_class.new }
+
+    should have_readers :hash
+    should have_imeths :add, :exception_classes, :result_for
+  end
+
+  class InitAddTests < InitTests
+    desc "#add"
+
+    let(:exception_class){ StandardError }
+    let(:block){ proc{ MuchResult.failure } }
+
+    let(:invalid_exception_class) do
+      [
+        Class.new,
+        Factory.string,
+        nil,
+      ].sample
+    end
+
+    should "add an exception class and block" do
+      subject.add(exception_class, &block)
+      assert_that(subject.hash[exception_class]).is(block)
+    end
+
+    should "raise an error when it's not passed an Exception" do
+      assert_that{
+        subject.add(invalid_exception_class, &block)
+      }.raises(ArgumentError)
+    end
+  end
+
+  class InitExceptionClassesTests < InitTests
+    desc "#exception_classes"
+
+    setup do
+      exception_classes.each do |exception_class|
+        subject.add(exception_class, &block)
+      end
+    end
+
+    let(:exception_classes) do
+      [
+        StandardError,
+        ArgumentError,
+        RuntimeError,
+      ]
+    end
+    let(:block){ proc{ MuchResult.failure } }
+
+    should "return all the added exception classes" do
+      assert_that(subject.exception_classes).equals(exception_classes)
+    end
+  end
+
+  class InitResultForTests < InitTests
+    desc "#result_for"
+
+    setup do
+      subject.add(exception_class, &block)
+    end
+
+    let(:exception){ exception_class.new(Factory.string) }
+    let(:exception_class){ StandardError }
+    let(:block) do
+      proc{ MuchResult.failure(error_message: failure_result_error_message) }
+    end
+    let(:failure_result_error_message){ Factory.string }
+
+    let(:inherited_exception){ RuntimeError.new(Factory.string) }
+
+    let(:invalid_exception){ Exception.new(Factory.string) }
+
+    should "return the result of calling the added block "\
+           "for the exception class" do
+      result = subject.result_for(exception)
+      assert_that(result.failure?).is_true
+      assert_that(result.error_message).equals(failure_result_error_message)
+    end
+
+    should "return the result of calling the added block "\
+           "for an exception class ancestor" do
+      result = subject.result_for(exception)
+      assert_that(result.failure?).is_true
+      assert_that(result.error_message).equals(failure_result_error_message)
+    end
+
+    should "raise an error if a block hasn't been added "\
+           "for the exception class" do
+      assert_that{
+        subject.result_for(invalid_exception)
+      }.raises(ArgumentError)
+    end
+  end
+end