mtgox 0.5.1 → 0.6.0

data/lib/mtgox/ask.rb

@@ -3,6 +3,11 @@ require 'mtgox/offer'
 module MtGox
   class Ask < Offer
 
+    def initialize(price=nil, amount=nil)
+      self.price = price.to_f
+      self.amount = amount.to_f
+    end
+
     def eprice
       price / (1 - MtGox.commission)
     end

data/lib/mtgox/bid.rb

@@ -3,6 +3,11 @@ require 'mtgox/offer'
 module MtGox
   class Bid < Offer
 
+    def initialize(price=nil, amount=nil)
+      self.price = price.to_f
+      self.amount = amount.to_f
+    end
+
     def eprice
       price * (1 - MtGox.commission)
     end

data/lib/mtgox/client.rb

@@ -33,11 +33,15 @@ module MtGox
     #   offers.bids[0, 3]
     def offers
       offers = get('/code/data/getDepth.php')
-      offers['asks'] = offers['asks'].sort_by{|ask| ask[0].to_f}.map do |ask|
-        Ask.new({:price => ask[0].to_f, :amount => ask[1].to_f})
+      offers['asks'] = offers['asks'].sort_by do |ask|
+        ask[0].to_f
+      end.map! do |ask|
+        Ask.new(*ask)
       end
-      offers['bids'] = offers['bids'].sort_by{|bid| bid[0].to_f}.reverse.map do |bid|
-        Bid.new({:price => bid[0].to_f, :amount => bid[1].to_f})
+      offers['bids'] = offers['bids'].sort_by do |bid|
+        -bid[0].to_f
+      end.map! do |bid|
+        Bid.new(*bid)
       end
       offers
     end
@@ -78,7 +82,7 @@ module MtGox
     # Fetch the highest priced bid
     #
     # @authenticated false
-    # @return [MinBin]
+    # @return [MinBid]
     # @example
     #   MtGox.max_bid
     def max_bid
@@ -228,7 +232,7 @@ module MtGox
     end
 
     def pass_params
-      {:name => MtGox.name, :pass => MtGox.pass}
+      {:name => MtGox.username, :pass => MtGox.password}
     end
   end
 end

data/lib/mtgox/configuration.rb

@@ -5,8 +5,8 @@ module MtGox
     # An array of valid keys in the options hash when configuring a {MtGox::Client}
     VALID_OPTIONS_KEYS = [
       :commission,
-      :name,
-      :pass,
+      :password,
+      :username,
     ]
 
     DEFAULT_COMMISSION = 0.0065.freeze
@@ -33,8 +33,8 @@ module MtGox
     # Reset all configuration options to defaults
     def reset
       self.commission = DEFAULT_COMMISSION
-      self.name       = nil
-      self.pass       = nil
+      self.password   = nil
+      self.username   = nil
       self
     end
   end

data/lib/mtgox/max_bid.rb

@@ -12,15 +12,15 @@ module MtGox
     end
 
     def up?
-      price > previous_price.to_f
+      price.to_f > previous_price.to_f
     end
 
     def down?
-      price < previous_price.to_f
+      price.to_f < previous_price.to_f
     end
 
     def changed?
-      price != previous_price.to_f
+      price.to_f != previous_price.to_f
     end
 
     def unchanged?

data/lib/mtgox/min_ask.rb

@@ -12,15 +12,15 @@ module MtGox
     end
 
     def up?
-      price > previous_price.to_f
+      price.to_f > previous_price.to_f
     end
 
     def down?
-      price < previous_price.to_f
+      price.to_f < previous_price.to_f
     end
 
     def changed?
-      price != previous_price.to_f
+      price.to_f != previous_price.to_f
     end
 
     def unchanged?

data/lib/mtgox/offer.rb

@@ -1,12 +1,5 @@
 module MtGox
   class Offer
     attr_accessor :amount, :price
-
-    def initialize(attributes={})
-      attributes.each_pair do |key, value|
-        self.send(:"#{key}=", value) if self.respond_to?(:"#{key}=")
-      end
-    end
-
   end
 end

data/lib/mtgox/version.rb

@@ -1,3 +1,3 @@
 module MtGox
-  VERSION = "0.5.1".freeze unless defined? ::MtGox::VERSION
+  VERSION = "0.6.0".freeze unless defined? ::MtGox::VERSION
 end

data/spec/mtgox/client_spec.rb

@@ -4,8 +4,8 @@ describe MtGox::Client do
   before do
     @client = MtGox::Client.new
     MtGox.configure do |config|
-      config.name = "my_name"
-      config.pass = "my_password"
+      config.username = "my_name"
+      config.password = "my_password"
     end
   end
 

data/spec/mtgox_spec.rb

@@ -8,14 +8,14 @@ describe MtGox do
   end
 
   describe ".configure" do
-    it "should set 'name' and 'pass'" do
+    it "should set 'username' and 'password'" do
       MtGox.configure do |config|
-        config.name = "username"
-        config.pass = "password"
+        config.username = "username"
+        config.password = "password"
       end
 
-      MtGox.name.should == "username"
-      MtGox.pass.should == "password"
+      MtGox.username.should == "username"
+      MtGox.password.should == "password"
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mtgox
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.6.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,12 +9,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-07-11 00:00:00.000000000 -07:00
+date: 2011-07-12 00:00:00.000000000 -07:00
 default_executable: 
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ZenTest
-  requirement: &70342739667420 !ruby/object:Gem::Requirement
+  requirement: &70226142918300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -22,10 +22,10 @@ dependencies:
         version: '4.5'
   type: :development
   prerelease: false
-  version_requirements: *70342739667420
+  version_requirements: *70226142918300
 - !ruby/object:Gem::Dependency
   name: maruku
-  requirement: &70342735692520 !ruby/object:Gem::Requirement
+  requirement: &70226142917500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -33,10 +33,10 @@ dependencies:
         version: '0.6'
   type: :development
   prerelease: false
-  version_requirements: *70342735692520
+  version_requirements: *70226142917500
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70342735691180 !ruby/object:Gem::Requirement
+  requirement: &70226142916860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -44,10 +44,10 @@ dependencies:
         version: '0.9'
   type: :development
   prerelease: false
-  version_requirements: *70342735691180
+  version_requirements: *70226142916860
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70342735689860 !ruby/object:Gem::Requirement
+  requirement: &70226142916160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -55,10 +55,10 @@ dependencies:
         version: '2.6'
   type: :development
   prerelease: false
-  version_requirements: *70342735689860
+  version_requirements: *70226142916160
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70342735689040 !ruby/object:Gem::Requirement
+  requirement: &70226142915420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -66,10 +66,10 @@ dependencies:
         version: '0.4'
   type: :development
   prerelease: false
-  version_requirements: *70342735689040
+  version_requirements: *70226142915420
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &70342735687980 !ruby/object:Gem::Requirement
+  requirement: &70226142914740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -77,10 +77,10 @@ dependencies:
         version: '1.6'
   type: :development
   prerelease: false
-  version_requirements: *70342735687980
+  version_requirements: *70226142914740
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &70342735686940 !ruby/object:Gem::Requirement
+  requirement: &70226142914080 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -88,10 +88,10 @@ dependencies:
         version: '0.7'
   type: :development
   prerelease: false
-  version_requirements: *70342735686940
+  version_requirements: *70226142914080
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &70342735686260 !ruby/object:Gem::Requirement
+  requirement: &70226142913360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -99,10 +99,10 @@ dependencies:
         version: 0.6.1
   type: :runtime
   prerelease: false
-  version_requirements: *70342735686260
+  version_requirements: *70226142913360
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
-  requirement: &70342735685680 !ruby/object:Gem::Requirement
+  requirement: &70226142911920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -110,10 +110,10 @@ dependencies:
         version: 0.6.3
   type: :runtime
   prerelease: false
-  version_requirements: *70342735685680
+  version_requirements: *70226142911920
 - !ruby/object:Gem::Dependency
   name: hashie
-  requirement: &70342735873460 !ruby/object:Gem::Requirement
+  requirement: &70226142926600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -121,10 +121,10 @@ dependencies:
         version: 1.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *70342735873460
+  version_requirements: *70226142926600
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &70342735872600 !ruby/object:Gem::Requirement
+  requirement: &70226142926000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -132,10 +132,10 @@ dependencies:
         version: 1.0.3
   type: :runtime
   prerelease: false
-  version_requirements: *70342735872600
+  version_requirements: *70226142926000
 - !ruby/object:Gem::Dependency
   name: rash
-  requirement: &70342735871880 !ruby/object:Gem::Requirement
+  requirement: &70226142925380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -143,7 +143,7 @@ dependencies:
         version: 0.3.0
   type: :runtime
   prerelease: false
-  version_requirements: *70342735871880
+  version_requirements: *70226142925380
 description: Ruby wrapper for the Mt. Gox Trade API. Mt. Gox allows you to trade US
   Dollars (USD) for Bitcoins (BTC) or Bitcoins for US Dollars.
 email: sferik@gmail.com