mtg_db 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f51fbd4706c4651c6b0693475753c4f7484651035ca5d9bdc3baf562f25f67ef
-  data.tar.gz: 8cbdf27fa93421ef6a78710dd1e23d1360c80907ababee549aee21c103d51be3
+  metadata.gz: 9af0d25de61f99984ee45a012fa4fac54d209ba435f9c1193af8a50f055f33e2
+  data.tar.gz: 4da2fa65165d73305f82ca20c5ac2f5e1602a566b7c2e3d499aded6f79174070
 SHA512:
-  metadata.gz: a86ee46235409de2e335f3d6c5b48fe500f3061a7bc1e3b8f4be38ec680c130511030094fa2dde715eda565b3e6a43c2d4b529ab553f91cd7794fdc8bd038277
-  data.tar.gz: f95749bff81a7a3b94aad2cecd562c8d68bef2bcff21999b12c01ff93202b530116bfdde7f1b036731949a35e118d5c833296b5ff6fb2225daaadce7ccec4ffb
+  metadata.gz: 7ccfcd97dcba46b64c0c021d5db43e22c1a8a659d855a574336fe0726bbd9c819cda854fa303053c101363a53f0babd8754af609597395d6ba64d06057e74ed3
+  data.tar.gz: dff5f78de48d6297931fdf6b3efdab2c26378f71bbae6623234a742c83fe5ee22671066312c949fb3ea538e725047dd775e517c0d198a52b60b388d3eaab1c3d

data/README.md

@@ -1,6 +1,6 @@
-# MtgDb
+# MtgDb [![Build Status](https://travis-ci.org/Hammit/mtg-database.svg?branch=master)](https://travis-ci.org/Hammit/mtg-database)
 
-A ruby (2.1) program that creates an SQLite3 database containing Magic: The Gathering
+A ruby program that creates an SQLite3 database containing Magic: The Gathering
 card information collected from [The Gatherer](http://gatherer.wizards.com/ "The Gatherer").
 
 ## Installation
@@ -29,7 +29,7 @@ Downloading card information from [The Gatherer](http://gatherer.wizards.com/ "T
 can take a long time. Be prepared to wait a while when creating the db.
 
 ## Misc
-* Schema for the Db is in sql/cards.schema.sql
+* Schema for the Db is in sql/db.schema.sql
 * bundle exec bin/mtg_db help
 
 ## Contributing

data/lib/mtg_db.rb

@@ -9,11 +9,11 @@ require 'tempfile'
 # Top level module
 module MtgDb
   TMP_DIR = File.join(Dir.tmpdir, 'mtg')
-  ALL_CARDS_DIR = 'standard'.freeze
-  DOUBLE_FACED_DIR = 'double-faced'.freeze
-  SCHEMA_FILENAME = File.join(__dir__, '..', 'sql', 'cards.schema.sql')
+  ALL_CARDS_DIR = 'standard'
+  DOUBLE_FACED_DIR = 'double-faced'
+  SCHEMA_FILENAME = File.join(__dir__, '..', 'sql', 'db.schema.sql')
   SQLITE3_HEADER_STRING_LENGTH = 15
-  SQLITE3_HEADER_STRING = "SQLite format 3"
+  SQLITE3_HEADER_STRING = 'SQLite format 3'
 
   # TODO: Remove the accessor as it's only required for debugging purposes
   class << self; attr_accessor :standard_files_downloaded end
@@ -107,7 +107,7 @@ module MtgDb
     db.disconnect
   end
 
-  # Downloading
+  # Downloading Double-Faced Cards
   def self.download_double_faced_cards(db_filename, tmp_dir)
     tmp_dir ||= TMP_DIR
     tmp_dir = File.join(tmp_dir, DOUBLE_FACED_DIR)
@@ -125,8 +125,11 @@ module MtgDb
       puts "#{card.name}, #{multiverse_id}"
       downloader.start(card.name.parameterize, multiverse_id)
     end
+
+    db.disconnect
   end
 
+  # Adding Downloaded Double-Faced Cards to Db
   def self.add_double_faced_cards_to_db(db_filename, tmp_dir)
     tmp_dir ||= TMP_DIR
     tmp_dir = File.join(tmp_dir, DOUBLE_FACED_DIR)
@@ -173,7 +176,7 @@ module MtgDb
     SQLITE3_HEADER_STRING_LENGTH.times do
       header += (Random.rand(26) + 48).chr
     end
-    
+
     File.open(db_filename, 'r+b') do |file|
       file.seek(0, IO::SEEK_SET)
       file.print(header)

data/lib/mtg_db/cli.rb

@@ -33,13 +33,13 @@ module MtgDb
       MtgDb.add_double_faced_cards_to_db(name, tmp_dir)
     end
 
-    desc "mangle NAME", "mangle the SQLite3 Db file header"
+    desc 'mangle NAME', 'mangle the SQLite3 Db file header'
     def mangle(name)
       name = File.expand_path(name)
       if not MtgDb.is_sqlite3?(name)
         puts "File is either already mangled or not an SQLite3 database: #{name}"
       else
-        puts "Mangling the SQLite3 file header"
+        puts 'Mangling the SQLite3 file header'
         MtgDb.mangle(name)
       end
     end

data/lib/mtg_db/constants.rb

@@ -32,8 +32,8 @@ module MtgDb
       'Phyrexian Red': '(R/P)',
       'Phyrexian Green': '(G/P)',
 
-      'Variable Colorless': 'X',
-    }.freeze
+      'Variable Colorless': 'X'
+    }
 
     # TODO: See if we can (?DEFINE) subroutines in the regex as per Perl/PCRE
     # http://www.regular-expressions.info/subroutine.html

data/lib/mtg_db/downloaders.rb

@@ -3,8 +3,9 @@ require 'mechanize'
 
 module MtgDb
   module Downloaders
+    # Base class for all downloaders
     class DownloaderBase
-      DEFAULT_OUTPUT_DIR = 'output'.freeze
+      DEFAULT_OUTPUT_DIR = 'output'
       attr_reader :agent
       attr_accessor :output_dir
 
@@ -65,7 +66,7 @@ module MtgDb
     # Useful for double-faced cards, where we can associate the face-up and face-down cards, both on this page
     class CardDetailsDownloader < DownloaderBase
       DEBUG = true
-      CARD_DETAILS_URL = 'http://gatherer.wizards.com/Pages/Card/Details.aspx?multiverseid=<PARAM_0>'.freeze
+      CARD_DETAILS_URL = 'http://gatherer.wizards.com/Pages/Card/Details.aspx?multiverseid=<PARAM_0>'
 
       def start(card_name, card_multiverse_id)
         url = CARD_DETAILS_URL

data/lib/mtg_db/parsers.rb

@@ -1,4 +1,3 @@
-# require 'pry'
 require_relative 'constants'
 require 'mechanize'
 require 'uri'
@@ -14,10 +13,10 @@ module MtgDb
       def initialize(uri = nil, response = nil, body = nil, code = nil)
         super(uri, response, body, code)
         @cards = parse_cards
-        # p @cards
       end
 
-    private
+      private
+
       # Each page in standard format has a bunch of cards
       def parse_cards
         cards = []
@@ -161,7 +160,7 @@ module MtgDb
           set = match['SET']
           rarity = match['RARITY']
 
-          { :multiverse_id => multiverse_id, :set => set, :rarity => rarity, :set_abbreviation => set_abbreviation }
+          { multiverse_id: multiverse_id, set: set, rarity: rarity, set_abbreviation: set_abbreviation }
         end
       end
     end
@@ -177,7 +176,6 @@ module MtgDb
         @cards = parse_cards
         @faceup_card_name = @cards.first
         @facedown_card_name = @cards.last
-        #p @cards
       end
 
       private
@@ -185,7 +183,6 @@ module MtgDb
       def parse_cards
         cards = []
         card_nodes = search('.cardDetails')
-        # binding.pry
         # Each page has 2 cards if it's transformable
         if card_nodes.size == 2
           face_up_name = name(card_nodes.first)
@@ -196,7 +193,6 @@ module MtgDb
           # face_down_card = Card.where(:name => face_down_name).first
           cards << face_down_name
         end
-        # p cards if DEBUG
 
         cards
       end
@@ -254,6 +250,5 @@ module MtgDb
         subtype
       end
     end
-
   end
 end

data/lib/mtg_db/version.rb

@@ -1,3 +1,3 @@
 module MtgDb
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mtg_db
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Byron Hammond
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-27 00:00:00.000000000 Z
+date: 2019-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -189,7 +189,7 @@ files:
 - lib/mtg_db/parsers.rb
 - lib/mtg_db/version.rb
 - mtg_db.gemspec
-- sql/cards.schema.sql
+- sql/db.schema.sql
 - test/files/double-faced/aberrant-researcher.html
 - test/files/double-faced/abolisher-of-bloodlines.html
 - test/files/double-faced/accursed-witch.html