mt940 0.3.0 → 0.4.0

data/README.md

@@ -13,10 +13,21 @@ The following Dutch banks are implemented:
 Usage
 =====
 
-    file_name = File.dirname(__FILE__) + 'ing.940'
+With the file name as argument:
+
+    file_name = '/Users/dovadi/Downloads/ing.940'
 
     @transactions = MT940:::Base.transactions(file_name)
 
+or with the file itself:
+
+    file_name = '/Users/dovadi/Downloads/ing.940'
+
+    file = File.open(file_name)
+
+    @transactions = MT940:::Base.transactions(file)
+
+
 * Independent of the bank, a transaction always consists of:
 
   - accountnumber

data/VERSION

@@ -1 +1 @@
-0.3.0
+0.4.0

data/lib/mt940/base.rb

@@ -2,20 +2,15 @@ module MT940
 
   class Base
 
-    def self.transactions(file_name)
-      first_line = File.open(file_name) {|f| f.readline}
-      klass = if first_line.match(/INGBNL/)
-        ING
-      elsif first_line.match(/ABNANL/)
-        Abnamro
-      elsif first_line.match(/^:940:/)
-        Rabobank
+    def self.transactions(file)
+      file  = File.open(file) if file.is_a?(String) 
+      if file.is_a?(File)
+        instance = determine_bank(file.readline).new(file)
+        file.close
+        instance.parse
       else
-        self
+        raise ArgumentError.new('No file is given!')
       end
-      instance = klass.new(file_name)
-      instance.parse
-      instance.instance_variable_get('@transactions')
     end
 
     def parse
@@ -29,9 +24,21 @@ module MT940
 
     private
 
-    def initialize(file_name)
+    def self.determine_bank(first_line)
+      if first_line.match(/INGBNL/)
+        ING
+      elsif first_line.match(/ABNANL/)
+        Abnamro
+      elsif first_line.match(/^:940:/)
+        Rabobank
+      else
+        self
+      end
+    end
+
+    def initialize(file)
       @transactions = []
-      @lines = File.readlines(file_name)
+      @lines = file.readlines
     end
 
     def parse_tag_25

data/mt940.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{mt940}
-  s.version = "0.3.0"
+  s.version = "0.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["dovadi"]
-  s.date = %q{2011-06-27}
+  s.date = %q{2011-07-04}
   s.description = %q{A basic MT940 parser with implementations for Dutch banks.}
   s.email = %q{frank.oxener@gmail.com}
   s.extra_rdoc_files = [
@@ -39,6 +39,7 @@ Gem::Specification.new do |s|
     "test/fixtures/triodos.txt",
     "test/helper.rb",
     "test/test_mt940_abnamro.rb",
+    "test/test_mt940_base.rb",
     "test/test_mt940_ing.rb",
     "test/test_mt940_rabobank.rb",
     "test/test_mt940_triodos.rb"

data/test/test_mt940_base.rb

@@ -0,0 +1,31 @@
+require 'helper'
+
+class TestMt940Base < Test::Unit::TestCase
+
+  should 'read the transactions with the filename of the MT940 file' do
+    file_name = File.dirname(__FILE__) + '/fixtures/ing.txt'
+    @transactions = MT940::Base.transactions(file_name)
+    assert_equal 6, @transactions.size
+  end
+
+  should 'read the transactions with the handle to the mt940 file itself' do
+    file_name = File.dirname(__FILE__) + '/fixtures/ing.txt'
+    file = File.open(file_name)
+    @transactions = MT940::Base.transactions(file)
+    assert_equal 6, @transactions.size
+  end
+
+  should 'raise an exception if the file does not exist' do
+    file_name = File.dirname(__FILE__) + '/fixtures/123.txt'
+    assert_raise Errno::ENOENT do
+      @transactions = MT940::Base.transactions(file_name)
+    end
+  end
+
+  should 'raise an ArgumentError if a wrong argument was given' do
+    assert_raise ArgumentError do
+      MT940::Base.transactions(Hash.new)
+    end
+  end
+
+end

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
-  - 3
+  - 4
   - 0
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors: 
 - dovadi
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-27 00:00:00 +02:00
+date: 2011-07-04 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -89,6 +89,7 @@ files:
 - test/fixtures/triodos.txt
 - test/helper.rb
 - test/test_mt940_abnamro.rb
+- test/test_mt940_base.rb
 - test/test_mt940_ing.rb
 - test/test_mt940_rabobank.rb
 - test/test_mt940_triodos.rb