mrspec 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c9b7422e1ee184d93d1efcb320e1d66d95261d72
-  data.tar.gz: 2cb80072ccc287fce0ae9deeeaf5e4cf7714f755
+  metadata.gz: 4c2fcc823e51b94b52dba0d39f0b2440519373e8
+  data.tar.gz: 4ab34320cf0c8d6bba5726ba562276980ab711d4
 SHA512:
-  metadata.gz: a4f44abb23f546d633264ad6d0f91d769cb8e56afc3c92051c4371bc2c5ae582f80aef74dae65ca1349d839775316fe0bc9311501c26e1019e02d7ee54ddc3f5
-  data.tar.gz: 5d7e7dc0778e64e6d6269caf5b03930a5d09d24f0fc6844fabfecad914dd53edc9c07ce98863f18fe29890a399a83de7f1f0b2c55d44c201538daad5333c21cd
+  metadata.gz: f5d9fa09313eb832dcabdafb817a8778f1ba6cd416287d0fca519122cb303afad9f011d799e5bf8140590b0d41bb7b63e02dfe2ab4d2c0f8528f0bc144e071c8
+  data.tar.gz: d8a9f3f30ef85c8e552230e91a3abd16e65848efeb9916a9a2cfb35772341d6ad4eb18c0454a1082cf4c08ad9ea342c57161b9e1c08fac7fdbd4a4241ee5d326

data/features/mrspec.feature

@@ -88,6 +88,39 @@ Feature: mrspec
     And stdout does not include "Minitest.run_one_method"
 
 
+  Scenario: Minitest::Spec definitions without bodies show line of the declaration in the backtrace, and not the full backtrace
+    Given the file "skip_spec.rb":
+    """
+    require 'minitest/spec'
+    describe 'a' do
+      it 'has no body'
+      it('calls skip') { skip }
+    end
+
+    class A < Minitest::Spec
+      it 'has no body'
+      it('calls skip') { skip }
+    end
+
+    class Wat < Minitest::Test
+      extend Minitest::Spec::DSL
+      register_spec_type /^lol/, self
+    end
+    describe 'lol' do
+      it 'has no body'
+      it('calls skip') { skip }
+    end
+    """
+    When I run "mrspec skip_spec.rb"
+    Then stdout includes "skip_spec.rb:3"
+    Then stdout includes "skip_spec.rb:4"
+    Then stdout includes "skip_spec.rb:8"
+    Then stdout includes "skip_spec.rb:9"
+    Then stdout includes "skip_spec.rb:17"
+    Then stdout includes "skip_spec.rb:18"
+    And stdout does not include "/mrspec/"
+
+
   Scenario: Works with Minitest::Test, choosing intelligent names
     Given the file "some_test.rb":
     """
@@ -313,6 +346,47 @@ Feature: mrspec
     And  stdout includes "tagged with 1 only"
     And  stdout includes "untagged"
 
+
+  Scenario: Can add metadata to Minitest::Specs
+    Given the file "a_spec.rb":
+    """
+    require 'minitest/spec'
+
+    describe 'First' do
+      classmeta runthis: true
+      it('spec1') { }
+    end
+
+    class MySpec < Minitest::Spec
+      meta runthis: true
+      it('spec2') { }
+      it('spec3') { }
+      it('spec4') { }
+    end
+
+    class Wat < Minitest::Test
+      extend Minitest::Spec::DSL
+      register_spec_type /^Lol/, self
+
+      def bbq
+        'rofl'
+      end
+    end
+
+    describe 'LolSpec!' do
+      meta runthis: true
+      it 'has different inheritance' do
+        assert self.kind_of? Wat
+      end
+    end
+    """
+    When I run 'mrspec -t runthis a_spec.rb'
+    Then the program ran successfully
+    And stdout includes "3 examples"
+    And stdout includes "0 failures"
+
+
+
   Scenario: Intelligently formats Minitest's assertions
     Given the file "test/some_assertions.rb":
     """

data/lib/mrspec/declare_minitests.rb

@@ -1,6 +1,7 @@
 require 'minitest'
 require 'mrspec/minitest_assertion_for_rspec'
 
+
 module MRspec
   module DeclareMinitests
     extend self
@@ -46,7 +47,7 @@ module MRspec
 
     def wrap_test(example_group, klass, mname)
       metadata = klass.example_metadata[mname.intern]
-      example = example_group.example example_name(mname), metadata do
+      example  = example_group.example example_name(mname), metadata do
         instance = Minitest.run_one_method klass, mname
         next              if instance.passed?
         pending 'skipped' if instance.skipped?

data/lib/mrspec/fix_backtraces_on_minitest_spec.rb

@@ -0,0 +1,21 @@
+# Monkey in the middleing Minitest::Spec::DSL#it,
+# and aliases to record the block in the user's code,
+# this way the backtrace lines up with the logical definition site,
+# and we don't risk filtering the entire backtrace
+# which causes RSpec to not filter,
+# and the entire backtrace is quite distracting
+require 'minitest/spec'
+dsl = Minitest::Spec::DSL
+it_location = dsl.instance_method(:it).source_location
+dsl.instance_methods
+   .map    { |name| [name, dsl.instance_method(name)] }
+   .select { |name, method| method.source_location == it_location }
+   .each   { |name, method|
+     dsl.__send__ :define_method, name do |*args, &block|
+       callsite = caller[0] || 'unknown-location:0:' # can't think of a situation where this wouldn't be true, but just in case
+       callsite =~ /^(.*?):(\d+):/
+       caller_filename, caller_lineno = $1, $2.to_i
+       block ||= eval 'proc { skip "(no tests defined)" }', binding, caller_filename, caller_lineno
+       method.bind(self).call(*args, &block)
+     end
+   }

data/lib/mrspec/version.rb

@@ -1,3 +1,3 @@
 module MRspec
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/lib/mrspec.rb

@@ -1,5 +1,6 @@
 require 'mrspec/version'
 require 'mrspec/minitest_metadata'
+require 'mrspec/fix_backtraces_on_minitest_spec'
 require 'mrspec/runner'
 require 'mrspec/configuration'
 require 'mrspec/option_parser'

data/test/test_mrspec.rb

@@ -155,6 +155,7 @@ class TestMRspec < Minitest::Spec
     it 'omits minitest code from the backtrace'
     it 'omits rspec code from the backtrace'
     it 'omits mrspec code from the backtrace'
+    it 'allows Minitest::Spec to be declared without bodies, and backtrace shows the call to the it block'
   end
 
   describe 'identifying which test to run' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mrspec
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Josh Cheek
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-26 00:00:00.000000000 Z
+date: 2015-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-core
@@ -93,6 +93,7 @@ files:
 - lib/mrspec.rb
 - lib/mrspec/configuration.rb
 - lib/mrspec/declare_minitests.rb
+- lib/mrspec/fix_backtraces_on_minitest_spec.rb
 - lib/mrspec/minitest_assertion_for_rspec.rb
 - lib/mrspec/minitest_metadata.rb
 - lib/mrspec/option_parser.rb