mrkt 0.9.0 → 1.0.1

data/spec/concerns/crud_asset_static_lists_spec.rb

@@ -0,0 +1,183 @@
+describe Mrkt::CrudAssetStaticLists do
+  include_context 'initialized client'
+
+  let(:response_static_list_result) do
+    {
+      id: 1001,
+      name: 'Test Static List Name',
+      description: 'Provided description',
+      createdAt: '2019-03-15T21:41:46Z+0000',
+      updatedAt: '2019-03-15T21:41:46Z+0000',
+      folder: {
+        id: 14,
+        type: 'Folder'
+      },
+      computedUrl: 'https://app-devlocal1.marketo.com/#ST1001A1'
+    }
+  end
+
+  describe '#create_static_list' do
+    subject { client.create_static_list(name, folder, description: description) }
+
+    let(:name) { 'Test Static List Name' }
+    let(:folder) do
+      { id: 14, type: 'Folder' }
+    end
+    let(:description) { 'Provided description' }
+    let(:response_stub) do
+      {
+        requestId: 'eba#16982091b99',
+        result: [
+          response_static_list_result
+        ],
+        success: true,
+        errors: [],
+        warnings: []
+      }
+    end
+
+    let(:json_folder) { JSON.generate(folder) }
+    let(:request_body) do
+      {
+        name: name,
+        folder: json_folder,
+        description: description
+      }
+    end
+
+    before do
+      stub_request(:post, "https://#{host}/rest/asset/v1/staticLists.json")
+        .with(body: request_body)
+        .to_return(json_stub(response_stub))
+    end
+
+    it { is_expected.to eq(response_stub) }
+  end
+
+  describe '#get_static_list_by_id' do
+    subject { client.get_static_list_by_id(id) }
+
+    let(:id) { response_static_list_result[:id] }
+    let(:response_stub) do
+      {
+        requestId: '378a#16983419fff',
+        result: [
+          response_static_list_result
+        ],
+        success: true,
+        errors: [],
+        warnings: []
+      }
+    end
+
+    before do
+      stub_request(:get, "https://#{host}/rest/asset/v1/staticList/#{id}.json")
+        .to_return(json_stub(response_stub))
+    end
+
+    context 'when a static list with the given id exists' do
+      let(:response_stub) do
+        {
+          requestId: '378a#16983419fff',
+          result: [
+            response_static_list_result
+          ],
+          success: true,
+          errors: [],
+          warnings: []
+        }
+      end
+
+      it { is_expected.to eq(response_stub) }
+    end
+
+    context 'when a static list with the given id does not exist' do
+      let(:response_stub) do
+        {
+          requestId: 'a8d#1698369857b',
+          success: false,
+          warnings: [],
+          errors: [
+            {
+              code: '702',
+              message: 'Static List not found or it has been deleted'
+            }
+          ]
+        }
+      end
+
+      it 'should raise an Error' do
+        expect { subject }.to raise_error(Mrkt::Errors::RecordNotFound)
+      end
+    end
+  end
+
+  describe '#get_static_list_by_name' do
+    subject { client.get_static_list_by_name(name) }
+
+    let(:name) { 'Test Static List Name' }
+    let(:request_query) { "name=#{name}" }
+
+    before do
+      stub_request(:get, "https://#{host}/rest/asset/v1/staticList/byName.json?#{request_query}")
+        .to_return(json_stub(response_stub))
+    end
+
+    context 'when a static list with the given name exists' do
+      let(:response_stub) do
+        {
+          requestId: '13a74#169834522b9',
+          result: [
+            response_static_list_result
+          ],
+          success: true,
+          errors: [],
+          warnings: []
+        }
+      end
+
+      it { is_expected.to eq(response_stub) }
+    end
+
+    context 'when a static list with the given name does not exist' do
+      let(:response_stub) do
+        {
+          requestId: '4ec2#1698384ae02',
+          success: true,
+          errors: [],
+          warnings: [
+            'No assets found for the given search criteria.'
+          ]
+        }
+      end
+
+      it { is_expected.to eq(response_stub) }
+    end
+  end
+
+  describe '#delete_static_list' do
+    subject { client.delete_static_list(id) }
+
+    let(:id) { 1001 }
+    let(:response_stub) do
+      {
+        requestId: '94c3#169833275df',
+        result: [
+          {
+            id: 1001
+          }
+        ],
+        success: true,
+        errors: [],
+        warnings: []
+      }
+    end
+
+    before do
+      stub_request(:post, "https://#{host}/rest/asset/v1/staticList/#{id}/delete.json")
+        .to_return(json_stub(response_stub))
+    end
+
+    it { is_expected.to eq(response_stub) }
+  end
+end

data/spec/concerns/crud_custom_activities_spec.rb

@@ -162,7 +162,9 @@ describe Mrkt::CrudCustomObjects do
         }
       end
 
-      subject { client.create_custom_activity(lead_id, activity_type_id, primary_attribute_value, attributes: attributes, date: date) }
+      subject do
+        client.create_custom_activity(lead_id, activity_type_id, primary_attribute_value, attributes: attributes, date: date)
+      end
 
       it { is_expected.to eq(response_stub) }
     end

data/spec/concerns/crud_custom_objects_spec.rb

@@ -55,7 +55,7 @@ describe Mrkt::CrudCustomObjects do
     end
 
     context 'with object names' do
-      let(:object_names) { %w(device_c manufacturer_c) }
+      let(:object_names) { %w[device_c manufacturer_c] }
 
       before do
         stub_request(:get, "https://#{host}/rest/v1/customobjects.json")

data/spec/concerns/crud_leads_spec.rb

@@ -1,9 +1,63 @@
 describe Mrkt::CrudLeads do
   include_context 'initialized client'
 
+  describe 'get_lead_by_id' do
+    subject { client.get_lead_by_id(id, fields: fields) }
+
+    let(:id) { 200 }
+
+    let(:fields_query) { fields ? "fields=#{fields.join(',')}" : nil }
+
+    before do
+      stub_request(:get, "https://#{host}/rest/v1/lead/#{id}.json?#{fields_query}")
+        .to_return(json_stub(response_stub))
+    end
+
+    context 'when no fields are given' do
+      let(:fields) { nil }
+      let(:response_stub) do
+        {
+          requestId: '1134#169a69aae86',
+          result: [
+            {
+              id: id,
+              firstName: 'John',
+              lastName: 'Snow',
+              email: 'jfrost@mrkt.com',
+              updatedAt: '2019-03-19T20:39:23Z',
+              createdAt: '2019-03-14T13:41:37Z'
+            }
+          ],
+          success: true
+        }
+      end
+
+      it { is_expected.to eq(response_stub) }
+    end
+
+    context 'when an array of fields is given' do
+      let(:fields) { %w[email dateOfBirth] }
+      let(:response_stub) do
+        {
+          requestId: '33dd#169a6b5ba65',
+          result: [
+            {
+              id: id,
+              email: 'jfrost@mrkt.com',
+              dateOfBirth: '1813-03-15'
+            }
+          ],
+          success: true
+        }
+      end
+
+      it { is_expected.to eq(response_stub) }
+    end
+  end
+
   describe '#get_leads' do
     let(:filter_type) { 'email' }
-    let(:filter_values) { %w(user@example.com) }
+    let(:filter_values) { %w[user@example.com] }
     let(:response_stub) do
       {
         requestId: 'c245#14cd6830ae2',
@@ -157,7 +211,7 @@ describe Mrkt::CrudLeads do
     subject { client.merge_leads(id, losing_lead_ids) }
 
     before do
-      params = Faraday::Utils::ParamsHash.new
+      params = ::Faraday::Utils::ParamsHash.new
       params[:mergeInCRM] = false
       params[:leadIds] = losing_lead_ids.join(',') if losing_lead_ids
 
@@ -196,4 +250,52 @@ describe Mrkt::CrudLeads do
       end
     end
   end
+
+  describe '#describe_lead' do
+    let(:response_stub) do
+      {
+        requestId: '5c9e#169a68fa806',
+        result: [
+          {
+            id: 4,
+            displayName: 'Company Name',
+            dataType: 'string',
+            length: 255,
+            rest: {
+              name: 'company',
+              readOnly: false
+            },
+            soap: {
+              name: 'Company',
+              readOnly: false
+            }
+          },
+          {
+            id: 56,
+            displayName: 'Email Address',
+            dataType: 'email',
+            length: 255,
+            rest: {
+              name: 'email',
+              readOnly: false
+            },
+            soap: {
+              name: 'Email',
+              readOnly: false
+            }
+          }
+        ],
+        success: true
+      }
+    end
+
+    subject { client.describe_lead }
+
+    before do
+      stub_request(:get, "https://#{host}/rest/v1/leads/describe.json")
+        .to_return(json_stub(response_stub))
+    end
+
+    it { is_expected.to eq(response_stub) }
+  end
 end

data/spec/concerns/crud_lists_spec.rb

@@ -63,4 +63,37 @@ describe Mrkt::CrudLists do
 
     it { is_expected.to eq(response_stub) }
   end
+
+  describe '#remove_leads_from_list' do
+    let(:list_id) { '1001' }
+    let(:lead_ids) { ['1'] }
+    let(:request_body) do
+      {
+        input: [
+          { id: '1' }
+        ]
+      }
+    end
+    let(:response_stub) do
+      {
+        requestId: '10de4#1697e81c821',
+        result: [
+          {
+            id: 1,
+            status: 'removed'
+          }
+        ],
+        success: true
+      }
+    end
+    subject { client.remove_leads_from_list(list_id, lead_ids) }
+
+    before do
+      stub_request(:delete, "https://#{host}/rest/v1/lists/#{list_id}/leads.json")
+        .with(json_stub(request_body))
+        .to_return(json_stub(response_stub))
+    end
+
+    it { is_expected.to eq(response_stub) }
+  end
 end

data/spec/concerns/import_leads_spec.rb

@@ -5,7 +5,7 @@ describe Mrkt::ImportLeads do
   include_context 'initialized client'
 
   describe '#import_lead' do
-    let(:tempfile) { Tempfile.new(['import-leads', 'csv']) }
+    let(:tempfile) { Tempfile.new(%w[import-leads csv]) }
     let(:response_stub) do
       {
         requestId: 'c245#14cd6830ae2',
@@ -22,8 +22,8 @@ describe Mrkt::ImportLeads do
 
     before do
       CSV.open(tempfile, 'wb') do |csv|
-        csv << %w(email firstName lastName)
-        csv << %w(sample@example.com John Snow)
+        csv << %w[email firstName lastName]
+        csv << %w[sample@example.com John Snow]
       end
 
       stub_request(:post, "https://#{host}/bulk/v1/leads.json")

data/spec/faraday/params_encoder_spec.rb

@@ -0,0 +1,24 @@
+describe Mrkt::Faraday::ParamsEncoder do
+  describe '.encode' do
+    let(:params) do
+      {
+        string: 'foobar',
+        number: 1,
+        boolean: true,
+        array: [1, 2, 3]
+      }
+    end
+
+    subject { described_class.encode(params) }
+
+    it { is_expected.to eq(Faraday::Utils::ParamsHash.new.merge(params.merge(array: '1,2,3')).to_query) }
+  end
+
+  describe '.decode' do
+    let(:value) { 'foo=foo&bar=bar' }
+
+    subject { described_class.decode(value) }
+
+    it { is_expected.to eq('foo' => 'foo', 'bar' => 'bar') }
+  end
+end

data/spec/spec_helper.rb

@@ -8,7 +8,9 @@ Bundler.setup
 
 require 'mrkt'
 
-Dir[File.expand_path('spec/support/**/*.rb')].each { |f| require f }
+Dir[File.expand_path('spec/support/**/*.rb')].sort.each do |file|
+  require file
+end
 
 RSpec.configure do |config|
   config.default_formatter = :doc if config.files_to_run.one?

data/spec/support/webmock.rb

@@ -1,16 +1,10 @@
 require 'webmock/rspec'
 
-RSpec.configure do |config|
+RSpec.configure do
   def json_stub(content_stub)
     {
       headers: { content_type: 'application/json' },
       body: JSON.generate(content_stub)
     }
   end
-
-  if ENV['CODECLIMATE_REPO_TOKEN']
-    config.after(:suite) do
-      WebMock.disable_net_connect!(allow: 'codeclimate.com')
-    end
-  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mrkt
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 1.0.1
 platform: ruby
 authors:
 - KARASZI István
@@ -9,48 +9,36 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-19 00:00:00.000000000 Z
+date: 2020-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
-      - !ruby/object:Gem::Version
-        version: 0.9.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.0
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
-      - !ruby/object:Gem::Version
-        version: 0.9.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.0
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
-      - !ruby/object:Gem::Version
-        version: 0.9.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.13.0
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
-      - !ruby/object:Gem::Version
-        version: 0.9.0
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.13.0
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -66,103 +54,103 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: gem-release
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '3.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '3.7'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.21.0
+        version: '12.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.21.0
+        version: '12.3'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.1
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.1
+        version: '3.2'
 - !ruby/object:Gem::Dependency
-  name: pry-byebug
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.4.0
+        version: 0.87.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.4.0
+        version: 0.87.1
 - !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 0.17.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 0.17.1
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.45.0
+        version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.45.0
+        version: '3.1'
 description: This gem helps you to use the Marketo REST API
 email:
 - github@spam.raszi.hu
@@ -177,6 +165,7 @@ files:
 - ".travis.yml"
 - Gemfile
 - Gemfile.lock
+- LICENSE
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -184,6 +173,8 @@ files:
 - lib/mrkt/concerns/authentication.rb
 - lib/mrkt/concerns/connection.rb
 - lib/mrkt/concerns/crud_activities.rb
+- lib/mrkt/concerns/crud_asset_folders.rb
+- lib/mrkt/concerns/crud_asset_static_lists.rb
 - lib/mrkt/concerns/crud_campaigns.rb
 - lib/mrkt/concerns/crud_custom_activities.rb
 - lib/mrkt/concerns/crud_custom_objects.rb
@@ -194,12 +185,16 @@ files:
 - lib/mrkt/concerns/import_custom_objects.rb
 - lib/mrkt/concerns/import_leads.rb
 - lib/mrkt/errors.rb
+- lib/mrkt/faraday.rb
+- lib/mrkt/faraday/params_encoder.rb
 - lib/mrkt/faraday_middleware.rb
 - lib/mrkt/faraday_middleware/response.rb
 - lib/mrkt/version.rb
 - mrkt.gemspec
 - spec/concerns/authentication_spec.rb
 - spec/concerns/crud_activities_spec.rb
+- spec/concerns/crud_asset_folders_spec.rb
+- spec/concerns/crud_asset_static_lists_spec.rb
 - spec/concerns/crud_campaigns_spec.rb
 - spec/concerns/crud_custom_activities_spec.rb
 - spec/concerns/crud_custom_objects_spec.rb
@@ -209,6 +204,7 @@ files:
 - spec/concerns/import_custom_objects_spec.rb
 - spec/concerns/import_leads_spec.rb
 - spec/errors_spec.rb
+- spec/faraday/params_encoder_spec.rb
 - spec/mkto_rest_spec.rb
 - spec/spec_helper.rb
 - spec/support/initialized_client.rb
@@ -225,21 +221,22 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - "~>"
     - !ruby/object:Gem::Version
-      version: '2.0'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Marketo REST API Facade
 test_files:
 - spec/concerns/authentication_spec.rb
 - spec/concerns/crud_activities_spec.rb
+- spec/concerns/crud_asset_folders_spec.rb
+- spec/concerns/crud_asset_static_lists_spec.rb
 - spec/concerns/crud_campaigns_spec.rb
 - spec/concerns/crud_custom_activities_spec.rb
 - spec/concerns/crud_custom_objects_spec.rb
@@ -249,6 +246,7 @@ test_files:
 - spec/concerns/import_custom_objects_spec.rb
 - spec/concerns/import_leads_spec.rb
 - spec/errors_spec.rb
+- spec/faraday/params_encoder_spec.rb
 - spec/mkto_rest_spec.rb
 - spec/spec_helper.rb
 - spec/support/initialized_client.rb