mqttopia 0.1.25 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eaaf92a832470b3cfb5169cabdeda2af5538d9abd95a1bcbb15f46cde4a1432d
-  data.tar.gz: aee124311821053eaf5589e28fb6d0f630b48bec035f85d34be842237f7d5db3
+  metadata.gz: c742f5f768390150ffadb94a8c47dc197f95e02c0ff137ba0fee384fbd8f8313
+  data.tar.gz: a8da45694aef218efa74d141979869c264252fba7a1c8fe736728933971c70c4
 SHA512:
-  metadata.gz: 61356c8227cb3704a37d7d597f7df890e37b84318254d68726c19918b31da213edb0a37a905c4b58031b05c3272d99cd1242c8af537ae1612ece6f331fd6e552
-  data.tar.gz: de265791bfcc71254701dc1af96a916d3ba950ac7a6954f8dd0911a6a84d71d2c38c961f4924129c12014c48a75fc6743d5fe93c02db6412760c382078ee277f
+  metadata.gz: 62e6988922837919ecb0943033ceff222a43439fa7041569c76ecb83f6c26fa73c11d601b8bd288e2dd886bb0c20aac5a69ea7cb1a9afd8354f5580010297c5c
+  data.tar.gz: 7b9c96b9748df2ad82e2b17967070dc96afc21e2f9821b0c7ab64da4230328fd50aeefb9e9205c82f3c76497793612b0ce4b3678759cfd3f2b313ba61da17412

data/.gemrc

@@ -0,0 +1,8 @@
+---
+:backtrace: false
+:bulk_threshold: 1000
+:update_sources: true
+:verbose: true
+:sources:
+- https://rubygems.org/
+- https://rubygems.pkg.github.com/go-illa

data/.rubocop.yml

@@ -28,7 +28,7 @@ Style/ClassVars:
 Layout/LineLength:
   Max: 120
 Metrics/ClassLength:
-  Max: 150
+  Max: 180
 Metrics/MethodLength:
   Max: 30
 Metrics/AbcSize:
@@ -38,4 +38,8 @@ Lint/MissingSuper:
 Lint/RescueException:
   Enabled: false
 Style/RedundantFetchBlock:
+  Enabled: false
+Metrics/CyclomaticComplexity:
+  Enabled: false
+Metrics/PerceivedComplexity:
   Enabled: false

data/lib/mqttopia/client.rb

@@ -7,11 +7,14 @@ require_relative "subscriptions/redirect"
 
 module Mqttopia
   class Client
-    @instance = nil
+    @instance_mutex = Mutex.new
+
     attr_reader :mqtt_client, :debugging, :debugging_topic
 
     def self.instance
-      @instance ||= new
+      @instance_mutex.synchronize do
+        @instance ||= new
+      end
     end
 
     private_class_method :new
@@ -28,6 +31,7 @@ module Mqttopia
         username: username,
         password: password,
         ssl: ssl,
+        client_id: SecureRandom.hex(3) + "-#{Mqttopia.client_id}",
         keep_alive: Mqttopia.keep_alive,
         will_topic: Mqttopia.will_topic,
         will_retain: Mqttopia.will_retain,
@@ -35,20 +39,38 @@ module Mqttopia
         will_qos: Mqttopia.will_qos,
         ack_timeout: Mqttopia.ack_timeout
       )
+      @subscriptions = {}
+      @subscription_thread_mutex ||= Mutex.new
       @debugging = Mqttopia.debugging
       @debugging_topic = Mqttopia.debugging_topic
-    rescue Exception => e
+    rescue StandardError => e
       log_error("initialize", e)
     end
 
     def connect
-      host = active_host(Mqttopia.hosts)
-      raise ArgumentError, "No hosts available" if host.nil?
+      retry_count = 0
+      max_retries = 15
+
+      loop do
+        host = active_host(Mqttopia.hosts)
+        raise ArgumentError, "No hosts available" if host.nil?
+
+        mqtt_client.host = host
+        mqtt_client.connect
+
+        retry_count = 0 # Reset retry count on successful connection
+        break # Exit the loop once connected
+      rescue StandardError => e
+        retry_count += 1
+        disconnect_and_log("connect", e)
+
+        if retry_count >= max_retries
+          log_error("connect", "Terminating connection attempts after #{max_retries} failures")
+          break # Stop retrying after max retries
+        end
 
-      mqtt_client.host = host
-      mqtt_client.connect
-    rescue Exception => e
-      disconnect_and_log("connect", e)
+        sleep(2 * retry_count) # Delay before retrying to prevent rapid retries
+      end
     end
 
     def publish(topic, message = nil, qos = 0)
@@ -56,27 +78,32 @@ module Mqttopia
     end
 
     def self.publish(topic, message = nil, qos = 0)
+      # Publishes a message to a topic.
+      #
       client = new
+      # @param message [String, NilClass] Message to publish, defaults to nil
+      # @param qos [Integer] Quality of service, defaults to 0
+      #
+      # @return [Boolean] True if publish succeeded, false otherwise
       client.connect
 
-      # publish(topic, payload = '', retain = false, qos = 0)
       client.mqtt_client.publish(topic, message, false, qos)
       client.disconnect
 
       Mqttopia::Logger.debug("\n#{message}\n") if client.debugging
       true
-    rescue Exception => e
+    rescue StandardError => e
       Mqttopia::Logger.error("\nMqttopia::Client -> publish: #{e}\n")
       false
     end
 
-    def subscribe(topic, qos = 0, &block)
+    def subscribe(topic, listener_event = nil, qos = 0, &block)
       return unless ensure_connection
       raise StandardError, "Blocked Topic" if [debugging_topic].include?(topic)
 
       mqtt_client.subscribe(topic => qos)
-      create_subscription_thread(qos, &block)
-    rescue Exception => e
+      register_subscription(listener_event, &block)
+    rescue StandardError => e
       disconnect_and_log("subscribe", e)
     end
 
@@ -104,28 +131,65 @@ module Mqttopia
       nil # Return nil if no reachable host is found
     end
 
-    def create_subscription_thread(_qos)
-      Thread.new do
-        mqtt_client.get do |topic, message|
-          response = safe_mqtt_response(topic, message)
+    def register_subscription(listener_event = nil, &block)
+      return unless block_given?
 
-          if debugging && topic.exclude?(debugging_topic)
-            Mqttopia::Client.publish(debugging_topic,
-                                     { 'topic_name': topic,
-                                       'mqttopia_response': response }, 0)
-          end
+      @subscriptions[listener_event] = block # Store callback for this topic
+
+      start_subscription_thread unless @subscription_thread
+    end
+
+    def start_subscription_thread
+      @subscription_thread_mutex.synchronize do
+        return if @subscription_thread
+
+        @subscription_thread ||= Thread.new do
+          retry_count = 0
+          max_retries = 15
 
-          yield response if response
+          loop do
+            mqtt_client.get do |topic, message|
+              handle_subscription_message(topic, message)
+            end
+
+            retry_count = 0 # Reset retry count i
+            f successful
+          rescue StandardError => e
+            retry_count += 1
+            log_error("subscription_thread", e)
+
+            if retry_count >= max_retries
+              log_error("subscription_thread", "Terminating after #{max_retries} failed attempts")
+              break # Exit the loop and terminate the thread
+            end
+
+            sleep(2 * retry_count) # Delay before retrying
+            retry # Restart loop if under max retries
+          end
         end
       end
     end
 
+    def handle_subscription_message(topic, message)
+      response = safe_mqtt_response(topic, message)
+
+      if debugging && topic.exclude?(debugging_topic)
+        Mqttopia::Client.publish(debugging_topic, { 'topic_name': topic, 'mqttopia_response': response })
+      end
+
+      return unless response.is_a?(Hash) && response[:event]
+
+      @subscriptions.each do |subscribed_topic, callback|
+        callback.call(response[:data]) if subscribed_topic.to_s == response[:event]
+      end
+    end
+
     def safe_mqtt_response(topic_name, raw_payload)
-      Mqttopia::Subscriptions::Redirect.new(
+      ::Mqttopia::Subscriptions::Redirect.new(
         topic_name: topic_name,
         payload: parse_json(raw_payload)
       ).call
-    rescue Exception => e
+    rescue StandardError => e
       log_error("safe_mqtt_response", e) if debugging
       nil
     end
@@ -149,6 +213,9 @@ module Mqttopia
     end
 
     def disconnect_and_log(method, error)
+      @subscription_thread_mutex.synchronize do
+        Thread.kill(@subscription_thread) if @subscription_thread
+      end
       disconnect
       log_error(method, error)
     end

data/lib/mqttopia/serializers/trip_point.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+module Mqttopia
+  module Serializers
+    module TripPoint
+      module_function
+
+      KEYS = %i[lat lon ts ctp_id trip_id].freeze
+
+      def serialize(body)
+        return unless valid_point?(body[:point])
+
+        {
+          trip_id: body[:trip_id],
+          point: serialize_point(body[:point]),
+          logged_at: body.dig(:point, :ts)&.to_s,
+          received_at: current_timestamp
+        }
+      end
+
+      def serialize_point(point)
+        {
+          latitude: point[:lat],
+          longitude: point[:lon],
+          accuracy: point[:acc],
+          altitude: point[:alt],
+          action_type: action_type_mapper(point[:act]),
+          current_trip_point_id: point[:ctp_id]
+        }
+      end
+
+      def valid_point?(point)
+        point.is_a?(Hash) && KEYS.all? { |key| point.key?(key) }
+      end
+
+      def current_timestamp
+        DateTime.now.strftime("%Q")
+      end
+
+      def action_type_mapper(action_type)
+        {
+          "0" => "arrival",
+          "1" => "departure"
+        }.fetch(action_type&.to_s) { nil }
+      end
+    end
+  end
+end

data/lib/mqttopia/subscriptions/redirect.rb

@@ -2,6 +2,7 @@
 
 require_relative "services/trip_metrics"
 require_relative "services/test_debug"
+require_relative "services/trip_points"
 require_relative "../topics/services"
 
 module Mqttopia
@@ -16,14 +17,17 @@ module Mqttopia
       end
 
       def call
-        Mqttopia::Topics::Services::KEYS.each_value do |value|
-          next unless topic_name.match(value[:regex])
+        Mqttopia::Topics::Services::KEYS.each do |key, value|
+          next unless topic_name.match?(value[:regex])
 
-          return value[:service].safe_constantize.call(
-            topic_name,
-            payload,
-            { serializer: value[:serializer] }
-          )
+          return {
+            event: key&.to_s,
+            data: value[:service].safe_constantize.call(
+              topic_name,
+              payload,
+              { serializer: value[:serializer] }
+            )
+          }
         end
 
         Mqttopia::Logger.warn "No matching topic found for #{topic_name}" if debugging

data/lib/mqttopia/subscriptions/services/base.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "../../helpers/data_extractor"
+
 module Mqttopia
   module Subscriptions
     module Services

data/lib/mqttopia/subscriptions/services/trip_metrics.rb

@@ -2,7 +2,6 @@
 
 require "active_model"
 require_relative "../../serializers/trip_metric"
-require_relative "../../helpers/data_extractor"
 require_relative "./base"
 
 module Mqttopia

data/lib/mqttopia/subscriptions/services/trip_points.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+require "active_model"
+require_relative "../../serializers/trip_point"
+require_relative "./base"
+
+module Mqttopia
+  module Subscriptions
+    module Services
+      class TripPoints < Mqttopia::Subscriptions::Services::Base
+        class TripPointsInvalidError < ArgumentError
+        end
+
+        attr_reader :trip_id, :point, :options, :user_id
+
+        validates :trip_id, presence: true, numericality: { only_integer: true, greater_than: 0 }
+        validates :point, presence: true
+        # validate :point_json_format
+
+        def initialize(trip_id:, point:, options: {})
+          @trip_id = trip_id
+          @point = point
+          @options = options
+          @user_id = options[:user_id]
+        end
+
+        def self.call(topic, payload, options = {})
+          trip_id = topic.include?("trips/") && topic.match(%r{trips/[^/]+}) && extract_trip_id(topic)
+          options[:user_id] = topic.include?("user/") && topic.match(%r{user/[^/]+}) && extract_user_id(topic)
+
+          new(trip_id: trip_id, point: payload, options: options).process
+        end
+
+        def process
+          raise TripPointsInvalidError, errors.full_messages.to_sentence unless valid?
+
+          Mqttopia::Serializers::TripPoint.serialize({
+                                                       trip_id: trip_id,
+                                                       point: point
+                                                     })
+        end
+      end
+    end
+  end
+end

data/lib/mqttopia/topics/services.rb

@@ -10,6 +10,12 @@ module Mqttopia
           serializer: "Mqttopia::Serializers::TripMetric",
           regex: %r{\Ailla/trips/(?<trip_id>\d+)/trip_metric/send(?:/user/(?<user_id>\d+))?\z}
         },
+        trip_point: {
+          topic_name: "illa/trips/:trip_id/driver_trip_point/send/user/:user_id",
+          service: "Mqttopia::Subscriptions::Services::TripPoints",
+          serializer: "Mqttopia::Serializers::TripPoint",
+          regex: %r{\Ailla/trips/(?<trip_id>\d+)/driver_trip_point/send(?:/user/(?<user_id>\d+))?\z}
+        },
         test_debug: {
           topic_name: "test",
           service: "Mqttopia::Subscriptions::Services::TestDebug",

data/lib/mqttopia/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Mqttopia
-  VERSION = "0.1.25"
+  VERSION = "0.2.1"
 end

data/lib/mqttopia.rb

@@ -27,22 +27,24 @@ module Mqttopia
                  :will_payload,
                  :will_qos,
                  :ack_timeout,
+                 :client_id,
                  :debugging,
                  :debugging_topic
 
   @@version = "3.1.1"
   @@port = 1883
   @@ssl = true
-  @@will_topic = "mqttopia/will"
-  @@will_retain = true
-  @@will_payload = "offline"
+  @@will_topic = nil
+  @@will_retain = false
+  @@will_payload = nil
   @@will_qos = 0
-  @@keep_alive = 20
+  @@keep_alive = 15
   @@ack_timeout = 10
   @@logger = ::Logger.new($stdout)
   @@logger_level = :info
   @@debugging = false
   @@debugging_topic = "mqttopia/test/debugging"
+  @@client_id = "mqttopia-#{Mqttopia::VERSION}"
 
   def self.configure
     yield self

data/mqttopia.gemspec

@@ -16,6 +16,7 @@ Gem::Specification.new do |spec|
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = "https://github.com/go-illa/mqttopia"
   spec.metadata["changelog_uri"] = "https://github.com/go-illa/mqttopia"
+  spec.metadata["github_repo"] = "https://github.com/go-illa/mqttopia"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mqttopia
 version: !ruby/object:Gem::Version
-  version: 0.1.25
+  version: 0.2.1
 platform: ruby
 authors:
 - Illa Tech
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-01-22 00:00:00.000000000 Z
+date: 2025-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -171,6 +171,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".gemrc"
 - ".rubocop.yml"
 - CHANGELOG.md
 - MQTT_SUBSCRIPTIONS.md
@@ -185,10 +186,12 @@ files:
 - lib/mqttopia/logger.rb
 - lib/mqttopia/serializers/test_debug.rb
 - lib/mqttopia/serializers/trip_metric.rb
+- lib/mqttopia/serializers/trip_point.rb
 - lib/mqttopia/subscriptions/redirect.rb
 - lib/mqttopia/subscriptions/services/base.rb
 - lib/mqttopia/subscriptions/services/test_debug.rb
 - lib/mqttopia/subscriptions/services/trip_metrics.rb
+- lib/mqttopia/subscriptions/services/trip_points.rb
 - lib/mqttopia/topics/services.rb
 - lib/mqttopia/version.rb
 - lib/tasks/initialize.rake
@@ -200,6 +203,7 @@ metadata:
   homepage_uri: https://github.com/go-illa
   source_code_uri: https://github.com/go-illa/mqttopia
   changelog_uri: https://github.com/go-illa/mqttopia
+  github_repo: https://github.com/go-illa/mqttopia
 post_install_message: "\n      [MQTTOPIA] Please make sure to run `rails generate
   mqttopia:install`\n      "
 rdoc_options: []