moxml 0.5.27 → 0.5.28

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b9d156e4f8dfd71fc334b5626690f325a78abf95496bf19b6141bf649beeee58
-  data.tar.gz: 5f3c24b3211e8381d14a34c7c23781a808e2f55b1d73d06af3be0fe7d3640a75
+  metadata.gz: c393ef51976af7e0ccf0ff232d009863a0b2b7be044b70e8500beedb216bd122
+  data.tar.gz: 1718f58a399c09fc218b269faa62dbd52e50e2bbdcdea32e52f9c7e72ad05a8a
 SHA512:
-  metadata.gz: 1c5cd5d01ece3fcced5049148d2df776a1dcb9b1e95b0fe9a145caef05c0e2d5080b32214c7eb9f8f7bb277412827b413b3c59e38a49162241208944791a6ed6
-  data.tar.gz: 33faf5c9269c3c74a6def61ef3933a9bdc2caedf484e0144ca1c8e6465aeb1640bb47c3f44ce9c777ed5bbe8e9682efd840cb87d4eceedac764f4c496519fff3
+  metadata.gz: cf11cb89af1acd465fe769616d925e1c20fb3961953ed29483147ef67a132e09a52f763601a3397887f6ff49d42f4dddc2b27ce6f1f659d99062e332eb401cf2
+  data.tar.gz: 5033d59e77e627b40fb054036ac87ee45e5c60408e37dcb6ff2790cca7a3276f4a45ee62d36bab5ec2d9d7af038eb4c1467c84bd3174ace1b5fc73b483d0d8db

data/lib/moxml/adapter/leptris.rb

@@ -288,6 +288,19 @@ module Moxml
           return set_attribute_namespace(node, namespace) if node.is_a?(::Leptris::XML::Attr)
 
           element = node
+          if namespace.nil?
+            # Nil-clear contract (issue #164): undeclare the default
+            # namespace (xmlns="") and drop any name prefix — the
+            # element then reports no namespace, matching the other
+            # adapters. Elements that carried a PREFIX cannot fully
+            # detach the engine's namespace link (leptris-ruby#132):
+            # the name is unqualified and the undeclaration added, but
+            # the serializer may re-attach the old prefix until the
+            # engine grows a clear entry.
+            element.name = element.name.split(":", 2)[-1] if element.name.include?(":")
+            element.default_namespace = ""
+            return element
+          end
           prefix = namespace.is_a?(String) ? nil : namespace.prefix
           uri = namespace.is_a?(String) ? namespace : namespace.href
           if prefix.nil? || prefix.empty?

data/lib/moxml/adapter/oga.rb

@@ -170,6 +170,12 @@ module Moxml
         end
 
         def set_namespace(element, ns_or_string)
+          if ns_or_string.nil?
+            element.namespace_name = nil
+            set_attribute(element, "xmlns", "")
+            return element
+          end
+
           element.namespace_name = ns_or_string.to_s
           element
         end

data/lib/moxml/adapter/ox.rb

@@ -149,6 +149,12 @@ module Moxml
         def set_namespace(element, ns)
           return element unless element.is_a?(::Ox::Element) || element.is_a?(::Ox::Node)
 
+          if ns.nil?
+            set_attribute(element, "xmlns", "")
+            element.name = element.name.to_s.sub(/\A(?:\w+):/, "")
+            return element
+          end
+
           prefix = ns.prefix
           # attributes don't have attributes but can have a namespace prefix
           if element.is_a?(::Ox::Element)

data/lib/moxml/adapter/rexml.rb

@@ -485,6 +485,14 @@ module Moxml
 
         # add a namespace prefix to the element name AND a namespace definition
         def set_namespace(element, ns)
+          if ns.nil?
+            # Nil-clear contract (issue #164): the XML Namespaces 1.0
+            # undeclaration, plus an unqualified name.
+            element.add_namespace(nil, "") if element.is_a?(::REXML::Element)
+            element.name = element.name.to_s.sub(/\A(?:\w+):/, "")
+            return element
+          end
+
           prefix = ns.name.to_s.empty? ? "xmlns" : ns.name.to_s
           if element.is_a?(::REXML::Element)
             element.add_namespace(prefix,

data/lib/moxml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Moxml
-  VERSION = "0.5.27"
+  VERSION = "0.5.28"
 end

data/spec/integration/shared_examples/node_wrappers/namespace_behavior.rb

@@ -280,6 +280,12 @@ RSpec.shared_examples "Moxml::Namespace" do
         expect(root.namespace.uri).to eq("http://example.org/1")
         expect(child.namespace.uri).to eq("http://example.org/2")
       end
+
+      it "accepts namespace = nil without raising (issue #164)" do
+        cleared = context.parse(%(<r xmlns="urn:clear"><c>t</c></r>))
+        child = cleared.root.children.first
+        expect { child.namespace = nil }.not_to raise_error
+      end
     end
   end
 end

data/spec/moxml/adapter/leptris_spec.rb

@@ -273,6 +273,25 @@ RSpec.describe Moxml::Adapter::Leptris do
       end
     end
 
+    it "clears the namespace with nil — full contract (issue #164)" do
+      doc = ctx.parse(%(<r xmlns="urn:clear"><c>t</c></r>))
+      child = doc.root.children.first
+      child.namespace = nil
+      expect(child.namespace).to be_nil
+      expect(doc.to_xml).to include(%(<c xmlns="">t</c>))
+      reparsed = ctx.parse(doc.to_xml)
+      expect(reparsed.root.children.first.namespace).to be_nil
+    end
+
+    it "does not raise clearing a namespace from a prefixed element (issue #164)" do
+      # The engine cannot detach a prefix element's namespace link
+      # (leptris-ruby#132); the name is unqualified and the
+      # undeclaration added meanwhile.
+      doc = ctx.parse(%(<r xmlns:p="urn:p"><p:c>t</p:c></r>))
+      child = doc.root.children.first
+      expect { child.namespace = nil }.not_to raise_error
+    end
+
     it "refuses noblanks on readonly parses while the strip path is active" do
       # The strip mutates the tree; readonly freezes it at parse. On
       # bindings whose engine flag is libxml2-safe (probe), the flag

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: moxml
 version: !ruby/object:Gem::Version
-  version: 0.5.27
+  version: 0.5.28
 platform: ruby
 authors:
 - Ribose Inc.