moxml 0.5.155 → 0.5.157

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c6118a2cde5308a843923649c4d115a89c39f99a74e5cf5b0804c7c69ffe17ce
-  data.tar.gz: 97fd393417a588ed4ffea5c885982ead30553b76679c38edea3a466f8c093e23
+  metadata.gz: 87300d8760e99b65ddda1dd2163c09eeef602885700b8bf7159ee8cb06f708f5
+  data.tar.gz: 2bcf6f9deb2fd3bef73234ca9d2e9cac11771efc37e8339ecd2cbc82a2a9cb15
 SHA512:
-  metadata.gz: 4471e50a04a8b3432a56555eb5f45edaecfd20b704dc890d6f89f5c076752f8350fe7c95b8e8c58b9569add68900619561ef685706161b0dee2c4275f2a54c12
-  data.tar.gz: 04f39ca1432d7e910485b9305e9fe4aa042890f6dd49b80981bc262846152d1ab8fa5d6ac5a584c000612a491bc3625849ee3ed5c65694d892f462787d007115
+  metadata.gz: bfa9a5c9582fc99bae9aed8888c653ce3bdca81a3a5a3b32ed5be598eea5f0900793d9ef1f453cf8185a6838912a4f6393ae43038f1db2e6a9d1ca3a99c34dd6
+  data.tar.gz: e07cd31013b48ec143ef5840097c32cba6f00dff10141ca6f2e6371c98bde6ab98bdf920dc1e8701d5d2bea26d961d09d5c35d3229864beffa26e5066dc98e7c

data/.github/workflows/performance-release.yml

@@ -72,8 +72,25 @@ jobs:
       - name: Measure the scoreboard
         run: |
           SCORE_MARKDOWN=/tmp/section.md \
+            SCORE_JSON=/tmp/measured-scoreboard.json \
+            SCORE_PUBLISH=1 \
             bundle exec ruby benchmark/scoreboard.rb
 
+      - name: Upload the measured scoreboard
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: scoreboard-${{ github.event.workflow_run.id || 'dispatch' }}
+          # The measurement behind the published notes section plus the
+          # regenerated baseline + blocks: the data commit back to main
+          # rides a PR from these files (never a direct push).
+          path: |
+            /tmp/measured-scoreboard.json
+            benchmark/scoreboard.json
+            docs/_pages/performance.adoc
+            benchmark/README.md
+          if-no-files-found: ignore
+
       - name: Append the scoreboard to the release notes of the measured version
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

data/benchmark/README.md

@@ -27,7 +27,7 @@ with raw nokogiri on the same operation?**
 | --- | --------- | ---- |
 | `parse` | `Nokogiri::XML` vs `ctx.parse` on the catalog document | parity |
 | `serialize` | `doc.to_xml` | parity |
-| `xpath //field (count)` | node-set cardinality, nothing materialized | structural (parity paused; 1.9.380 evaluator regression, leptris-ruby#527) |
+| `xpath //field (count)` | node-set cardinality, nothing materialized | parity |
 | `xpath //field (each)` | iterate every result (wrapper materialization) | structural |
 | `attr pairs listing` | collect `[name, value]` for every record | parity |
 | `build add_element` | create + attach 300 records x 4 fields with attrs and text | structural |
@@ -66,9 +66,17 @@ SCORE_LOCK=1 SCORE_BASELINE=benchmark/scoreboard.json \
 Rows with a tracked upstream regression are logged as paused and do not
 fail the lock (`KNOWN_REGRESSIONS` in `scoreboard.rb`); they stay
 measured and published, and the entry is removed when its issue lands.
-The current entries are the three crossing-bound walk rows
-(`walk+read (warm)`, `walk+read (cold)`, `children recursion (cold)`)
-under leptris-ruby#527 (the 1.9.380 crossing regression).
+The current entries are the two cold crossing-bound walk rows
+(`walk+read (cold)`, `children recursion (cold)`) under
+leptris-ruby#527 (the per-element crossings of the 1.9.380+ line —
+facade-side, not evaluator-side: the engine's own eval and walk
+measured flat across 1.9.374→1.9.380). `walk+read (warm)` recovered
+above parity (1.15-1.17x on the release runs) and left the pause
+list — a future dip now fails the lock again. The count row's
+0.70x reading that opened #527 was the adapter minting every row
+before the caller asked (fixed by the deferred bulk mint); it
+measures 3.50x on the released tree and is promoted back to a
+parity row.
 
 A smoke run on a loaded machine:
 

data/benchmark/scoreboard.rb

@@ -51,7 +51,6 @@ module Scoreboard
   # the regressed value and the lock signal is lost. Remove an entry
   # when its issue lands.
   KNOWN_REGRESSIONS = {
-    "walk+read (warm)" => "leptris-ruby#527 (1.9.380 crossing regression)",
     "walk+read (cold)" => "leptris-ruby#527 (1.9.380 crossing regression)",
     "children recursion (cold)" =>
       "leptris-ruby#527 (1.9.380 crossing regression)",
@@ -191,11 +190,11 @@ module Scoreboard
         # opened leptris-ruby#527 was the adapter minting every row
         # before the caller asked (leptris-ruby#527 verification:
         # engine eval + count is ~0.75us and flat across the
-        # 1.9.374->1.9.380 line). The bulk mint is now deferred, so
-        # size answers from the result handle. Tracked here until a
-        # measured run confirms the row above the parity floor, then
-        # promote to :parity.
-        "xpath //field (count)" => [:structural,
+        # 1.9.374->1.9.380 line). The bulk mint is deferred (#444
+        # LazyBulkRows), so size answers from the result handle:
+        # the released tree measures 3.50x on both release runs
+        # (v0.5.155, v0.5.156) — the promotion condition above.
+        "xpath //field (count)" => [:parity,
                                     -> { baseline_doc.xpath("//field").size },
                                     -> { moxml_doc.xpath("//field").size }],
         # Materialized results: what a consumer iterating the set pays.
@@ -421,7 +420,14 @@ module Scoreboard
     when "parity"
       row["ratio"] >= PARITY_FLOOR ? "met" : "open (below parity)"
     when "structural"
-      "tracked (below parity)"
+      status =
+        if row["ratio"] >= PARITY_FLOOR
+          "tracked (at parity)"
+        else
+          "tracked (below parity)"
+        end
+      ref = KNOWN_REGRESSIONS[row["row"]]
+      ref ? "#{status}, paused: #{ref}" : status
     else
       "informational"
     end

data/lib/moxml/adapter/leptris.rb

@@ -1285,27 +1285,41 @@ module Moxml
           end
         end
 
-        # 1.9.381.0: the children_read face stopped reflecting
-        # post-splice state — Element#add_next_sibling lands the node
-        # in the tree (native bulk reads and walk_columnar see it) but
-        # leaves the face's child list stale. Probe the exact repro
-        # once: prime the face, splice, and require children_read to
-        # see the inserted node. Unsafe builds take the adapter
-        # children path; fixed builds restore the fast path
-        # automatically.
+        # 1.9.381.0: the children_read face served a version-stamped
+        # child memo (leptris-ruby#530) that raw-FFI writes did not
+        # advance (leptris-ruby#545) — the adapter bumps the version at
+        # every raw site (leptris-ruby#543), and the binding's own
+        # element splice bumps it in C, so the memo observes splices.
+        # Probe that contract once with a live splice through the same
+        # faces the adapter uses: prime the memo, splice via the
+        # binding's Element face (NativeNode has no add_*_ sibling
+        # method), and require children_read to see the inserted node.
+        # Unsafe builds take the adapter children path; fixed builds
+        # restore the fast path automatically. Bindings without the
+        # memo faces have nothing to go stale.
         def children_read_splice_safe?
           return @children_read_splice_safe unless @children_read_splice_safe.nil?
 
-          @children_read_splice_safe = begin
-            native_doc = ::Leptris::XML::Document.parse("<r><a/>\n<b/></r>")
-            root = native_doc.root
-            root.children_read.to_a # prime the face's child list
-            a = root.children.to_a.first
-            a.add_next_sibling(native_doc.create_element("x"))
-            root.children_read.to_a.map { |n| n.name.to_s } == %w[a x b]
-          rescue StandardError
-            false
-          end
+          @children_read_splice_safe =
+            if !NN.method_defined?(:children_read) ||
+                !::Leptris::XML::Document.method_defined?(:native_node)
+              true
+            else
+              begin
+                native_doc = ::Leptris::XML::Document.parse("<r><a/>\n<b/></r>")
+                root = native_doc.native_node
+                root.children_read.to_a # prime the version-stamped memo
+                a = root.children.to_a.first
+                bridged = ::Leptris::XML::Node.wrap(
+                  ::FFI::Pointer.new(a.address), native_doc
+                )
+                bridged.add_next_sibling(native_doc.create_element("x"))
+                names = root.children_read.to_a.map { |n| n.name.to_s }
+                names[0] == "a" && names[1] == "x"
+              rescue StandardError
+                false
+              end
+            end
         end
 
         def xpath_index_document(node)

data/lib/moxml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Moxml
-  VERSION = "0.5.155"
+  VERSION = "0.5.157"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: moxml
 version: !ruby/object:Gem::Version
-  version: 0.5.155
+  version: 0.5.157
 platform: ruby
 authors:
 - Ribose Inc.