moxml 0.5.138 → 0.5.140

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 20467d4026cf631dd85798aaaa47a53526e1a6c8e26b1583ac896e56bb0fa4b4
-  data.tar.gz: 3d3829939332dfd24a1d552308d10fd7c0dbbe6eed998a5292ec5a5d82d53def
+  metadata.gz: 40599a2ac65b555f44dd70acb32404c381886b86d1385e9d4cb9c516c613e3ae
+  data.tar.gz: 5ed6d5baf3ba27e62191b468da167f8ad1f844a961d6879fb6343308ca646b62
 SHA512:
-  metadata.gz: 353a615d10c7755a3d03a5dd13988eb57b1f30b2bc68f1506e68bc48d053deca42fd968cbba67f5df10cd14dff7da757bfd15f89a734cd1e607e34d3b319eb0a
-  data.tar.gz: bfa917028338657c3c09d91f32a964a653f4e50bc8d5abd1d0c7cf404d284d2efb216b0e62df1f17f1d731ef636c6d60bbe27a5f587ccca2c45bb65aa93c8e39
+  metadata.gz: 17709b3e62f6b7c19724b8c493dd1d46f44dc7f2c980d7c39a263be46d6118cad5be71f8493b2f23ed8a4ed214ab8e8c21be5790dfddf6e127302e280593f8d1
+  data.tar.gz: 8ff39e0c9ac39d25f9cfd931055461cc26da5852f12881a63d4bccebde698d4dacb29995c9f40b3242ca943a55a10b2a69a5ea524f88b00f0bf3f87bb9b5674d

data/lib/moxml/adapter/base.rb

@@ -303,6 +303,16 @@ module Moxml
         # validator raise; leptris gates on >= 1.9.321.0.
         XSD_SUPPORTED = false
 
+        # Issue #384: schema handles are adapter-native objects — a
+        # handle compiled through one adapter must not dispatch
+        # through another. Adapters with an XSD engine answer their
+        # handle type; the default (no engine) matches nothing, so a
+        # mismatched wrap raises a clear error at construction
+        # instead of a NoMethodError deep in the first validate.
+        def xsd_handle_match?(_handle)
+          false
+        end
+
         def xsd_compile(_schema_source)
           raise Moxml::NotImplementedError,
                 "XSD validation requires an adapter with an XSD engine"

data/lib/moxml/adapter/leptris.rb

@@ -92,8 +92,20 @@ module Moxml
       # NativeNode#[]), so the adapter's native fast paths speak to
       # the native layer through these bound entries — bind_call is
       # the same C dispatch without the shadow lookup.
+      # Always defined: nothing can be an instance of an anonymous
+      # class, so on the FFI-only lane is_a?(NN) is uniformly false
+      # and the ungated native-node conditionals keep their
+      # semantics without the compiled ext.
+      NN = NATIVE_READ_LAYER ? ::Leptris::XML::NativeNode : Class.new
+
+      # The binding's Document.parse gained the strict: kwarg later
+      # than the native layer's default-strict behavior — probe the
+      # face instead of version-gating (the RECOVER_MODE pattern).
+      STRICT_PARSE_KWARG =
+        ::Leptris::XML::Document.method(:parse)
+          .parameters.any? { |_, key| key == :strict }
+
       if NATIVE_READ_LAYER
-        NN = ::Leptris::XML::NativeNode
         NN_ATTRIBUTE = NN.instance_method(:attribute)
         NN_NAME = NN.instance_method(:name)
         NN_PARENT = NN.instance_method(:parent)
@@ -290,6 +302,11 @@ module Moxml
           ::Leptris::XML::XSD.compile(schema_source)
         end
 
+        def xsd_handle_match?(handle)
+          defined?(::Leptris::XML::XSD::Schema) &&
+            handle.is_a?(::Leptris::XML::XSD::Schema)
+        end
+
         def xsd_compile_file(path)
           unless XSD_SUPPORTED && ::Leptris::XML::XSD.respond_to?(:compile_file)
             raise Moxml::NotImplementedError,
@@ -397,6 +414,27 @@ module Moxml
         end
       end
 
+      class << self
+        # These three live OUTSIDE the NATIVE_READ_LAYER gate:
+        # ungated methods (register_mint_klasses!, the
+        # create/register seams) and the specs' singleton const_get
+        # read them, and on the FFI-only lane the gate's Identity
+        # classes do not exist. NATIVE_MUTATIONS_COHERENT is false
+        # without the native layer, so all three evaluate false
+        # there.
+        NATIVE_IDENTITY =
+          NATIVE_MUTATIONS_COHERENT &&
+          Gem::Version.new(::Leptris::VERSION) >= Gem::Version.new("1.9.174.4")
+
+        NATIVE_C_MINT =
+          NATIVE_IDENTITY &&
+          Gem::Version.new(::Leptris::VERSION) >= Gem::Version.new("1.9.255.2")
+
+        NATIVE_KLASS_CHILDREN =
+          NATIVE_IDENTITY &&
+          Gem::Version.new(::Leptris::VERSION) >= Gem::Version.new("1.9.193.2")
+      end
+
       if NATIVE_READ_LAYER
         # root NativeNode -> binding document (recorded at #root
         # mint; the native layer exposes no document accessor).
@@ -501,10 +539,6 @@ module Moxml
             TEXT.include(Reads)
           end
 
-          NATIVE_IDENTITY =
-            NATIVE_MUTATIONS_COHERENT &&
-            Gem::Version.new(::Leptris::VERSION) >= Gem::Version.new("1.9.174.4")
-
           # leptris-ruby#246 klass-propagating reads: the read
           # family (children/element_children/next_sibling/parent)
           # mints the mapped subclass per kind, so children arrive
@@ -521,14 +555,6 @@ module Moxml
           # classes — walked and built nodes arrive already carrying the
           # contract, and the Ruby shell mint drops out entirely
           # (moxml#288: the entire remaining walk/build gap).
-          NATIVE_C_MINT =
-            NATIVE_IDENTITY &&
-            Gem::Version.new(::Leptris::VERSION) >= Gem::Version.new("1.9.255.2")
-
-          NATIVE_KLASS_CHILDREN =
-            NATIVE_IDENTITY &&
-            Gem::Version.new(::Leptris::VERSION) >= Gem::Version.new("1.9.193.2")
-
           if NATIVE_KLASS_CHILDREN
             kind_classes = [
               Identity::ELEMENT,
@@ -1065,6 +1091,10 @@ module Moxml
             ::Leptris::XML::Document.parse(
               processed,
               readonly: options[:readonly] == true,
+              # The FFI fallback lane parses leniently by default —
+              # the strict intent must ride explicitly or strict
+              # callers silently get a best-effort tree.
+              **(options[:strict] && STRICT_PARSE_KWARG ? { strict: true } : {}),
               options: parse_flags(options, recover: recover,
                                             context: _context),
             )
@@ -1343,13 +1373,22 @@ module Moxml
         # comment, cdata, pi. Parsed documents register right after
         # the binding mint. Unregistered bindings (older floors, the
         # C-mint off) are unchanged — the shell path stays.
-        MINT_KIND_CLASSES = [
-          Identity::ELEMENT,
-          Identity::TEXT,
-          Identity::COMMENT,
-          Identity::CDATA,
-          Identity::PROCESSING_INSTRUCTION,
-        ].freeze
+        # Identity lives under the NATIVE_READ_LAYER gate — on the
+        # FFI-only lane (windows, or a binding whose native bundle
+        # fails to load) the constant must not be referenced at load
+        # time. register_mint_klasses! never reads it there
+        # (NATIVE_C_MINT is false).
+        MINT_KIND_CLASSES = if NATIVE_READ_LAYER
+                              [
+                                Identity::ELEMENT,
+                                Identity::TEXT,
+                                Identity::COMMENT,
+                                Identity::CDATA,
+                                Identity::PROCESSING_INSTRUCTION,
+                              ].freeze
+                            else
+                              [].freeze
+                            end
 
         def register_mint_klasses!(binding_doc)
           return binding_doc unless NATIVE_C_MINT && binding_doc
@@ -2349,7 +2388,7 @@ module Moxml
           # upstream (its absorbed_into? checks are not transitive) —
           # those keep the pin + adoption copy. Entity references
           # keep the marker flow below.
-          if NATIVE_DOC_ABSORB && !child.is_a?(NN) &&
+          if NATIVE_READ_LAYER && NATIVE_DOC_ABSORB && !child.is_a?(NN) &&
               child.is_a?(::Leptris::XML::Node) &&
               !child.is_a?(CustomizedLeptris::EntityReference)
             child_doc = child.document
@@ -2447,8 +2486,11 @@ module Moxml
           end
           # 1.9.311: an absorbed element source moves through the raw
           # engine faces — the binding's sibling insert drops it.
-          if new_node.is_a?(::Leptris::XML::Element) &&
-              !new_node.is_a?(::Leptris::XML::NativeNode)
+          # NATIVE_READ_LAYER: the absorb needs the raw engine add to
+          # land the source; on the FFI lane the binding's own insert
+          # handles it and the absorbed-source splice loses the node.
+          if NATIVE_READ_LAYER && new_node.is_a?(::Leptris::XML::Element) &&
+              !new_node.is_a?(NN)
             new_doc = new_node.document
             node_doc = node.document
             if new_doc && node_doc && !new_doc.equal?(node_doc)
@@ -2477,8 +2519,11 @@ module Moxml
           pin_foreign_owner_document(node, new_node)
           # 1.9.311: an absorbed element source moves through the raw
           # engine faces — the binding's sibling insert drops it.
-          if new_node.is_a?(::Leptris::XML::Element) &&
-              !new_node.is_a?(::Leptris::XML::NativeNode)
+          # NATIVE_READ_LAYER: the absorb needs the raw engine add to
+          # land the source; on the FFI lane the binding's own insert
+          # handles it and the absorbed-source splice loses the node.
+          if NATIVE_READ_LAYER && new_node.is_a?(::Leptris::XML::Element) &&
+              !new_node.is_a?(NN)
             new_doc = new_node.document
             node_doc = node.document
             if new_doc && node_doc && !new_doc.equal?(node_doc)

data/lib/moxml/adapter/nokogiri.rb

@@ -215,6 +215,10 @@ module Moxml
           ::Nokogiri::XML::Schema.new(schema_source.to_s)
         end
 
+        def xsd_handle_match?(handle)
+          handle.is_a?(::Nokogiri::XML::Schema)
+        end
+
         def xsd_compile_file(path)
           path = path.to_s
           # libxml2 resolves schemaLocation hrefs against the

data/lib/moxml/config.rb

@@ -47,7 +47,23 @@ module Moxml
       def runtime_default_adapter
         return opal_runtime_adapter if RUBY_ENGINE == "opal"
 
-        return PREFERRED_ADAPTER if leptris_preferred_available?
+        preferred = leptris_preferred_available?
+        return PREFERRED_ADAPTER if preferred == true
+
+        # Issue #384: a PRESENT-but-unusable leptris (broken native
+        # bundle, adapter load failure) must not degrade silently —
+        # validation semantics differ per adapter, so the
+        # substitution is announced. A machine without the gem at
+        # all is a normal nokogiri/rexml deployment: no noise.
+        if preferred == :broken
+          Kernel.warn(
+            "moxml: the leptris adapter is installed but unusable " \
+            "(see the preceding error); falling back to " \
+            "#{detect_loaded_adapter || FALLBACK_ADAPTER} — " \
+            "adapter-specific behavior (XSD validation, " \
+            "serialization) will differ",
+          )
+        end
 
         detect_loaded_adapter || FALLBACK_ADAPTER
       end
@@ -74,14 +90,19 @@ module Moxml
       def leptris_preferred_available?
         return @leptris_preferred_available if defined?(@leptris_preferred_available)
 
-        @leptris_preferred_available = begin
-          require "leptris"
-          Moxml::Adapter.load(:leptris)
-          Gem::Version.new(::Leptris::VERSION) >=
-            Gem::Version.new(Moxml::Adapter::Leptris::MINIMUM_BINDING_VERSION)
-        rescue LoadError, NameError
-          false
-        end
+        @leptris_preferred_available =
+          begin
+            require "leptris"
+            Moxml::Adapter.load(:leptris)
+            Gem::Version.new(::Leptris::VERSION) >=
+              Gem::Version.new(Moxml::Adapter::Leptris::MINIMUM_BINDING_VERSION)
+          rescue LoadError
+            # Not installed: a normal deployment shape, silent.
+            false
+          rescue NameError, Moxml::AdapterError
+            # Installed but unusable (adapter load failure): loud.
+            :broken
+          end
       end
 
       def detect_loaded_adapter

data/lib/moxml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Moxml
-  VERSION = "0.5.138"
+  VERSION = "0.5.140"
 end

data/lib/moxml/xsd.rb

@@ -92,6 +92,29 @@ module Moxml
       def initialize(handle, context)
         @handle = handle
         @context = context
+        assert_adapter_matches_handle!
+      end
+
+      # Issue #384: the handle is an adapter-native object; routing
+      # it through a different adapter's xsd_validate surfaced as a
+      # distant NoMethodError. Fail at the wrap with the mismatch
+      # named.
+      def assert_adapter_matches_handle!
+        adapter = @context.config.adapter
+        return if adapter.xsd_handle_match?(@handle)
+
+        raise Moxml::AdapterError.new(
+          "schema handle mismatch: #{handle_class_name(@handle)} " \
+          "cannot be validated through the " \
+          "#{adapter.respond_to?(:adapter_name) ? adapter.adapter_name : adapter} " \
+          "adapter — compile the schema through the same adapter " \
+          "that will validate it",
+          operation: "xsd_compile",
+        )
+      end
+
+      def handle_class_name(handle)
+        handle.class.name.split("::").last(2).join("::")
       end
 
       # Validate a node or raw XML string. Returns [] when valid.

data/spec/moxml/config_degradation_spec.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+# Issue #384: when the preferred default adapter is installed but
+# unusable, the silent substitution to the fallback adapter changed
+# validation semantics invisibly. The degradation now announces
+# itself; an install without the gem at all stays silent (a normal
+# deployment shape).
+RSpec.describe "Config default-adapter degradation" do
+  def with_broken_leptris
+    old_default_adapter =
+      Moxml::Config.instance_variable_get(:@default_adapter)
+    Moxml::Config.remove_instance_variable(:@default_adapter) if old_default_adapter
+    # The state a broken install produces (adapter load failure with
+    # the gem present): present-but-unusable, not absent.
+    Moxml::Config.instance_variable_set(:@leptris_preferred_available, :broken)
+    yield
+  ensure
+    Moxml::Config.remove_instance_variable(:@leptris_preferred_available)
+    Moxml::Config.instance_variable_set(:@default_adapter, :nokogiri)
+  end
+
+  it "warns loudly and names the fallback" do
+    with_broken_leptris do
+      expect do
+        Moxml::Config.default_adapter
+      end.to output(/leptris adapter is installed but unusable/).to_stderr
+    end
+  end
+
+  it "still answers a usable adapter" do
+    with_broken_leptris do
+      expect(Moxml::Config.default_adapter).to eq(:nokogiri)
+    end
+  end
+
+  it "keeps a working leptris install silent" do
+    expect do
+      Moxml::Config.default_adapter
+    end.not_to output(/unusable/).to_stderr
+  end
+end

data/spec/moxml/xsd_handle_mismatch_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+# Issue #384: a schema handle compiled through one adapter must not
+# dispatch through another — the misroute surfaced as a NoMethodError
+# far from its cause when a silently-degraded context resolved to
+# nokogiri while the handle came from the leptris API.
+RSpec.describe "Moxml::XSD::Schema handle/adapter matching" do
+  let(:leptris_ctx) { Moxml.new(:leptris) }
+  let(:nokogiri_ctx) { Moxml.new(:nokogiri) }
+
+  it "accepts a handle compiled through the same adapter" do
+    schema = leptris_ctx.xsd("<xsd:schema xmlns:xsd='http://www.w3.org/2001/XMLSchema'/>")
+    expect(schema).to be_a(Moxml::XSD::Schema)
+  end
+
+  it "raises a named mismatch at the wrap, not a distant NoMethodError" do
+    handle = leptris_ctx.config.adapter.xsd_compile(
+      "<xsd:schema xmlns:xsd='http://www.w3.org/2001/XMLSchema'/>",
+    )
+
+    expect do
+      Moxml::XSD::Schema.new(handle, nokogiri_ctx)
+    end.to raise_error(Moxml::AdapterError, /schema handle mismatch/)
+  end
+
+  it "keeps same-adapter validation working end to end" do
+    schema = nokogiri_ctx.xsd(
+      "<xsd:schema xmlns:xsd='http://www.w3.org/2001/XMLSchema'>" \
+      "<xsd:element name='r'/></xsd:schema>",
+    )
+    expect(schema.valid?(nokogiri_ctx.parse("<r/>"))).to be(true)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: moxml
 version: !ruby/object:Gem::Version
-  version: 0.5.138
+  version: 0.5.140
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-10-15 00:00:00.000000000 Z
+date: 2026-10-16 00:00:00.000000000 Z
 dependencies: []
 description: |
   Moxml is a unified XML manipulation library that provides a common API
@@ -491,6 +491,7 @@ files:
 - spec/moxml/cdata_spec.rb
 - spec/moxml/children_source_retention_spec.rb
 - spec/moxml/comment_spec.rb
+- spec/moxml/config_degradation_spec.rb
 - spec/moxml/config_spec.rb
 - spec/moxml/context_spec.rb
 - spec/moxml/css_spec.rb
@@ -585,6 +586,7 @@ files:
 - spec/moxml/xpath_capabilities_spec.rb
 - spec/moxml/xpath_spec.rb
 - spec/moxml/xsd_error_contract_spec.rb
+- spec/moxml/xsd_handle_mismatch_spec.rb
 - spec/moxml/xsd_release_spec.rb
 - spec/moxml/xsd_spec.rb
 - spec/moxml/xslt/stylesheet_spec.rb