moxml 0.5.136 → 0.5.137

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7ae551e19c600eba6d19a7a2a1c764275673d4ad7deba04d3778d407464ec8b9
-  data.tar.gz: e546f3c3290bfde650efb0d42625146abaf87f20741be65aee93ab8dad0a1c84
+  metadata.gz: 43beff2cbabe6c8800099bc8f56a76b4c2510c6158cb632984cd31c8c3893a24
+  data.tar.gz: e7d0540ce919c428a26b55805f0c78fc25de976c08f2639a83161eab6ffc3b4d
 SHA512:
-  metadata.gz: 30ba4c3744a7742dcde2b457fcfa99a0a32f7ddac8ebd721ca79eff029b0faeb4ab91b8577d4270975973933193594b3ff7e05926e7e84500dee25d20c90ce3b
-  data.tar.gz: 12791df8b1c31cc43204904abbe4f7b5e3f3d1e3e4be248637efbb67d734fe6be36f9384a6345be95ba3993efcec43c0f387086d63cafc623d0f63a66c9c69fa
+  metadata.gz: 8e33f465faabc1da5cc0c7233f70e60592e0080cb4897b81d98eb1b073fedeea21160d2252170e322c8a66b33f4899e1752f96b30555ba0959f4b6f2e46ecd8b
+  data.tar.gz: 29dde54bd4af8259207a708175309fdf9ad7fd3c4702eacf1e77a92d5fbfbd03b0993d2730c70ddb0c5b30edc41bbc4871e73d10334814fd51b813f2e6905629

data/lib/moxml/adapter/customized_leptris.rb

@@ -12,7 +12,6 @@ module Moxml
       autoload :Doctype, "moxml/adapter/customized_leptris/doctype"
       autoload :EntityReference, "moxml/adapter/customized_leptris/entity_reference"
       autoload :TextSegment, "moxml/adapter/customized_leptris/text_segment"
-      autoload :DocumentPI, "moxml/adapter/customized_leptris/document_pi"
     end
   end
 end

data/lib/moxml/adapter/leptris/document_parts.rb

@@ -83,8 +83,6 @@ module Moxml
             doc.root = child
           when ::Leptris::XML::ProcessingInstruction
             doc.add_pi(child.target, child.content.to_s)
-          when CustomizedLeptris::DocumentPI
-            doc.add_pi(child.target, child.data)
           when ::Leptris::XML::Text
             texts = attachments.get(doc, :document_text) || []
             texts << child

data/lib/moxml/adapter/leptris/markers.rb

@@ -20,8 +20,7 @@ module Moxml
 
           case native
           when CustomizedLeptris::Declaration, CustomizedLeptris::Doctype,
-             CustomizedLeptris::EntityReference, CustomizedLeptris::TextSegment,
-             CustomizedLeptris::DocumentPI
+             CustomizedLeptris::EntityReference, CustomizedLeptris::TextSegment
             true
           else
             # Parentless elements come only from Iterparse —

data/lib/moxml/adapter/leptris/serialize.rb

@@ -86,7 +86,7 @@ module Moxml
           # binding, so a Text branch first would swallow CDATA nodes.
           case node
           when CustomizedLeptris::Declaration, CustomizedLeptris::Doctype,
-               CustomizedLeptris::EntityReference, CustomizedLeptris::DocumentPI
+               CustomizedLeptris::EntityReference
             return node.to_xml
           when ::Leptris::XML::CDATA
             return XmlEmitter.cdata(node.content)

data/lib/moxml/adapter/leptris.rb

@@ -1639,7 +1639,7 @@ module Moxml
           when ::Leptris::XML::Text, CustomizedLeptris::TextSegment then :text
           when ::Leptris::XML::Attr, ::Leptris::XML::ResultAttr then :attribute
           when ::Leptris::XML::Comment then :comment
-          when ::Leptris::XML::ProcessingInstruction, CustomizedLeptris::DocumentPI then :processing_instruction
+          when ::Leptris::XML::ProcessingInstruction then :processing_instruction
           when ::Leptris::XML::Document then :document
           when ::Leptris::XML::DocType, CustomizedLeptris::Doctype then :doctype
           when CustomizedLeptris::Declaration then :declaration
@@ -1666,7 +1666,6 @@ module Moxml
 
         def node_name(node)
           return node.root_name if node.is_a?(::Leptris::XML::DocType)
-          return node.target if node.is_a?(CustomizedLeptris::DocumentPI)
 
           if NATIVE_READ_LAYER && node.is_a?(::Leptris::XML::NativeNode)
             # PIs expose no name through the native layer.
@@ -1684,7 +1683,7 @@ module Moxml
         def set_node_name(node, name)
           node = to_binding(node) if NATIVE_READ_LAYER
           case node
-          when ::Leptris::XML::ProcessingInstruction, CustomizedLeptris::DocumentPI then node.target = name
+          when ::Leptris::XML::ProcessingInstruction then node.target = name
           else node.name = name
           end
         end
@@ -1698,8 +1697,6 @@ module Moxml
             CustomizedLeptris::Doctype.new(node.name, node.external_id, node.system_id)
           when CustomizedLeptris::EntityReference
             CustomizedLeptris::EntityReference.new(node.name)
-          when CustomizedLeptris::DocumentPI
-            CustomizedLeptris::DocumentPI.new(node.target, node.data, node.parent_doc)
           else
             node.dup
           end
@@ -1796,7 +1793,6 @@ module Moxml
             assemble_document_children(node)
           when CustomizedLeptris::Declaration, CustomizedLeptris::Doctype,
                CustomizedLeptris::EntityReference, CustomizedLeptris::TextSegment,
-               CustomizedLeptris::DocumentPI,
                # Terminal node kinds pay an FFI round trip for an empty
                # list; unfiltered recursions visit every text node.
                ::Leptris::XML::Text, ::Leptris::XML::Comment,
@@ -1832,8 +1828,7 @@ module Moxml
           case node
           when ::Leptris::XML::Element then root_parent(node)
           when ::Leptris::XML::Document then nil
-          when CustomizedLeptris::Declaration, CustomizedLeptris::Doctype,
-               CustomizedLeptris::DocumentPI then node.parent_doc
+          when CustomizedLeptris::Declaration, CustomizedLeptris::Doctype then node.parent_doc
           when CustomizedLeptris::TextSegment, CustomizedLeptris::EntityReference then node.parent
           # Same body as the Element arm by design (frequency
           # ordering); the generic kinds are cold.
@@ -2535,23 +2530,6 @@ module Moxml
             end
           when CustomizedLeptris::EntityReference
             marker_text_for(node.parent, node.name)&.unlink
-          when CustomizedLeptris::DocumentPI
-            if NATIVE_DOC_PARTS && node.parent_doc
-              pis = node.parent_doc.processing_instructions
-              index = pis.index do |target, data|
-                target == node.target && data == node.data
-              end
-              if index
-                node.parent_doc.remove_pi(index)
-                node.parent_doc = nil
-              end
-            else
-              raise Moxml::NotImplementedError.new(
-                "libleptris has no document-level PI removal",
-                adapter: :leptris,
-                feature: :remove,
-              )
-            end
           else
             begin
               node.unlink

data/lib/moxml/attribute_resolver.rb

@@ -142,6 +142,16 @@ module Moxml
     # Remove the attribute named by XML-correct resolution (see
     # #assign for the name semantics).
     #
+    # #378: a bare name that matches no no-namespace attribute falls
+    # back to the SINGLE namespaced attribute carrying that local
+    # name — callers spelling the local part (the name
+    # attribute_nodes-style listings expose) expect removal, and the
+    # silent no-op broke remediation flows. Bare-name resolution
+    # keeps Namespaces 1.0 §5.2 semantics for reads; removal widens
+    # only when unambiguous. Several prefixed spellings sharing the
+    # local name remove nothing — guessing a prefix would corrupt
+    # documents.
+    #
     # @return [Moxml::Attribute, nil] the removed attribute
     def remove(element, name)
       name = name.to_s
@@ -153,6 +163,8 @@ module Moxml
       end
 
       attr = resolve(element, name)
+      attr ||= resolve_unique_local(element, name) unless name.include?(":")
+
       return nil unless attr
 
       adapter.remove_attribute_native(attr.native)
@@ -160,6 +172,17 @@ module Moxml
       attr
     end
 
+    # The single namespaced attribute whose local name matches, or
+    # nil when none or several do (see #remove).
+    def resolve_unique_local(element, local)
+      matches = element.attributes.select do |attr|
+        attr_name = attr.name
+        local_name(attr_name) == local &&
+          !attribute_uri(element, attr, attr_name).nil?
+      end
+      matches.one? ? matches.first : nil
+    end
+
     # XPath 1.0 attribute node test, sharing the resolver's
     # expanded-name semantics:
     #

data/lib/moxml/element.rb

@@ -233,11 +233,15 @@ module Moxml
       adapter.attachments.set(@native, :children_source_docs, merged)
     end
 
+    # Removes the attribute named by XML-correct resolution — a
+    # qualified name ("p:x"), or a bare name (the no-namespace
+    # attribute, falling back to the single namespaced attribute
+    # carrying that local name when no bare one exists, #378).
+    #
+    # @return [Moxml::Attribute, nil] the removed attribute, nil
+    #   when nothing matched (nokogiri-compatible)
     def remove_attribute(name)
-      # Both remove paths end in invalidate_attribute_cache!, which
-      # bumps the generation.
       Moxml::AttributeResolver.remove(self, name)
-      self
     end
 
     # Append a raw XML fragment's top-level nodes as children.

data/lib/moxml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Moxml
-  VERSION = "0.5.136"
+  VERSION = "0.5.137"
 end

data/spec/integration/shared_examples/node_wrappers/attribute_behavior.rb

@@ -126,6 +126,41 @@ RSpec.shared_examples "Moxml::Attribute" do
       end
     end
 
+    describe "removing by local name (#378)" do
+      before do
+        element.add_namespace("q", "http://x.org")
+        element["q:type"] = "namespaced"
+        element["type"] = "bare"
+      end
+
+      it "removes the single namespaced attribute carrying that local name" do
+        element.remove_attribute("type")
+        element.remove_attribute("type")
+
+        expect(element["q:type"]).to be_nil
+        expect(element["type"]).to be_nil
+        expect(element.attributes).to be_empty
+      end
+
+      it "returns the removed attribute, nil when nothing matched" do
+        removed = element.remove_attribute("type")
+
+        expect(removed).to be_a(described_class)
+        expect(element["type"]).to be_nil
+        expect(element.remove_attribute("nonexistent")).to be_nil
+      end
+
+      it "removes nothing when several prefixes share the local name" do
+        element.remove_attribute("type")
+        element.add_namespace("other", "http://other.org")
+        element["other:type"] = "second"
+
+        expect(element.remove_attribute("type")).to be_nil
+        expect(element["q:type"]).to eq("namespaced")
+        expect(element["other:type"]).to eq("second")
+      end
+    end
+
     describe "manipulation" do
       before do
         element["test"] = "value"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: moxml
 version: !ruby/object:Gem::Version
-  version: 0.5.136
+  version: 0.5.137
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-10-14 00:00:00.000000000 Z
+date: 2026-10-15 00:00:00.000000000 Z
 dependencies: []
 description: |
   Moxml is a unified XML manipulation library that provides a common API
@@ -134,7 +134,6 @@ files:
 - lib/moxml/adapter/customized_leptris.rb
 - lib/moxml/adapter/customized_leptris/declaration.rb
 - lib/moxml/adapter/customized_leptris/doctype.rb
-- lib/moxml/adapter/customized_leptris/document_pi.rb
 - lib/moxml/adapter/customized_leptris/entity_reference.rb
 - lib/moxml/adapter/customized_leptris/text_segment.rb
 - lib/moxml/adapter/customized_libxml.rb

data/lib/moxml/adapter/customized_leptris/document_pi.rb

@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-module Moxml
-  module Adapter
-    module CustomizedLeptris
-      # Document-level processing instruction. libleptris stores these
-      # outside the element tree (a flat, document-ordered list with no
-      # prolog/epilog anchoring — its serializer emits them all before
-      # the root), reachable through Document#processing_instructions
-      # as [target, data] pairs. This pseudo-native gives the pairs a
-      # node identity so the moxml contract can list them as document
-      # children (and answer mutations: creation routes native via
-      # add_pi; removal has no engine entry).
-      class DocumentPI
-        attr_accessor :target, :data, :parent_doc
-        alias content data
-        alias content= data=
-
-        def initialize(target, data = "", parent_doc = nil)
-          @target = target
-          @data = data.to_s
-          @parent_doc = parent_doc
-        end
-
-        def to_xml
-          data.empty? ? "<?#{target}?>" : "<?#{target} #{data}?>"
-        end
-
-        def ==(other)
-          other.is_a?(self.class) && target == other.target && data == other.data
-        end
-      end
-    end
-  end
-end