moxml 0.5.134 → 0.5.136

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 16541b7e14c315d57375c3ac583844239801ef5dd81e69e87df9f701553d62f9
-  data.tar.gz: dad46bc86c7f5617813cb03ccc9f60a3d9b9be2785a991ffb9932f29d78fcbe1
+  metadata.gz: 7ae551e19c600eba6d19a7a2a1c764275673d4ad7deba04d3778d407464ec8b9
+  data.tar.gz: e546f3c3290bfde650efb0d42625146abaf87f20741be65aee93ab8dad0a1c84
 SHA512:
-  metadata.gz: 99ef7ebe98b5722cff35e18f0862fba36628f9eef548bf166dc65cd3d207f1299706c7a7da92b17896ded2463f15114933b2ff17c79d549bf658620191974e48
-  data.tar.gz: 41506cc4e7ca3ea53dd8b275830814ec37bc138b8b4a174840d894aaf63dd7a97d7cf6d75ec0b3a9e12ff40c156262bcfa39bec155c828256d7aa1b2191fba56
+  metadata.gz: 30ba4c3744a7742dcde2b457fcfa99a0a32f7ddac8ebd721ca79eff029b0faeb4ab91b8577d4270975973933193594b3ff7e05926e7e84500dee25d20c90ce3b
+  data.tar.gz: 12791df8b1c31cc43204904abbe4f7b5e3f3d1e3e4be248637efbb67d734fe6be36f9384a6345be95ba3993efcec43c0f387086d63cafc623d0f63a66c9c69fa

data/lib/moxml/adapter/leptris.rb

@@ -194,6 +194,15 @@ module Moxml
         ::Leptris::XML::ParseOptions.instance_method(:initialize)
           .parameters.any? { |_, key| key == :recover }
 
+      # moxml#375 — the element-attribute snapshot (binding
+      # 1.9.353.0, engine leptris#1689): every attribute's
+      # qualified name and value in ONE crossing, replacing the
+      # per-attribute reads behind ::Leptris::XML::Element
+      # #attribute_pairs.
+      ELEMENT_ATTR_SNAPSHOT =
+        Gem::Version.new(::Leptris::VERSION) >= Gem::Version.new("1.9.353.0") &&
+        ::Leptris::XML::Element.method_defined?(:attributes_snapshot)
+
       # Markup-accumulating builder face (leptris-ruby#374 lever 2,
       # binding 1.9.313): the DSL accumulates markup in a plain
       # String and ONE native crossing (parse + attach) flushes the
@@ -2059,6 +2068,7 @@ module Moxml
         def attribute_pairs(element)
           binding_element = to_binding(element)
           return super unless binding_element.respond_to?(:attribute_pairs)
+          return binding_element.attributes_snapshot.to_a if ELEMENT_ATTR_SNAPSHOT
 
           binding_element.attribute_pairs
         end

data/lib/moxml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Moxml
-  VERSION = "0.5.134"
+  VERSION = "0.5.136"
 end

data/spec/moxml/adapter/leptris_attribute_snapshot_spec.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+# moxml#375 — element hydration through the binding's
+# attributes_snapshot face (libleptris 1.9.353, engine
+# leptris#1689): one crossing for every attribute instead of one
+# per attribute. The output contract is stride-identical to the
+# binding's per-attribute face: qualified names, document order,
+# fresh values.
+RSpec.describe "leptris element-attribute snapshot hydration" do
+  let(:ctx) { Moxml.new(:leptris) }
+
+  context "when the snapshot face is armed (>= 1.9.353.0)" do
+    before do
+      unless Moxml::Adapter::Leptris::ELEMENT_ATTR_SNAPSHOT
+        skip "binding #{Leptris::VERSION} has no attributes_snapshot face"
+      end
+    end
+
+    it "matches the binding per-attribute face stride for stride" do
+      doc = ctx.parse(
+        '<root a="1" xml:lang="en" xmlns:ns="urn:u" ns:p="v"/>',
+      )
+      binding_element = Moxml::Adapter::Leptris.to_binding(doc.root)
+      expected = binding_element.attribute_pairs
+
+      expect(doc.root.attribute_pairs).to eq(expected)
+      expect(doc.root.attribute_pairs).to eq(
+        [["a", "1"], ["xml:lang", "en"], ["ns:p", "v"]],
+      )
+    end
+
+    it "keeps document order across plain and prefixed attributes" do
+      doc = ctx.parse(
+        '<root z="9" xmlns:m="urn:m" m:x="8" k="7"/>',
+      )
+      expect(doc.root.attribute_pairs.map(&:first)).to eq(
+        %w[z m:x k],
+      )
+    end
+
+    it "keeps the per-attribute face's memoized-read semantics" do
+      doc = ctx.parse('<root a="1"/>')
+      first = doc.root.attribute_pairs
+      first[0][1] << "mutated"
+
+      # The wrapper memoizes attribute reads; the snapshot path
+      # preserves that (values are shared across reads exactly as
+      # the binding face's memo does).
+      expect(doc.root.attribute_pairs).to eq([["a", "1mutated"]])
+    end
+
+    it "hydrates child elements the same way" do
+      doc = ctx.parse('<r><child b="2" c="3"/></r>')
+      expect(doc.at("//child").attribute_pairs).to eq(
+        [["b", "2"], ["c", "3"]],
+      )
+    end
+
+    it "yields an empty list for attribute-less elements" do
+      doc = ctx.parse("<root/>")
+      expect(doc.root.attribute_pairs).to eq([])
+    end
+  end
+
+  context "with any arm state" do
+    it "agrees with the binding per-attribute face" do
+      doc = ctx.parse(
+        '<root a="1" xml:lang="en" xmlns:ns="urn:u" ns:p="v"/>',
+      )
+      binding_element = Moxml::Adapter::Leptris.to_binding(doc.root)
+      expect(doc.root.attribute_pairs).to eq(
+        binding_element.attribute_pairs,
+      )
+    end
+  end
+end

data/spec/moxml/adapter/leptris_strict_mismatch_spec.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+# Engine 1.9.355 (leptris#1700) names the tag mismatch in strict-parse
+# failures — "expected </a>, got </b>" instead of the generic
+# "malformed input". moxml passes the binding message through
+# verbatim, so strict callers get the diagnostic for free; the spec
+# pins it so a regression (or a re-genericization upstream) is caught.
+RSpec.describe "leptris strict-parse mismatch diagnostic" do
+  let(:ctx) { Moxml.new(:leptris) }
+
+  context "when the engine names the mismatch (>= 1.9.355.0)" do
+    before do
+      unless Gem::Version.new(Leptris::VERSION) >= Gem::Version.new("1.9.355.0")
+        skip "binding #{Leptris::VERSION} predates the mismatch diagnostic"
+      end
+    end
+
+    it "names expected and got in the raised message" do
+      expect do
+        ctx.parse("<root><a></b></root>", strict: true)
+      end.to raise_error(Moxml::ParseError) do |e|
+        expect(e.message).to include("tag mismatch")
+        expect(e.message).to include("</a>")
+        expect(e.message).to include("</b>")
+      end
+    end
+
+    it "reports the byte offset of the failure" do
+      expect do
+        ctx.parse("<root><a></b></root>", strict: true)
+      end.to raise_error(Moxml::ParseError, /byte 13/)
+    end
+  end
+
+  it "still raises Moxml::ParseError on strict parse failure" do
+    expect do
+      ctx.parse("<root><a></b></root>", strict: true)
+    end.to raise_error(Moxml::ParseError)
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: moxml
 version: !ruby/object:Gem::Version
-  version: 0.5.134
+  version: 0.5.136
 platform: ruby
 authors:
 - Ribose Inc.
@@ -450,6 +450,7 @@ files:
 - spec/moxml/adapter/headed_ox_spec.rb
 - spec/moxml/adapter/leptris_adoption_spec.rb
 - spec/moxml/adapter/leptris_append_gc_spec.rb
+- spec/moxml/adapter/leptris_attribute_snapshot_spec.rb
 - spec/moxml/adapter/leptris_binding_cap_spec.rb
 - spec/moxml/adapter/leptris_doc_parts_spec.rb
 - spec/moxml/adapter/leptris_parse_skips_spec.rb
@@ -457,6 +458,7 @@ files:
 - spec/moxml/adapter/leptris_sax_dup_attr_spec.rb
 - spec/moxml/adapter/leptris_sax_records_spec.rb
 - spec/moxml/adapter/leptris_spec.rb
+- spec/moxml/adapter/leptris_strict_mismatch_spec.rb
 - spec/moxml/adapter/leptris_xpath_identity_spec.rb
 - spec/moxml/adapter/libxml_internals_spec.rb
 - spec/moxml/adapter/libxml_spec.rb