moxml 0.5.119 → 0.5.120

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7a30730e871854c7b88fc3b6a3498b4f4d5504ac47caa2aabcc530f2bf0eec96
-  data.tar.gz: 8d4f301d7d100cab15cc55b4f0e3db36bc5e50916775adfd34f64b816546d466
+  metadata.gz: '08beda03b741fa08eec72ad7be564ecc57eda0446fbb8005fbf9a633d8233593'
+  data.tar.gz: cf087e7eeb0673b9085fc4d0c5f4f937fb7fb46a96e1186e000889169c201eb5
 SHA512:
-  metadata.gz: 4b61a839f7399e0b9e9236b1d921cfc161714b114d73da1b737a80c98795d8c88b96f8e85e71c3a71f58a090578b2ba6ffa4ec57cb9a6309cb53296bb000b277
-  data.tar.gz: b42fa624031b28da813039d441024be7766f8322fc54f247075b0c205cb79ec57052ababc789ab90f1c3b91b04a0ced4de85760af3178c1675aedd390fdd8046
+  metadata.gz: 95510cdd0f6ff20bde573e9ee0a1c6945fccf326c1557cc7891af74d633704cc8df3dbb912ef73e88f08888750f9a81e9345682cb67f672276b72c0741578e3f
+  data.tar.gz: c55e6d2963c9730cccda04d8e3ee22a6f5a295ac9f880ec498536afc9e5a5e493d34eed3b5970f4b422b7397c7cf1077e56a5c284b258c6e4cd89513ac10d53b

data/lib/moxml/adapter/leptris.rb

@@ -2220,11 +2220,22 @@ module Moxml
               # absorbed-source nodes upstream.
               child_doc = NN_DOCUMENT.bind_call(child)
               parent_doc = NN_DOCUMENT.bind_call(parent)
-              if child_doc && parent_doc &&
-                  !child_doc.equal?(parent_doc) && child.node_type == :element
-                absorb_source_document(to_binding(parent_doc), to_binding(child_doc))
-                return structural_adopt(parent, child) unless
-                  source_absorbed_into?(parent, child)
+              if child_doc && parent_doc && !child_doc.equal?(parent_doc)
+                if child.node_type == :element
+                  absorb_source_document(to_binding(parent_doc), to_binding(child_doc))
+                  return structural_adopt(parent, child) unless
+                    source_absorbed_into?(parent, child)
+                else
+                  # moxml#347: the C add_child's foreign-child
+                  # fallback dispatches parent.add_child through
+                  # RUBY — on Identity natives the contract modules
+                  # shadow the C method, so that dispatch re-enters
+                  # Moxml's add_child forever. Foreign content kinds
+                  # (text/comment/CDATA/PI) rebuild in the parent's
+                  # pool directly; they carry no cross-document
+                  # identity worth a move.
+                  return rebuild_foreign_child(parent, child)
+                end
               end
 
               doc = NN_DOCUMENT.bind_call(parent)

data/lib/moxml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Moxml
-  VERSION = "0.5.119"
+  VERSION = "0.5.120"
 end

data/spec/moxml/adapter/leptris_adoption_spec.rb

@@ -146,4 +146,46 @@ RSpec.describe "leptris cross-document adoption" do
       expect(doc.at("//r/e").text).to eq("t")
     end
   end
+
+  # moxml#347: the C add_child's foreign-child fallback dispatches
+  # parent.add_child through Ruby — on Identity natives the contract
+  # modules shadow the C method and the dispatch re-enters Moxml's
+  # add_child (SystemStackError). Foreign content kinds rebuild in
+  # the parent's pool; foreign elements absorb/move.
+  context "when adding foreign children (moxml#347)" do
+    let(:fragment_xml) do
+      "<__root__>hello<b attr=\"1\"/>world<!-- note --><?tgt data?><![CDATA[x < y]]></__root__>"
+    end
+
+    it "appends every node kind from a same-context fragment" do
+      doc = ctx.parse("<bibitem/>")
+      frag = ctx.parse(fragment_xml)
+      frag.root.children.each { |c| doc.root.add_child(c) }
+      expect(doc.root.to_xml).to include("<b attr=\"1\">")
+      expect(doc.root.text).to include("hello")
+      expect(doc.root.to_xml).to include("<!-- note -->")
+      expect(doc.root.to_xml).to include("<?tgt data?>")
+      expect(doc.root.to_xml).to include("<![CDATA[x < y]]>")
+    end
+
+    it "appends every node kind across contexts without recursing" do
+      doc = ctx.parse("<bibitem/>")
+      frag = Moxml.new(:leptris).parse(fragment_xml)
+      frag.root.children.each { |c| doc.root.add_child(c) }
+      expect(doc.root.to_xml).to include("<b attr=\"1\">")
+      expect(doc.root.to_xml).to include("<!-- note -->")
+      expect(doc.root.to_xml).to include("<?tgt data?>")
+      expect(doc.root.to_xml).to include("<![CDATA[x < y]]>")
+    end
+
+    it "moves foreign elements by reference (the absorb path stays first)" do
+      doc = ctx.parse("<r><a/></r>")
+      other = Moxml.new(:leptris).parse("<other><new/></other>")
+      child = other.root.children.first
+      doc.root.add_child(child)
+      expect(doc.root.children.last).to eq(child)
+      expect(child["probe"] = "1").to eq("1")
+      expect(doc.at("//r/new")["probe"]).to eq("1")
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: moxml
 version: !ruby/object:Gem::Version
-  version: 0.5.119
+  version: 0.5.120
 platform: ruby
 authors:
 - Ribose Inc.