moxml 0.5.108 → 0.5.110

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fff38acca654943d1500e6647de3b62fadbb6919e73a1a655c84718a47a08d20
-  data.tar.gz: cb163aac66d87cb7bb3140bfce8f682791b4cb8430bb435219d3d30141e5ada1
+  metadata.gz: 3982cbbfe581d8786fa674d3ec8dd1f63900530621265baec4d6e2ff03a5791f
+  data.tar.gz: 83906c429efb771af92ba8358a0cd67523d52e7d732cf0ab7e2d6edf1f400af0
 SHA512:
-  metadata.gz: c8ce340193f8f168f5fc06cc12191478dddd56e0debb1e960c43aee2380613350ae3d44e972ba3d1a5084319c3c26902c3ee5aa14ad61c94af57ca259045b1db
-  data.tar.gz: 771fdc938de78cb25a12830f1257f80c2387ee56916b29c9de46dfa3bb340a3179ed5876498c2c36b22ca4c870f3a70a14c495783aeca73ff68f0eaab59b42f1
+  metadata.gz: '0459f6ce8ee1713a840295ce951f19950b1f9e9acffa5ff2949b840fef604468897ae59398aae9bd9a3c1ea0c0b0f6ec591e02e7bf4eaf11dae96d56e3864f61'
+  data.tar.gz: 1ed691f3d140ea793f6f94ddef4693dab5155cbf9abbf8c2dce227bf828e2ae976bacf9db7b69839d0f8345f31b2aa6991e7ee6c52acf72ae5628e4bd82e8498

data/lib/moxml/element.rb

@@ -122,8 +122,14 @@ module Moxml
     # per-attribute objects. Names may be shared frozen strings —
     # dup before mutating. Mutation and per-attribute namespace
     # resolution stay on #attributes.
+    # One C crossing per read re-allocates the row set (moxml#329);
+    # memoized on the attribute-value clock — element-side value
+    # writes bump it (see invalidate_attribute_value_cache!).
     def attribute_pairs
-      adapter.attribute_pairs(@native)
+      generation = attribute_value_generation
+      @attribute_pairs = nil if @attribute_pairs_gen != generation
+      @attribute_pairs_gen = generation
+      @attribute_pairs ||= adapter.attribute_pairs(@native)
     end
 
     # Create an element with attributes and attach it under this
@@ -248,9 +254,18 @@ module Moxml
     alias add_namespace_definition add_namespace
 
     # it's NOT the same as namespaces.first
+    # Per-read namespace resolution pays an FFI fetch plus a wrapper
+    # mint on every call (moxml#329: a top attribution site in the
+    # fallback-path census). Memoized on the namespace-scope clock —
+    # every scope mutation bumps it (see invalidate_namespace_cache!).
     def namespace
-      ns = adapter.namespace(@native)
-      ns && Wrappers::Namespace.new(ns, context)
+      generation = context.namespace_scope_generation
+      @namespace = nil if @namespace_gen != generation
+      @namespace_gen = generation
+      @namespace ||= begin
+        ns = adapter.namespace(@native)
+        ns && Wrappers::Namespace.new(ns, context)
+      end
     end
 
     # add the prefix to the element name

data/lib/moxml/materializer.rb

@@ -72,7 +72,11 @@ module Moxml
       def group_flat(flat, stride)
         return EMPTY_ATTRIBUTES if flat.empty?
 
-        flat.each_slice(stride).to_a
+        # Direct indexing over each_slice: no enumerator chain per
+        # record (moxml#329's slice-churn row — the enumerator
+        # allocation dominated the sub-array cost on deep trees).
+        count = flat.size / stride
+        Array.new(count) { |i| flat[i * stride, stride] }
       end
     end
 

data/lib/moxml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Moxml
-  VERSION = "0.5.108"
+  VERSION = "0.5.110"
 end

data/spec/moxml/element_attribute_pairs_spec.rb

@@ -39,4 +39,23 @@ RSpec.describe Moxml::Element do
       end
     end
   end
+
+  context "when memoized" do
+    it "returns the same object on repeated reads" do
+      with_adapter(:leptris) do |ctx|
+        root = ctx.parse(xml).root
+        expect(root.attribute_pairs).to equal(root.attribute_pairs)
+      end
+    end
+
+    it "refreshes after a value write" do
+      with_adapter(:leptris) do |ctx|
+        root = ctx.parse(xml).root
+        before = root.attribute_pairs
+        root["id"] = "r9"
+        expect(root.attribute_pairs).not_to equal(before)
+        expect(root.attribute_pairs).to include(["id", "r9"])
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: moxml
 version: !ruby/object:Gem::Version
-  version: 0.5.108
+  version: 0.5.110
 platform: ruby
 authors:
 - Ribose Inc.