moxml 0.1.8 → 0.1.10

data/spec/moxml/declaration_preservation_spec.rb

@@ -0,0 +1,217 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+RSpec.describe "XML Declaration Preservation" do
+  # Test with all available adapters
+  ADAPTERS = %i[nokogiri oga rexml ox libxml headed_ox].freeze
+
+  ADAPTERS.each do |adapter_name|
+    context "with #{adapter_name} adapter" do
+      let(:context) { Moxml.new(adapter_name) }
+
+      describe "automatic preservation" do
+        context "when input has no XML declaration" do
+          let(:xml_without_decl) { '<svg xmlns="http://www.w3.org/2000/svg"><rect/></svg>' }
+
+          it "does not add XML declaration to output" do
+            doc = context.parse(xml_without_decl)
+            output = doc.to_xml
+
+            expect(output).not_to include("<?xml")
+            expect(output).to include("<svg")
+          end
+
+          it "sets has_xml_declaration to false" do
+            doc = context.parse(xml_without_decl)
+            expect(doc.has_xml_declaration).to be false
+          end
+        end
+
+        context "when input has XML declaration" do
+          let(:xml_with_decl) do
+            '<?xml version="1.0" encoding="UTF-8"?><root><child/></root>'
+          end
+
+          it "preserves XML declaration in output" do
+            doc = context.parse(xml_with_decl)
+            output = doc.to_xml
+
+            expect(output).to include("<?xml")
+            expect(output).to include('version="1.0"')
+          end
+
+          it "sets has_xml_declaration to true" do
+            doc = context.parse(xml_with_decl)
+            expect(doc.has_xml_declaration).to be true
+          end
+        end
+
+        context "when input has declaration with standalone attribute" do
+          let(:xml_with_standalone) do
+            '<?xml version="1.0" encoding="UTF-8" standalone="yes"?><root/>'
+          end
+
+          it "preserves the declaration" do
+            doc = context.parse(xml_with_standalone)
+            output = doc.to_xml
+
+            expect(output).to include("<?xml")
+          end
+        end
+      end
+
+      describe "explicit override" do
+        let(:xml_without_decl) { "<root><child/></root>" }
+        let(:xml_with_decl) { '<?xml version="1.0"?><root><child/></root>' }
+
+        context "when forcing declaration on document without one" do
+          it "adds declaration when declaration: true" do
+            doc = context.parse(xml_without_decl)
+            output = doc.to_xml(declaration: true)
+
+            expect(output).to include("<?xml")
+          end
+        end
+
+        context "when removing declaration from document with one" do
+          it "removes declaration when declaration: false" do
+            doc = context.parse(xml_with_decl)
+            output = doc.to_xml(declaration: false)
+
+            expect(output).not_to include("<?xml")
+            expect(output).to include("<root")
+          end
+        end
+
+        context "when explicitly preserving declaration" do
+          it "keeps declaration when declaration: true" do
+            doc = context.parse(xml_with_decl)
+            output = doc.to_xml(declaration: true)
+
+            expect(output).to include("<?xml")
+          end
+        end
+      end
+
+      describe "round-trip fidelity" do
+        context "for document without declaration" do
+          let(:original) { "<root><item id=\"1\"/></root>" }
+
+          it "maintains absence of declaration through parse and serialize" do
+            doc = context.parse(original)
+            output = doc.to_xml
+
+            expect(output).not_to include("<?xml")
+
+            # Parse again and verify
+            doc2 = context.parse(output)
+            expect(doc2.has_xml_declaration).to be false
+          end
+        end
+
+        context "for document with declaration" do
+          let(:original) do
+            '<?xml version="1.0" encoding="UTF-8"?><root><item id="1"/></root>'
+          end
+
+          it "maintains presence of declaration through parse and serialize" do
+            doc = context.parse(original)
+            output = doc.to_xml
+
+            expect(output).to include("<?xml")
+
+            # Parse again and verify
+            doc2 = context.parse(output)
+            expect(doc2.has_xml_declaration).to be true
+          end
+        end
+      end
+
+      describe "edge cases" do
+        context "with empty document" do
+          it "does not add declaration to empty document" do
+            doc = context.create_document
+
+            # Empty documents should not have declaration by default
+            expect(doc.has_xml_declaration).to be false
+          end
+        end
+
+        context "with built document" do
+          it "does not add declaration to programmatically built document" do
+            doc = context.create_document
+            root = doc.create_element("root")
+            doc.root = root
+
+            output = doc.to_xml
+
+            expect(output).not_to include("<?xml")
+            expect(doc.has_xml_declaration).to be false
+          end
+
+          it "can explicitly add declaration to built document" do
+            doc = context.create_document
+            root = doc.create_element("root")
+            doc.root = root
+
+            output = doc.to_xml(declaration: true)
+
+            expect(output).to include("<?xml")
+          end
+        end
+      end
+
+      describe "non-document nodes" do
+        let(:xml) { '<?xml version="1.0"?><root><child>text</child></root>' }
+
+        it "does not add declaration when serializing element nodes" do
+          doc = context.parse(xml)
+          root = doc.root
+          output = root.to_xml
+
+          expect(output).not_to include("<?xml")
+          expect(output).to include("<root>")
+        end
+      end
+    end
+  end
+
+  describe "integration with svg_conform use case" do
+    let(:context) { Moxml.new }
+
+    context "remediating SVG without declaration" do
+      let(:svg_input) { '<svg xmlns="http://www.w3.org/2000/svg" width="100" height="100"><rect x="10" y="10" width="80" height="80"/></svg>' }
+
+      it "does not add declaration to remediated output" do
+        doc = context.parse(svg_input)
+
+        # Simulate remediation: add viewport
+        root = doc.root
+        root["viewBox"] = "0 0 100 100"
+
+        output = doc.to_xml
+
+        expect(output).not_to include("<?xml")
+        expect(output).to include('viewBox="0 0 100 100"')
+      end
+    end
+
+    context "remediating SVG with declaration" do
+      let(:svg_input) { '<?xml version="1.0" encoding="UTF-8"?><svg xmlns="http://www.w3.org/2000/svg"><rect/></svg>' }
+
+      it "preserves declaration in remediated output" do
+        doc = context.parse(svg_input)
+
+        # Simulate remediation
+        root = doc.root
+        root["viewBox"] = "0 0 100 100"
+
+        output = doc.to_xml
+
+        expect(output).to include("<?xml")
+        expect(output).to include('viewBox="0 0 100 100"')
+      end
+    end
+  end
+end

data/spec/moxml/doctype_spec.rb

@@ -8,7 +8,6 @@ RSpec.describe Moxml::Doctype do
 
   describe "#name" do
     it "returns doctype name" do
-      skip "Doctype accessor methods not yet implemented in all adapters"
       doctype = doc.create_doctype("root", nil, "test.dtd")
       expect(doctype.name).to eq("root")
     end
@@ -16,15 +15,32 @@ RSpec.describe Moxml::Doctype do
 
   describe "#system_id" do
     it "returns system identifier" do
-      skip "Doctype accessor methods not yet implemented in all adapters"
       doctype = doc.create_doctype("root", nil, "test.dtd")
       expect(doctype.system_id).to eq("test.dtd")
     end
   end
 
+  describe "#external_id" do
+    it "returns external identifier when present" do
+      doctype = doc.create_doctype("html", "-//W3C//DTD HTML 4.01//EN", "http://www.w3.org/TR/html4/strict.dtd")
+      expect(doctype.external_id).to eq("-//W3C//DTD HTML 4.01//EN")
+    end
+
+    it "returns nil when not present" do
+      doctype = doc.create_doctype("root", nil, "test.dtd")
+      expect(doctype.external_id).to be_nil
+    end
+  end
+
+  describe "#identifier" do
+    it "returns the doctype name" do
+      doctype = doc.create_doctype("html", nil, nil)
+      expect(doctype.identifier).to eq("html")
+    end
+  end
+
   describe "creation" do
     it "creates a doctype" do
-      skip "Doctype accessor methods not yet implemented in all adapters"
       doctype = doc.create_doctype("html", nil, nil)
       expect(doctype).to be_a(described_class)
       expect(doctype.name).to eq("html")

data/spec/performance/memory_usage_spec.rb

@@ -51,9 +51,10 @@ RSpec.shared_examples "Memory Usage Examples" do
     end
 
     it "handles streaming processing" do
-      if %i[ox headed_ox].include?(context.config.adapter_name)
-        pending "Ox/HeadedOx have load_file method but not stream parsing"
+      if context.config.adapter_name == :headed_ox
+        pending "HeadedOx double-wrapping issue with file-based parsing"
       end
+
       # Process file
       doc = nil
       File.open("spec/fixtures/small.xml") do |f|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: moxml
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.10
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-11-24 00:00:00.000000000 Z
+date: 2025-11-26 00:00:00.000000000 Z
 dependencies: []
 description: |
   Moxml is a unified XML manipulation library that provides a common API
@@ -29,7 +29,6 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
-- ".ruby-version"
 - Gemfile
 - LICENSE.md
 - README.adoc
@@ -44,9 +43,11 @@ files:
 - docs/_guides/development-testing.adoc
 - docs/_guides/index.adoc
 - docs/_guides/modifying-xml.adoc
+- docs/_guides/node-api-consistency.adoc
 - docs/_guides/parsing-xml.adoc
 - docs/_guides/sax-parsing.adoc
 - docs/_guides/working-with-documents.adoc
+- docs/_guides/xml-declaration.adoc
 - docs/_pages/adapter-compatibility.adoc
 - docs/_pages/adapters/headed-ox.adoc
 - docs/_pages/adapters/index.adoc
@@ -203,6 +204,7 @@ files:
 - spec/moxml/comment_spec.rb
 - spec/moxml/config_spec.rb
 - spec/moxml/context_spec.rb
+- spec/moxml/declaration_preservation_spec.rb
 - spec/moxml/declaration_spec.rb
 - spec/moxml/doctype_spec.rb
 - spec/moxml/document_builder_spec.rb

data/.ruby-version

@@ -1 +0,0 @@
-3.0.7@moxml