moxml 0.1.13 → 0.1.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a3d9ee4016fae355b5533b22d992f4a127e788b1a39cef001458c3085133f42d
-  data.tar.gz: 79c85ee71c8def65d684cf1243d44871a9120260ec505d48341ef0b96eaa31e0
+  metadata.gz: c46c9d241e38351b1547ab8be8297ff2902886f022ccdfb3fc2f196d2594bf2b
+  data.tar.gz: b1d34fb4306d96d940afea932d5d9f6c6bcffc74c6715e00a6f622302be2f878
 SHA512:
-  metadata.gz: fda8c13b2491e63200ed771dd85cd29fa15a7bc297583fe8c33b8d9ad8b93b05b4dca29d253d798397c37d3b72304d0588d5f11c95de6e16aba74ea26472cdbb
-  data.tar.gz: d1853370b28eee67a4df08cd4b4bdbc83816866282f731eeca15870da119ff1e643898db823d49ee5e98ae1bcfc34370672b29e38abc5ccab542088bb239e3d9
+  metadata.gz: 9178c13199c195aa0b3ed628d5837fa6c1fdaeaa3e3cc462a8520a89ad6bb98963ff0a9c2b668038ff27a0653e2aa2fba98ce1c8bc10eccc74abab0daa26e455
+  data.tar.gz: 5b1b06dea56ac0b28dd2b8ca072fa554039936c336e6b262430d40f45ab2972b1e6bf38f3c13cf192c9fc2a9cc9fe827abc99aa662d30ebdaae97d361d981475

data/lib/moxml/adapter/customized_oga/xml_generator.rb

@@ -16,7 +16,7 @@ module Moxml
         def on_element(element, output)
           name = element.expanded_name
 
-          attrs = ""
+          attrs = []
           element.attributes.each do |attr|
             attrs << " "
             on_attribute(attr, attrs)
@@ -28,7 +28,7 @@ module Moxml
                           ">"
                         end
 
-          output << "<#{name}#{attrs}#{closing_tag}"
+          output << "<#{name}#{attrs.join}#{closing_tag}"
         end
 
         def on_namespace_definition(ns, output)

data/lib/moxml/adapter/oga.rb

@@ -479,7 +479,7 @@ module Moxml
 
             if should_include_decl && !node.xml_declaration && !has_existing_declaration
               # Need to add declaration - create default one
-              output = +""
+              output = []
               output << '<?xml version="1.0" encoding="UTF-8"?>'
               output << "\n"
 
@@ -491,10 +491,10 @@ module Moxml
                 output << ::Moxml::Adapter::CustomizedOga::XmlGenerator.new(child).to_xml
               end
 
-              return output
+              return output.join
             elsif !should_include_decl
               # Skip xml_declaration
-              output = +""
+              output = []
 
               # Serialize doctype if present
               output << node.doctype.to_xml << "\n" if node.doctype
@@ -506,7 +506,7 @@ module Moxml
                 output << ::Moxml::Adapter::CustomizedOga::XmlGenerator.new(child).to_xml
               end
 
-              return output
+              return output.join
             end
           end
 
@@ -514,19 +514,20 @@ module Moxml
           # But first check if we need to handle declaration specially
           if node.is_a?(::Oga::XML::Document) && node.xml_declaration
             # Document has declaration - use custom handling to avoid duplicates
-            output = +""
+            output = []
+            xml_declaration_serialized = false
 
             # Serialize children, but skip XmlDeclaration if it would cause duplication
             node.children.each do |child|
-              # Check if this would cause duplication by seeing if we already have one in output
-              if child.is_a?(::Oga::XML::XmlDeclaration) && output.include?("<?xml")
-                next # Skip duplicate declaration
-              end
+              xml_declaration = child.is_a?(::Oga::XML::XmlDeclaration)
+              next if xml_declaration && xml_declaration_serialized
+
+              xml_declaration_serialized = true if xml_declaration
 
               output << ::Moxml::Adapter::CustomizedOga::XmlGenerator.new(child).to_xml
             end
 
-            output
+            output.join
           else
             # Normal case - use XmlGenerator directly
             ::Moxml::Adapter::CustomizedOga::XmlGenerator.new(node).to_xml

data/lib/moxml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Moxml
-  VERSION = "0.1.13"
+  VERSION = "0.1.14"
 end

data/spec/moxml/adapter/oga_spec.rb

@@ -12,6 +12,22 @@ RSpec.describe Moxml::Adapter::Oga do
 
   it_behaves_like "xml adapter"
 
+  describe "serialization" do
+    it "does not duplicate XML declarations when declaration nodes repeat" do
+      context = Moxml::Context.new(:oga)
+      doc = context.create_document
+
+      doc.add_child(doc.create_declaration("1.0", "UTF-8"))
+      doc.add_child(doc.create_declaration("1.0", "UTF-8"))
+      doc.add_child(doc.create_element("root"))
+
+      serialized = doc.to_xml
+
+      expect(serialized.scan("<?xml").size).to eq(1)
+      expect(serialized).to include("<root></root>")
+    end
+  end
+
   describe "entity handling" do
     it "preserves non-breaking space through parse and serialize round-trip" do
       xml = "<root>Item&nbsp;One</root>"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: moxml
 version: !ruby/object:Gem::Version
-  version: 0.1.13
+  version: 0.1.14
 platform: ruby
 authors:
 - Ribose Inc.