moxml 0.1.11 → 0.1.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 22ee4b9d877466a93b1253a05f5b64f65cb637335f8e5a02b02c357fd87b505d
-  data.tar.gz: 90c377d7eac0bd5bb9e15393b00c3cfa9e8b5b4eeb80f56d6f52ccb7e11b5774
+  metadata.gz: 4157530fd51f50d52969541f0a41d18f3b70d2ccada5dea86ea38e3882511385
+  data.tar.gz: ea71910278f9883ac2580e3f20d9d6a5ea2d0981fbbd9d9c7fecbcf6b2694247
 SHA512:
-  metadata.gz: 73b2b180410acadc4be69bd87948f5966cdd8c8c2480bf61cb66f212e7cd893a6ab31e536f8922dde8814a6e04e57b794206d504b8a479e68288b714b2396ddb
-  data.tar.gz: ec4a72fc0c930dc2abfef2719dea6cce1ff37efb00e0255f46828f624aaab4007c9f523d39f86680a01f49a8a3a1c4f184319dd6fc6381562bd151167f22f780
+  metadata.gz: 47dd22ad3d886d60cd6f4c2717f0d39e78ebbcaa743cb14a072476753410c681fb19b0a6d3fd6019f7a70bb2a7902bbb3239d4255f5fe5041a4fd2dce5beec74
+  data.tar.gz: fa217b1a960165a88dc97bcf765147d836dbe77e90be528cdb045ed99c28f6181d59634e50a4059348b89f0a23c4661660e1fb10fe8a46e06e1a434f9e08f456

data/lib/moxml/adapter/nokogiri.rb

@@ -288,7 +288,9 @@ module Moxml
         end
 
         def inner_text(node)
-          text_children = node.children - node.element_children
+          text_children = node.children.reject do |c|
+            c.element? || c.comment?
+          end
           text_children.map(&:content).join
         end
 

data/lib/moxml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Moxml
-  VERSION = "0.1.11"
+  VERSION = "0.1.12"
 end

data/spec/integration/shared_examples/node_wrappers/element_behavior.rb

@@ -129,6 +129,20 @@ RSpec.shared_examples "Moxml::Element" do
         expect(outer_p.inner_text).to eq("")
         expect(inner_p.text).to include("Some text inside paragraph")
       end
+
+      it "excludes comment content from inner_text" do
+        element.add_child(doc.create_comment("comment text"))
+        element.add_child("actual text")
+        expect(element.inner_text).to eq("actual text")
+      end
+
+      it "excludes comments mixed with text and elements from inner_text" do
+        element.add_child("before ")
+        element.add_child(doc.create_comment("a comment"))
+        element.add_child(doc.create_element("child"))
+        element.add_child("after")
+        expect(element.inner_text).to eq("before after")
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: moxml
 version: !ruby/object:Gem::Version
-  version: 0.1.11
+  version: 0.1.12
 platform: ruby
 authors:
 - Ribose Inc.