movie_organizer 0.1.11 → 1.0.1

data/movie_organizer.gemspec

@@ -31,13 +31,16 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.2'
   spec.add_development_dependency 'rubocop'
   spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'titleize', '~> 1.3'
+  spec.add_development_dependency 'vcr', '~> 4.0'
+  spec.add_development_dependency 'webmock', '~> 3.3'
 
   spec.add_runtime_dependency 'colored'
   spec.add_runtime_dependency 'fileutils'
-  spec.add_runtime_dependency 'mime-types'
   spec.add_runtime_dependency 'net-scp', '~> 1.2'
+  spec.add_runtime_dependency 'ruby-filemagic', '~> 0.7.2' # Determine mime types
   spec.add_runtime_dependency 'themoviedb', '~> 1.0'
-  spec.add_runtime_dependency 'titleize', '~> 1.3'
   spec.add_runtime_dependency 'trollop'
+  # spec.add_runtime_dependency 'tvdbr', '~> 0.2'
 end
 # rubocop:enable Metrics/BlockLength

data/spec/files/bad.mp4

@@ -0,0 +1 @@
+this is not a media file

data/spec/fixtures/.blank_settings.yml

@@ -0,0 +1,3 @@
+---
+:new_media_directories:
+- "~/Videos"

data/spec/lib/movie_organizer/file_copier_spec.rb

@@ -5,6 +5,8 @@ require 'spec_helper'
 # rubocop:disable Metrics/BlockLength
 module MovieOrganizer
   RSpec.describe FileCopier, type: :lib do
+    include_context 'media_shared'
+
     let(:tmp_movie_src) { MovieOrganizer.root.join('spec', 'files', 'movies') }
     let(:tmp_dest) { MovieOrganizer.root.join('tmp', 'files', 'movies') }
     test_files = {}
@@ -25,9 +27,10 @@ module MovieOrganizer
       context 'with a local target' do
         test_files.each_pair do |src, dst|
           it "copies [#{src}] to [#{dst}]" do
+            expect(File.exist?(src)).to eq(true)
             expect(File.exist?(dst)).to eq(false)
-            file_copier = FileCopier.new(src, dst, dry_run: false)
-            file_copier.copy
+            file_copier = FileCopier.new(src, dst)
+            file_copier.copy!
             expect(File.exist?(dst)).to eq(true)
           end
         end

data/spec/lib/movie_organizer/media_list_spec.rb

@@ -1,49 +1,20 @@
 # frozen_string_literal: true
 
-# rubocop:disable Metrics/BlockLength
+require 'spec_helper'
+
 module MovieOrganizer
   RSpec.describe MediaList, type: :lib do
     include_context 'media_shared'
 
-    let(:media_list) { MediaList.new([tmpdir]) }
+    let(:media_list) { MediaList.new(Dir[file_fixture_path]) }
 
     context '#new' do
-      %w(m4v mov mkv mp4 avi).each do |extension|
-        it "includes #{extension} files" do
-          create_test_file(count: 3, extension: extension)
-          expect(media_list.file_collection.count).to eq(3)
-        end
-      end
-    end
-
-    context '.video?' do
-      it 'returns true if passed filename has a video extension' do
-        expect(media_list.video?('bogus.mp4')).to eq(true)
-      end
-
-      it "returns false if passed filename isn't a video extension" do
-        expect(media_list.video?('bogus.mp3')).to eq(false)
-      end
-    end
-
-    context '.subtitle?' do
-      it 'returns true if passed filename has a subtitle extension' do
-        expect(media_list.subtitle?('bogus.sub')).to eq(true)
-        expect(media_list.subtitle?('bogus.srt')).to eq(true)
-      end
-
-      it "returns false if passed filename isn't a subtitle extension" do
-        expect(media_list.subtitle?('bogus.mp3')).to eq(false)
-      end
-    end
-
-    context '.media?' do
-      it 'returns true if passed filename has a media extension' do
-        expect(media_list.media?('bogus.srt')).to eq(true)
-        expect(media_list.media?('bogus.mov')).to eq(true)
-        expect(media_list.media?('bogus.mp3')).to eq(false)
+      it 'only collects video files' do
+        good = media_list.file_collection.grep(/good/)
+        expect(good.count).to eq(5)
+        bad = media_list.file_collection.grep(/bad/)
+        expect(bad.count).to eq(0)
       end
     end
   end
 end
-# rubocop:enable Metrics/BlockLength

data/spec/lib/movie_organizer/medium_spec.rb

@@ -0,0 +1,97 @@
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/BlockLength
+module MovieOrganizer
+  RSpec.describe Medium, type: :lib do
+    include_context 'media_shared'
+
+    context '::media_file?' do
+      Dir[file_fixture_path.join('bad.*')].each do |vid|
+        it "returns false for #{vid}" do
+          expect(Medium.media_file?(vid)).to eq(false)
+        end
+      end
+
+      Dir[file_fixture_path.join('good.*')].each do |vid|
+        it "returns true for #{vid}" do
+          expect(Medium.media_file?(vid)).to eq(true)
+        end
+      end
+    end
+
+    context '::build_instance', vcr: true do
+      Dir[file_fixture_path.join('movies', '*')].each do |vid|
+        it "returns a Movie instance type for #{vid}" do
+          expect(Medium).to receive(:media_file?).and_return(true)
+          instance = Medium.build_instance(vid)
+          expect(instance).to be_a(Movie)
+        end
+      end
+
+      Dir[file_fixture_path.join('tv_shows', '*')].each do |vid|
+        it "returns a TvShow instance type for #{vid}" do
+          expect(Medium).to receive(:media_file?).and_return(true)
+          instance = Medium.build_instance(vid)
+          expect(instance).to be_a(TvShow)
+        end
+      end
+    end
+
+    # context '.subtype' do
+    #   tv_shows = {
+    #     'SnnEnn' => 'The.Walking.Dead.S04E08.HDTV.x264-2HD',
+    #     'nxn'    => 'The.Walking.Dead.4x0.HDTV.x264-2HD',
+    #     'nnxn'   => 'The.Walking.Dead.12x8.HDTV.x264-2HD',
+    #     'nnxnn'  => 'The.Walking.Dead.12x08.HDTV.x264-2HD',
+    #     'nxnn'   => 'The.Walking.Dead.2x18.HDTV.x264-2HD'
+    #   }
+    #
+    #   tv_shows.each_pair do |syntax, filename|
+    #     it "returns a TvShow with season and episode syntax: #{syntax}" do
+    #       filename = create_test_file(
+    #         filename: filename,
+    #         extension: 'mp4'
+    #       ).first
+    #       expect(Media.subtype(filename, default_options)).to be_a(TvShow)
+    #     end
+    #   end
+    #
+    #   movies = [
+    #     'Coco.2017.1080p.BluRay.x264-[BOGUS.IT]',
+    #     'Beetlejuice',
+    #     'Justice.League.2017.1080p.BluRay.x264-[YTS.AM]',
+    #     'Jumanji.Welcome.To.The.Jungle.2017.1080p.WEBRip.x264-[YTS.AM].mp4'
+    #   ]
+    #
+    #   movies.each do |filename|
+    #     it "returns a Movie for '#{filename}'" do
+    #       expect(Tmdb::Movie).to receive(:find).at_least(1).times.and_return([1])
+    #       filename = create_test_file(
+    #         filename: filename
+    #       ).first
+    #       expect(Media.subtype(filename, default_options)).to be_a(Movie)
+    #     end
+    #   end
+    #
+    #   videos = [
+    #     'IMG_2052',
+    #     'IMG_3322',
+    #     'VID_3322',
+    #     'VIDEO_3322',
+    #     'Our Summer Vacation',
+    #     'Tom and Jerry on the Beach'
+    #   ]
+    #
+    #   videos.each do |filename|
+    #     it "returns a Video for '#{filename}'" do
+    #       expect(Tmdb::Movie).to receive(:find).at_least(1).times.and_return([])
+    #       filename = create_test_file(
+    #         filename: filename
+    #       ).first
+    #       expect(Medium.subtype(filename, default_options)).to be_a(Video)
+    #     end
+    #   end
+    # end
+  end
+end
+# rubocop:enable Metrics/BlockLength

data/spec/lib/movie_organizer/movie_spec.rb

@@ -1,8 +1,9 @@
 # frozen_string_literal: true
 
 # rubocop:disable Metrics/BlockLength
+# rubocop:disable Metrics/ModuleLength
 module MovieOrganizer
-  RSpec.describe Movie, type: :lib do
+  RSpec.describe Movie, type: :lib, vcr: true do
     include_context 'media_shared'
 
     movies = {
@@ -11,9 +12,9 @@ module MovieOrganizer
         name: 'Coco (2017).mp4'
       },
       'Beetlejuice' => {
-        directory: 'Beetlejuice (1995)',
-        year: '1995',
-        name: 'Beetlejuice (1995).mp4'
+        directory: 'Beetlejuice (1988)',
+        year: '1988',
+        name: 'Beetlejuice (1988).mp4'
       },
       'Justice.League.2017.1080p.BluRay.x264-[YTS.AM]' => {
         year: '2017',
@@ -21,7 +22,7 @@ module MovieOrganizer
       },
       'Jumanji.Welcome.To.The.Jungle.2017.1080p.WEBRip.x264-[YTS.AM]' => {
         year: '2017',
-        name: 'Jumanji Welcome To The Jungle (2017).mp4'
+        name: 'Jumanji: Welcome to the Jungle (2017).mp4'
       },
       'The.Prestige.2006.m720p.x264' => {
         year: '2006',
@@ -32,9 +33,9 @@ module MovieOrganizer
         name: 'Gone in Sixty Seconds (2000).mp4'
       },
       'Rain.Man.Br.YIFY' => {
-        directory: 'Rain Man (2000)',
-        year: '2000',
-        name: 'Rain Man (2000).mp4'
+        directory: 'Rain Man (1988)',
+        year: '1988',
+        name: 'Rain Man (1988).mp4'
       },
       'Stealth (2005) BDRip 720p x264-muxed' => {
         year: '2005',
@@ -44,10 +45,10 @@ module MovieOrganizer
         year: '1973',
         name: 'The Train Robbers (1973).mp4'
       },
-      'waterhorse720p.x264' => {
+      'the.water.horse.720p.x264' => {
         year: '2007',
         directory: 'The Water Horse (2007)',
-        name: 'The Water Horse (2007)'
+        name: 'The Water Horse (2007).mp4'
       }
     }
 
@@ -58,7 +59,9 @@ module MovieOrganizer
           @filepath = create_test_file(filename: filename, extension: 'mp4', dirname: dirname).first
           @expected_filename = data[:name]
           @expected_year = data[:year]
-          @movie = Movie.new(@filepath, default_options)
+          tmdb_instance = Movie.match?(@filepath)
+          @movie = Movie.new(@filepath, tmdb_instance)
+          @movie.process!
         end
 
         context '.processed_filename' do
@@ -71,7 +74,7 @@ module MovieOrganizer
 
         context '.year' do
           it 'returns the correct year' do
-            expect(@movie.year).to eq(@expected_year)
+            expect(@movie.year).to eq(@expected_year.to_i)
           end
         end
       end
@@ -83,7 +86,10 @@ module MovieOrganizer
           filename: 'Foreign+Correspondent+(1940)+1080p', extension: 'mp4'
         ).first
       end
-      let(:movie) { Movie.new(filename, default_options) }
+      let(:movie) do
+        tmdb_instance = Movie.match?(filename)
+        Movie.new(filename, tmdb_instance)
+      end
 
       context '#new' do
         it 'is a Movie' do
@@ -97,7 +103,7 @@ module MovieOrganizer
 
       context '.process!' do
         it 'moves the file to the configured location' do
-          settings = Settings.new
+          settings = Settings.instance
           settings[:movies][:directory] = MovieOrganizer.root.join('tmp', 'files', 'movies').to_s
           settings.save
           movie.process!
@@ -108,3 +114,4 @@ module MovieOrganizer
   end
 end
 # rubocop:enable Metrics/BlockLength
+# rubocop:enable Metrics/ModuleLength

data/spec/lib/movie_organizer/tmdb_instance_spec.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module MovieOrganizer
+  # rubocop:disable Metrics/BlockLength
+  RSpec.describe TmdbInstance, type: :lib, vcr: true do
+    context '#movie?' do
+      it 'returns false if the title is not found' do
+        instance = TmdbInstance.new('unknown tv show')
+        expect(instance.movie?).to eq(false)
+      end
+
+      it 'returns self if the title is found' do
+        instance = TmdbInstance.new('the matrix', 1999)
+        expect(instance.movie?).to eq(instance)
+      end
+    end
+
+    context '#likely_match' do
+      context 'when passing a year' do
+        it 'returns the first match with a release date matching the year' do
+          instance = TmdbInstance.new('star wars', 2015)
+          instance.movie?
+          match = instance.likely_match
+          expect(match.title).to eq('Star Wars: The Force Awakens')
+        end
+      end
+
+      context 'when not passing a year' do
+        it 'returns the first match' do
+          instance = TmdbInstance.new('star wars')
+          instance.movie?
+          match = instance.likely_match
+          expect(match.title).to eq('Star Wars')
+        end
+      end
+    end
+  end
+  # rubocop:enable Metrics/BlockLength
+end

data/spec/lib/movie_organizer/tvdb_instance_spec.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module MovieOrganizer
+  RSpec.describe TvdbInstance, type: :lib, vcr: true do
+    context '#tv_show?' do
+      it 'returns false if the title is not found' do
+        instance = TvdbInstance.new('unknown tv show')
+        expect(instance.tv_show?).to eq(false)
+      end
+
+      it 'returns self if the title is found' do
+        instance = TvdbInstance.new('the walking dead')
+        expect(instance.tv_show?).to eq(instance)
+      end
+    end
+  end
+end

data/spec/lib/movie_organizer/video_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'spec_helper'
+
 # rubocop:disable Metrics/BlockLength
 module MovieOrganizer
   RSpec.describe Video, type: :lib do
@@ -11,11 +13,11 @@ module MovieOrganizer
         extension: 'mp4'
       ).first
     end
-    let(:video) { Video.new(filename, default_options) }
+    let(:video) { Video.new(filename) }
 
     context '#new' do
       it 'returns a child of the Media class' do
-        expect(video).to be_a(Media)
+        expect(video).to be_a(Medium)
       end
 
       it 'is a Video' do
@@ -35,8 +37,8 @@ module MovieOrganizer
 
     context '.process!' do
       it 'moves the file to the configured location' do
-        fc = FileCopier.new('/tmp/bogus', '/tmp/bogus2', default_options)
-        expect(fc).to receive(:copy).and_return(nil)
+        fc = FileCopier.new('/tmp/bogus', '/tmp/bogus2')
+        expect(fc).to receive(:copy!).and_return(nil)
         video.process!(fc)
       end
     end

data/spec/lib/movie_organizer_spec.rb

@@ -49,18 +49,10 @@ RSpec.describe MovieOrganizer, type: :module do
   context '#source_directories' do
     context 'when configured' do
       it 'returns an array of strings' do
-        settings = MovieOrganizer::Settings.new
+        settings = MovieOrganizer::Settings.instance
         expect(MovieOrganizer.source_directories(settings)).to be_an(Array)
       end
     end
-
-    context 'when not yet configured' do
-      it 'returns an array of strings' do
-        blank = MovieOrganizer.root.join('spec', 'fixtures', '.blank_settings.yml')
-        settings = MovieOrganizer::Settings.new(blank)
-        expect(MovieOrganizer.source_directories(settings, '~/Videos')).to be_an(Array)
-      end
-    end
   end
 end
 # rubocop:enable Metrics/BlockLength

data/spec/spec_helper.rb

@@ -91,4 +91,9 @@ RSpec.configure do |config|
   # test failures related to randomization by passing the same `--seed` value
   # as the one that triggered the failure.
   Kernel.srand config.seed
+
+  config.before(:each) do
+    options = MovieOrganizer::Options.instance
+    options.send(:initialize_hash, dry_run: false, verbose: false, copy: true)
+  end
 end

data/spec/support/shared_contexts/media_shared.rb

@@ -50,3 +50,12 @@ shared_context 'media_shared' do
   end
 end
 # rubocop:enable Metrics/BlockLength
+
+def file_fixture_path
+  MovieOrganizer.root.join('spec', 'files')
+end
+
+def stub_tvdb(return_value)
+  stub = double('TvdbInstance', :tv_show?)
+  allow(TvdbInstance).to receive(:new).and_return(stub)
+end