motion 0.4.3 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d25829b24f8c2781bcc44f9132061532d3c5b3466e60e69ab646407d27c32519
-  data.tar.gz: c3e69af9595e1fe7b659a6ed51a57c252d2028581aa4f154e4a150ee2a74b12c
+  metadata.gz: ff2870c4229fefaba7ff72f8275b969006a6b0db22144c234e5dd3554523a95d
+  data.tar.gz: 5c5488e3dd2ae17e8bd4db86c5daf64db3093bcf35729a2d185965cc84f8be27
 SHA512:
-  metadata.gz: f1bb6c0022e3636d62d6ba054aeac9e16c353bc5d646aa83c460a0eaf1f0fc0774efd71b03d3eb47456a033a66521907fc3e23e29fc02c4d09124a03732e940c
-  data.tar.gz: aa336213b2487da46b868b8c89f74ff55ec745078ffdb1e75fdeafe7d7707870f8f140013d8d9218e68998f89911813f9e0437d75f9261ccc29ec957990b6b02
+  metadata.gz: af5d390212fac33bc5db249f23d9401b5ca5da3c2ef4edfd6a606d68ce5fa4fc8c5153b5e29ee2fb8b4a8d5c07e40aa543e1ef35cef0682c021675a24fcb7fed
+  data.tar.gz: 4418c496d43ea478b16c828538fc3a18850c8ba60d68646a715453ee47b80c9751aa1948df1c423002c4b19b223be115d12b9ed4be7ce28cc14db611272d4f04

data/lib/motion/channel.rb

@@ -13,7 +13,7 @@ module Motion
     ACTION_METHODS = Set.new(["process_motion"]).freeze
     private_constant :ACTION_METHODS
 
-    # Don't use the ActionCable huertistic for deciding what actions can be
+    # Don't use the ActionCable heuristic for deciding what actions can be
     # called from JavaScript. Instead, hard-code the list so we can make other
     # methods public without worrying about them being called from JavaScript.
     def self.action_methods
@@ -66,7 +66,7 @@ module Motion
 
     def synchronize
       component_connection.if_render_required do |component|
-        transmit(renderer.render(component))
+        transmit(renderer.render(component, layout: nil))
       end
 
       streaming_from component_connection.broadcasts,
@@ -84,7 +84,7 @@ module Motion
       @log_helper ||= LogHelper.for_channel(self)
     end
 
-    # Memoize the renderer on the connection so that it can be shared accross
+    # Memoize the renderer on the connection so that it can be shared across
     # all components. `ActionController::Renderer` is already thread-safe and
     # designed to be reused.
     def renderer

data/lib/motion/component/rendering.rb

@@ -23,9 +23,14 @@ module Motion
         @controller
         @request
         @tag_builder
+
+        @asset_resolver_strategies
+        @assets_environment
       ].freeze
 
-      private_constant :STATE_EXCLUDED_IVARS
+      STATE_IVAR_OBFUSCATION_PREFIX = "@__vc_"
+
+      private_constant :STATE_EXCLUDED_IVARS, :STATE_IVAR_OBFUSCATION_PREFIX
 
       def rerender!
         @_awaiting_forced_rerender = true
@@ -53,7 +58,7 @@ module Motion
             view_context.capture { super }
           }
 
-        raise RenderAborted, self if html == false
+        raise RenderAborted, self unless html
 
         Motion.markup_transformer.add_state_to_html(self, html)
       end
@@ -66,6 +71,7 @@ module Motion
 
       def marshal_dump
         (instance_variables - STATE_EXCLUDED_IVARS)
+          .reject { |ivar| ivar.start_with? STATE_IVAR_OBFUSCATION_PREFIX }
           .map { |ivar| [ivar, instance_variable_get(ivar)] }
           .to_h
       end

data/lib/motion/component_connection.rb

@@ -41,7 +41,7 @@ module Motion
     end
 
     def process_motion(motion, event = nil)
-      timing("Proccessed #{motion}") do
+      timing("Processed #{motion}") do
         component.process_motion(motion, event)
       end
 
@@ -53,7 +53,7 @@ module Motion
     end
 
     def process_broadcast(broadcast, message)
-      timing("Proccessed broadcast to #{broadcast}") do
+      timing("Processed broadcast to #{broadcast}") do
         component.process_broadcast broadcast, message
       end
 
@@ -65,7 +65,7 @@ module Motion
     end
 
     def process_periodic_timer(timer)
-      timing("Proccessed periodic timer #{timer}") do
+      timing("Processed periodic timer #{timer}") do
         component.process_periodic_timer timer
       end
 

data/lib/motion/element.rb

@@ -22,6 +22,10 @@ module Motion
       raw["value"]
     end
 
+    def checked?
+      raw["checked"]
+    end
+
     def attributes
       raw.fetch("attributes", {})
     end

data/lib/motion/errors.rb

@@ -68,7 +68,7 @@ module Motion
   class InvalidComponentStateError < ComponentError; end
 
   class UnrepresentableStateError < InvalidComponentStateError
-    def initialize(component, cause)
+    def initialize(component, cause, failing_ivars)
       super(
         component,
         "Some state prevented `#{component.class}` from being serialized " \
@@ -79,6 +79,9 @@ module Motion
         "\n" \
         "The specific error from `Marshal.dump` was: #{cause}\n" \
         "\n" \
+        "unserializable ivars: #{failing_ivars.join(", ")}\n"\
+        "\n" \
+        "\n" \
         "Hint: Ensure that any exotic state variables in " \
         "`#{component.class}` are removed or replaced."
       )
@@ -114,7 +117,7 @@ module Motion
         "of the application to be mounted because new code with old state " \
         "can lead to unpredictable and unsafe behavior.\n" \
         "\n" \
-        "Hint: If you would like to allow this component to surive " \
+        "Hint: If you would like to allow this component to survive " \
         "deployments, consider providing an alternative implimentation for " \
         "`#{component.class}.upgrade_from`."
       )

data/lib/motion/serializer.rb

@@ -61,10 +61,22 @@ module Motion
 
     private
 
-    def dump(component)
+    def dump!(component)
       Marshal.dump(component)
+    end
+
+    def dump(component)
+      dump!(component)
     rescue TypeError => e
-      raise UnrepresentableStateError.new(component, e.message)
+      failing_ivars = []
+
+      component.marshal_dump.each do |ivar_name, ivar_value|
+        dump!(ivar_value)
+      rescue TypeError
+        failing_ivars << ivar_name
+      end
+
+      raise UnrepresentableStateError.new(component, e.message, failing_ivars)
     end
 
     def load(state)

data/lib/motion/test_helpers.rb

@@ -4,6 +4,14 @@ require "motion"
 
 module Motion
   module TestHelpers
+    class MockComponent < ViewComponent::Base
+      include Motion::Component
+    end
+
+    def callback_stub(method_name = :bound)
+      Motion::Callback.new(MockComponent.new, method_name)
+    end
+
     def assert_motion(component, motion_name)
       assert motion?(component, motion_name)
     end
@@ -16,14 +24,47 @@ module Motion
       component.motions.include?(motion_name.to_s)
     end
 
-    def run_motion(component, motion_name)
+    def run_motion(component, motion_name, event = motion_event)
       if block_given?
         c = component.dup
-        c.process_motion(motion_name.to_s)
+        c.process_motion(motion_name.to_s, event)
         yield c
       else
-        component.process_motion(motion_name.to_s)
+        component.process_motion(motion_name.to_s, event)
       end
     end
+
+    def process_broadcast(component, method_name, msg)
+      callback = component.bind(method_name)
+      component.process_broadcast(callback.broadcast, msg)
+    end
+
+    def assert_timer(component, method_name, interval)
+      assert_equal interval, component.periodic_timers[method_name.to_s]
+    end
+
+    def refute_timer(component, method_name)
+      refute timer?(component, method_name)
+    end
+
+    def timer?(component, method_name)
+      component.periodic_timers.include?(method_name.to_s)
+    end
+
+    def motion_event(attributes = {})
+      Motion::Event.new(ActiveSupport::JSON.decode(attributes.to_json)).tap do |event|
+        set_form_data(event, attributes)
+      end
+    end
+
+    private
+
+    def set_form_data(event, attrs)
+      return event unless attrs.fetch(:element, nil)
+
+      form_data = attrs.dig(:element, :formData) || {}
+      params = ActionController::Parameters.new(form_data)
+      event.element.instance_variable_set(:@form_data, params)
+    end
   end
 end

data/lib/motion/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Motion
-  VERSION = "0.4.3"
+  VERSION = "0.7.0"
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: motion
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.7.0
 platform: ruby
 authors:
 - Alec Larsen
 - Drew Ulmer
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-22 00:00:00.000000000 Z
+date: 2022-06-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -31,14 +31,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: lz4-ruby
   requirement: !ruby/object:Gem::Requirement
@@ -102,7 +102,7 @@ metadata:
   source_code_uri: https://github.com/unabridged/motion
 post_install_message: |
   Friendly reminder: When updating the motion gem, don't forget to update the
-  NPM package as well (`bin/yarn add '@unabridged/motion@0.4.3'`).
+  NPM package as well (`bin/yarn add '@unabridged/motion@0.7.0'`).
 rdoc_options: []
 require_paths:
 - lib
@@ -117,8 +117,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: Reactive frontend UI components for Rails in pure Ruby.
 test_files: []