motion-http 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ee2f69f478379a7838d88c114210624948da74f8
-  data.tar.gz: d5ac4b833aec97568819341f555a07ef48507fb3
+  metadata.gz: 295321b18316c5b3a47c29692b4831e25ed4b1c7
+  data.tar.gz: afcdbfc33304f05cf290fcdd33e339ad693fcb74
 SHA512:
-  metadata.gz: 32c6a1ade57a803e9a99416d6591d9b6afc510d3dbe06edba804c4f5c35cbe8b36f27282c718ed7231bfb0af22a98984831eba9c7256da2571310dc03a83f62a
-  data.tar.gz: ca7d792bb704dcd23da1d1454c138f426eadeb1fba2003750243b053a8df07b9cd2a94494283d58fae2b2b8dde1789b36e3411412e1de4cdcfabb3de78ea820b
+  metadata.gz: '095e68b01bca380833a6e93c2e25e5e6abd389727b6ff92aa1b39c9fef79132bec440ea2b280b4e0e5436535534dc158e234d1ed54bc9c99cc518a246fa5cf77'
+  data.tar.gz: 0667af5350564fb4f4199437a3ae827435f5ce942842ca333adba98ed46efaa7a8c4ff1dce85dc67c17b9fa382abdf28b7ba5645fa0e6064581cf405e9e3e5ed

data/README.md

@@ -6,6 +6,12 @@ Supported platforms:
 - iOS, macOS, tvOS, watchOS
 - Android
 
+This gem depends on two really popular networking libraries:
+- [AFNetworking](https://github.com/AFNetworking/AFNetworking) (for Cocoa platforms)
+- [OkHttp](http://square.github.io/okhttp/) (for Android)
+
+Please note that this library is still a work in progress. Please report bugs and suggestions for improvement!
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -18,6 +24,12 @@ And then execute:
     $ rake pod:install # for iOS apps
     $ rake gradle:install # for Android apps
 
+### iOS Specific Configuration
+
+If you will be making insecure HTTP requests (not HTTPS), you will need to explicitly allow insecure HTTP requests by adding this line to your app's configuration in your Rakefile:
+
+    app.info_plist['NSAppTransportSecurity'] = { 'NSAllowsArbitraryLoads' => true }
+
 ## Usage
 
 Using `Motion::HTTP` is quick and easy. You can use the simple approach for making one-off requests, or the advanced approach of creating a reusable API client for further customization.
@@ -80,9 +92,9 @@ end
 
 `PUT`, `PATCH`, and `DELETE` requests work the same way:
 ```ruby
-Motion::HTTP.put(url, params)
-Motion::HTTP.patch(url, params)
-Motion::HTTP.delete(url, params)
+Motion::HTTP.put(url, params) { ... }
+Motion::HTTP.patch(url, params) { ... }
+Motion::HTTP.delete(url, params) { ... }
 ```
 
 ### Advanced Usage
@@ -90,11 +102,16 @@ Motion::HTTP.delete(url, params)
 A common use case is to create a reusable HTTP client that uses a common base URL or request headers.
 
 ```ruby
-client = Motion::HTTPClient.new("http://www.example.com")
-# Set or replace a header
+client = Motion::HTTP::Client.new("http://www.example.com")
+# Set or replace a single header:
 client.header "X-API-TOKEN", "abc123xyz"
+
+# To set or replace multiple headers:
+client.headers "X-API-TOKEN" => "abc123xyz",
+               "Accept" => "application/json"
+
 # It is valid for some headers to appear multiple times (Accept, Vary, etc).
-# Use add_header to append multiple headers of the same name.
+# To append multiple headers of the same key:
 client.add_header "Accept", "application/json"
 client.add_header "Accept", "application/vnd.api+json"
 ```

data/lib/common/http/client.rb

@@ -1,7 +1,7 @@
 class Motion
   class HTTP
     class Client
-      attr_reader :base_url, :headers
+      attr_reader :base_url
 
       def initialize(base_url = nil)
         @base_url = base_url || ""
@@ -9,11 +9,20 @@ class Motion
       end
 
       def header(key, value)
-        headers.set(key, value)
+        @headers.set(key, value)
       end
 
       def add_header(key, value)
-        headers.add(key, value)
+        @headers.add(key, value)
+      end
+
+      def headers(hash = nil)
+        if hash
+          hash.each do |key, value|
+            @headers.set(key, value)
+          end
+        end
+        @headers
       end
 
       # FIXME: doesn't work on Android
@@ -24,11 +33,11 @@ class Motion
       # end
 
       def get(path, params = nil, &callback)
-        Request.new(:get, base_url + path, headers, params, &callback).call
+        Request.new(:get, base_url + path, @headers, params, &callback).call
       end
 
       def post(path, params = nil, &callback)
-        Request.new(:post, base_url + path, headers, params, &callback).call
+        Request.new(:post, base_url + path, @headers, params, &callback).call
       end
     end
   end

data/lib/common/http/headers.rb

@@ -11,7 +11,8 @@ class Motion
 
       def add(key, value)
         key = key.downcase
-        if @headers[key] && !@headers[key].is_a?(Array)
+        @headers[key] ||= []
+        unless @headers[key].is_a?(Array)
           @headers[key] = [@headers[key]]
         end
         @headers[key] << value

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: motion-http
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Andrew Havens
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-16 00:00:00.000000000 Z
+date: 2018-03-26 00:00:00.000000000 Z
 dependencies: []
 description: A cross-platform HTTP client for RubyMotion that's quick and easy to
   use.