mothership 0.0.8 → 0.0.9

data/lib/mothership/base.rb

@@ -54,7 +54,7 @@ class Mothership
   # invoke a command with the given inputs
   def invoke(name, inputs = {})
     if cmd = @@commands[name]
-      cmd.invoke(inputs)
+      cmd.invoke({}, inputs)
     else
       unknown_command(name)
     end

data/lib/mothership/command.rb

@@ -52,12 +52,12 @@ class Mothership
       str
     end
 
-    def invoke(inputs)
+    def invoke(given, inputs = {})
       @before.each { |f, c| c.new.instance_exec(&f) }
 
       name = @name
       ctx = @context.new(self)
-      input = Inputs.new(self, ctx, inputs)
+      input = Inputs.new(self, ctx, given, inputs)
 
       action = proc do |*given_inputs|
         ctx.send(name, given_inputs.first || input)

data/lib/mothership/errors.rb

@@ -14,12 +14,13 @@ class Mothership
   end
 
   class ExtraArguments < Error
-    def initialize(cmd)
+    def initialize(cmd, extra)
       @command = cmd
+      @extra = extra
     end
 
     def to_s
-      "#{@command}: too many arguments"
+      "#{@command}: too many arguments; extra: #{@extra.join(" ")}"
     end
   end
 

data/lib/mothership/inputs.rb

@@ -2,32 +2,34 @@ class Mothership
   class Inputs
     attr_reader :inputs
 
-    def initialize(command, context = nil, inputs = {})
+    def initialize(command, context = nil, given = {}, inputs = {})
       @command = command
       @context = context
+      @given = given
       @inputs = inputs
-      @cache = {}
     end
 
     def given?(name)
-      @inputs.key?(name)
+      @given.key?(name)
     end
 
     def given(name)
-      @inputs[name]
+      @given[name]
     end
 
     def merge(inputs)
-      self.class.new(@command, @context, @inputs.merge(inputs))
+      self.class.new(@command, @context, @given, @inputs.merge(inputs))
     end
 
     def without(*names)
+      given = @given.dup
       inputs = @inputs.dup
       names.each do |n|
+        given.delete(n)
         inputs.delete(n)
       end
 
-      self.class.new(@command, @context, inputs)
+      self.class.new(@command, @context, given, inputs)
     end
 
     def [](name, *args)
@@ -35,57 +37,66 @@ class Mothership
     end
 
     def get(name, context, *args)
-      return @cache[name] if @cache.key? name
+      return @inputs[name] if @inputs.key?(name)
 
       meta = @command.inputs[name]
       return unless meta
 
-      if @inputs.key?(name) && @inputs[name] != []
-        val =
-          if convert = meta[:from_given]
-            if @inputs[name].is_a?(Array)
-              @inputs[name].collect do |i|
-                @context.instance_exec(i, *args, &convert)
-              end
-            else
-              @context.instance_exec(@inputs[name], *args, &convert)
-            end
-          else
-            @inputs[name]
-          end
+      singular = meta[:singular]
+      return @inputs[name] = [@inputs[singular]] if @inputs.key?(singular)
+
+      given = @given[name] if @given.key?(name)
 
-        return @cache[name] = val
+      # value given; convert if needed
+      if given && given != []
+        return @inputs[name] = convert_given(meta, context, given, *args)
       end
 
-      val =
-        if meta[:default].respond_to? :to_proc
-          unless context
-            raise "no context for input request"
-          end
-
-          context.instance_exec(*args, &meta[:default])
-        elsif meta[:default]
-          meta[:default]
-        elsif meta[:type] == :boolean
-          false
-        elsif meta[:argument] == :splat
-          if meta[:singular] && single = @inputs[meta[:singular]]
-            [single]
-          else
-            []
-          end
-        end
+      # no value given; set as default
+      val = default_for(meta, context, *args)
 
       unless meta[:forget]
-        @cache[name] = val
+        @inputs[name] = val
       end
 
       val
     end
 
     def forget(name)
-      @cache.delete(name)
+      @given.delete(name)
       @inputs.delete(name)
     end
+
+    private
+
+    def convert_given(meta, context, given, *args)
+      if convert = meta[:from_given]
+        if given.is_a?(Array)
+          given.collect do |i|
+            context.instance_exec(i, *args, &convert)
+          end
+        else
+          context.instance_exec(given, *args, &convert)
+        end
+      else
+        given
+      end
+    end
+
+    def default_for(meta, context, *args)
+      if meta.key?(:default)
+        default = meta[:default]
+
+        if default.respond_to? :to_proc
+          context.instance_exec(*args, &default)
+        else
+          default
+        end
+      elsif meta[:type] == :boolean
+        false
+      elsif meta[:argument] == :splat
+        []
+      end
+    end
   end
 end

data/lib/mothership/parser.rb

@@ -124,7 +124,7 @@ class Mothership
         end
       end
 
-      raise ExtraArguments.new(@command.name) unless args.empty?
+      raise ExtraArguments.new(@command.name, args) unless args.empty?
     end
 
     private

data/lib/mothership/version.rb

@@ -1,3 +1,3 @@
 class Mothership
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: mothership
 version: !ruby/object:Gem::Version 
-  hash: 15
+  hash: 13
   prerelease: 
   segments: 
   - 0
   - 0
-  - 8
-  version: 0.0.8
+  - 9
+  version: 0.0.9
 platform: ruby
 authors: 
 - Alex Suraci