mote_sms 1.0.1 → 1.0.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: c312886b6c0d6e48f72f426ba3efe178752581d5
+  data.tar.gz: 16edf6e1e061cf5a7004996e6fc83be54e5bb09d
+SHA512:
+  metadata.gz: af66032a5d8c66e65184c714bd3901a85797ccbaac71d26b1045c24a75b7fa78f521c9f20de50f0d3291ffa601e8986cfc4573f506296c58ab526e74233f5d7b
+  data.tar.gz: 2460d1109f8f138db675389344e589761b98ac307c17f950995b6d6f42aa75cb04cd3d873a48acbaa61cacdda22be3726c6d423a0654186aafd865ad84910327

data/.travis.yml

@@ -3,3 +3,4 @@ rvm:
   - jruby-19mode
   - rbx-19mode
   - 1.9.3
+  - 2.0.0

data/lib/mote_sms/version.rb

@@ -1,3 +1,3 @@
 module MoteSMS
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/mote_sms.gemspec

@@ -19,10 +19,10 @@ Gem::Specification.new do |gem|
 
   gem.required_ruby_version = '>= 1.9'
 
-  gem.add_dependency 'phony', ['~> 1.7.0']
+  gem.add_dependency 'phony', ['~> 1.7']
 
   gem.add_development_dependency 'rake'
-  gem.add_development_dependency 'rspec', ['~> 2.10']
+  gem.add_development_dependency 'rspec', ['~> 2.14']
   gem.add_development_dependency 'webmock', ['~> 1.8.0']
   gem.add_development_dependency 'actionmailer', ['>= 3.2']
 end

data/spec/mote_sms/message_spec.rb

@@ -8,26 +8,26 @@ describe MoteSMS::Message do
       to '+41 79 123 12 12'
       body 'This is the SMS content'
     end
-    msg.from.number.should == 'SENDER'
-    msg.to.normalized_numbers.should == %w{41791231212}
-    msg.body.should == 'This is the SMS content'
+    expect(msg.from.number).to be == 'SENDER'
+    expect(msg.to.normalized_numbers).to be == %w{41791231212}
+    expect(msg.body).to be == 'This is the SMS content'
   end
 
   context '#to' do
     it 'behaves as accessor' do
       subject.to = '41791231212'
-      subject.to.normalized_numbers.should == %w{41791231212}
+      expect(subject.to.normalized_numbers).to be == %w{41791231212}
     end
 
     it 'behaves as array' do
       subject.to << '41791231212'
       subject.to << '41797775544'
-      subject.to.normalized_numbers.should == %w{41791231212 41797775544}
+      expect(subject.to.normalized_numbers).to be == %w{41791231212 41797775544}
     end
 
     it 'normalizes numbers' do
       subject.to = '+41 79 123 12 12'
-      subject.to.normalized_numbers.should == %w{41791231212}
+      expect(subject.to.normalized_numbers).to be == %w{41791231212}
     end
   end
 
@@ -36,24 +36,24 @@ describe MoteSMS::Message do
     subject { described_class.new(transport) }
 
     it "sends messages to transport" do
-      transport.should_receive(:deliver).with(subject, {})
+      expect(transport).to receive(:deliver).with(subject, {})
       subject.deliver
     end
 
     it "can pass additional attributes to transport" do
-      transport.should_receive(:deliver).with(subject, serviceid: "myapplication")
+      expect(transport).to receive(:deliver).with(subject, serviceid: "myapplication")
       subject.deliver serviceid: "myapplication"
     end
 
     it "can override per message transport using :transport option" do
-      transport.should_not_receive(:deliver)
+      expect(transport).to_not receive(:deliver)
       subject.deliver transport: double(deliver: true)
     end
 
     it "uses global MoteSMS.transport if no per message transport defined" do
       message = described_class.new
-      transport.should_receive(:deliver).with(message, {})
-      MoteSMS.should_receive(:transport) { transport }
+      expect(transport).to receive(:deliver).with(message, {})
+      expect(MoteSMS).to receive(:transport) { transport }
       message.deliver
     end
   end

data/spec/mote_sms/number_list_spec.rb

@@ -3,31 +3,31 @@ require 'mote_sms/number_list'
 
 describe MoteSMS::NumberList do
   it 'has length' do
-    subject.length.should == 0
+    expect(subject.length).to be == 0
     subject << '+41 79 111 22 33'
-    subject.length.should == 1
+    expect(subject.length).to be == 1
     5.times { subject << '+41 79 222 33 44' }
-    subject.length.should == 6
+    expect(subject.length).to be == 6
   end
 
   it 'has empty?' do
-    subject.empty?.should be_true
+    expect(subject.empty?).to be_true
     subject << '+41 79 111 22 33'
-    subject.empty?.should be_false
+    expect(subject.empty?).to be_false
   end
 
   it 'can add numbers by string' do
     subject << '+41 79 111 22 33'
-    subject.normalized_numbers.should == %w{41791112233}
+    expect(subject.normalized_numbers).to be == %w{41791112233}
   end
 
   it 'can multiple numbers using push' do
     subject.push '+41 79 111 22 33', '+41 44 111 22 33'
-    subject.normalized_numbers.should == %w{41791112233 41441112233}
+    expect(subject.normalized_numbers).to be == %w{41791112233 41441112233}
   end
 
   it 'can push multiple numbers with adding country codes' do
     subject.push '079 111 22 33', '0041 44 111 22 33', cc: '41', ndc: /(44|79)/
-    subject.normalized_numbers.should == %w{41791112233 41441112233}
+    expect(subject.normalized_numbers).to be == %w{41791112233 41441112233}
   end
 end

data/spec/mote_sms/number_spec.rb

@@ -36,15 +36,15 @@ describe MoteSMS::Number do
 
   context 'non conforming number' do
     it 'raises error when creating' do
-      Proc.new { described_class.new('what ever?') }.should raise_error(ArgumentError, /unable to parse/i)
-      Proc.new { described_class.new('0000') }.should raise_error(ArgumentError)
-      Proc.new { described_class.new('123456789012345678901') }.should raise_error(ArgumentError)
+      expect { described_class.new('what ever?') }.to raise_error(ArgumentError, /unable to parse/i)
+      expect { described_class.new('0000') }.to raise_error(ArgumentError)
+      expect { described_class.new('123456789012345678901') }.to raise_error(ArgumentError)
     end
   end
 
   context 'wrong cc/ndc' do
     it 'raises error when creating instance with wrong ndc' do
-      Proc.new { described_class.new('+41 44 364 35 33', cc: '41', ndc: '43') }.should raise_error(ArgumentError, /national destination/i)
+      expect { described_class.new('+41 44 364 35 33', cc: '41', ndc: '43') }.to raise_error(ArgumentError, /national destination/i)
     end
   end
 
@@ -57,13 +57,13 @@ describe MoteSMS::Number do
     its(:vanity?) { should be_true }
 
     it 'raises error if more than 11 alpha numeric chars' do
-      Proc.new { described_class.new('1234567890AB', vanity: true) }.should raise_error(ArgumentError, /invalid vanity/i)
+      expect { described_class.new('1234567890AB', vanity: true) }.to raise_error(ArgumentError, /invalid vanity/i)
     end
 
     it 'can also be normal phone number' do
       num = described_class.new('0800 123 12 12', vanity: true)
-      num.to_s.should == '08001231212'
-      num.to_number.should == '08001231212'
+      expect(num.to_s).to be == '08001231212'
+      expect(num.to_number).to be == '08001231212'
     end
   end
 end

data/spec/mote_sms/transports/action_mailer_transport_spec.rb

@@ -19,9 +19,9 @@ describe MoteSMS::ActionMailerTransport do
 
   it 'sends SMS as e-mail' do
     subject.deliver message
-    email.to.should == ["sms@example.com"]
-    email.from.should == ["sms@example.com"]
-    email.subject.should == "SMS to +41 79 123 12 12"
-    email.body.should == "This is the SMS content"
+    expect(email.to).to be == ["sms@example.com"]
+    expect(email.from).to be == ["sms@example.com"]
+    expect(email.subject).to be == "SMS to +41 79 123 12 12"
+    expect(email.body).to be == "This is the SMS content"
   end
 end

data/spec/mote_sms/transports/mobile_technics_transport_spec.rb

@@ -7,7 +7,7 @@ require 'mote_sms/transports/mobile_technics_transport'
 describe MoteSMS::MobileTechnicsTransport do
   before do
     @logger = described_class.logger
-    described_class.logger = stub(debug: true, info: true, error: true)
+    described_class.logger = double("logger", debug: true, info: true, error: true)
   end
 
   after do
@@ -33,10 +33,10 @@ describe MoteSMS::MobileTechnicsTransport do
     it "sends POST to endpoint with URL encoded body" do
       stub_request(:post, endpoint).with do |req|
         params = CGI.parse(req.body)
-        params['username'].should == %w{example}
-        params['password'].should == %w{123456}
-        params['text'].should == ['Hello World, with äöü.']
-        params['call-number'].should == ['0041791231212']
+        expect(params['username']).to be == %w{example}
+        expect(params['password']).to be == %w{123456}
+        expect(params['text']).to be == ['Hello World, with äöü.']
+        expect(params['call-number']).to be == ['0041791231212']
       end.to_return(success)
       subject.deliver message
     end
@@ -51,17 +51,17 @@ describe MoteSMS::MobileTechnicsTransport do
 
     it 'raises exception if required parameter is missing' do
       stub_request(:post, endpoint).to_return(body: 'Result_code: 02, call-number')
-      Proc.new { subject.deliver message }.should raise_error(MoteSMS::MobileTechnicsTransport::ServiceError)
+      expect { subject.deliver message }.to raise_error(MoteSMS::MobileTechnicsTransport::ServiceError)
     end
 
     it 'raises exception if status code is not 200' do
       stub_request(:post, endpoint).to_return(status: 500)
-      Proc.new { subject.deliver message }.should raise_error(MoteSMS::MobileTechnicsTransport::ServiceError)
+      expect { subject.deliver message }.to raise_error(MoteSMS::MobileTechnicsTransport::ServiceError)
     end
 
     it 'returns message id' do
       stub_request(:post, endpoint).to_return(success)
-      subject.deliver(message).should == %w{43797917}
+      expect(subject.deliver(message)).to be == %w{43797917}
     end
 
     it 'logs curl compatible output' do
@@ -70,21 +70,21 @@ describe MoteSMS::MobileTechnicsTransport do
       stub_request(:post, endpoint).to_return(success)
       subject.deliver message
       io.rewind
-      io.read.should =~ %r{curl -XPOST 'http://test.nth.ch' -d 'allow_adaption=1&}
+      expect(io.read).to match %r{curl -XPOST 'http://test.nth.ch' -d 'allow_adaption=1&}
     end
   end
 
   context "#options" do
     it 'can be passed in as last item in the constructor' do
       transport = described_class.new endpoint, 'user', 'pass', allow_adaption: false, validity: 30
-      transport.options[:allow_adaption].should be_false
-      transport.options[:validity].should == 30
-      transport.options[:something].should be_nil
+      expect(transport.options[:allow_adaption]).to be_false
+      expect(transport.options[:validity]).to be == 30
+      expect(transport.options[:something]).to be_nil
     end
 
     it 'should be exposed as hash' do
       subject.options[:messageid] = "test"
-      subject.options[:messageid].should == "test"
+      expect(subject.options[:messageid]).to be == "test"
     end
 
     it 'overrides settings from #defaults' do

data/spec/mote_sms/transports/test_transport_spec.rb

@@ -6,12 +6,12 @@ describe MoteSMS::TestTransport do
   before { MoteSMS.deliveries.clear }
 
   it 'defines global #deliveries' do
-    MoteSMS.should respond_to(:deliveries)
+    expect(MoteSMS).to respond_to(:deliveries)
   end
 
   it 'appends deliveries' do
     subject.deliver "firstMessage"
     subject.deliver "secondMessage"
-    MoteSMS.deliveries.should == %w{firstMessage secondMessage}
+    expect(MoteSMS.deliveries).to be == %w{firstMessage secondMessage}
   end
 end

data/spec/mote_sms_spec.rb

@@ -5,7 +5,7 @@ describe MoteSMS do
   subject { described_class }
 
   it 'has a version' do
-    subject::VERSION.should =~ /\d/
+    expect(subject::VERSION).to match /\d/
   end
 
   context "transport" do
@@ -14,23 +14,23 @@ describe MoteSMS do
     let(:transport) { double("transport") }
 
     it "has no default transport" do
-      subject.transport.should be_nil
+      expect(subject.transport).to be_nil
     end
 
     it "can change global transport" do
       subject.transport = transport
-      subject.transport.should == transport
+      expect(subject.transport).to be == transport
     end
 
     context "#deliver" do
       it 'delivers quick and dirty using global transport' do
-        transport.should_receive(:deliver).with(kind_of(MoteSMS::Message), {})
+        expect(transport).to receive(:deliver).with(kind_of(MoteSMS::Message), {})
         subject.transport = transport
         subject.deliver { body 'Hello World' }
       end
 
       it 'raises error if block is missing' do
-        Proc.new { subject.deliver }.should raise_error(ArgumentError, /block missing/i)
+        expect { subject.deliver }.to raise_error(ArgumentError, /block missing/i)
       end
     end
   end

data/spec/spec_helper.rb

@@ -3,3 +3,10 @@ require 'bundler/setup'
 
 require 'rspec'
 require 'webmock/rspec'
+
+# Disable should syntax
+RSpec.configure do |config|
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+end

metadata

@@ -1,68 +1,60 @@
 --- !ruby/object:Gem::Specification
 name: mote_sms
 version: !ruby/object:Gem::Version
-  version: 1.0.1
-  prerelease: 
+  version: 1.0.2
 platform: ruby
 authors:
 - Lukas Westermann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-21 00:00:00.000000000 Z
+date: 2013-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: phony
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: '1.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.10'
+        version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.10'
+        version: '2.14'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -70,7 +62,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -78,22 +69,21 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: actionmailer
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.2'
-description: ! "Unofficial ruby adapter for MobileTechnics HTTP Bulk SMS API.\n                         Tries
-  to mimick mail API, so users can switch e.g. ActionMailer\n                         with
-  this SMS provider."
+description: |-
+  Unofficial ruby adapter for MobileTechnics HTTP Bulk SMS API.
+                           Tries to mimick mail API, so users can switch e.g. ActionMailer
+                           with this SMS provider.
 email:
 - lukas.westermann@at-point.ch
 executables: []
@@ -127,30 +117,26 @@ files:
 - spec/spec_helper.rb
 homepage: https://at-point.ch/opensource
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '1.9'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -686134082126475921
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Deliver SMS using MobileTechnics HTTP API.
 test_files:
 - spec/mote_sms/message_spec.rb