most_related 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d1a63ce584fc9c15f6c22b779faa18ed0b282c97
-  data.tar.gz: 2c658856e11fd8ae33e2577f6e31ebd8483f086d
+  metadata.gz: b655ee05c62fde06ac5da9dbb806d5b2d46aa2e8
+  data.tar.gz: b716b9ac1370e5fa5f31a1cb6c12a3fa0267c397
 SHA512:
-  metadata.gz: 2c37efcfe4ff80b99537a3629e76eb62d75fd5625cbf04fb14e5eb11b4815b24c846f7c60af719f02770c0b15e48394ba8994c9a8b5222266b5331ca75a42e43
-  data.tar.gz: 694fd16398d5a0a46eb39407f6ecdd70608dda4fd83ea072b79c0d8db39d88e96438d1f707890975469bdefffd9dc9c89524da2a1885fde2a929b07637f764a3
+  metadata.gz: 652d59f88d1a0dfbf6b782dbfa6c9b4cd6d5b61d6eb812470aa5398771ec63f9b53f145a981d03c7d8bfbac1c087da72f73abada3fc2bd42b34ee7f61374ac32
+  data.tar.gz: bd8d55d28bb3c534d440d41a5f447994ccc10ec5439730ed2434900fcc4e27d80134e1001a2080debefeb83e9aeaae3c5a03ba6c25c36d1890ed7274fd8a0664

data/.ruby-version

@@ -1 +1 @@
-2.0.0-p247
+2.2.2

data/README.md

@@ -54,9 +54,10 @@ The count of the many to many associated models in common is accessible on each
 
     post.most_related_count
     post.most_related_by_tag_count
-    post.most_related_by_author_or_tag
+    post.most_related_by_author_or_tag_count
 
-If multiple many to many associations are used, the syntax is specific to MySql.
+If multiple many to many associations are used, the syntax is specific to MySql although
+it could be made to work with Postgres.
 
 Because of the use of 'group', pagination is not supported.
 

data/lib/most_related/version.rb

@@ -1,3 +1,3 @@
 module MostRelated
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/most_related.rb

@@ -35,7 +35,7 @@ module MostRelated
   #   post.most_related_by_author_or_tag
   #
   # The count of the many to many associated models in common is accessible on each returned model
-  #   eg post.most_related_count, post.most_related_by_tag_count and post.most_related_by_author_or_tag
+  #   eg post.most_related_count, post.most_related_by_tag_count and post.most_related_by_author_or_tag_count
   #
   def has_most_related(many_to_many_associations, as: :most_related)
 
@@ -60,6 +60,8 @@ module MostRelated
           joins("INNER JOIN #{join_table} ON #{join_table}.#{foreign_key} = #{table_name}.id")
       end
 
+      # with postgres, multiple many-to-many associations doesn't work and here's why
+      # http://dba.stackexchange.com/questions/88988/postgres-error-column-must-appear-in-the-group-by-clause-or-be-used-in-an-aggre
       scope = self.class.select("#{table_name}.*, count(#{table_name}.id) AS #{as}_count").
         where.not(id: self.id).group("#{table_name}.id").order("#{as}_count DESC")
 
@@ -68,7 +70,7 @@ module MostRelated
         scope.merge(association_scopes.first)
       else
         # see http://blog.ubersense.com/2013/09/27/tech-talk-unioning-scoped-queries-in-rails/
-        scope.from("((#{association_scopes.map(&:to_sql).join(') UNION ALL (')})) #{table_name}")
+        scope.from("((#{association_scopes.map(&:to_sql).join(') UNION ALL (')})) AS #{table_name}")
       end
     end
 
@@ -88,4 +90,4 @@ module MostRelated
 end
 
 # Extend ActiveRecord functionality
-ActiveRecord::Base.extend MostRelated
+ActiveRecord::Base.extend MostRelated

data/most_related.gemspec

@@ -7,9 +7,9 @@ Gem::Specification.new do |spec|
   spec.name          = "most_related"
   spec.version       = MostRelated::VERSION
   spec.authors       = ["Jolyon Pawlyn"]
-  spec.email         = ["jolyon.pawlyn@unboxedconsulting.com"]
-  spec.description   = %q{Adds an instance method to a active record model that returns the most related models based on many to many associated models in common}
-  spec.summary       = %q{Returns models that have the most many to many associated models in common}
+  spec.email         = ["jpawlyn@gmail.com"]
+  spec.description   = %q{Adds an instance method to a active record model that returns the most related models based on associated models in common}
+  spec.summary       = %q{Returns models that have the most associated models in common}
   spec.homepage      = "https://github.com/jpawlyn/most_related"
   spec.license       = "MIT"
 
@@ -18,8 +18,13 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rspec", "~> 2.14.1"
-  spec.add_development_dependency "activerecord", "~> 4.0.0"
-  spec.add_development_dependency "sqlite3"
+  spec.required_ruby_version     = '>= 1.9.3'
+  spec.add_runtime_dependency 'activerecord', '~> 4.0', '>= 4.0.0'
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'rspec', '~> 2.14', '>= 2.14.1'
+  spec.add_development_dependency 'database_cleaner', '~>1.4'
+  spec.add_development_dependency 'sqlite3', '~>1.3'
+  spec.add_development_dependency 'mysql2', '~>0.3'
+  spec.add_development_dependency 'pg', '~>0.18'
+  spec.add_development_dependency 'byebug', '~>4.0'
 end

data/spec/post_spec.rb

@@ -37,30 +37,16 @@ describe Post do
   end
 
   context "combination of 'has_many through:' and habtm" do
-    let(:post)  { Post.create! authors: [author1, author2, author3], tags: [tag1, tag2, tag3] }
-    let(:post1) { Post.create! authors: [author1, author2, author3], tags: [tag1, tag2, tag4] }
-    let(:post2) { Post.create! authors: [author1, author4] }
-    let(:post3) { Post.create! tags: [tag4] }
-    let(:post4) { Post.create! authors: [author1], tags: [tag1, tag2, tag3] }
+    let!(:post)  { Post.create! authors: [author1, author2, author3], tags: [tag1, tag2, tag3] }
+    let!(:post1) { Post.create! authors: [author1, author2, author3], tags: [tag1, tag2, tag4] }
+    let!(:post2) { Post.create! authors: [author1, author4] }
+    let!(:post3) { Post.create! tags: [tag4] }
+    let!(:post4) { Post.create! authors: [author1], tags: [tag1, tag2, tag3] }
 
     it 'return posts that have the most authors and tags in common with post' do
-      pending 'Does not work with sqlite - mysql only perhaps?'
+      # note, this test currently only passes with MySQL
       expect(post.most_related_by_author_or_tag.map(&:most_related_by_author_or_tag_count)).to eq([5, 4, 1])
       expect(post.most_related_by_author_or_tag).to eq([post1, post4, post2])
     end
-
-    it 'sql check' do
-      expect(post.most_related_by_author_or_tag.where_clauses).to eq(["(\"posts\".\"id\" != #{post.id})"])
-      expect(post.most_related_by_author_or_tag.order_clauses).to eq(["most_related_by_author_or_tag_count DESC"])
-      sql = <<-eos
-        SELECT posts.*, count(posts.id) AS most_related_by_author_or_tag_count FROM
-          ((SELECT \"posts\".* FROM \"posts\" INNER JOIN author_posts ON author_posts.post_id = posts.id WHERE
-            (author_posts.author_id IN (select author_posts.author_id from author_posts where author_posts.post_id = #{post.id})))
-          UNION ALL (SELECT \"posts\".* FROM \"posts\" INNER JOIN posts_tags ON posts_tags.post_id = posts.id WHERE
-            (posts_tags.tag_id IN (select posts_tags.tag_id from posts_tags where posts_tags.post_id = #{post.id})))) posts
-        WHERE (\"posts\".\"id\" != #{post.id}) GROUP BY posts.id  ORDER BY most_related_by_author_or_tag_count DESC
-      eos
-      expect(post.most_related_by_author_or_tag.to_sql.squish!).to eq(sql.squish!)
-    end
   end
 end

data/spec/spec_helper.rb

@@ -6,13 +6,18 @@
 
 # see http://blog.markstarkman.com/blog/2013/01/23/using-sqlite-to-test-active-record-models/
 require 'active_record'
-ActiveRecord::Base.establish_connection adapter: 'sqlite3', database: ':memory:'
+
+ActiveRecord::Base.establish_connection adapter: 'mysql2', database: 'most_related'
+# ActiveRecord::Base.establish_connection adapter: 'sqlite3', database: ':memory:'
+# ActiveRecord::Base.establish_connection adapter: 'postgresql', database: 'most_related'
 load 'support/schema.rb'
 
 require 'most_related'
 require 'support/models'
-require 'support/string'
+require 'database_cleaner'
+require 'byebug'
 
+DatabaseCleaner.strategy = :transaction
 
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
@@ -25,4 +30,12 @@ RSpec.configure do |config|
   # the seed, which is printed after each run.
   #     --seed 1234
   config.order = 'random'
+
+  config.before :each do
+    DatabaseCleaner.start
+  end
+
+  config.after :each do
+    DatabaseCleaner.clean
+  end
 end

data/spec/support/schema.rb

@@ -2,17 +2,17 @@ ActiveRecord::Schema.define do
   self.verbose = false
 
   create_table :authors, force: true do |t|
-    t.timestamps
+    t.timestamps null: false
   end
 
   create_table :author_posts, force: true do |t|
     t.integer :author_id, null: false
     t.integer :post_id, null: false
-    t.timestamps
+    t.timestamps null: false
   end
 
   create_table :posts, force: true do |t|
-    t.timestamps
+    t.timestamps null: false
   end
 
   create_table :posts_tags, force: true do |t|

metadata

@@ -1,82 +1,150 @@
 --- !ruby/object:Gem::Specification
 name: most_related
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Jolyon Pawlyn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-09 00:00:00.000000000 Z
+date: 2015-05-09 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.14'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.14.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.14'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.14.1
 - !ruby/object:Gem::Dependency
-  name: activerecord
+  name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: '1.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.0.0
+        version: '1.4'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: mysql2
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.3'
+- !ruby/object:Gem::Dependency
+  name: pg
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.18'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.18'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.0'
 description: Adds an instance method to a active record model that returns the most
-  related models based on many to many associated models in common
+  related models based on associated models in common
 email:
-- jolyon.pawlyn@unboxedconsulting.com
+- jpawlyn@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .ruby-version
+- ".gitignore"
+- ".rspec"
+- ".ruby-version"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -88,7 +156,6 @@ files:
 - spec/spec_helper.rb
 - spec/support/models.rb
 - spec/support/schema.rb
-- spec/support/string.rb
 homepage: https://github.com/jpawlyn/most_related
 licenses:
 - MIT
@@ -99,23 +166,22 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
-summary: Returns models that have the most many to many associated models in common
+summary: Returns models that have the most associated models in common
 test_files:
 - spec/post_spec.rb
 - spec/spec_helper.rb
 - spec/support/models.rb
 - spec/support/schema.rb
-- spec/support/string.rb

data/spec/support/string.rb

@@ -1,8 +0,0 @@
-class String
-  def squish!
-    gsub!(/\A[[:space:]]+/, '')
-    gsub!(/[[:space:]]+\z/, '')
-    gsub!(/[[:space:]]+/, ' ')
-    self
-  end
-end