morpheus-cli 9.0.1 → 9.1.0

data/test/cli/affinity_groups_cluster_scope_test.rb

@@ -0,0 +1,171 @@
+require 'test/unit'
+require 'stringio'
+require 'morpheus'
+
+class AffinityGroupsClusterScopeTest < Test::Unit::TestCase
+  class FakeCloudsInterface
+    attr_reader :calls
+
+    def initialize(cloud)
+      @cloud = cloud
+      @calls = []
+      @dry = false
+    end
+
+    def setopts(_options)
+      self
+    end
+
+    def dry
+      @dry = true
+      self
+    end
+
+    def get(id, params = {})
+      @calls << [:get, id, params]
+      {'zone' => @cloud}
+    end
+
+    def list(params = {})
+      @calls << [:list, params]
+      {'zones' => [@cloud]}
+    end
+
+    def list_affinity_groups(id, params = {})
+      @calls << [:list_affinity_groups, id, params]
+      return {'affinityGroups' => []} unless @dry
+
+      {method: :get, url: "/api/zones/#{id}/affinity-groups", params: params}
+    end
+  end
+
+  class FakeResourcePoolsInterface
+    attr_reader :calls
+
+    def initialize(pool)
+      @pool = pool
+      @calls = []
+    end
+
+    def get(cloud_id, id, params = {})
+      @calls << [:get, cloud_id, id, params]
+      {'resourcePool' => @pool}
+    end
+
+    def list(cloud_id, params = {})
+      @calls << [:list, cloud_id, params]
+      {'resourcePools' => [@pool]}
+    end
+
+    def list_without_cloud(params = {})
+      @calls << [:list_without_cloud, params]
+      {'resourcePools' => [@pool]}
+    end
+  end
+
+  class FakeClustersInterface
+    attr_reader :calls
+
+    def initialize(clusters = [])
+      @clusters = clusters
+      @calls = []
+      @dry = false
+    end
+
+    def setopts(_options)
+      self
+    end
+
+    def dry
+      @dry = true
+      self
+    end
+
+    def list(params = {})
+      @calls << [:list, params]
+      {'clusters' => @clusters.select {|cluster| cluster['name'] == params[:name]}}
+    end
+
+    def list_affinity_groups(id, params = {})
+      @calls << [:list_affinity_groups, id, params]
+      return {'affinityGroups' => []} unless @dry
+
+      {method: :get, url: "/api/clusters/#{id}/affinity-groups", params: params}
+    end
+  end
+
+  def setup
+    @cloud = {'id' => 59, 'name' => 'vCenter Cloud'}
+    @pool = {
+      'id' => 501,
+      'name' => 'QA',
+      'type' => 'Cluster',
+      'zone' => @cloud
+    }
+  end
+
+  def test_cloud_qualified_cluster_sends_pool_id
+    command, pools, = build_command
+
+    output = capture_stdout do
+      command.list(['--cloud', 'vCenter Cloud', '--cluster', 'QA', '--dry-run'])
+    end
+
+    assert_match(%r{/api/zones/59/affinity-groups}, output)
+    assert_match(/poolId=501/, output)
+    assert_equal [[:list, 59, {name: 'QA', type: 'Cluster'}]], pools.calls
+  end
+
+  def test_cluster_name_falls_back_to_unique_vsphere_cluster
+    command, pools, clusters = build_command
+
+    output = capture_stdout { command.list(['--cluster', 'QA', '--dry-run']) }
+
+    assert_match(%r{/api/zones/59/affinity-groups}, output)
+    assert_match(/poolId=501/, output)
+    assert_equal [[:list, {name: 'QA'}]], clusters.calls
+    assert_equal [
+      [:list_without_cloud, {name: 'QA', type: 'Cluster', max: 1000}]
+    ], pools.calls
+  end
+
+  def test_managed_cluster_takes_precedence
+    managed_cluster = {'id' => 8, 'name' => 'QA'}
+    command, pools, clusters = build_command([managed_cluster])
+
+    output = capture_stdout { command.list(['--cluster', 'QA', '--dry-run']) }
+
+    assert_match(%r{/api/clusters/8/affinity-groups}, output)
+    assert_equal [
+      [:list, {name: 'QA'}],
+      [:list_affinity_groups, 8, {}]
+    ], clusters.calls
+    assert_empty pools.calls
+  end
+
+  private
+
+  def build_command(managed_clusters = [])
+    clouds = FakeCloudsInterface.new(@cloud)
+    pools = FakeResourcePoolsInterface.new(@pool)
+    clusters = FakeClustersInterface.new(managed_clusters)
+    command = Morpheus::Cli::AffinityGroupsCommand.new
+    command.define_singleton_method(:connect) do |_options|
+      @clouds_interface = clouds
+      @clusters_interface = clusters
+      @cloud_resource_pools_interface = pools
+    end
+    [command, pools, clusters]
+  end
+
+  def capture_stdout
+    terminal = Morpheus::Terminal.instance
+    original = terminal.stdout
+    buffer = StringIO.new
+    terminal.set_stdout(buffer)
+    yield
+    buffer.string
+  ensure
+    terminal.set_stdout(original)
+  end
+end

data/test/cli/affinity_groups_test.rb

@@ -0,0 +1,57 @@
+require 'morpheus_test'
+
+# Tests for Morpheus::Cli::AffinityGroupsCommand
+#
+# Scope note: these cover only client-side behaviour -- help output and argument
+# validation -- both of which resolve before any API call is made.
+#
+# Tests that would exercise list/get/add/update/remove against the appliance are
+# deliberately omitted until the /api/affinity-groups request and response
+# contract is confirmed against the MORPH-14136 / MORPH-16074 server work.
+# See test/cli/affinity_helper_test.rb for the offline coverage of the shared
+# affinity enums and formatters.
+class MorpheusTest::AffinityGroupsTest < MorpheusTest::TestCase
+
+  def test_affinity_groups_help
+    assert_execute %(affinity-groups --help)
+    assert_execute %(affinity-groups list --help)
+    assert_execute %(affinity-groups get --help)
+    assert_execute %(affinity-groups add --help)
+    assert_execute %(affinity-groups update --help)
+    assert_execute %(affinity-groups remove --help)
+  end
+
+  ## Argument validation (fails during option parsing, before any request)
+
+  def test_affinity_groups_unknown_subcommand
+    assert_error %(affinity-groups nonsense-subcommand)
+  end
+
+  def test_affinity_groups_get_requires_an_id
+    assert_error %(affinity-groups get)
+  end
+
+  def test_affinity_groups_update_requires_an_id
+    assert_error %(affinity-groups update)
+  end
+
+  def test_affinity_groups_remove_requires_an_id
+    assert_error %(affinity-groups remove -y)
+  end
+
+  def test_affinity_groups_list_rejects_unknown_option
+    assert_error %(affinity-groups list --not-a-real-option)
+  end
+
+  # There is no unscoped list/create route -- morpheus-ui ApiV1UrlMappings
+  # exposes only /api/affinity-groups/{id} at the top level, so list and add
+  # must refuse to run without --cloud or --cluster rather than 404.
+  def test_affinity_groups_list_requires_a_scope
+    assert_error %(affinity-groups list)
+  end
+
+  def test_affinity_groups_add_requires_a_scope
+    assert_error %(affinity-groups add --name cli-test --dry-run)
+  end
+
+end

data/test/cli/affinity_groups_violations_scope_test.rb

@@ -0,0 +1,141 @@
+require 'test/unit'
+require 'stringio'
+require 'morpheus'
+
+# Offline exercise of the MORPH-17279 --cluster scope for
+# AffinityGroupsCommand#violations. Unlike list/add, the violations endpoint
+# (AffinityGroupsController#violations) only accepts clusterId or cloudId -- it
+# has no poolId path and no vSphere-pool-scoped violation data. So a managed
+# cluster name resolves to clusterId, while a cloud-owned vSphere cluster name
+# must produce a clear error instead of silently exiting 1 or broadening scope.
+class AffinityGroupsViolationsScopeTest < Test::Unit::TestCase
+  class FakeAffinityGroupsInterface
+    attr_reader :calls
+
+    def initialize
+      @calls = []
+      @dry = false
+    end
+
+    def setopts(_options)
+      self
+    end
+
+    def dry
+      @dry = true
+      self
+    end
+
+    def violations(params = {})
+      @calls << [:violations, params]
+      return {'violations' => []} unless @dry
+
+      {method: :get, url: "/api/affinity-groups/violations", params: params}
+    end
+  end
+
+  class FakeCloudsInterface
+    def initialize(cloud)
+      @cloud = cloud
+    end
+
+    def setopts(_options); self; end
+    def dry; self; end
+    def get(id, params = {}); {'zone' => @cloud}; end
+    def list(params = {}); {'zones' => [@cloud]}; end
+  end
+
+  class FakeResourcePoolsInterface
+    def initialize(pools)
+      @pools = pools
+    end
+
+    def get(cloud_id, id, params = {})
+      {'resourcePool' => @pools.find {|p| p['id'].to_i == id.to_i }}
+    end
+
+    def list(cloud_id, params = {})
+      {'resourcePools' => @pools}
+    end
+
+    def list_without_cloud(params = {})
+      {'resourcePools' => @pools}
+    end
+  end
+
+  class FakeClustersInterface
+    def initialize(clusters = [])
+      @clusters = clusters
+    end
+
+    def list(params = {})
+      {'clusters' => @clusters.select {|cluster| cluster['name'] == params[:name]}}
+    end
+  end
+
+  def setup
+    @cloud = {'id' => 59, 'name' => 'vCenter Cloud'}
+    @pool = {'id' => 501, 'name' => 'QA', 'type' => 'Cluster', 'zone' => @cloud}
+  end
+
+  def test_managed_cluster_name_scopes_violations_by_cluster_id
+    command, affinity = build_command([{'id' => 8, 'name' => 'QA'}])
+
+    output = capture_stdout { command.violations(['--cluster', 'QA', '--dry-run']) }
+
+    assert_match(%r{/api/affinity-groups/violations}, output)
+    assert_match(/clusterId=8/, output)
+    assert_equal [[:violations, {'clusterId' => 8}]], affinity.calls
+  end
+
+  def test_vsphere_cluster_name_reports_clear_error_without_calling_violations
+    command, affinity = build_command([])
+
+    result = nil
+    err = capture_stderr do
+      capture_stdout { result = command.violations(['--cluster', 'QA', '--dry-run']) }
+    end
+
+    assert_equal 1, (result.is_a?(Array) ? result[0] : result)
+    assert_match(/only available for Morpheus managed clusters/i, err)
+    assert_match(/vCenter Cloud/, err)
+    assert_empty affinity.calls
+  end
+
+  private
+
+  def build_command(managed_clusters = [])
+    affinity = FakeAffinityGroupsInterface.new
+    clouds = FakeCloudsInterface.new(@cloud)
+    pools = FakeResourcePoolsInterface.new([@pool])
+    clusters = FakeClustersInterface.new(managed_clusters)
+    command = Morpheus::Cli::AffinityGroupsCommand.new
+    command.define_singleton_method(:connect) do |_options|
+      @affinity_groups_interface = affinity
+      @clouds_interface = clouds
+      @clusters_interface = clusters
+      @cloud_resource_pools_interface = pools
+    end
+    [command, affinity]
+  end
+
+  def capture_stdout
+    terminal = Morpheus::Terminal.instance
+    original = terminal.stdout
+    buffer = StringIO.new
+    terminal.set_stdout(buffer)
+    yield
+    buffer.string
+  ensure
+    terminal.set_stdout(original)
+  end
+
+  def capture_stderr
+    original = $stderr
+    $stderr = StringIO.new
+    yield
+    $stderr.string
+  ensure
+    $stderr = original
+  end
+end