morpheus-cli 5.3.2.3 → 5.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fedf8a7443a29dd8ac5097e8f17bec94d481d3d1cadffd16dce033d9cb152f61
-  data.tar.gz: f1a306e2a42cebcb474371e589c07b2b31f6ed84faee0d47b640813e672d08ce
+  metadata.gz: ca7c939828b8f72ee86c663a19d01743a56d5c6c209cecc5e17b44046caeb484
+  data.tar.gz: e13fccbf1a45e8980e818e4cc1f0dba98d65e405c79f5d90e13c33341ad2e514
 SHA512:
-  metadata.gz: fe7834f3099b3dd5666c9230c8b833ac05a613d58465850d0eaf5e88cdb973a8eec4ac020946d6ba902abb43cd71d705760040e69b243a2e670e2dd8b5295c9b
-  data.tar.gz: 3cc4909d59ae2fcf99f319e74a13eb4db2261fe475629723b6a091fbf3dd13aa5f92e939ae9262ec44b9817b97591c21d6ac69046c400c41523ed588c9602087
+  metadata.gz: 5965b1af85499cadcae249f3109b6fd0ea4bee6af38192196fd6091bdcdb452f75c1f4025f372ec3d5f47ab1531e04acbf5fb2ed17848ba023087c309fdd06ee
+  data.tar.gz: 56bc2124de4e6b28c0c4484b5fa40beef19287708edd98ee1fdddbe334bc7854b853153209d1531793502aa8034d1c8ccf9fca643ec13aebf3eb8353cdd1f72e

data/Dockerfile

@@ -1,5 +1,5 @@
 FROM ruby:2.5.1
 
-RUN gem install morpheus-cli -v 5.3.2.3
+RUN gem install morpheus-cli -v 5.3.3
 
 ENTRYPOINT ["morpheus"]

data/lib/morpheus/api/instances_interface.rb

@@ -57,11 +57,24 @@ class Morpheus::InstancesInterface < Morpheus::APIClient
     execute(opts)
   end
 
-  def cancel_removal(id, params = {})
-    url = "#{@base_url}/api/instances/#{id}/cancel-removal"
-    headers = {:params => params, :authorization => "Bearer #{@access_token}", 'Content-Type' => 'application/json' }
-    opts = {method: :put, url: url, headers: headers}
-    execute(opts)
+  def extend_shutdown(id, params={}, payload={}, headers={})
+    execute(method: :put, url: "#{base_path}/#{id}/extend-shutdown", params: params, payload: payload, headers: headers)
+  end
+
+  def extend_expiration(id, params={}, payload={}, headers={})
+    execute(method: :put, url: "#{base_path}/#{id}/extend-expiration", params: params, payload: payload, headers: headers)
+  end
+
+  def cancel_shutdown(id, params={}, payload={}, headers={})
+    execute(method: :put, url: "#{base_path}/#{id}/cancel-shutdown", params: params, payload: payload, headers: headers)
+  end
+
+  def cancel_expiration(id, params={}, payload={}, headers={})
+    execute(method: :put, url: "#{base_path}/#{id}/cancel-expiration", params: params, payload: payload, headers: headers)
+  end
+
+  def cancel_removal(id, params={}, payload={}, headers={})
+    execute(method: :put, url: "#{base_path}/#{id}/cancel-removal", params: params, payload: payload, headers: headers)
   end
 
   def stop(id, params={})

data/lib/morpheus/api/virtual_images_interface.rb

@@ -45,10 +45,10 @@ class Morpheus::VirtualImagesInterface < Morpheus::APIClient
     execute(method: :put, url: url, headers: headers, payload: payload.to_json)
   end
 
-  def destroy(id)
+  def destroy(id, params={})
     url = "#{@base_url}/api/virtual-images/#{id}"
     headers = { :authorization => "Bearer #{@access_token}", 'Content-Type' => 'application/json' }
-    execute(method: :delete, url: url, headers: headers)
+    execute(method: :delete, url: url, params: params, headers: headers)
   end
 
   # multipart file upload
@@ -165,4 +165,25 @@ class Morpheus::VirtualImagesInterface < Morpheus::APIClient
     execute(method: :delete, url: url, headers: headers)
   end
 
+  def location_base_path(resource_id)
+    "/api/virtual-images/#{resource_id}/locations"
+  end
+
+  def list_locations(resource_id, params={}, headers={})
+    validate_id!(resource_id)
+    execute(method: :get, url: "#{location_base_path(resource_id)}", params: params, headers: headers)
+  end
+
+  def get_location(resource_id, id, params={}, headers={})
+    validate_id!(resource_id)
+    validate_id!(id)
+    execute(method: :get, url: "#{location_base_path(resource_id)}/#{id}", params: params, headers: headers)
+  end
+
+  def destroy_location(resource_id, id, params = {}, headers={})
+    validate_id!(resource_id)
+    validate_id!(id)
+    execute(method: :delete, url: "#{location_base_path(resource_id)}/#{id}", params: params, headers: headers)
+  end
+
 end

data/lib/morpheus/cli/apps.rb

@@ -438,7 +438,7 @@ class Morpheus::Cli::Apps
                       instance_prompt_options[:default_cloud] = cloud ? cloud['name'] : nil
                       instance_prompt_options[:environment] = selected_environment ? selected_environment['code'] : nil
                       instance_prompt_options[:default_security_groups] = scoped_instance_config['securityGroups'] ? scoped_instance_config['securityGroups'] : nil
-                      
+
                       instance_prompt_options[:no_prompt] = options[:no_prompt]
                       #instance_prompt_options[:always_prompt] = options[:no_prompt] != true # options[:always_prompt]
                       instance_prompt_options[:options] = scoped_instance_config # meh, actually need to make these default values instead..
@@ -460,8 +460,9 @@ class Morpheus::Cli::Apps
                       instance_prompt_options[:locked_fields] = scoped_instance_config['lockedFields']
                       instance_prompt_options[:for_app] = true
                       # this provisioning helper method handles all (most) of the parsing and prompting
+                      scoped_instance_config = Marshal.load( Marshal.dump(scoped_instance_config) )
                       instance_config_payload = prompt_new_instance(instance_prompt_options)
-                      
+
                       # strip all empty string and nil
                       instance_config_payload.deep_compact!
                       # use the blueprint config as the base

data/lib/morpheus/cli/cli_command.rb

@@ -1202,11 +1202,18 @@ module Morpheus
       # this could go be done in optparse.parse instead perhaps
       def verify_args!(opts={})
         args = opts[:args] || []
-        if opts[:count]
-          if args.count < opts[:count]
-            raise_args_error("not enough arguments, expected #{opts[:count]} and got #{args.count == 0 ? '0' : args.count.to_s + ': '}#{args.join(', ')}", args, opts[:optparse])
-          elsif args.count > opts[:count]
-            raise_args_error("too many arguments, expected #{opts[:count]} and got #{args.count == 0 ? '0' : args.count.to_s + ': '}#{args.join(', ')}", args, opts[:optparse])
+        count = opts[:count]
+        # simplify output for verify_args!(min:2, max:2) or verify_args!(max:0)
+        if opts[:min] && opts[:max] && opts[:min] == opts[:max]
+          count = opts[:min]
+        elsif opts[:max] == 0
+          count = 0
+        end
+        if count
+          if args.count < count
+            raise_args_error("not enough arguments, expected #{count} and got #{args.count == 0 ? '0' : args.count.to_s + ': '}#{args.join(', ')}", args, opts[:optparse])
+          elsif args.count > count
+            raise_args_error("too many arguments, expected #{count} and got #{args.count == 0 ? '0' : args.count.to_s + ': '}#{args.join(', ')}", args, opts[:optparse])
           end
         else
           if opts[:min]

data/lib/morpheus/cli/cli_registry.rb

@@ -77,14 +77,26 @@ module Morpheus
 
         def exec_command(command_name, args)
           #puts "exec_command(#{command_name}, #{args})"
-          found_alias_command = instance.get_alias(command_name)
           if has_alias?(command_name)
             exec_alias(command_name, args)
           elsif has_command?(command_name)
             instance.get(command_name).new.handle(args)
           else
             # todo: need to just return error instead of raise
-            raise CommandNotFoundError.new("'#{command_name}' is not a morpheus command.")
+            msg = "'#{command_name}' is not a morpheus command."
+            suggestions = find_command_suggestions(command_name)
+            if suggestions && suggestions.size == 1
+              msg += "\nThe most similar command is:\n"
+              suggestions.first(5).each do |suggestion|
+                msg += "\t" + suggestion + "\n"
+              end
+            elsif suggestions && suggestions.size > 1
+              msg += "\nThe most similar commands are:\n"
+              suggestions.first(5).each do |suggestion|
+                msg += "\t" + suggestion + "\n"
+              end
+            end
+            raise CommandNotFoundError.new(msg)
           end
         end
 
@@ -269,6 +281,47 @@ module Morpheus
           return exit_code, err
         end
 
+        def cached_command_list
+          @cached_command_list ||= (all.keys + all_aliases.keys).collect { |it| it.to_s }.sort
+        end
+
+        def clear_cached_command_list
+          @cached_command_list = nil
+        end
+
+        # find suggested commands (or aliases) for a name that was not found
+        # First this looks for the plural of the original guess
+        # Then pop characters off the end looking for partial matches
+        # as long as the guess is at least 3 characters
+        def find_command_suggestions(command_name)
+          every_command = cached_command_list
+          guess = command_name
+          suggestions = []
+          while guess.size >= 3
+            plural_guess = guess.pluralize
+            if every_command.include?(guess)
+              suggestions << guess
+            end
+            if every_command.include?(plural_guess)
+              suggestions << plural_guess
+            end
+            # if every_command.include?(guess)
+            #   suggestions << plural_guess
+            # else
+              guess_regexp = /^#{Regexp.escape(guess)}/i
+              every_command.each do |it|
+                if it =~ guess_regexp
+                  suggestions << it
+                end
+              end
+            # end
+            guess = guess[0..-2]
+          end
+          suggestions.uniq!
+          suggestions.sort! { |x,y| [x.split('-').size, x] <=> [y.split('-').size, y] }
+          return suggestions
+        end
+
       end
 
     end

data/lib/morpheus/cli/cloud_resource_pools_command.rb

@@ -7,6 +7,7 @@ require 'morpheus/cli/mixins/infrastructure_helper'
 class Morpheus::Cli::CloudResourcePoolsCommand
   include Morpheus::Cli::CliCommand
   include Morpheus::Cli::InfrastructureHelper
+  include Morpheus::Cli::OptionSourceHelper
 
   #set_command_name :'cloud-resource-pools'
   set_command_name :'resource-pools'
@@ -191,6 +192,12 @@ class Morpheus::Cli::CloudResourcePoolsCommand
         "Status" => lambda {|it| it['status'].to_s.capitalize },
         "Tenants" => lambda {|it| it['tenants'] ? it['tenants'].collect {|it| it['name'] }.uniq.join(', ') : '' }
       }
+
+      if cloud['zoneType']['code'] == 'openstack'
+        role = resource_pool['config']['roleId'] ? load_option_source_data('openstackRoles', {zoneId: cloud['id']}).find {|it| it['value'] == resource_pool['config']['roleId']} : nil
+        description_cols['Role'] = lambda {|it| role ? role['name'] : ''}
+      end
+
       print_description_list(description_cols, resource_pool)
 
       if resource_pool['resourcePermission'].nil?
@@ -329,8 +336,14 @@ class Morpheus::Cli::CloudResourcePoolsCommand
       opts.on('--default-pool [on|off]', String, "Set resource pool as the default") do |val|
         options['defaultPool'] = val.to_s == 'on' || val.to_s == 'true' || val.to_s == ''
       end
-      build_common_options(opts, options, [:options, :payload, :json, :dry_run, :remote])
-      opts.footer = "Update a resource pool." + "\n" +
+      opts.on("--description [TEXT]", String, "Description") do |val|
+        options['description'] = val.to_s
+      end
+      opts.on( '--role ROLE', String, "Role Name or ID (applicable to select resource pools)" ) do |val|
+        options[:role] = val
+      end
+      build_standard_add_options(opts, options)
+      opts.footer = "Add a resource pool." + "\n" +
                     "[cloud] is required. This is the name or id of the cloud."
     end
     optparse.parse!(args)
@@ -349,151 +362,156 @@ class Morpheus::Cli::CloudResourcePoolsCommand
 
     connect(options)
 
-    begin
-      # load cloud
-      if cloud_id.nil?
-        puts_error "#{Morpheus::Terminal.angry_prompt}missing required option: [cloud]\n#{optparse}"
-        return 1
-      end
-      cloud = find_cloud_by_name_or_id(cloud_id)
-      return 1 if cloud.nil?
-      
-      # merge -O options into normally parsed options
-      options.deep_merge!(options[:options].reject {|k,v| k.is_a?(Symbol) }) if options[:options]
+    # load cloud
+    if cloud_id.nil?
+      puts_error "#{Morpheus::Terminal.angry_prompt}missing required option: [cloud]\n#{optparse}"
+      return 1
+    end
+    cloud = find_cloud_by_name_or_id(cloud_id)
+    return 1 if cloud.nil?
 
-      # construct payload
-      payload = nil
-      if options[:payload]
-        payload = options[:payload]
-      else
-        # prompt for resource pool options
-        payload = {
-          'resourcePool' => {
-          }
+    # merge -O options into normally parsed options
+    options.deep_merge!(options[:options].reject {|k,v| k.is_a?(Symbol) }) if options[:options]
+
+    # construct payload
+    payload = nil
+    if options[:payload]
+      payload = options[:payload]
+    else
+      # prompt for resource pool options
+      payload = {
+        'resourcePool' => {
         }
-        
-        # allow arbitrary -O options
-        payload['resourcePool'].deep_merge!(options[:options].reject {|k,v| k.is_a?(Symbol) }) if options[:options]
+      }
 
+      # allow arbitrary -O options
+      payload['resourcePool'].deep_merge!(options[:options].reject {|k,v| k.is_a?(Symbol) }) if options[:options]
 
-        # Name
-        if options['name']
-          payload['resourcePool']['name'] = options['name']
-        else
-          v_prompt = Morpheus::Cli::OptionTypes.prompt([{'fieldName' => 'name', 'fieldLabel' => 'Name', 'type' => 'text', 'required' => true, 'description' => 'Name'}], options)
-          payload['resourcePool']['name'] = v_prompt['name']
-        end
+      # Name
+      if options['name']
+        payload['resourcePool']['name'] = options['name']
+      else
+        v_prompt = Morpheus::Cli::OptionTypes.prompt([{'fieldName' => 'name', 'fieldLabel' => 'Name', 'type' => 'text', 'required' => true, 'description' => 'Name'}], options)
+        payload['resourcePool']['name'] = v_prompt['name']
+      end
 
-        # Group Access
-        if group_access_all != nil
+      # Group Access
+      if group_access_all != nil
+        payload['resourcePermissions'] ||= {}
+        payload['resourcePermissions']['all'] = group_access_all
+      else
+        # default to all
+        if payload['resourcePermissions'].nil? || payload['resourcePermissions']['all'].nil?
           payload['resourcePermissions'] ||= {}
-          payload['resourcePermissions']['all'] = group_access_all
-        else
-          # default to all
-          if payload['resourcePermissions'].nil? || payload['resourcePermissions']['all'].nil?
-            payload['resourcePermissions'] ||= {}
-            payload['resourcePermissions']['all'] = true
-          end
+          payload['resourcePermissions']['all'] = true
         end
-        if group_access_list != nil
-          payload['resourcePermissions'] ||= {}
-          payload['resourcePermissions']['sites'] = group_access_list.collect do |site_id|
-            site = {"id" => site_id.to_i}
-            if group_defaults_list && group_defaults_list.include?(site_id)
-              site["default"] = true
-            end
-            site
+      end
+      if group_access_list != nil
+        payload['resourcePermissions'] ||= {}
+        payload['resourcePermissions']['sites'] = group_access_list.collect do |site_id|
+          site = {"id" => site_id.to_i}
+          if group_defaults_list && group_defaults_list.include?(site_id)
+            site["default"] = true
           end
+          site
         end
+      end
 
-        # Service Plan Access
-        if plan_access_all != nil
+      # Service Plan Access
+      if plan_access_all != nil
+        payload['resourcePermissions'] ||= {}
+        payload['resourcePermissions']['allPlans'] = plan_access_all
+      else
+        # default to all
+        if payload['resourcePermissions'].nil? || payload['resourcePermissions']['allPlans'].nil?
           payload['resourcePermissions'] ||= {}
-          payload['resourcePermissions']['allPlans'] = plan_access_all
-        else
-          # default to all
-          if payload['resourcePermissions'].nil? || payload['resourcePermissions']['allPlans'].nil?
-            payload['resourcePermissions'] ||= {}
-            payload['resourcePermissions']['allPlans'] = true
-          end
+          payload['resourcePermissions']['allPlans'] = true
         end
-        if plan_access_list != nil
-          payload['resourcePermissions'] ||= {}
-          payload['resourcePermissions']['plans'] = plan_access_list.collect do |site_id|
-            site = {"id" => site_id.to_i}
-            if plan_defaults_list && plan_defaults_list.include?(site_id)
-              site["default"] = true
-            end
-            site
+      end
+      if plan_access_list != nil
+        payload['resourcePermissions'] ||= {}
+        payload['resourcePermissions']['plans'] = plan_access_list.collect do |site_id|
+          site = {"id" => site_id.to_i}
+          if plan_defaults_list && plan_defaults_list.include?(site_id)
+            site["default"] = true
           end
+          site
         end
+      end
 
-        # Tenants
-        if options['tenants']
-          payload['tenantPermissions'] = {}
-          payload['tenantPermissions']['accounts'] = options['tenants']
-        end
-
-        # Active
-        if options['active'] != nil
-          payload['resourcePool']['active'] = options['active']
-        else
-          payload['resourcePool']['active'] = true
-        end
+      # Tenants
+      if options['tenants']
+        payload['tenantPermissions'] = {}
+        payload['tenantPermissions']['accounts'] = options['tenants']
+      end
 
-        # Default
-        if options['defaultPool'] != nil
-          payload['resourcePool']['defaultPool'] = options['defaultPool']
-        end
-        
-        # Visibility
-        if options['visibility'] != nil
-          payload['resourcePool']['visibility'] = options['visibility']
-        else
-          payload['resourcePool']['visibility'] = 'private'
-        end
-
-
-        # Config options depend on type (until api returns these as optionTypes)
-        zone_type = cloud['zoneType'] ? cloud['zoneType']['code'] : ''
-        if zone_type == 'amazon'
-          payload['resourcePool']['config'] ||= {}
-          # CIDR
-          v_prompt = Morpheus::Cli::OptionTypes.prompt([{'fieldContext' => 'config', 'fieldName' => 'cidrBlock', 'fieldLabel' => 'CIDR', 'type' => 'text', 'required' => true, 'description' => 'Provide the base CIDR Block to use for this VPC (must be between a /16 and /28 Block)'}], options)
-          payload['resourcePool']['config']['cidrBlock'] = v_prompt['config']['cidrBlock']
-          # Tenancy
-          v_prompt = Morpheus::Cli::OptionTypes.prompt([{'fieldContext' => 'config', 'fieldName' => 'tenancy', 'fieldLabel' => 'Tenancy', 'type' => 'select', 'selectOptions' => [{'name' => 'Default', 'value' => 'default'}, {'name' => 'Dedicated', 'value' => 'dedicated'}], 'defaultValue' => 'default'}], options)
-          payload['resourcePool']['config']['tenancy'] = v_prompt['config']['tenancy']
-
-        elsif zone_type == 'azure'
-          # no options
-        elsif zone_type == 'cloudFoundry' || zone_type == 'bluemixCloudFoundry'
-          
-        elsif zone_type == 'standard'
-          # no options
-        else
-          #raise_command_error "Cloud type '#{zone_type}' does not allow creating resource pools"
-        end
+      # Active
+      if options['active'] != nil
+        payload['resourcePool']['active'] = options['active']
+      else
+        payload['resourcePool']['active'] = true
+      end
 
+      # Default
+      if options['defaultPool'] != nil
+        payload['resourcePool']['defaultPool'] = options['defaultPool']
       end
-      @cloud_resource_pools_interface.setopts(options)
-      if options[:dry_run]
-        print_dry_run @cloud_resource_pools_interface.dry.create(cloud['id'], payload)
-        return
+
+      # Visibility
+      if options['visibility'] != nil
+        payload['resourcePool']['visibility'] = options['visibility']
+      else
+        payload['resourcePool']['visibility'] = 'private'
       end
-      json_response = @cloud_resource_pools_interface.create(cloud['id'], payload)
-      if options[:json]
-        puts as_json(json_response)
+
+
+      # Config options depend on type (until api returns these as optionTypes)
+      zone_type = cloud['zoneType'] ? cloud['zoneType']['code'] : ''
+      if zone_type == 'amazon'
+        payload['resourcePool']['config'] ||= {}
+        # CIDR
+        v_prompt = Morpheus::Cli::OptionTypes.prompt([{'fieldContext' => 'config', 'fieldName' => 'cidrBlock', 'fieldLabel' => 'CIDR', 'type' => 'text', 'required' => true, 'description' => 'Provide the base CIDR Block to use for this VPC (must be between a /16 and /28 Block)'}], options)
+        payload['resourcePool']['config']['cidrBlock'] = v_prompt['config']['cidrBlock']
+        # Tenancy
+        v_prompt = Morpheus::Cli::OptionTypes.prompt([{'fieldContext' => 'config', 'fieldName' => 'tenancy', 'fieldLabel' => 'Tenancy', 'type' => 'select', 'selectOptions' => [{'name' => 'Default', 'value' => 'default'}, {'name' => 'Dedicated', 'value' => 'dedicated'}], 'defaultValue' => 'default'}], options)
+        payload['resourcePool']['config']['tenancy'] = v_prompt['config']['tenancy']
+
+      elsif zone_type == 'azure'
+        # no options
+      elsif zone_type == 'cloudFoundry' || zone_type == 'bluemixCloudFoundry'
+
+      elsif zone_type == 'openstack'
+        payload['resourcePool']['config'] ||= {}
+        # Description
+        v_prompt = Morpheus::Cli::OptionTypes.prompt([{'fieldName' => 'description', 'fieldLabel' => 'Description', 'type' => 'text'}], options)
+        payload['resourcePool']['description'] = v_prompt['description']
+        # Role
+        role_options = load_option_source_data('openstackRoles', {zoneId: cloud['id']})
+        if role = options[:role] ? role_options.find {|it| [it['name'], it['value']].include?(options[:role])} : nil
+          payload['resourcePool']['config']['roleId'] = role['value']
+        else
+          v_prompt = Morpheus::Cli::OptionTypes.prompt([{'fieldContext' => 'config', 'fieldName' => 'roleId', 'fieldLabel' => 'Role', 'type' => 'select', 'selectOptions' => role_options, 'required' => true}], options, @api_client,{zoneId: cloud['id']})
+          payload['resourcePool']['config']['roleId'] = v_prompt['config']['roleId']
+        end
+      elsif zone_type == 'standard'
+        # no options
       else
-        resource_pool = json_response['resourcePool']
-        print_green_success "Created resource pool #{resource_pool['name']}"
-        get([cloud['id'].to_s, resource_pool['id'].to_s])
+        #raise_command_error "Cloud type '#{zone_type}' does not allow creating resource pools"
       end
-      return 0
-    rescue RestClient::Exception => e
-      print_rest_exception(e, options)
-      return 1
     end
+
+    @cloud_resource_pools_interface.setopts(options)
+    if options[:dry_run]
+      print_dry_run @cloud_resource_pools_interface.dry.create(cloud['id'], payload)
+      return
+    end
+    json_response = @cloud_resource_pools_interface.create(cloud['id'], payload)
+    render_response(json_response, options, 'resourcePool') do
+      resource_pool = json_response['resourcePool']
+      print_green_success "Created resource pool #{resource_pool['name']}"
+      get([cloud['id'].to_s, resource_pool['id'].to_s])
+    end
+    return 0, nil
   end
 
   def update(args)
@@ -563,6 +581,12 @@ class Morpheus::Cli::CloudResourcePoolsCommand
       opts.on('--default-pool [on|off]', String, "Set resource pool as the default") do |val|
         options['defaultPool'] = val.to_s == 'on' || val.to_s == 'true' || val.to_s == ''
       end
+      opts.on("--description [TEXT]", String, "Description") do |val|
+        options['description'] = val.to_s
+      end
+      opts.on( '--role ROLE', String, "Role Name or ID (applicable to select resource pools)" ) do |val|
+        options['role'] = val
+      end
       build_common_options(opts, options, [:options, :payload, :json, :dry_run, :remote])
       opts.footer = "Update a resource pool." + "\n" +
                     "[cloud] is required. This is the name or id of the cloud." + "\n"
@@ -591,7 +615,7 @@ class Morpheus::Cli::CloudResourcePoolsCommand
 
       resource_pool = find_resource_pool_by_name_or_id(cloud['id'], resource_pool_id)
       return 1 if resource_pool.nil?
-      
+
       # merge -O options into normally parsed options
       options.deep_merge!(options[:options].reject {|k,v| k.is_a?(Symbol) }) if options[:options]
 
@@ -605,11 +629,11 @@ class Morpheus::Cli::CloudResourcePoolsCommand
           'resourcePool' => {
           }
         }
-        
+
         # allow arbitrary -O options
         payload['resourcePool'].deep_merge!(options[:options].reject {|k,v| k.is_a?(Symbol) }) if options[:options]
 
-      
+
         # Group Access
         if group_access_all != nil
           payload['resourcePermissions'] ||= {}
@@ -657,12 +681,26 @@ class Morpheus::Cli::CloudResourcePoolsCommand
         if options['defaultPool'] != nil
           payload['resourcePool']['defaultPool'] = options['defaultPool']
         end
-        
+
         # Visibility
         if options['visibility'] != nil
           payload['resourcePool']['visibility'] = options['visibility']
         end
 
+        # Description
+        if options['description'] != nil
+          payload['resourcePool']['description'] = options['description']
+        end
+
+        # Role
+        if options['role'] != nil
+          role_options = load_option_source_data('openstackRoles', {zoneId: cloud['id']})
+          if role = role_options.find {|it| [it['name'], it['value']].include?(options['role'])}
+            payload['resourcePool']['config'] ||= {}
+            payload['resourcePool']['config']['roleId'] = role['value']
+          end
+        end
+
         if payload['resourcePool'].empty? && payload['resourcePermissions'].nil? && payload['tenantPermissions'].nil?
           raise_command_error "Specify at least one option to update.\n#{optparse}"
         end
@@ -674,14 +712,12 @@ class Morpheus::Cli::CloudResourcePoolsCommand
         return
       end
       json_response = @cloud_resource_pools_interface.update(cloud['id'], resource_pool["id"], payload)
-      if options[:json]
-        puts as_json(json_response)
-      else
+      render_response(json_response, options, 'resourcePool') do
         resource_pool = json_response['resourcePool']
         print_green_success "Updated resource pool #{resource_pool['name']}"
         get([cloud['id'].to_s, resource_pool['id'].to_s])
       end
-      return 0
+      return 0, nil
     rescue RestClient::Exception => e
       print_rest_exception(e, options)
       return 1